enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

ecore_con: Fix dereferencing of null pointer 

Summary:
Coverity reports that 'svr' might be NULL here, so we should check it
is valid before trying to use it.

Fixes Coverity CID1396990

@fix

Depends on D8320

Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8321
This commit is contained in:
Christopher Michael 2019-03-14 07:22:54 -04:00
parent 27095e859a
commit e43b644168
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/ecore_con/ecore_con_legacy.c
View File

@ -293,7 +293,7 @@ _ecore_con_client_free(Ecore_Con_Client *cl)
efl_event_callback_array_del(inner_socket, _ecore_con_client_socket_ssl_cbs(), cl);
parent = efl_parent_get(cl->socket);
if (parent && (parent != svr->server))
if (parent && svr && (parent != svr->server))
efl_del(cl->socket); /* we own it */
else
efl_unref(cl->socket);