enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

elm/list: use while() loop to iterate item list during smart delete 

Summary:
using EINA_LIST_FREE here double deletes 2 list items on every iteration
due to recursive list removals, which prevents some items from being
deleted as expected

fix T7266

Reviewers: netstar

Reviewed By: netstar

Subscribers: netstar, cedric, #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T7266

Differential Revision: https://phab.enlightenment.org/D6829
This commit is contained in:
Mike Blumenkrantz 2018-08-15 09:45:06 +01:00 committed by Alastair Poole
parent 672cacaaf6
commit e708c0ae33
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/lib/elementary/elm_list.c
View File

@ -2431,8 +2431,9 @@ _elm_list_efl_canvas_group_group_del(Eo *obj, Elm_List_Data *sd)
evas_object_event_callback_del
(sd->box, EVAS_CALLBACK_CHANGED_SIZE_HINTS, _size_hints_changed_cb);
EINA_LIST_FREE(sd->items, eo_it)
efl_del(eo_it);
while (sd->items)
/* will be removed from list in _elm_list_item_elm_widget_item_del_pre */
efl_del(eina_list_data_get(sd->items));
sd->selected = eina_list_free(sd->selected);