ecore_exe_win32: CreateProcess was called with random flags.

CreateProcess() has a flags parameter which is being passed
"run_pri | CREATE_SUSPENDED".

The issue lies in the value of run_pri. It is best explained by the
following code somewhere else in the file:

switch (run_pri)
{
case IDLE_PRIORITY_CLASS:
return ECORE_EXE_WIN32_PRIORITY_IDLE;

The run_pri variable is supposed to store a value from the win32 API while
it was used to store one from the ecore API.

If I recall correctly, the windows one is equal to 32 and the ecore one to
9999. Meaning 9999 ended up used as flags so let's have a look at what that
actually enabled; the reference is "Process Creation Flags" from MSDN
http://msdn.microsoft.com/en-us/library/ms684863%28v=vs.85%29.aspx .

Matches nothing? Weird. Well, maybe. Except that I stumbled upon this define
in the mingw-w64 headers:
#define CREATE_FORCEDOS 0x2000

Mingw-w64 only has a #define, Wine has nothing (they don't do DOS anyway),
but ReactOS has some code about it:
https://git.reactos.org/?p=reactos.git;a=blob;f=reactos/dll/win32/kernel32/client/proc.c;hb=f60941f8dc775427af04eb0a3c3e4d38160c7641#l3007

Overall the actual set of flags probably made very little sense and wasn't
working very well. :)

I also noticed the following in the mingw-w64 headers:
#define INHERIT_CALLER_PRIORITY 0x20000

This should be a better match for what seemed to be the original intent of
inheriting the priority. I haven't tested it and it's only documented on
MSDN for Windows CE and similar so I'm really not sure about what it does.

MSDN however mentions that the child processes will have at most the
"normal" priority by default (same as its parent if the parent has less
than the default one) but I'm under the impression a process can raise its
own priority level... Anyway, "NORMAL_PRIORITY_CLASS" will do for now.

With this change and a couple others, elementary's theme builds properly
on Windows (_on_ Windows). I'll assess the usefulness of the other changes
in my tree over the next few days.

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>

This commit is contained in:

Adrien Nader

2014-10-25 16:35:06 +02:00

committed by

Cedric BAIL

parent a67feee6ec

commit e9e61718d1

1 changed files with 1 additions and 1 deletions

									
										2

src/lib/ecore/ecore_exe_win32.c

										View File
									
				@ -34,7 +34,7 @@

				#define ECORE_EXE_WIN32_TIMEOUT 3000

				static int run_pri = ECORE_EXE_PRIORITY_INHERIT;

				static int run_pri = NORMAL_PRIORITY_CLASS;

				static Eina_Bool

				_ecore_exe_close_cb(void *data,

ecore_exe_win32: CreateProcess was called with random flags.

2 src/lib/ecore/ecore_exe_win32.c Unescape Escape View File

2

src/lib/ecore/ecore_exe_win32.c

View File