enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

efl_ui_tab_bar: fix error about double free 

Summary:
tab is the parent of the icon.
so deleting the tab causes deleting the icon automatically.
in this case, it can cause double-freed problem once icon has deleted.

Test Plan: elementary_test -to efl.ui.tab_pager

Reviewers: cedric, Jaehyun_Cho, jpeg

Reviewed By: Jaehyun_Cho

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7407
This commit is contained in:
Bowon Ryu 2018-12-05 20:28:24 +09:00 committed by Jaehyun Cho
parent f15c1f1417
commit ede6c1316b
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lib/elementary/efl_ui_tab_bar.c
View File

@ -298,7 +298,6 @@ _efl_ui_tab_bar_tab_remove(Eo *obj EINA_UNUSED, Efl_Ui_Tab_Bar_Data *sd, int ind
_tab_unselect(sd, ti);
evas_object_box_remove(sd->bx, ti->tab);
efl_del(ti->tab);
efl_del(ti->icon);
sd->tab_infos = eina_list_remove(sd->tab_infos, ti);
sd->cnt --;