enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

layout: fix "elm,state,text,hidden" signal never be emitted 

Summary:
 In _elm_layout_text_set function, text_signal_emit is called.
 But in that case, check text whether it is null or not null before call signal_emit.
 So "text" is not null always, and text_signal_emit's parameter "visible" is also always EINA_TRUE.

Reviewers: Jaehyun_Cho, cedric, jpeg

Reviewed By: Jaehyun_Cho

Differential Revision: https://phab.enlightenment.org/D5049
This commit is contained in:
JinYong Park 2017-08-04 15:33:27 +09:00 committed by Jaehyun Cho
parent 63f0dcc5fc
commit f2082c0412
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/lib/elementary/elm_layout.c
View File

@ -1231,6 +1231,7 @@ _elm_layout_text_set(Eo *obj, Elm_Layout_Smart_Data *sd, const char *part, const
{
if (!text)
{
_text_signal_emit(sd, sub_d, EINA_FALSE);
eina_stringshare_del(sub_d->part);
free(sub_d);
edje_object_part_text_escaped_set
@ -1258,7 +1259,7 @@ _elm_layout_text_set(Eo *obj, Elm_Layout_Smart_Data *sd, const char *part, const
sd->subs = eina_list_append(sd->subs, sub_d);
}
_text_signal_emit(sd, sub_d, !!text);
_text_signal_emit(sd, sub_d, EINA_TRUE);
elm_layout_sizing_eval(obj);