enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

elm_win: Fix ABI break with missing EAPIs 

EAPI elm_win_type_set
EAPI elm_win_name_set

Those two APIs should never have been part of the legacy API,
but they have been generated since at least 1.16. The commits
  1aceb3bc19
and
  41aa19447c
removed the legacy symbols generation. It seemed like a good
idea since the APIs shouldn't exist, but in fact this broke
ABI. I hate this. So sorry about it.

I'm adding them back in with no documentation and as
EINA_DEPRECATED.

This is an emergency commit before the 1.18.x release
announcement.

Fixes T4344
@fix
This commit is contained in:
Jean-Philippe Andre 2016-08-12 07:44:08 +09:00
parent f4a90dcde2
commit f8684635e4
3 changed files with 19 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/lib/elementary/efl_ui_win.c
View File

@ -6979,4 +6979,19 @@ elm_win_aspect_get(const Eo *obj)
return _win_aspect_get(sd);
}
// deprecated
EAPI void
elm_win_name_set(Evas_Object *obj, const char *name)
{
ERR("Calling deprecrated function '%s'", __FUNCTION__);
efl_ui_win_name_set(obj, name);
}
EAPI void
elm_win_type_set(Evas_Object *obj, Elm_Win_Type type)
{
ERR("Calling deprecrated function '%s'", __FUNCTION__);
efl_ui_win_type_set(obj, type);
}
#include "efl_ui_win.eo.c"

12
src/lib/elementary/efl_ui_win.eo
View File

@ -557,12 +557,6 @@ class Efl.Ui.Win (Elm.Widget, Efl.Canvas, Elm.Interface.Atspi.Window,
Note: Once set, it can NOT be modified afterward.
]]
/* FIXME-doc
Example:
@code
win = eo_add(ELM_WIN_CLASS, NULL, elm_obj_win_name_set(ELM_WIN_BASIC));
@endcode
*/
set {
[[Can only be used at creation time, within \@ref eo_add.]]
legacy: null;
@ -582,12 +576,6 @@ class Efl.Ui.Win (Elm.Widget, Efl.Canvas, Elm.Interface.Atspi.Window,
Note: Once set, it can NOT be modified afterward.
]]
/* FIXME-doc
Example:
@code
win = eo_add(ELM_WIN_CLASS, NULL, elm_obj_win_type_set(ELM_WIN_BASIC));
@endcode
*/
set {
[[Can only be used at creation time, within \@ref eo_add.]]
legacy: null;

4
src/lib/elementary/elm_deprecated.h
View File

@ -1640,3 +1640,7 @@ EINA_DEPRECATED EAPI const char *elm_fileselector_entry_selected_get(const Evas_
//TODO: remvoe below - use elm_access_text_set(); or elm_access_cb_set();
EINA_DEPRECATED EAPI void elm_access_external_info_set(Evas_Object *obj, const char *text);
EINA_DEPRECATED EAPI char *elm_access_external_info_get(const Evas_Object *obj);
// elm_win
EINA_DEPRECATED EAPI void elm_win_type_set(Evas_Object *obj, Elm_Win_Type type);
EINA_DEPRECATED EAPI void elm_win_name_set(Evas_Object *obj, const char *name);