enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

efl net - fix ipv6 getsockname to use the proper struct to do it 

struct sockaddr_storage *addr;

AS the actual storage ( a ptr to store the whole data). kind of...
wrong. it should be:

      struct sockaddr_storage addr;

see examples of this kind of usage of getsockname:

http://www.masterraghu.com/subjects/np/introduction/unix_network_programming_v1.3/ch04lev1sec10.html

found by PVS studio

@fix
This commit is contained in:
Carsten Haitzler 2017-07-29 10:35:39 +09:00
parent d532f28284
commit ff26991220
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/ecore_con/efl_net_server_tcp.c
View File

@ -167,7 +167,7 @@ _efl_net_server_tcp_efl_net_server_fd_socket_activate(Eo *o, Efl_Net_Server_Tcp_
char buf[INET6_ADDRSTRLEN + sizeof("[]:65536")];
Eina_Bool listening;
Eina_Error err;
struct sockaddr_storage *addr;
struct sockaddr_storage addr;
socklen_t addrlen;
SOCKET fd;

2
src/lib/ecore_con/efl_net_server_udp.c
View File

@ -213,7 +213,7 @@ _efl_net_server_udp_efl_net_server_fd_socket_activate(Eo *o, Efl_Net_Server_Udp_
{
char buf[INET6_ADDRSTRLEN + sizeof("[]:65536")];
Eina_Error err;
struct sockaddr_storage *addr;
struct sockaddr_storage addr;
socklen_t addrlen;
SOCKET fd;

2
src/lib/ecore_con/efl_net_server_unix.c
View File

@ -173,7 +173,7 @@ _efl_net_server_unix_efl_net_server_fd_socket_activate(Eo *o, Efl_Net_Server_Uni
char buf[INET6_ADDRSTRLEN + sizeof("[]:65536")];
Eina_Bool listening;
Eina_Error err;
struct sockaddr_storage *addr;
struct sockaddr_storage addr;
socklen_t addrlen;
SOCKET fd;