Commit Graph

112 Commits

Author SHA1 Message Date
Marcel Hollerbach f5e24c3bcf ecore_con: Fix error goto, scope data should not be freed
Summary:
If the function jumpes to the error, the scope data is freed, this is
wrong, just the object should be destroyed, so not free, just eo_unref
the object. Cause the object is just added above the object ref count
should get 0 and obj will get removed

Test Plan: Use the ecore_con_server_client_limit_set function and set the max count to 1, at the connect of a second client the server will fail at this free.

Reviewers: tasn

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1459
2014-09-19 02:16:37 +01:00
Savio Sena 5bc2efcf87 ecore-con: Fixed header to allow compilation in C++.
Summary: C++ takes the second typedef as redefinition and yields errors.

Reviewers: zmike, tasn

Reviewed By: tasn

Subscribers: larry, cedric, felipealmeida

Differential Revision: https://phab.enlightenment.org/D1455
2014-09-18 07:07:53 +01:00
Daniel Kolesa 7786b96359 eolian: builtin complex types
From now on, there are 5 builtin complex types, particularly accessor, array,
iterator, hash and list. All other types are simple - they can't have a complex
part. Also, the <> now binds to the type itself, not the pointer. More builtin
complex types will be added as needed.
2014-09-08 14:53:13 +01:00
Stefan Schmidt fdc8e455e4 ecore_con: Make sure host_server is not NUL before dereferencing
This was intended to get fixed in f53683f76a

CID 1232731
2014-09-04 10:57:19 +02:00
Tom Hacohen 0c9a1d8a99 Ecore con: Add Connector class (the connecting variant of server).
This change also consists of cleaning up the server class and adding a
constructor and a finalizer to it.
2014-09-01 12:35:22 +01:00
Tom Hacohen 056c54ebc9 Ecore con server: Fix destructor to call super correctly. 2014-09-01 11:12:17 +01:00
Tom Hacohen a58c1b6c97 Ecore con url: Migrate to eo. 2014-09-01 11:12:17 +01:00
Mike Blumenkrantz 7b0db79c2d revert all recent ecore-con related eo changes. completely broken.
please test things before committing.

reverts all changes since and including f6156c9a62
2014-08-30 08:12:54 -04:00
Tom Hacohen 0f9627c363 Ecore con: Fix constructing (the whole object was broken).
We were constructing some things too late which caused url setting to not
work at all.
2014-08-29 11:41:51 +01:00
Daniel Kolesa 3e5da03f7d eolian: update virtual to the new syntax (as per wiki) 2014-08-29 11:40:29 +01:00
Tom Hacohen 607901fb0e Ecore con server: Fix destructor to call super correctly. 2014-08-29 10:26:23 +01:00
Tom Hacohen 61cd629a59 Ecore con: Limit some functions to only be called from inside eo_add(). 2014-08-29 10:26:23 +01:00
Tom Hacohen bba7ac87f1 Ecore con: Add Connector class (the connecting variant of server).
This change also consists of cleaning up the server class and adding a
constructor and a finalizer to it.
2014-08-28 14:31:17 +01:00
Tom Hacohen bdb60f017f Ecore con: Update migration TODO. 2014-08-28 12:00:31 +01:00
Tom Hacohen f6156c9a62 Ecore con url: Migrate to eo. 2014-08-28 11:52:38 +01:00
Tom Hacohen 2a144e5717 Ecore con: Fix to the correct parameter type.
Can finally be done because the eolian cycle bug was fixed.
2014-08-28 10:26:17 +01:00
Tom Hacohen 18895e2489 Ecore con: Fix some ecore con runtime issues on windows. 2014-08-27 16:25:27 +01:00
Tom Hacohen 98281cc523 Ecore con: Fix compilation on windows. 2014-08-27 16:19:25 +01:00
Carsten Haitzler 1383f025d3 ecore-con - fix typo in error handling for ssl client init
fixes CID 1232730
2014-08-27 17:18:22 +09:00
Carsten Haitzler f53683f76a ecore-con - fix explicit null dereference
fix CID 1232731
2014-08-27 17:16:17 +09:00
Carsten Haitzler 9de5c8131d ecore-con - fix explicit null ptr deref
fix CID 1232729
2014-08-27 17:14:30 +09:00
Carsten Haitzler 8762004bf1 ecore-con - check return of mkdir
fix CID 1039699
2014-08-27 16:28:46 +09:00
Carsten Haitzler cbf5e0ef1d ecore-con - check return of ecore con ssl init
check return of ssl init for server connection

fixes CID 1039700
2014-08-27 16:25:51 +09:00
Carsten Haitzler f5b975174f ecore-con - use return valude of sendto.
fixes CID 1232726
2014-08-27 14:49:47 +09:00
Tom Hacohen 00b3996ee1 Ecore con: Fix compilation on windows.
Hopefully. I don't have a winodws box to test it on. Go Jenkins go.
2014-08-26 14:53:23 +01:00
Tom Hacohen 540581f629 Ecore con: Hopefully fix for windows. 2014-08-26 11:11:20 +01:00
Marcel Hollerbach 8749504b5c ecore_con: pass the correct pointer as data in the callback.
Summary:
The pass of the wrong pointer caused a wrong scope get call cause the the
passed pointer was not a valid eo pointer.

Test Plan: Run enlightenment entrance, it wont crash anymore

Reviewers: tasn

Subscribers: cedric, Sachiel

Differential Revision: https://phab.enlightenment.org/D1352
2014-08-23 16:39:14 +09:00
Tom Hacohen 974e3afabc Ecore con: Rename to Ecore.Con.Base for the C++ bindings. 2014-08-22 17:37:56 +01:00
Tom Hacohen 9a8a416325 Ecore con server: Add support for some eo events. 2014-08-22 17:37:56 +01:00
Tom Hacohen d72f809fb8 Ecore con server: Migrate to eo. 2014-08-22 17:37:56 +01:00
Tom Hacohen 718a942bde Ecore con client: Add support for some eo events. 2014-08-22 17:11:54 +01:00
Tom Hacohen d9b5f192d4 Ecore con client: Migrate to eo. 2014-08-22 17:11:54 +01:00
Tom Hacohen 218e76fd30 Ecore con: Start migration to eo. 2014-08-22 17:00:49 +01:00
Carsten Haitzler c0ca1bcf44 ecore-con - fix possible leak due to other fix
this fixes potential leak due to
ff652084e0 fixing a valgrind access
issue. make sure the server is in the list before handling error
conditions in case a callback sets delete_me (should never though).
2014-08-13 08:44:44 +09:00
Carsten Haitzler ff652084e0 fix valgrind report on ecore con server connect failure
this should fix T1508 - my testing seems to indicate so. test suite
succeeds, some manual tests of mine work. so is ay this is a good fix
that could fix critical segvs in apps using ecore-con - eg like
weather module in e
2014-08-11 20:49:42 +09:00
Mike Blumenkrantz 9c5d565d2b call ecore_init() for ecore_con_url_init()
ecore functions are used by this api, so ecore must be initialized
2014-07-28 09:48:18 -04:00
Cedric BAIL 29226ee49d ecore_con: just a reminder to look at later. 2014-06-27 13:41:20 +02:00
Carsten Haitzler 4b24b386db fix duplicate function call names in ecore and ecore_con that can clash
this fixes T1341. also it removes the pointless return value from
these two functions as the return is never used. also the ifdef in
ecore_main.c seemed wrong as it wasd using fcntl not execvp but the
ifdef was for execvp. this just never was discovered, so it's slid
under the hood for a long time.
2014-06-16 15:57:05 +09:00
Raoul Hecky 06a343afda Fix curl dynamic loading on windows
With win-builds.org curl dll name is libcurl-4.dll. Try to load this
correct filename first
2014-06-03 18:09:14 +02:00
Guillaume Friloux 08a70a113f Fix warning with undefined ntohl(). 2014-05-30 14:15:27 +02:00
Jean-Philippe Andre f4a0c8054f Win64: Fix a bunch of warnings
Fix invalid casts.
Use printf("%z") where appropriate.
Fix unused variables warnings.

Thanks vtorri for the patch.

@fix
2014-05-29 20:02:16 +09:00
Carsten Haitzler 7c00bd5123 fix ecore_con_url using 100% cpu and just let fd handler do work
this fixes T1251 - @fix
2014-05-15 15:48:18 +09:00
Stefan Schmidt 9f7c9f9536 ecore_con: Force unsigned to unsigned comparison
num was changed to size_t which makes it unsigned while count is a normal
(signed) int. Comparing them does not always work as expected but in this
case we already checked if count is < 0 before and would have returned if
that would be true. Thus we can safely cast count to unsigned here as it
will be greater 0 anyway.
2014-04-11 11:50:47 +02:00
Stefan Schmidt b53a68d4c6 ecore_con: Remove superfluous >= 0 check for unsigned
Since num was changed from (signed) int to (unsigned)  size_t in
16d7b981eb this check no longer
makes sense as it will always be true.
2014-04-11 11:26:18 +02:00
Carsten Haitzler 16d7b981eb ecore-con - deal with internal buffer growing over 2g in size
@fix this fixes a corner case where you may buffer 2g or more of data
in ecore-con buffers. this leads to a stall. @fix
2014-04-04 19:36:50 +09:00
Chris Michael 24ac2e278d Fix doxy typo
Signed-off-by: Chris Michael <devilhorns@comcast.net>
2014-01-19 12:06:05 +00:00
ChunEon Park 84cd13bf96 efl/ecore_con - compare same types. 2014-01-18 18:50:51 +09:00
Cedric BAIL 313cd699f2 ecore_con: fix build on windows by matching the #if around the if statement. 2014-01-09 14:30:43 +09:00
Carsten Haitzler e8c13118eb fix mingw build for setuid fix/checks 2014-01-08 22:06:41 +09:00
Carsten Haitzler b95ef3801f setuid safeness - ensure if an app that is setuid doesn't do bad things
this makes efl ignore certain env vars for thnigs and entirely removes
user modules (that no one ever used) etc. etc. to ensure that *IF* an
app is setuid, there isn't a priv escalation path that is easy.
2014-01-08 19:46:23 +09:00