enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity
9,958 Commits 489 Branches 2 Tags 426 MiB
Commit Graph

329 Commits

Author SHA1 Message Date
Tom Hacohen 0ccbff2cea toolbar: Adjusted to Eo2. 2014-04-10 09:39:31 +01:00
Amitesh Singh 1479664ec0 list/genlist/gengrid/toolbar: Fix - _nearest_visible_item_get() should always return an item. 
Test Plan:
Bug:
- elementary_test->genlist/list/toolbar/gengrid Focus
- Resize the window to a state when no item is fully visible. only partially visible.
- Move Focus from outer widgets (Up/Down/Left/right buttons) to list/genlist/gengrid/toolbar.
- Focus goes away (size - 0). Reason: _nearest_visible_item_get returns NULL.

@fix

Reviewers: seoz, raster, woohyun

Reviewed By: raster

CC: seoz, nirajkr, anand.km

Differential Revision: https://phab.enlightenment.org/D696
 2014-04-04 12:04:04 +09:00
Amitesh Singh d593ad85e2 toolbar: Added focus movement on widget items by mouse in. 
Summary:
- Added a test case in "Toolbar Focus".
@feature

Test Plan: elementary_test->Toolbar Focus

Reviewers: raster, cedric, woohyun

Reviewed By: raster

CC: seoz

Differential Revision: https://phab.enlightenment.org/D665
 2014-04-01 20:26:33 +09:00
Daniel Zaoui 9b798e7a64 Eolian: Integration of Toolbar 2014-03-31 10:23:51 +03:00
ChunEon Park 0b9a8cfd66 toolbar - fixed to use elm apis for elm objects 2014-03-25 15:57:22 +09:00
Carsten Haitzler fe621de2c1 fix segv in toolbar item focus (new feature) 2014-03-25 15:02:13 +09:00
Amitesh Singh 35ead0992d toolbar: Check disabled status of an item in nearest visible item. 
Summary:
Also
- corrected the code for getting the toolbar item from the list.
- added a test for it.

Test Plan: elementary_test -> "Toolbar Focus"

Reviewers: seoz

CC: seoz

Differential Revision: https://phab.enlightenment.org/D653
 2014-03-24 15:55:46 +09:00
Amitesh Singh ffa7f989d7 toolbar: implemented widget item focus feature. 
Summary:
1. Added "item,focused" and "item,unfocused" smart callbacks.
2. Added _elm_toolbar_focus_highlight_geometry_get().
3. Implemented elm_object_item_focus_set() and elm_object_item_focus_get().
4. Implemented elm_object_focused_item_get()
5. Ported _elm_toolbar_nearest_visible_item_get from cc827fef6.
6. Added Test Case "Toolbar Focus".

@feature

Test Plan: elementary_test->Toolbar Item Focus

Reviewers: seoz, woohyun, raster

CC: nirajkr, raster

Differential Revision: https://phab.enlightenment.org/D555
 2014-03-24 00:22:32 +09:00
Daniel Juyung Seo 4e30fa3b6f toolbar: Fixed wrong parameter for elm_widget_sub_object_del. 
Remove the icon from the sub object list for a widget not for an edje object.
 2014-03-20 02:13:41 +09:00
Daniel Zaoui 7460467419 Eolian: Integration of Scrollable Interface 2014-03-18 08:14:44 +02:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
Daniel Juyung Seo c69cfdf4de segment_control, toolbar: Fixed broken scale of widget item. 
@fix. This needs to be partially backported.
 2014-03-16 03:09:56 +09:00
Tom Hacohen 01186b6e66 Ship missing headers, and remove wrong includes 
elm_gen_common.h was not installed, but is needed by installed headers.
Remove dependencies on internal headers from shipped headers.
 2014-03-12 14:30:21 +00:00
Jaehwan Kim db23689614 access: Add smart signal "access,changed" 
It occurs that access mode is changed.
Application can add this callback for each widget.
 2014-02-08 14:05:14 +09:00
ChunEon Park f8d00ae0f2 elementary - override widget translation but work also the base widget's behavior. 
Some widgets override the widget translation but it didn't inherit the base widget's function.
Becuase of it,The language changed won't be properly called in the widget tree.

Now it fixed it.
 2014-01-23 20:20:43 +09:00
ChunEon Park dbacb2fef9 elementary - send signal "language,changed" with one way in the widget. 
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.

This makes reducing duplicated code and supporting language,chagned from all widgets.
 2014-01-23 19:30:34 +09:00
ChunEon Park aebdcff513 elementary - use the focused/unfocused string in widget defined. 
Now, it will share the strings so that reduce the binary size also user uses it in one way.
 2014-01-23 17:27:17 +09:00
Jihoon Kim 54ec084e76 fix some typos in comment and description 2014-01-22 13:20:15 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Daniel Juyung Seo a4f3074f9c elm: Removed unnecessary null check for ecore_timer_del, 
ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
 2014-01-21 23:18:16 +09:00
Daniel Juyung Seo 068c9a095f toolbar: Do not check ev->string for Return key and react on space key. 
space key works as same as Return key.
 2014-01-21 19:58:10 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply" 
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
 2014-01-21 11:08:29 +02:00
Ryuan Choi 5e46f2ff6d toolbar: Check whether icon is null before sending signal 
There are warnings when icon is null since rELM4c3e23de9e46.
 2014-01-14 21:46:27 +09:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo 16f687b87a multibuttonentry, genlist, layout, toolbar: Fixed dereference of null 
pointers which were reported by clang builg.

https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-XZo1hW.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-isAlRt.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-8Ascv8.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-gBkVuE.html#EndPath
 2014-01-06 23:26:46 +09:00
Daniel Juyung Seo 2942212cb3 toolbar: Fixed dead assignment reported by clang build. 
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-0ipfss.html#EndPath
 2014-01-06 23:14:14 +09:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI. 
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
 2013-12-26 13:03:55 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines. 
being pedantic.
 2013-12-15 06:18:35 +09:00
Daniel Juyung Seo 88a8c46af3 ctxpopup, player, slideshow, spinner, toolbar, video: internal refactoring of smart event routines. 
Now most of smart events codes look consistent.
 2013-11-13 10:29:30 +09:00
Daniel Juyung Seo 5567837cf5 button,check,colorselector,diskselector,flipselector,image,radio,toolbar: fixed formatting of smart_event functions before working on it. 
Now they look more consistent.
 2013-11-13 09:54:37 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent. 
All the class names are now of the format: Elm_Type_Subtype_Extra
 2013-11-07 11:44:22 +00:00
Daniel Juyung Seo d22076681b elm: Fixed formatting about smart_event check for code consistency. 
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
 2013-10-28 23:30:12 +09:00
Jaehyun Cho db2d711d64 [elm_widget] Enable not to add resize object to or delete resize object from sub object when the resize object is set. 
Summary: Add one more argument, 'Eina_Bool sub_object' to elm_widget_resize_object_set. If the argument, 'sub_object' is set as EINA_TRUE, the new resize object is added to the sub object and the previous resize object is deleted from the sub object.

Reviewers: Hermet, seoz

CC: Jaehyun_Cho, seoz, raster

Differential Revision: https://phab.enlightenment.org/D265
 2013-10-17 01:19:40 +09:00
Daniel Juyung Seo e82477ab29 elm_toolbar.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:15:58 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
ChunEon Park d461a8be05 elementary/widgets - set parents before widget constructs their body. 
This avoids unnecessary multiple setups when obj and subobj has connected.
 2013-08-27 14:19:19 +09:00
Daniel Juyung Seo c5b0d63838 fixed documentation for consistency. Gets -> Get. 
Occurance of Get is super much higher than Gets.
So change Gets to Get for consistency.
 2013-08-22 05:24:46 +09:00
Carsten Haitzler 59e8bc5a35 Fix elm to use key not keyname (so xmodmap works) 2013-07-31 15:16:41 +09:00
Shinwoo Kim c47ef1b7fe [access] use proper name _elm_access_info_get(); not _elm_access_object_get(); to get access information 2013-07-31 12:57:49 +09:00
Daniel Juyung Seo 7bbcf8a271 elm_toolbar.c: check reorder_from at the start of _items_change. reorder_from is used here and there. 
this fixes dereference before null issue which was spotted by coverity. CID 1039999.
 2013-07-06 12:26:59 +09:00
Hosang Kim 32affd3725 added callback call "scroll", "scroll,anim,start", "scroll,anim,stop", "scroll,drag,start", "scroll,drag,stop" 
in toolar widget.
 2013-07-03 13:57:17 +09:00
Daniel Juyung Seo 6cf684f02a elm: added more "focused" and "unfocused" documentations. 
genlist, hover, index, list, map, photocam, progressbar, radio, scroller, slider, slideshow, spinner, toolbar, win.
 2013-06-10 14:13:55 +09:00
Daniel Juyung Seo 8bfdbd2ba6 elm: all the focusable widget now emits "focused" and "unfocused" smart callbacks. 
1. documentations, NEWS, and ChangeLog will be updated later after some more test.
2. need to check entry.
 2013-06-07 01:13:37 +09:00
Daniel Juyung Seo 4355c54715 elm_toolbar.c: ELM_SAFE_FREE adoption. 
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
 2013-05-29 21:08:50 +09:00
Daniel Juyung Seo 5f053bf79a elm: refactoring. use more ELM_FREE_FUNC. 2013-05-23 15:54:49 +09:00
Hosang Kim 5eda949b8f [toolbar] fixed code for verification(ecore_job_add) 
make a pair for job event, check the event is alive before adding event.
 2013-05-22 16:55:23 +09:00
Daniel Juyung Seo ac25946a19 elm: introduce ELM_FREE_FUNC for code quality enhancement. 
There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.

This is not all. I will work on enhancing elementary more and more.
 2013-05-22 02:24:02 +09:00
Carsten Haitzler df9f486bdb toolbar needs to be able to adjust better to layout 
as part of 1.8 review... elm toolbar really should add some signals so
theme can adjust better.
 2013-05-10 16:53:34 +09:00
Cedric Bail c929b33052 elementary: properly sanitize headers order. 2013-05-03 16:07:06 +09:00
Daniel Zaoui 187d6bf8de Elementary: replace eo_data_get for objects data referencing. 2013-05-01 11:04:09 +03:00