Commit Graph

145 Commits

Author SHA1 Message Date
Jaehwan Kim 0dedfc9248 focus: add the APIs to set the focus next about item.
Add elm_object_focus_next_item_set/get,
elm_object_item_focus_next_object_set/get and
elm_object_item_focus_next_item_set/get.

If the item and object is set at the same time,
the item is preference to object when the focus moves.

This feature is implemented about gengrid.
It will be implemented about ohter widgets.

@feature
2015-09-15 19:53:23 +09:00
Carsten Haitzler be2ae5f410 elm autofocus show - fix cases where focus is inside containers
i found that the focus doesnt auto-show when focusing things inside
scrollers and so on. i had to add more points to trigger auto show.
this fixes that

@fix
2015-09-10 18:29:24 +09:00
WooHyun Jung e20662fb9d diskselector: return when the new item is NULL 2015-07-31 19:03:21 +09:00
Avi Levin 44a53caa61 elm_diskselector: porting evas smart callbacks to eo 2015-07-05 13:05:38 +03:00
Tom Hacohen 27b72840c8 Adjust usage of eo_constructor() according to recent changes. 2015-05-20 13:03:28 +01:00
michelle legrand 65bb320c00 elm_diskselector: check if sd variable is null.
Summary:
This causes a segmentation fault when closing the DiskSelector window
on Windows.

@fix

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-03-26 18:13:27 +01:00
woochan lee acf58903b4 elm_diskselector.c: idle enterer add condition changed.
Summary:
The idle enterer added even after deleted sd for diskselector.
it makes crash.

@fix

Test Plan:
1. Run elementary_test
2. Execution diskselector.
3. Close diskselector sample window.
4. Crash occured.

Reviewers: Hermet, seoz, Jaehyun

Differential Revision: https://phab.enlightenment.org/D1843
2015-01-07 11:16:38 +09:00
Daniel Juyung Seo 288189ede6 diskselector, flipselector: Optimize eo item usage.
Remove unnecessary pointer reference.
2014-11-25 21:54:54 +09:00
Daniel Zaoui 7e396432ef Object Items: replace most of del_pre functions with destructor.
This change is not simple because Elementary has not been built from the
first day to work with Eo. Code had to be adapted to fit the new design.

The del_pre that have not been replaced yet can return FALSE and
prevent deletion. For these classes, code modification has to be deeper
and will be done later.
2014-11-12 12:03:58 +02:00
Daniel Zaoui 05225b162e Object Items: remove data variable from widget item.
Now, data is stored in Eo layer via eo_key_data_set/get.

Two macros have been added to facilitate access.
2014-11-12 12:03:58 +02:00
Daniel Zaoui ef03bc098e Object Items: remove legacy APIs.
They are now generated by Eolian.
2014-11-12 12:03:58 +02:00
Daniel Zaoui b01d01528a Object Items: remove casts that are no more needed.
It includes casts to Eo, Elm_Object_Item and to specific items data.
This belongs to the cleaning phase of the object items porting to Eo.
2014-11-12 12:03:57 +02:00
Daniel Zaoui 99971686d3 Elm DiskSelector Item: Migrate to Eo 2014-11-12 12:03:56 +02:00
Daniel Zaoui a9b13f7633 Elm Widget Item: Migrate to Eo
Since we want to support legacy inheritance mechanism, code is not
finished and will have to be cleaned when all the items are ported.
2014-11-12 11:52:10 +02:00
Lukasz Stanislawski 2ca1f8a75a atspi: properly include at-spi headers.
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.

Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
  (if someone decides to use beta APIs).

Test Plan: out-off tree build with gcc, g++

Reviewers: tasn

Reviewed By: tasn

Subscribers: seoz, q66, kuuko

Maniphest Tasks: T1721

Differential Revision: https://phab.enlightenment.org/D1528
2014-10-17 16:57:26 +01:00
Tom Hacohen 7629c147eb Eo related: Change according to recent changes in eo_add().
For more info check out a7560dbc61 in
the EFL tree.
2014-09-25 17:39:34 +01:00
Lukasz Stanislawski 09b9ef0bc0 atspi: expose more actions through atspi bus.
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.

Reviewers: z.kosinski

Reviewed By: z.kosinski

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1227
2014-07-25 11:58:16 +02:00
Zbigniew Kosinski 9ce23f0004 atspi:Set roles for widgets
Reviewers: stanluk, m.jagiello, raster

Differential Revision: https://phab.enlightenment.org/D930
2014-06-11 11:07:16 +09:00
Tom Hacohen efa41c7d75 Elm: Update code to use the new class names generated by eolian. 2014-06-03 11:54:44 +01:00
Carsten Haitzler 9d55fab418 entry: wrong viewport value calculation issue fix
Summary:
Issue: As entire scroller edje co-ordinates was being taken instead of the actual viewport value,
if in scroller edje more parts are added apart from just "elm.swallow.content", then the viewport value
set will be wrong. hence the selection handlers will not hide when they have to hide.

solution: Instead of taking scroller edje's geometry, get the actual viewport values.
To get viewport x,y a new scrollable interface is also added.

signed-off by: Shilpa Singh <shilpa.singh@samsung.com>

@fix

Test Plan: Selection handlers have to hide correctly when the text is scrolled in a scrolled entry, if the scroller edc of entry has more parts added other than elm.swallow.content, then when we scroll the selection handlers are not hidden correctly.

Reviewers: jaehwan, woohyun, seoz, Hermet, raster

CC: govi, rajeshps, thiepha

Differential Revision: https://phab.enlightenment.org/D674
2014-04-21 12:31:49 +09:00
ChunEon Park 5ab6a7739f widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.

conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
Tom Hacohen f51643bad3 diskselector: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Jaeun Choi 837fc28ed4 calendar, colorselector, diskselector: fix build warnings
Summary: This patch fixed build warnings in calendar, colorselector and diskselector.

Test Plan: make

Reviewers: Hermet

Differential Revision: https://phab.enlightenment.org/D685
2014-04-01 22:22:02 +09:00
Jaeun Choi 121f5446c7 check, colorselector, calendar, diskselector: apply key binding
Summary:
apply key binding to 4 widgets
this revision is only for reviewing
I'll send 4 seperate patches after review is done.

Test Plan: None

Reviewers: Hermet, seoz, raster

Differential Revision: https://phab.enlightenment.org/D678
2014-04-01 11:10:25 +09:00
Daniel Juyung Seo 1572444238 elm: Fixed shadow variable warnings during compilation.
elm_bubble.eo.c:110:14: warning: declaration of 'access' shadows a
global declaration [-Wshadow]

Special thanks to Jack DanielZ
2014-03-23 20:22:09 +09:00
Daniel Zaoui 702396e282 Eolian: Integration of Disk Selector 2014-03-23 10:56:44 +02:00
Daniel Juyung Seo a31c16d243 diskselector: Compare correct variables.
It was comparing the same variable.
Fixed coverity CID 1193236:  Pointless string comparison
(CONSTANT_EXPRESSION_RESULT)

@fix
2014-03-21 00:46:47 +09:00
Daniel Zaoui 7460467419 Eolian: Integration of Scrollable Interface 2014-03-18 08:14:44 +02:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
Jaeun Choi 6aa752a679 diskselector: Remove unreachable codes
Summary:
The soon to be deleted item 'it' is removed from the list at line 356.
So the first item of the list can never be the same one with it,
which means else statement is unreachable.

Test Plan: None

Reviewers: raster, seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D597
2014-03-03 23:30:53 +09:00
Jaeun Choi 295630ed9d diskselector: Fix segmentation fault
Summary:
The code was missing null check of sd->items list.
If the deleted item is the only item of the list,
sd->items becomes empty after removing it.
In that case, sd->selected_item should be set as NULL.
@fix
Fixes T988

Test Plan: execute diskselector_example_02 > click "Delete item" button 3 times

Reviewers: raster, seoz

Reviewed By: seoz

CC: seoz

Maniphest Tasks: T988

Differential Revision: https://phab.enlightenment.org/D595
2014-03-03 18:12:34 +09:00
Jaehwan Kim db23689614 access: Add smart signal "access,changed"
It occurs that access mode is changed.
Application can add this callback for each widget.
2014-02-08 14:05:14 +09:00
Daniel Juyung Seo 98a08addc4 elm: Defined the same macro, MAX and MIN, in elm_priv.h
MAX and MIN are defined in a couple of places and they was already
defined in elm_priv.h. So use elm_priv.h's one.
I also moved CEIL to elm_priv.h that can be used in another places.
2014-01-23 23:15:39 +09:00
ChunEon Park 39ad0e358e elementary - support language changed callback from a few widgets.
support a language,changed callback if a widget has the text part in default.
2014-01-23 20:07:20 +09:00
ChunEon Park aebdcff513 elementary - use the focused/unfocused string in widget defined.
Now, it will share the strings so that reduce the binary size also user uses it in one way.
2014-01-23 17:27:17 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Daniel Juyung Seo c066009c49 elm: Removed unnecessary null check for ecore_idler_del, ecore_idle_enterer_del. 2014-01-22 10:54:28 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Daniel Juyung Seo 01f2f195ba diskselector, entry, index: Refactoring by reducing unnecessary redundant function calls
and removed unnecessary local variable.

- Do not need to call the same function with same parameter many times.
Use local variable for them.
- Remove unnecessary local variable if it is not needed.
2014-01-08 17:42:55 +09:00
Jihoon Kim 7d6e81c09f elm: replace 0 or 1 with EINA_FALSE or EINA_TRUE 2014-01-08 08:23:58 +09:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
Carsten Haitzler 594d99934f elm - diskselector - fix min height to at least be min height of items
diskselector needs a major rewrite effort, BUT... until that happens
this fixes minbimum height and that fixes T506
2013-11-28 19:24:26 +09:00
Daniel Juyung Seo d88f919cad elm_diskselector.c: reduce item_count number on _item_del. or reducing item_count could be skipped in some cases like elm_index_clear.
This fixes T508.
2013-11-21 14:27:15 +09:00
Daniel Juyung Seo 5567837cf5 button,check,colorselector,diskselector,flipselector,image,radio,toolbar: fixed formatting of smart_event functions before working on it.
Now they look more consistent.
2013-11-13 09:54:37 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Juyung Seo d22076681b elm: Fixed formatting about smart_event check for code consistency.
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Jaehyun Cho db2d711d64 [elm_widget] Enable not to add resize object to or delete resize object from sub object when the resize object is set.
Summary: Add one more argument, 'Eina_Bool sub_object' to elm_widget_resize_object_set. If the argument, 'sub_object' is set as EINA_TRUE, the new resize object is added to the sub object and the previous resize object is deleted from the sub object.

Reviewers: Hermet, seoz

CC: Jaehyun_Cho, seoz, raster

Differential Revision: https://phab.enlightenment.org/D265
2013-10-17 01:19:40 +09:00
Carsten Haitzler 95fdc9cc88 fix up namespace for many signal while keeping old versions for compat 2013-10-05 21:35:27 +09:00
Daniel Juyung Seo ef877959c8 elm_diskselector.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:14:08 +09:00