Commit Graph

10898 Commits

Author SHA1 Message Date
ChunEon Park 1470572cef genlist: code refactoring.
just clean up code. no logic change.
2015-01-02 16:54:01 +09:00
ChunEon Park a41e9d8044 genlist: refactoring code.
removed invalid content string free call.
and renamed flip_content_objs -> flip_contents.
2015-01-02 16:48:29 +09:00
ChunEon Park 60202b7f0a genlist: code refactoring.
remove contents string list that doesn't needed to keep in widget data.

next code refactoring based on this patch will be coming.
2015-01-02 16:17:16 +09:00
ChunEon Park 67e4baf1df genlist: exceptional handling.
just be hidden if contents are failed to swallow.
2015-01-02 12:14:41 +09:00
Mike Blumenkrantz 8265a01c2a box layout should not silently fail when size is less than min size hint
this broke box display in any case where the user had manually changed size hints, eg. when using box align

@fix
2014-12-31 15:32:29 -05:00
ChunEon Park 2dd05e1580 genlist: free selected items when genlist is cleared. 2014-12-31 19:55:09 +09:00
ChunEon Park ff9de8bea8 genlist: send reorder signal to decoration item and views.
Previous logic was too much stick to special case for *tizen*
let decide item styles in theme as possible.

This might break reorder group item ui, but it won't be critical.
because tizen ui only depeneded on the scenario and they don't use them anymore.

This will be much better for multiple scenario in the future.
2014-12-31 19:10:40 +09:00
ChunEon Park 4f1b1bcb9f genlist: let group item set reorder style as it needs.
we don't need to limit the group item it's reorder style.
2014-12-31 18:59:28 +09:00
woochan lee c45739d0bf test_gengrid.c: Fixed Item_Data array size for prevent buffer overflow.
Summary:
Item_Data size set as 144 before. but test_gengrid_speed function called create_gengrid function with 5000 items.
it makes crash.

@fix

Test Plan:
1. run elementary_test.
2. click Gengrid update Speed.
3. crash.

Reviewers: seoz, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D1834
2014-12-31 17:38:28 +09:00
Amitesh Singh 2ba1640a00 test_glview_simple: opimize draw code.
Summary:
There is no need to call glVertexAttribPointer &
glEnableVertexAttribArray() while rendering.

Reviewers: seoz, jpeg, Hermet

Reviewed By: Hermet

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1827
2014-12-31 17:33:32 +09:00
Davide Andreoli 19d6ed361c Icon theme: added standard freedesktop names.
OK, this  commit try to fix the mess we have done with icon names in elm.
I just added standard names to icons yet existing in the elm theme, the
old name are, of course, preserved. But I marked them as -deprecated-.

Also added a new test: Icon Standard. It show all the icon that have standard
fdo names. This can be really usefull for user that need to choose icons to use.

I put some guidelines comment in the icons.edc files, I hope people will follow
the rules from now on... or will recive my personal spanking :D

I will work on those icons more in the next days: will add the new names to
elm docs, will try to match better fdo icon names, and maybe also add some
new icons...

Suggestions are always welcome.
@feature (maybe)
2014-12-30 23:03:12 +01:00
Daniel Juyung Seo 8db407f89c Revert "gesture_layer: Remove unnecessary value assignment."
This reverts commit d389a44b42d482414d1bfb2f4d0ccebbda510d7b.

Tasn said this value needs to be used. Let's fix it correctly later.
Thanks Tom.
2014-12-31 01:05:11 +09:00
Daniel Juyung Seo 27a8502959 gesture_layer: Remove unnecessary value assignment.
This fixes coverity CID 1261280.
But this is not critical.
2014-12-31 00:13:01 +09:00
ChunEon Park 66d78a4512 genlist: + warning msg for user notice
don't unrealize reordering item.
2014-12-30 17:56:24 +09:00
ChunEon Park 7dc5c3863c genlist: use convenient macro. 2014-12-30 17:36:14 +09:00
ChunEon Park 0e5b3f32d5 Revert "genlist: return as possible as soon."
This reverts commit ef56ed167206612f146d2c70f5b35a7bcd62c4c6.

This caused logic change. should not be changed.
2014-12-30 15:44:46 +09:00
ChunEon Park 10ac198400 Revert "genlist: return as possible as soon"
This reverts commit 1e6736c3a13d58c4e1a01d7e23983c721051be08.

This caused logic. should not be changed.
2014-12-30 15:43:20 +09:00
ChunEon Park 65de16477c genlist: return as possible as soon 2014-12-30 15:32:41 +09:00
Jee-Yong Um c890310c01 elm_colorselector: Fixed to get proper min size with picker only mode
Summary:
Fixed to make colorselector have proper min size
when colorselector is in ELM_COLORSELECTOR_PICKER mode

@fix

Reviewers: Hermet

Subscribers: Hermet

Differential Revision: https://phab.enlightenment.org/D1832
2014-12-30 13:11:50 +09:00
ChunEon Park f86dbe4854 genlist: removed unnecessary check 2014-12-30 11:17:46 +09:00
Daniel Juyung Seo f14fa87c84 genlist: Fix internal comments. 2014-12-30 01:31:43 +09:00
Daniel Juyung Seo 6d13e4e2bf test_genlist: Add clicked,right test case. 2014-12-30 00:35:24 +09:00
ChunEon Park f9cc9863a3 genlist: return as possible as soon. 2014-12-29 22:58:38 +09:00
ChunEon Park f2b7e575f0 genlist: clean up code.
repositioned function and remove unnecessary prototype declaration.
2014-12-29 22:51:39 +09:00
ChunEon Park fb8af1004c genlist: remove duplicated signal registration. 2014-12-29 22:34:45 +09:00
ChunEon Park 1f73409844 genlist: send an additional signal
send flip disabled signal when it's state is switched.
2014-12-29 22:27:28 +09:00
ChunEon Park cce9511130 genlist: send a signal internally.
send a signal so that item set it's style according to it's depth
2014-12-29 22:16:34 +09:00
Davide Andreoli 02b5c7065d Fileselector: beautify the search entry
Entry moved to the top-right corner and added the guide text
2014-12-29 13:47:31 +01:00
ChunEon Park 5b2493b7af genlist: send a disabled signal when the decorated item is unrealized. 2014-12-29 21:44:50 +09:00
Davide Andreoli 40f50c0a55 Hover and derivates: dismiss with every mouse buttons, not only 1 2014-12-29 12:45:43 +01:00
Davide Andreoli 62fe9c4964 List: new signal: clicked,right with simple test
@feature
2014-12-29 12:18:04 +01:00
ChunEon Park b4fe364f1b genlist: code refactoring
declare/use const strings for internal signals
2014-12-29 19:50:39 +09:00
Davide Andreoli a6486bc1b6 Gengrid: new signal: clicked,right with proper test
@feature
2014-12-29 11:38:17 +01:00
Davide Andreoli 9988b752c7 Genlist: do not fire clicked,right while dragging in progress 2014-12-29 11:19:21 +01:00
ChunEon Park eb229ae0e2 genlist: add "scroll" smart call
@feature
2014-12-29 19:02:08 +09:00
Daniel Juyung Seo b54b7178ed test_transit: Cast integer to pointer correctly to support 64 bit system. 2014-12-27 22:25:24 +09:00
Amitesh Singh eb3d69a8ec test_glview: Refractored the shader/program log code.
Summary:
Added a function print_glerror_log to handle both shaders and programs
logs.

Test Plan: elementary_test -> glview

Reviewers: raster, jpeg, seoz

Reviewed By: seoz

Subscribers: anand.km, seoz

Differential Revision: https://phab.enlightenment.org/D1826
2014-12-27 22:12:30 +09:00
Davide Andreoli 69b6310954 Improve -clicked- detection code by accept only if the mouse do not move too much
Too much in this case is a fixed 4px. As fingers do not have a right button I think
that taking into account finger size is not needed here.

Also someone argued about the signal name is not really correct...
should I change it to somethig like: clicked,secondary ?
2014-12-26 18:46:28 +01:00
Davide Andreoli 536c5de134 Genlist: added the clicked,right event on items
@feature
2014-12-26 17:29:51 +01:00
Davide Andreoli 8fdd65704b Genlist: better text style for the default_style selected style
When the genlist item is selected it change the text effect from
shadow to glow, this has 2 side effects:
1. the text gets an unwanted 2px offset (because glow require more space, I think)
2. the text color the user has set usually looks ugly with the glow color

This commit change the style to always use a normal shadow, whenever the item
is selected or not. Only apply to the default_style item style.
2014-12-26 15:19:56 +01:00
Amitesh Singh fc1579020c list/genlist/gengrid: Fix memory leak.
Summary: @Fix

Reviewers: kimcinoo, SanghyeonLee, raster, seoz

Reviewed By: seoz

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1825
2014-12-26 20:22:57 +09:00
Daniel Juyung Seo 748f86feff gengrid: Enhance realized_items_get performance. 2014-12-26 18:45:29 +09:00
Daniel Juyung Seo d47a4adae4 gengrid, genlist, list, toolbar: Fix memory leak and enhance performance.
1. Fix memory leak by freeing eina_list.
2. Enhance performance by getting the item list when it is really
needed.

@fix
2014-12-26 18:41:48 +09:00
Daniel Juyung Seo 9b038471bf genlist: Return the correct pointer for object item.
No backport needed.
2014-12-26 14:36:36 +09:00
Daniel Juyung Seo 4e6ce7da7a gengrid: Add missing "moved" callback call on item reorder by key.
This is a gengrid version of de75e6c0e852a2664c0ed022a6f79d6f431f64a0.

@fix
2014-12-26 14:33:32 +09:00
Andrii Kroitor 8148de6e17 elm_genlist: add missing callback call
Summary:
Added missing "moved" callback call when reordering items with keyboard
"up" and "down" arrows

@fix

Reviewers: cedric, raster, seoz

Reviewed By: seoz

Subscribers: reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1818
2014-12-26 14:23:42 +09:00
Andrii Kroitor c55e8ccac4 elm_toolbar: fix memory leak in _elm_toolbar_nearest_visible_item_get
@fix

Reviewers: cedric, seoz, Hermet, raster

Subscribers: reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1822
2014-12-26 11:27:07 +09:00
ChunEon Park cf25180e0c transit: revise tween sample 2014-12-26 11:23:12 +09:00
Mike Blumenkrantz c201ec6c87 genlist should ignore no-select items when moving with the keyboard
@fix
2014-12-25 20:39:17 -05:00
Jee-Yong Um 30d8089ff5 elm_transit: Append Elm_Transit_Tween_Mode sample to elementary_test
Summary:
A sample for elm_transit_tween mode which can be executed via
"Effects"-"Transit Tween Mode" button in elementary_test

Reviewers: Hermet

Subscribers: Hermet

Differential Revision: https://phab.enlightenment.org/D1817
2014-12-26 10:27:15 +09:00