Summary:
In some cases, elm_label doesn't calculate its min size if it is not resized from outside.
It is happened when only elm_label used with elm_label_line_wrap_set API.
The following APIs can change min size of the widget, so we can't skip the sizing_eval func.
elm_label_line_wrap_set
elm_label_line_width_set
elm_object_text_set -> _elm_label_elm_layout_text_set will be called.
@fix
Test Plan:
I put a change to test_notify.c for test.
elementary_test notify
-> click "top" button. -> You can't see elm_label without the patch.
Reviewers: woohyun, tasn, seoz
Reviewed By: seoz
Subscribers: herdsman
Differential Revision: https://phab.enlightenment.org/D1652
Summary:
Issue: elm_box_align_set APIs not working well
Solution: hint_set should not be called instead evas box align APIs
have to be used
@fix
Test Plan:
elementary test demo first page, though align is set as 0.0
0.5 it always shows as 0.5
Reviewers: Hermet, raster, seoz
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D1622
Summary:
Changing of styles for widget items isn't realized yet. This fix should
be presented to avoid segfaults when elm_object_item_style_set/get is calling
@fix
Reviewers: seoz, raster, cedric, Hermet
Reviewed By: Hermet
Subscribers: bluezery
Differential Revision: https://phab.enlightenment.org/D1595
Summary:
Because the "elm.swallow.event" part is used for internal needs of Panel widget
setting up or unsetting content of this part can break the behavior of this widget.
Due to the fact that this part is invisible and does not have any use cases for user
it seems acceptable to forbid changing of its content.
@fix
Reviewers: cedric, seoz, raster, Hermet
Reviewed By: Hermet
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1587
We do trigger an edje theme open during the first stage of quicklaunch as part of
config init apparently. So we better init or we will endup with some really bad
memory corruption.
Summary:
User application may call some fileselector APIs to configure fileselector instance.
And some of them may call _populate but only last request is needed.
However, T1663 raises that last request might be rejected with expansion option and
multiple requests of _populate.
It's because expansion mode do not allow next _populate until previous one is finished.
So, this patch fixes it via scheduling _populate instead of calling _populate() directly in APIs.
@fix
Maniphest Tasks: T1663
Several APIs are marked as not documented simply because the doxygen
documentation mentions a parameter named "foo" while the spelling in the
prototype is something like "fooh". An example correction is
- * @param fsize Finger size
+ * @param sz Finger size
Nothing very complicated and there are also a couple typo fixes I noticed
while going over the files.
In some cases, like having a drop target inside an inwin (looks like it
can be other containers too) can cause an infinite loop (as described in
the report). The reason for that is that while the drop target was added
when there was an X window available, the X window ws now gone, so the
non X path was being called which didn't have the code to remove the
item from the list being iterated. Yes, definition of spaghetti and
false assumptions.
Elm dnd/cnp need a massive overhaul, they are disgusting.
See the ticket for more information on the issue.
Fixes T1702
Before screaming "don't expose this", here's the reasoning:
There will be a few new APIs in evas-gl (support pbuffer, ...)
that require a pointer to the Evas_GL to be called. So, instead
of exposing each and every one of these evas gl functions in
a dummy wrapper in elm_glview, we just give access to the real
pointer.
GLView will always be a wrapper around evas_gl, because that's
what it is by definition.
Summary:
if translatable is FALSE and _translate_string_data_get returns NULL, ts
would be NULL which results into crash.
@fix
Reviewers: seoz, raster, Hermet
Reviewed By: Hermet
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1543
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.
Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
(if someone decides to use beta APIs).
Test Plan: out-off tree build with gcc, g++
Reviewers: tasn
Reviewed By: tasn
Subscribers: seoz, q66, kuuko
Maniphest Tasks: T1721
Differential Revision: https://phab.enlightenment.org/D1528
Summary:
There were wrong checkings in elm_win_size_base_get and
elm_win_size_step_get
@fix
Reviewers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1533
Summary:
Since the sd->image is swallowed to the edje object, it's position and size will be managed by edje smart object.
in the bg side, it doesn't need to care the position and size of the image.
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1525
Summary: First page's number is 0. So I changed '+' to '-'.
Reviewers: seoz, jaehwan, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1530
Summary:
When fileselector is opened, it would be nice to be able to provide initial filename.
Like "Untitled Document" in Gedit, when save for the first time.
More details in Gedit,
Gedit provies default name, "Untitled Document" and does not change default name
while navigating directories.
Once we selected any file, Gedit changes value of name entry to selected filename and
it is not also changed while navigating directories.
@feature
Reviewers: seoz, yakov-g
Reviewed By: yakov-g
Subscribers: seoz
Maniphest Tasks: T1664
Differential Revision: https://phab.enlightenment.org/D1504
eo_add()'s counterpart is eo_del, not eo_unref. Regardless of that, some
objects were being double-deleted which spew out some eo errors. These
things should now be fixed.
bc6b6aa457 is the relevant EFL commit.
This is a fix upon 6e7686c030fab162edb3128de005ec00ea8c0ffc.
This correctly deletes the list even if the windows are still referenced
and even if they are deleted from under out feets.
Summary:
Setting layer of a smart member is not required as it would remain
on same layer of slider.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1447
This reverts commits 123ca6a8744729525889bbc09ee1aff4b2b97b75, 0d527b03f4f630e81ab4480d7160bbf6352b0bac
this is still unusable even after being fixed so the fix was unnecessary to begin with
Summary:
Changed the text for Radio "changed" event to:
This is called when the radio object is selected.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: stefan_schmidt, seoz
Reviewed By: stefan_schmidt, seoz
Subscribers: stefan_schmidt
Maniphest Tasks: T1657
Differential Revision: https://phab.enlightenment.org/D1445
The scale is used for the application to be scaled.
If the application isn't made on the basis of scale 1.0,
the application layout will be scaled inappositely. So if the
application set the base scale, it is applied when the application is scaled.
This was leading to never enter the cnp functions dedicated to Wayland,
as the given object was not a window. The Copy And Paste test was not
working for this reason.
Summary:
If item select callback is elm_genlist_clear and genlist object have many item, elm_genlist_clear was broken.
This reason is due to incorrect code. In Old code, check the item focus after an item was deleted. So, I changed the order of the code.
Before item was deleted, Check the item focus.
@fix
Test Plan: I revised the elementary_test code and tested with that.
Reviewers: raster, SanghyeonLee, seoz
Reviewed By: seoz
Subscribers: bluezery, SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D1418
Summary:
Label size is incorrectly calculated (text does not wrap) if
elm_label_line_wrap_set() is called before elm_label_wrap_width_set().
@fix
Test Plan:
The label3 test case is added to show the bug case.
In label3 test case, if we switch the calling sequence of
elm_label_line_wrap_set() and elm_label_wrap_width_set(),
the result is different.
Reviewers: raster, seoz, woohyun, Hermet
Differential Revision: https://phab.enlightenment.org/D1369
Summary:
If gengrid select mode is not ELM_OBJECT_SELECT_MODE_ALWAYS, ELM_OBJECT_SELECT_MODE_ALWAYS mode for
elm_genlist_item_select_mode was broken. In the item select routine, item mode(it->mode) was not checked.
So, I added the check routine there.
@fix
Test Plan: I revised the elementary_test code and tested with that.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: SanghyeonLee, bluezery
Differential Revision: https://phab.enlightenment.org/D1372
This completely breaks automatic UI mirroring. The code there was
correct. Please, before removing code, contact the original author and
make sure you don't break things down. Especially if your reason for
removing is "this doesn't make sense to me" instead of "this breaks X
Y."
This reverts commit 24983fed239a3b37c05cc3c65ed9c56953a7176b.
thre are still all the old engines supported inside, but docs dont say
so so effectively deprecated. also handle a NULL engine. this is part
of our engine/display system cleanup.
Summary:
elm_widget calls _item_del_pre_hook of each widget and widget can
decide item deletion by return type. But gengrid and popup widget implemented
those _item_del_pre_hook function as a void type.
So this commit fixs the return types to Eina_Bool and changes gengrid widget to return EINA_FALSE when
the item wants to be deleted later.
And when the item wants to be deleted directly, it returns EINA_TRUE.
@fix
Test Plan: test in demo.
Reviewers: seoz, raster, bluezery
Subscribers: Hermet, jaehwan
Differential Revision: https://phab.enlightenment.org/D872
now that we have ELM_DISPLAY and ELM_ACCEL we have little need for a
lot of the elm engine stuff and frankly a lot was broken if you used
multiple engines etc. so this fixes a lot of it nd removes a lot of
cruft. i think i got it all right, but i may have oppsied. this also
remo9ves engine support for engines long gone from evas.
Summary:
ELM_OBJECT_SELECT_MODE_ALWAYS mode for elm_genlist_item_select_mode
was broken. In the item select routine, item mode(it->mode) was not
checked. So, I added the check routine there.
@fix
Test Plan: I revised the elementary_test code and tested with that.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: SanghyeonLee, bluezery
Differential Revision: https://phab.enlightenment.org/D1347
This reverts commit 2e2d003efeded27955cc9301279cd3a0d362f548.
Revert this patch to leave the credit to Andrii Kroitor.
I will fix this correctly in the next commit.
Sorry Andrii for the wrong review comments that can break compatibility.
But actually it was not documented at all so there was no problem.
Just to please hermet, let's not do more.
This reverts commit a2afbe91e851f3d943736d2a1aae9e2721d1a0d5.
definitely this will break compatibility.
and as i mentioned, we should prevent as possible that
until there are other methods.
Summary:
added support of bottom_left, bottom_right, top_left, top_right styles
of notify that are present in default theme
@fix
Reviewers: cedric, seoz, Hermet
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1329
if entry has selection, it would be cleared if selection region set is requested again.
because entry cancel the selection area after it reset the selection area.
unfortunately, the selection area is new selection so selection area is gone.
this patch prevent clearing selection and keep the new selection.
@fix
the engine checks are also broken - but that's a much bigger change,
so this fixes elm config and main code to not do their x11 work if no
DISPLAY env var is set. this is right for a wayland world where you
don't want DISPLAY but WAYLAND_DISPLAY set and used. this fixes
several ERRs that should never have hapapned in this setup.
lots of code unsing ENGINE_COMPARE where it should get the engine from
the ecore_evas directly - it happened to work as we happened to have
apps that have windows only for x11, or wayland etc, but not both in
an app. this was wrong, so remove the engine compare macro and do it
properly. no laziness.
this was yet another thing broken by the mostly-unreviewed and untested widget item focus feature. it's still not completely fixed, since the reorder modes are broken, but at least it works for the general case again
@fix
@fix
moved the user callbacks call at the end of the function, so the user
is able to modify the list without making the code below the call to
fail miserably.
Also improved the Genlist Del test to also include this case.
@fix
To calc the position in a table you need to make the modulo of the col/row size, not the modulo on the x/y value
This unbreak the elm_gengrid_item_pos_get() function that was reporting wrong values
Issue reported by Stefan Schmidt. Above atspi function had EAPI attribute
defined in implementation file, however this symbol should not be public in
elementary 1.11.
These headers are installed in the system but not officially supported
as they are considered as internal headers.
The reason why they still need to be installed is that
- they were exposed even in the previous releases.
- they are needed for widget customization (unofficially)
- or it will break ewe.
Special thanks to Stefan for the reporting.
Summary:
Elementary application crashes on startup when it is running with
wayland engine. This crash problem happens while ecore_x_screensaver API
is being called from _win_noblank_eval funcion. Thus we should not call
ecore_x_screensaver APIs if elm win doesn't have X11 window.
Test Plan:
1. build efl and elementary to support x11 and also wayland
1. run weston without xwayland
2. run elementary_test on the weston
Reviewers: raster, seoz, stefan_schmidt, devilhorns
Differential Revision: https://phab.enlightenment.org/D1293
misspelled.
In case someone exports the ELM_ENGINE to be wayland-shm or
wayland-egl, let's handle That case also. Typically it is set to
wayland_shm or wayland_egl but since we check variants of spelling for
other engines also, then let's check it for the wayland engines too.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
this deals with an issue brought up today on irc - seemingly rage
asking for accel is causing segvs in vbox with its gl accel subsystem
- the only way to disable this is an env var, and this is unfriendly,
so make config gui and stuff to mess with accel preference to fix this.
Summary:
In case, when ctxpopup content have larger size than parent object, (by height, width or both) was resized popup at the full width or height of parent object size.
@fix
Reviewers: raster, seoz, cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1266
Summary: Do not set access info for naviframe prev_btn and next_btn when their access info are already set.
Reviewers: Hermet, kimcinoo
Reviewed By: kimcinoo
Differential Revision: https://phab.enlightenment.org/D1255
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.
Reviewers: z.kosinski
Reviewed By: z.kosinski
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1227
Don't call ecore_x functions unless we are running under an
X11-compatible engine, else we get segfaults in elm_apps.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
better - why?
1. no reliance on fnmatrch headers - have special enums for this so
fnmatch is an internal detail (casefole may not exist)
2. don't leak strduped strings - free them when done
3. have the same code for genlist and grid (dup for now until an
interface makes it the same search interface)
4. improve docs
5. get right @since version
6. use label get func in item class - providing a func won't work when
multiple items of multiple classes exist in the list
As discussed in IRC, the commit that added text_part_set,
text_part_get functions to elm_button are wrong. The correct functions
to be used are from elm_layout: text_set and text_get.
Fixed the example to use these functions that are inherited on
elm_button from elm_layout and fixed the cleanup of childrens
in the parent window by using the del event callback.
Summary: This function allows user to search for item in Gengrid.
Test Plan: elementary_test -to "Gengrid Item Search By Text"
Reviewers: seoz, singh.amitesh, Hermet, raster
Differential Revision: https://phab.enlightenment.org/D1178
Summary:
This patch is dependent on D1193 and D1136.
It will be pushed after D1193 and D1136 patch.
Reviewers: singh.amitesh
Differential Revision: https://phab.enlightenment.org/D1168
Conflicts:
src/lib/elm_genlist.c
Summary: When item looping feature is on and press up or down key, screen seems to be frozen.
Test Plan: elementary_test -to "genlist focus" -> click item looing enable -> move list up and down
Reviewers: anand.km, seoz, woohyun
Subscribers: singh.amitesh
Differential Revision: https://phab.enlightenment.org/D1193
Removed portability warnings from Automake.
Removed *.eo.hh from BUILT_SOURCES.
Fixed some redeclaration of variables.
Added datarootdir and datadir to elementary.pc.in.
Youngbok Shin
Daniel Juyung Seo
shilpa.singh
Amitesh Singh
Tae-Hwan Kim
Cedric BAIL
artem.popov
ChunEon Park
Kateryna Fesyna
woochanlee
Carsten Haitzler
Ryuan Choi
Adrien Nader
Tom Hacohen
Jean-Philippe Andre
Lukasz Stanislawski
Jihoon Kim
Hosang Kim
Mike Blumenkrantz
zmike
Daniel Zaoui
Jaehyun Cho
Jaehwan Kim
Boris Faure
Wonguk Jeong
Srivardhan Hebbar
Savio Sena
Daniel Kolesa
Jae Yong Hwang
Vincent Torri
Vincent Torri
Jaeun Choi
Thiep Ha
SangHyeon Lee
Jérémy Zurcher
Andrii Kroitor
Davide Andreoli
Stefan Schmidt
Gwanglim Lee
Chris Michael
Chinmaya
Anand
Mykyta Biliavskyi
Sanjeev BA
Zbigniew Kosinski
Cedric BAIL
Felipe Magno de Almeida
Jyotiprakash Sahoo