Smart data is already initialized so we do not need to re-initialize them if the value equals to 0, NULL, or EINA_FALSE.
Sometimes re-initializing smart data explicitly is needed for readability. So there are left overs.
SVN revision: 82228
Subject: [E-devel] [PATCH] elm_icon is disappeared when theme hook is
called.
[Current Issue]
- The elm_icon can be disappeared when theme hook is called.
You can see the problem in the below situation.
a) elementary_test -> Layout select
b) elementary_config -> Fonts(toolbar) -> select some font
class, font,
style, size
c) Select "Apply" button
then two icons in title layout are disappeared.
[Main cause]
- when theme hook is called, internally
_elm_image_smart_sizing_eval
function is called.
The function calculates icon's min, max size.
But min, max size is calculated only in case no_scale is true or
resize_down or resize_up is false.
If application isn't set no_scale or resize_down/up, minw and
minh value
is just -1.
So when theme hooks is called then sizing_eval is called, icon's
min size
is -1 and that is disappeared.
[Change Description]
- I just added evas_object_size_hint_min_get(obj, &minw, minh) in
_elm_image_smart_sizing_eval.
Patch is working well, but I don't think this is right solution
because
that would break image(icon) min,max concept
SVN revision: 74163
new schema.
els_icon smart object was brought to be the base of the image widget,
in the form of an image class.
An elm icon is now a elm image, with a little more on top of it.
An elm photo is a now base widget aggregating an icon.
Toolbar's internal usage of the former els_icon is now changed to
icons, instead.
Some naviframe instantiations were set to enable events during
transitions, because this code is buggy and my chages exposed the
problem. It will be fixed as soon as I get to port Naviframe.
SVN revision: 71429
On Wed, Mar 7, 2012 at 12:21 PM, cnook <kimcinoo@gmail.com> wrote:
> Dear All, Hello.
>
> There was no API for preload cancel. simple
>
> Sincerely,
> Shinwoo Kim.
SVN revision: 68879
If you try to create a new widget, you must be sure that the parent
is really an evas object.
With the previous implementation it was possible to call an _add
function for an elementary widget with any non-null pointer as parent
eventually causing crashes (like with the elm_box).
SVN revision: 55521
Setters can't receive const pointers.
All setter need corresponding getter.
In this patch, i adjust getter in: Bg, Box, Icon, Image, Win and Main.
SVN revision: 53917
* Remove vim modelines:
find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;
* Remove leading blank lines:
find . -name '*.[cxh]' -exec sed -i '/./,$!d'
If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0
SVN revision: 50816
GENERAL WARNING:
do NOT delete sub-objects (elm_widget_sub_object_add) or resize object
(elm_widget_resize_object_set) from del_hook()!! These are deleted
automatically before this function is called, thus you might double
free.
Fixed all occurrences I've spotted with valgrind. Please do not add more :-)
SVN revision: 43682
2. standardise all callback names to be x,y,z etc. if they have multiple words.
3. add cal to get the region viewed
4. test photocams signals and new call
SVN revision: 43069
this is a patch for the elm_image so far.
After some valgrind work and with the help of Gustavo, the orient code
for the image is not leak free (according to valgrind). According to
k-s, this way of doing things would avoid any nasty caching errors I've
been getting though valgrind before.
SVN revision: 40314