Summary:
1) Recalc error occurs if combobox_hover_begin() was called by the app, it can be reproduced by keeping elm_combobox_hover_begin() in the test_combobox.c
2) Content_set in hover always considered "bottom" as it's best_location as it done during the constructor.
@fix
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan:
It can be reproduced by keeping elm_combobox_hover_begin() in the test_combobox.c.
Also the changing the position of combobox in the window would give top/bottom as it's best location.
Reviewers: cedric, shilpasingh
Reviewed By: shilpasingh
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D3544
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
it's wierd to expand hoversel without items.
the behavior made me suprised before i analyzed it.
it looked almost a bug.
if you have any other objections, please ping me.
conceptually, ctxpopup won't give any geometry information of the container.
this event is a way for returning the information of the container for user scenarios.
@feature.
fix @T2042
Coverity CID1347398 reports that this could potentially be a
non-portable assumption resulting in a sizeof mismatch. Fix this by
using the actual structure type in the call to calloc.
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
This patch just fixes a compiler warning about using fw/fh
uninitialized if the conditional is false
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
previously-applied max size hints should not be unset; these are only
able to be set externally from a parent object, so don't overwrite them
internally
@fix
Summary:
If argument variable is not used in function, then only
that variable should be declared as EINA_UNUSED.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
@fix
Reviewers: Hermet, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D3525
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
It was changed for testing shrink mode signals.
But, it was unnecessary change for default theme.
Test Plan: N/A
Reviewers: zmike, jaehwan
Differential Revision: https://phab.enlightenment.org/D3536
Summary:
When elm_sys_notify was not needed, its singleton instance
is NULL. Eo complained about passing a NULL pointer.
Thanks to bu5hm4n (Marcel Hollerbach) for the report.
@fix
Reviewers: stefan_schmidt, cedric
Subscribers: bu5hm4n
Differential Revision: https://phab.enlightenment.org/D3535
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
With the push of 1056b6ed01475817da2439012057d11865d2c5d8, elementary
compile broke due to undeclared variables. This patch fixes elm to
compile again by declaring the missing vars.
@fix
@raster, Please double check this change as I am unsure if it is what
you Really intended here.
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
this fixes the config monitoring to not use flush.cfg but to use the
correct profie.cfg or base.cfg in the profile we are using. this is
necessary to do "special" profiles per screen so apps that switched to
another profile because asked by e, monitor THAT profile for changes
specifically and dont also switch profiles since they have been told
what to use now.
@fix
this adds the ability to have one profile automatically be derived
from another with modifications applied. right now it only can do a
very limited modification - multiple scale. over time this will
expand. this is only inteded otbe sued by a DE like enlightenment, so
it's not going to be documented fully at this point.
@feature
tis would also make behavior more consistent with the tool as before
sometimes it flushed + saved, sometimes just flushed which would lose
settings. now since this works right in elm config in the lib, we dont
need to save if we flush as flush saves too.
support the ability to have hidden profiles that begin with a dot (.)
char like all hidden files/dirs. to do this we need to also be able to
create profiles with a given name (a hidden name) without switching to
them, so add the ability to save out to a specific profile name
without switching to it. of course this means to list profiles we need
to list them or list ALL includiing hidden profiles.
@feature
Summary:
Combobox is a combinational widget of a drop-down list and single line entry.
Based on the text entered in the entry, the list items are filtered accordingly.
Signed-Off By: Cedric Bail <cedric.bail@free.fr>
Signed-Off By: Divyesh Purohit <div.purohit@samsung.com>
Test Plan: test_combobox.c is added to elementary test
Reviewers: raster, shilpasingh, cedric, jpeg, stefan_schmidt
Reviewed By: raster, shilpasingh, cedric
Subscribers: SanghyeonLee, shashank0990, singh.amitesh, tasn, raster, seoz, poornima.srinivasan, rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D2537
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
when using elm_object_part_content_set(hover, "smart", content); it would cause segfault, this patch would fix T3004
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan:
please open the hover3 example in elementary for testing it, the hover
content shouldn't leave the window as "smart" direction is used.
Reviewers: shilpasingh, raster, cedric, Hermet
Subscribers: rajeshps, govi
Maniphest Tasks: T3004
Differential Revision: https://phab.enlightenment.org/D3524
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If auto_update feature changes hoversel width,
dismiss animation seems awful because hoversel contents move to
changed position in an instant.
This patch makes hoversel update its content with clicked item
after dismiss animation finished.
Test Plan: elementary_test hoversel
Reviewers: raster, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D3519
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Hoversel Widget is designed in such a way that it accepts top/bottom/left/right directions , internally it uses hover widget which does not take care if its content goes of it's parent (Elm_Win in most cases) . this patch ensures that the drop-down content remains restricted in visible hover_parent. it would fix T2965
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Signed-off-by: Jee-Yong Um <conr2d@gmail.com>
Test Plan:
Open entry widget and right click to show a hoversel widget, check if the hoversel or hover content goes out of the window.
this is what hoversel would look like after this patch {F27551}
Screenshots of top-left / top-right/ bottom-left and bottom-right corners in entry after this patch
{F27553}
{F27554}
{F27555}
{F27557}
Reviewers: shilpasingh, conr2d, raster, cedric, Hermet
Subscribers: rajeshps, govi
Projects: #elementary
Maniphest Tasks: T2965
Differential Revision: https://phab.enlightenment.org/D3513
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The following new color classes
for scroller widget are added and changed.
Reviewers: raster, cedric, Hermet, kimcinoo, woohyun
Differential Revision: https://phab.enlightenment.org/D3493
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Apply ctxpopup color class
- ctxpopup_bg
Test Plan:
1. change ctxpopup bg color class in colorclass.edc
2. run elementary test
3. check the color of ctxpopup bg
Reviewers: Hermet, kimcinoo, woohyun, raster
Differential Revision: https://phab.enlightenment.org/D3492
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Apply popup color class
- popup bg
- popup title bg
- popup title text
- popup text
Test Plan:
1. change popup color class in colorclass.edc
2. run elementary test
3. check the color of popup
Reviewers: Hermet, kimcinoo, woohyun, raster
Differential Revision: https://phab.enlightenment.org/D3489
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The following new color classes and text classes
for spinner widget are added.
"spinner_bg", "Spinner Background"
@feature
Reviewers: raster, cedric, Hermet, kimcinoo, woohyun
Subscribers: SanghyeonLee, eagleeye, id213sin
Differential Revision: https://phab.enlightenment.org/D3488
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Add new text classes and color classes for Entry widget according to
consistency with other widget's class.
And it removes legacy classes. If we need to support backward
compatibility, the legacy classes have to be maintained in each widget.
Test Plan: N/A
Reviewers: cedric, woohyun, jaehwan, kimcinoo, raster
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D3486
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The following new color classes and text classes
for calendar widget are added.
"calendar_year_text" - Year Text in Title Area
"calendar_month_text" - Month Text in Title Area
"calendar_weekday_text" - Weekday Text
"calendar_day_text" - Day Text
"calendar_day_text_holiday" - Holiday Text
"calendar_day_text_today" - Today Text
"calendar_day_text_disabled" - Disabled Day Text
"calendar_day_selected" - Selected Day Effect
"calendar_day_highlighted" - Highlighted Day Effect
"calendar_day_checked" - Checked Day Effect
@feature
Test Plan: N/A
Reviewers: woohyun, raster, cedric, kimcinoo, jaehwan
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D3482
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
minw and minh are overwritten in the next line at once.
This patch removes a meaningless line.
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3450
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>