Summary:
The numerical formula below is calculated with the double type.
-> h_pad / edje_object_base_scale_get(wd->resize_obj) * elm_widget_scale_get(obj) * elm_config_scale_get()
But if number of significant figure of the return value goes over 15, the epsilon error will happen.
Because of that, it is better to divide to do later.
Reviewers: woohyun, raster, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2872
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
We don't have event block area in mbe.
Item clicked callback is not called when user clicked the item in mbe shrinked state.
However, item press effect will be shown.
@fix
Test Plan:
Delete the line always calling expanded set API in MBE clicked callback.
Execute MBE sample in elementary_test.
Check the item got a click event but not call the clicked callback.
Reviewers: Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2870
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
After applying eo to elm_flipselector_item,
APIs in elm_flipselector_common.h are generated by eolian.
elm_flipselector_common.h is no more necessary.
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D2867
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm_calendar_weekdays_names_set() API is generated by eolian,
but its prototype is defined in both elm_calendar_common.h and
elm_calendar.eo.legacy.h.
Remove duplicated reference from elm_calendar_common.h
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D2866
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
strftime is quite a bad POSIX API. You won't know the size it needs to put the strings in
until you did give it enough byte and it could also fail without a clear way to detect it.
So this patch work around that and introduce a currently internal helper that will be moved
later to Eina.
This patch has been triggered by the issue reported and the attempt fix from D2877.
Summary:
Converted docs of elm_diskselector.eo and elm_diskselector_item.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2864
Summary:
Converted docs of elm_ctxpopup.eo and elm_ctxpopup_item.eo to new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2862
Summary:
Converted docs of elm_dayselector.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2863
Summary: eina_environment_tmp_get returns a const char string, so we
should declare the variable to match
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
Updated docs of elm_container.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2852
Summary:
Converted docs of elm_clock.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2849
Summary: This fixes ticket T2573 where an extra new line was being
added after dropping an item in the Genlist DnD tests. There's really
no need to be appending a '\n' on each item here as that ends up
adding an extra blank item to the drop.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
Changed the docs of elm_calendar.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2846
* convert opaque region theme part to SPACER
- add rels for shaded/maximized state
* namespace opaque region theme part
* update opaque region only on pre-render
- fixes race condition between render size and opaque size
ref T2575
Summary: This fix adjusts the shadow spacer elementary when we
maximize/unmaximize a window. When in a maximized state, we do not
have to reserve space for the window shadow. This partially fixes
T2578. I say partially because there is still a little bit of blank
space around a maximized window.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
Fix genlist crash issue of T2553 which happened by dangling pointer
access after deletion in item_select.
after item_focused callback, user call deletion and item_select din't
cover those cases.
Resolves: T2553
@fix
Test Plan: elementary_test -> genlist focus -> choose Genlist Cear on Focus
then originally crash will be happened. This patch will solve that problem.
Summary:
If x coordinate is equal to 0, key action is no more
effective as EINA_FALSE is returned. This is creating problem
in looping. Looping will be done when x < 0, but as soon as
x == 0, _key_action_move starts returning EINA_FALSE. Same
thing applies to y coordinate and other extremities.
@fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Test Plan: elementary_test -> Scroller -> Loop in X axis -> scroll left using left key(looping does not happen)
Reviewers: raster, Hermet, cedric, singh.amitesh, SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: sachin.dev, SanghyeonLee, eagleeye
Differential Revision: https://phab.enlightenment.org/D2778
Title icon of popup is not getting shown.
steps to reproduce:
1. elementary_test -to "popup"
2. click "popup bottom title + text + 3 buttons"
In the test popup example, the initial parent of icon is popup.
The title_icon is reset to null while adjusting elm parent from popup
to main_layout (elm_widget_sub_object_add which calls sub_object_del of popup)
on swallowing icon to main_layout.
Resolves: T2581
@fix
Summary: This patch fixes opaque region setting under wayland in a
more proper/accurate way. This now sets the opaque region to be Just
what is visible (ie: only the dialog).
NB: This does not actually fix T2575 as that problem is inside E itself.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: Elementary does not support toggling of shadows on windows,
but Enlightenment does so we need to use the proper program signal for
that.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This fixes T2575 more accurately (combined with previous
theme adjustments). Previous code would use a spacer object to help
calculate window opaque region. This is no longer necessary due to the
previous theme changes, and now calculates window opaque region to
coincide with what Enlightenment is expecting.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This fix addresses the issue of Elementary's Wayland border
theme not match close enough to E's. Now they are very much identical
with the exception of the program and signal names.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This adjusts the focus frame of Elementary applications to
more closely match what is done in X11. T2575 says that the focus
rectangle was larger than expected by a few pixels, so this slight
adjustment compensates for that.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
Changed the docs of elm_bubble.eo and elm_button.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2827
Without this, apps can't set a GLView to be in COPY mode.
COPY mode allows the glview to "poke holes" in the backbuffer of
the window, without the need for other objects below (eg. a
transparent rectangle in COPY mode).
Summary:
Converted docs of elm_bg.eo to new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Differential Revision: https://phab.enlightenment.org/D2819