Commit Graph

302 Commits

Author SHA1 Message Date
Lukasz Stanislawski 2ca1f8a75a atspi: properly include at-spi headers.
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.

Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
  (if someone decides to use beta APIs).

Test Plan: out-off tree build with gcc, g++

Reviewers: tasn

Reviewed By: tasn

Subscribers: seoz, q66, kuuko

Maniphest Tasks: T1721

Differential Revision: https://phab.enlightenment.org/D1528
2014-10-17 16:57:26 +01:00
Tom Hacohen 236bab8d53 Change according to recent Eo changes, and fix related wrong unrefs.
eo_add()'s counterpart is eo_del, not eo_unref. Regardless of that, some
objects were being double-deleted which spew out some eo errors. These
things should now be fixed.

bc6b6aa457 is the relevant EFL commit.
2014-09-30 14:54:52 +01:00
Tom Hacohen 7629c147eb Eo related: Change according to recent changes in eo_add().
For more info check out a7560dbc61 in
the EFL tree.
2014-09-25 17:39:34 +01:00
Tae-Hwan Kim e2a14d22ae elm_map: the widget use efreet cache home to save image files to, so efreet should be initialized.
Summary: @fix

Reviewers: raster

Differential Revision: https://phab.enlightenment.org/D1371

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-09-03 17:05:02 +02:00
Lukasz Stanislawski 09b9ef0bc0 atspi: expose more actions through atspi bus.
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.

Reviewers: z.kosinski

Reviewed By: z.kosinski

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1227
2014-07-25 11:58:16 +02:00
Daniel Zaoui 63168c996f Elm_Map: port API to eo file.
This function has to be described in elm_map.eo so Eolian can
generate the legacy and Eo APIs.
2014-07-22 13:59:41 +03:00
Stefan Schmidt d3b0bb58a4 elm_map: Avoid unlikely division by zero.
The division by zeor could happen when zoom_cnt is zeor OR when region_cnt
is zero. No need for both cases. In the curent implementation this is
impossible as both are hard coded defines. But code changes so we should
handle this.

CID: 1216619
2014-06-17 11:01:22 +02:00
Zbigniew Kosinski 9ce23f0004 atspi:Set roles for widgets
Reviewers: stanluk, m.jagiello, raster

Differential Revision: https://phab.enlightenment.org/D930
2014-06-11 11:07:16 +09:00
Tom Hacohen efa41c7d75 Elm: Update code to use the new class names generated by eolian. 2014-06-03 11:54:44 +01:00
bluezery 044b99a2f1 elm_map: Add new elm_map_region_zoom_bring_in() API
Summary:
By using this API, we  can do region show & bring in concurrently.
This needs some tuning more because some main layouting logic in map
needs to be modified to support more smooth animation.
I will spare my time to do that later.
@feature

Reviewers: Hermet, raster, stefan_schmidt

Reviewed By: raster

CC: Jaehyun

Differential Revision: https://phab.enlightenment.org/D887
2014-05-28 17:08:01 +09:00
Jaehyun Cho 39b35f059d elm_map: Fix to calculate map size not to be smaller than viewport size
Summary:
Fix to calculator map size not to be smaller than viewport size when zoom mode is either fit or fill.
Previously, map size could be either smaller or larger than viewport.
@fix

Reviewers: Hermet, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D861
2014-05-19 13:30:04 +09:00
Jaehyun Cho 7e6799db44 elm_map: Fix to show and bring in a correct region after zooming
Summary:
Show and bring in a region which has the given latitude and longitude after zooming
@fix

Reviewers: Hermet

CC: seoz

Differential Revision: https://phab.enlightenment.org/D851
2014-05-14 12:27:27 +09:00
Jean-Philippe Andre d94daa2a63 elm_map: Fix compilation warning/error
ELM_WIDGET_DATA_GET_OR_RETURN can take a VA_ARGS if the function
should return something.
2014-05-12 15:44:18 +09:00
Jaehyun Cho d0c95fe3af elm_map: Fix to support customized style for elm_map
Summary: Load a map theme with a style to support customized style

@fix

Reviewers: Hermet

Reviewed By: Hermet

CC: seoz

Differential Revision: https://phab.enlightenment.org/D845
2014-05-12 13:50:38 +09:00
Carsten Haitzler 9d55fab418 entry: wrong viewport value calculation issue fix
Summary:
Issue: As entire scroller edje co-ordinates was being taken instead of the actual viewport value,
if in scroller edje more parts are added apart from just "elm.swallow.content", then the viewport value
set will be wrong. hence the selection handlers will not hide when they have to hide.

solution: Instead of taking scroller edje's geometry, get the actual viewport values.
To get viewport x,y a new scrollable interface is also added.

signed-off by: Shilpa Singh <shilpa.singh@samsung.com>

@fix

Test Plan: Selection handlers have to hide correctly when the text is scrolled in a scrolled entry, if the scroller edc of entry has more parts added other than elm.swallow.content, then when we scroll the selection handlers are not hidden correctly.

Reviewers: jaehwan, woohyun, seoz, Hermet, raster

CC: govi, rajeshps, thiepha

Differential Revision: https://phab.enlightenment.org/D674
2014-04-21 12:31:49 +09:00
ChunEon Park 5ab6a7739f widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.

conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
Jaeun Choi d8d53f4268 map: apply key binding
Summary: This patch applies key binding to elm_map.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D733
2014-04-15 14:52:06 +09:00
Tom Hacohen d4108660a8 map: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
wonguk.jeong 173df1d361 map: remove memory leak
Summary:
1. Name of sources from external module was not free'd. (there was type mismatch between external module and internal impl.)
2. after eina_module_list_free(), eina_array_free() was not invoked.
3. alloc'd but not free'd

@fix

Test Plan: valgrind

Reviewers: raster, cedric, seoz, bluezery, woohyun

CC: seoz

Differential Revision: https://phab.enlightenment.org/D661
2014-04-04 11:47:40 +09:00
Rajesh PS 69bdc47081 elm_map: Fixed a leak when ecore_file_download_full fails
Summary:
The url variable used for ecore_file_download_full api was not being freed when the api failed

@fix

Test Plan: elementary_test->map

Reviewers: seoz, daniel, raster

Reviewed By: raster

CC: govi

Differential Revision: https://phab.enlightenment.org/D692
2014-04-03 19:16:14 +09:00
Daniel Zaoui 2f3f5b31cd Map: fix params names 2014-03-31 16:36:22 +03:00
Daniel Zaoui 3788c314a5 Eolian: Integration of Map and Map_Pan 2014-03-24 08:50:04 +02:00
Daniel Zaoui 7460467419 Eolian: Integration of Scrollable Interface 2014-03-18 08:14:44 +02:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
Jaehwan Kim db23689614 access: Add smart signal "access,changed"
It occurs that access mode is changed.
Application can add this callback for each widget.
2014-02-08 14:05:14 +09:00
Daniel Juyung Seo 5f0ca660b4 elm: Unified the usage of strncmp.
- Use strlen instead of sizeof(x) - 1 for string length calculation.
- Use !strncmp for null check.
2014-01-27 02:07:44 +09:00
ChunEon Park dbacb2fef9 elementary - send signal "language,changed" with one way in the widget.
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.

This makes reducing duplicated code and supporting language,chagned from all widgets.
2014-01-23 19:30:34 +09:00
ChunEon Park aebdcff513 elementary - use the focused/unfocused string in widget defined.
Now, it will share the strings so that reduce the binary size also user uses it in one way.
2014-01-23 17:27:17 +09:00
Jihoon Kim 54ec084e76 fix some typos in comment and description 2014-01-22 13:20:15 +09:00
Daniel Juyung Seo 5353aa863c elm: Removed unnecessary null check for free. 2014-01-22 11:13:11 +09:00
Daniel Juyung Seo 0d1ac0fa05 elm: Removed unnecessary null check for eina_list_free. 2014-01-22 10:55:01 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Daniel Juyung Seo 43533a2fb9 elm: Removed unnecessary null check for eina_stringshare_del. 2014-01-22 10:54:45 +09:00
Daniel Juyung Seo c066009c49 elm: Removed unnecessary null check for ecore_idler_del, ecore_idle_enterer_del. 2014-01-22 10:54:28 +09:00
Daniel Juyung Seo a4f3074f9c elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
2014-01-21 23:18:16 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Carsten Haitzler a188fdda01 fix sign/unsigned compare warn 2014-01-11 16:23:23 +09:00
Carsten Haitzler ae306c98fb use long not unsigned long - ftell returns long. 2014-01-11 16:19:25 +09:00
Carsten Haitzler 0c9480fc76 elm map - fix incorrect return check of fread
this fixes CID 1132735 (real bug)
2014-01-10 16:53:43 +09:00
Carsten Haitzler 1ac66c892a elm map - fix incorrect return check of fread
this fixes CID 1132736 (real bug)
2014-01-10 16:52:44 +09:00
Carsten Haitzler 900ae28870 elm map - fix incorrect return check of fread
this fixes CID 1132737 (a real bug)
2014-01-10 16:51:06 +09:00
Jihoon Kim 5b64757cc3 map: fix allocator sizeof operand mismatch reported by clang
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-vKmgoZ.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-5OVcIZ.html#EndPath
2014-01-08 08:51:15 +09:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
Carsten Haitzler 9d4a9900cc option build deps that efl guarantees... now just are assumed and not ifdef'd 2013-11-12 22:56:05 +09:00
Tom Hacohen 4c8d03894c Changed Eo class names to be consistent. #2
All the class names are now of the format: Elm_Type_Subtype_Extra

Thanks to Yakov for pointing out I forgot a few and for giving me a nice
list.
2013-11-07 14:30:22 +00:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Juyung Seo d22076681b elm: Fixed formatting about smart_event check for code consistency.
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Jaehyun Cho db2d711d64 [elm_widget] Enable not to add resize object to or delete resize object from sub object when the resize object is set.
Summary: Add one more argument, 'Eina_Bool sub_object' to elm_widget_resize_object_set. If the argument, 'sub_object' is set as EINA_TRUE, the new resize object is added to the sub object and the previous resize object is deleted from the sub object.

Reviewers: Hermet, seoz

CC: Jaehyun_Cho, seoz, raster

Differential Revision: https://phab.enlightenment.org/D265
2013-10-17 01:19:40 +09:00