The string will be freed in application's callback later. So 'const' is
not appropriate.
In elm_slider_indicator_format_function_set and
elm_slider_units_format_function_set.
SVN revision: 69692
<jchanwook@gmail.com>
On Wed, Mar 28, 2012 at 3:06 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> I added one line to fix the bug at tree effect. If the item is equal
to
> expanded_next_item, expanded_next_item set to NULL in _item_del
>
> Thanks,
> Joey
SVN revision: 69691
The squence is hold push -> mouse down -> mouse move -> hold pop -> mouse move continuously.
After upper sequence, the scroller will jump. So I fixed this issue.
SVN revision: 69631
Subject: [E-devel] [patch] elm_genlist - add merging edc strings list
I add like a routine in previous patch.
It add merging routines to realize functions.
also i removed "elm_widget_stringlist_free(cons)"
because all of it is freed at item_unrealize.
SVN revision: 69598
Subject: [E-devel] [?Patch]elm_?multibutto?nentry bug fix
I've attached patch to fix bug in multibuttonentry.
When this widget is unfocused, there's no code for making unfocused
entry in multibuttonentry.
Because of that, when multibuttonentry got focus again, entry couldn't
get focus normally.
so I've added code to fix this issue. when it's unfocused.
Also I removed unused value in resize_button() which is 'padding_inner'
SVN revision: 69583
Subject: [E-devel] [Patch][Genlist] Tree effect bug fix
I found some bugs in tree effect. flickering, emit signal to unrealize
item... so I fix it.
SVN revision: 69582
On Thu, Mar 22, 2012 at 9:38 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> Now, Elm_Map_Marker, Elm_Map_Marker_Class, Elm_Map_Group_Class,
> Marker_Bubble are not used anymore. So I removed all things related
> those in elm_map.
> Please review this patch.
> Thanks
>
SVN revision: 69571
Subject: [E-devel] [Patch][elm_map] Add line, polygon, circle, scale
overlay
This patch adds new overlay APIs (line, polygon, circle, scale) for elm_map.
These overlays are adhered to map even though zooming, panning.
You can test these by doing "elementary_test --> click mouse right -->
overlay"
SVN revision: 69562
Subject: [E-devel] [Patch][elementary] elc_ctxpopup using elm_list
internally.
The patch is for using elm_list as a item controller of elc_ctxpopup.
I have learned that there was an opinion to change the internal
structure
of ctxpopup using the list.
It would be able to match up to your expectation. but it is just a draft
version of using list in ctxpopup.
So, It would be pretty good to me if you give any feedback on this.
Thanks.
SVN revision: 69561
Subject: [E-devel] [Patch][elm_list] bug fix: crash occurs when
container which contains the elm_list is deleted on the "elm_list item
clicked" callback
I have resolved the elm_list issue(goto ELM_LIST_CRASH_ISSUE_MAIL below, I
sent mail but I cannot find the previous mail -_-;).
It would be related with double free issue. In the "sub-obejct-del"
callback which name is _sub_del() sets item->icon to NULL.
And in the EVAS_CALLBACK_MOUSE_UP callback funtion which name is
_mouse_up() calls evas_object_unref();
It would try to free the item->icon but the item->icon is already set to
NULL. So.. the crash would occur..
SVN revision: 69555
Subject: [E-devel] [Patch][elm_map] Map overlay color & grouping &
route Fix
This is patch for elm_map
1. Default and Class overlay can be set color by
elm_map_overlay_color_set().
2. Fix test application for map API testing more.
3. Fix grouping for enabling group callbacks. If overlay group is
clicked, callback will be called.
And elm_map_overlay_group_members_set() API will be added later to get
list of overlays in the group.
4. Simplify route overlay: Previously, many polygon objects are needed
for one route overlay.
But now just one is needed.
SVN revision: 69554
Subject: [E-devel] [patch] elm_genlist - bugfix at item_state_update
I fixed minor error in _elm_genlist_item_state_update.
If item is selected, it sends signal to item and edit_obj.
But edit_obj is not checked by if statement.
I added a parenthesis for it.
SVN revision: 69538
Subject: [E-devel] [Patch][Genlist] Add the moved.after/before signal
instead of moved
Some applications want to know moved.after or before and relative item
because of updating their own list. So I separated moved into
moved,after and move,before.
SVN revision: 69537
Subject: [E-devel] [patch] elm_genlist - bugfix at flip_realize
I found a bug in _item_flip_realize.
It replaces previous string list without free.
this patch fixed for it.
SVN revision: 69536
Subject: [E-devel] [Patch][elementary] elm_list.c - item_content_set()
related.
The Eina_Bool item->dummy_icon and item->dummy_end of Elm_List_Item
indicate whether the content has REAL object or not.
- "not" means.. if elm_object_item_part_content_set(); is called with
NULL content, the Elm_List set the swallow part with
rectangle which has alpha value 0 and the item->dummy_icon or
item->dummy_end is set to EINA_TRUE. -
But in the item_content_set(); it works the opposite way. So when
content set with NULL value the flag should be EINA_TRUE.
SVN revision: 69535
<hyoyoung@gmail.com>
On Mon, Mar 19, 2012 at 11:48 AM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> I found a bug in decorate mode that selection callback is called
twice.
> Because two _mouse_down callbacks are added to a genlist item.
> I'm fixing this bug and some refactoring.
>
> Thanks.
SVN revision: 69520
Rajeev. Thanks Rajeev.
Existing Issue before this change:
The popup width gets scaled twice when theme_hook gets invoked
because of some reason such as style change, change in elementary
scale factor, change in widget scaling etc.
Change Description:
Removed setting scaling of internal object wd->base from theme_hook
as it is set to the widget scaling automatically.
Signed-Off-By: RAJEEV RANJAN<rajeev.r@samsumg.com>
SVN revision: 69492
Attached to the mail is a patch for fixing issues
1. "bg edje object not deleted on deleting colorselector"
2. Theme hook fixed to read data items.
Existing Issue:
bg edje object of colorselector not deleted and data items not read again on theme hook.
Change Description:
1. elm_colorselector's edje object not deleted issue fix.
2. Theme hook updated to read data items again.
Signed-Off-By : ShilpaOnkar Singh <shilpa.singh@samsung.com>
SVN revision: 69459
Chanwook Jung <jchanwook@gmail.com>
On Thu, Mar 15, 2012 at 7:25 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> This patch is evas_object_unref position change properly in
_item_select.
>
> Thanks
> Joey
SVN revision: 69373
Jung <jchanwook@gmail.com> But this will never be correct without
performance issue.
On Thu, Mar 15, 2012 at 4:43 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> I made the patch to fix index bug.
>
> Thanks,
> Joey
SVN revision: 69366
<jchanwook@gmail.com>
On Thu, Mar 15, 2012 at 2:47 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> I made a simple patch. If ELM_LIST_COMPRESS mode, did not recalc
minw/minh
> in _sizing_eval.
>
> Thanks,
> Joey.
SVN revision: 69365
hyoyoung@gmail.com>. I committed his patch except for _calc_job diff.
On Wed, Mar 14, 2012 at 3:09 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all.
>
> This patch include two changes
>
> 1. at _scroll_item, added to check show_item is null or not.
> 2. at _calc_job, added to check genlist type
> because calc_job is added anytime, but some genlist clearing is can
> be done before doing calc_job.
>
> Thanks.
SVN revision: 69349
It's currently kinda hackish, but this can't be nicely solved without some
really needed (anyway) features in smart object callbacks. In the meanwhile
it's nice and working.
Thanks to WooHyun for the catch.
SVN revision: 69324
<hyoyoung@gmail.com>
On Tue, Mar 13, 2012 at 6:52 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> In _item_select, some if conditional is not working as user intention.
> always_select mode checking is reversed and no-select mode is not
checked.
> I add and fix it.
> Thanks
SVN revision: 69292
On Fri, Mar 9, 2012 at 5:49 PM, Hyoyoung Chang <hyoyoung@gmail.com> wrote:
> Dear all.
>
> This is a patch about genlist to add item signal emit hook.
> due to elm_genlist_item_object_get is deprecated,
> item sinal emit hook should be supported.
> So it's added.
>
> + elm_widget_item_signal_emit_hook_set(it, _item_signal_emit_hook);
>
> Thanks
SVN revision: 69111
Now that _elm_preferred_engine is the var. read for it,
let's read env. vars. before we set it, eh?
Now make doc on Elm is back to normality (ie buffer engine used).
SVN revision: 69070
Subject: [E-devel] [patch] elm_gengrid - add item_select_mode_set/get
apis
I made a item_select_mode_set/get in elm_gengrid.
It works like genlist_item_select_mode apis.
+EAPI void
+elm_gengrid_item_select_mode_set(Elm_Object_Item *it,
+ Elm_Object_Select_Mode mode)
+EAPI Elm_Object_Select_Mode
+elm_gengrid_item_select_mode_get(const Elm_Object_Item *it)
from this morning - left over from last night.
SVN revision: 69056
Subject: [E-devel] [patch] Elm_Object_Select_Mode comment update
After updated Elm_Object_Select_Mode naming, some comments are
outdated. I changed it.
SVN revision: 69014
Subject: [E-devel] [patch] elm_genlist - fix typos and remove
display_only variable
I found a mistake in example. and display_only value is remained.
It's fixed some trivial errors.
SVN revision: 69000
elm_genlist_height_for_width_mode_set/get. Use
elm_genlist_mode_set(obj, ELM_LIST_COMPRESS) instead. This may
introduce bugs or performance issue but I will fix this soon.
Signed-off-by: Daniel Juyung Seo <juyung.seo@samsung.com>
SVN revision: 68985
Subject: [E-devel] [patch] elm_list - add select_mode_set and some
remove deprecated apis in examples
Like other widget (genlist, gengrid...), I add select_mode to elm_list.
+elm_list_select_mode_set(Evas_Object *obj,
Elm_Object_Select_Mode_Type mode)
+EAPI Elm_Object_Select_Mode_Type
+elm_list_select_mode_get(const Evas_Object *obj)
And I removed deprecated apis (no_select, always_select) in examples
and edje_externals.
SVN revision: 68971
Subject: [E-devel] [Patch] Ecore, Elementary: Supporting indicator
opacity mode
This is Myoungwoon Roy Kim.
This patches are for supporting the indicator's opacity mode and made by
Jeonhoon Park(jh1979.park@samsung.com) who is responsible for Indicator
application.
Requirements:
- In mobile device, Indicator area should be displayed as Opacity,
Transparency, or sometimes Translucency according to the UX
requirements.
This requirement can be applied in case of fullscreen based menu and
fullscreen applications like video player etc.
Functional requirements:
1. User can set indicator's opacity mode as opacity, transparency, and
translucency
2. User can get the current indicator's opacity mode.
Currently there are no APIs for supporting the upper functional
requirements.
Thus, he added support for indicator's opacity mode.
It is designed for EFL developers easily to set the indicator's opacity
like the existing indicator's mode.
He added a Elm_Win_Indicator_Opacity_Mode structure variable into
Elm_Win
structure.
Meanwhile, new two APIs are implemented independently from the existing
source code.
Anybody please review this and apply it to upstream code.
SVN revision: 68959
Subject: [E-devel] [patch] elm_gengrid - add item_index_get func
I made a patch that's adding elm_gengrid_item_index_get function.
+EAPI int
+elm_gengrid_item_index_get(const Elm_Object_Item *it)
It works like elm_genlist_item_index_get()
SVN revision: 68951
Subject: [E-devel] [Patch][elementary_test] test_label
I have attached a patch for test_label. Please review the patch and
give any feedbacks. Thanks.
SVN revision: 68949
Subject: [E-devel] [patch] elm_gen{list, grid} - add
no_highlight_mode_set/get
actually change it to hilight_mode/set/get with the inverse.
SVN revision: 68947
Subject: [E-devel] [patch] elm_gen{list, grid} - add elm_genlist_select_mode_set
As discussed in irc, I made a patch about unifying
always_select_mode_set and no_select_mode_set.
I'm introducing two apis in genlist (also in gengrid)
+EAPI void
+elm_genlist_select_mode_set(Evas_Object *obj,
Elm_Object_Select_Mode_Type mode)
+EAPI Elm_Object_Select_Mode_Type
+elm_genlist_select_mode_get(const Evas_Object *obj);
And added a enum in elm_general.h
+typedef enum
+{
+ ELM_OBJECT_NORMAL_SELECT = 0, /**< default select mode */
+ ELM_OBJECT_ALWAYS_SELECT, /**< always select mode */
+ ELM_OBJECT_NO_SELECT, /**< no select mode */
+
+ ELM_OBJECT_SELECT_MODE_MAX
+} Elm_Object_Select_Mode_Type;
After this is commited, i'll send a patch about examples and
edje_external.
SVN revision: 68937
Subject: [E-devel] [Patch] elm_genlist : Add tree effect APIs
I made a patch for Tree Effect in elm_genlist.
This feature shows the flip effect when expand/contract the expandable
list.
External APIs :
+EAPI void elm_genlist_tree_effect_enabled_set(Evas_Object
*obj, Eina_Bool enabled);
- Set Genlist tree effect
+EAPI Eina_Bool elm_genlist_tree_effect_enabled_get(const
Evas_Object *obj);
- Get Genlist tree effect status
You can test it. "Genlist Tree Effect".
SVN revision: 68934
Subject: [E-devel] [Patch][elm_map] Change & Add map APIs
I rename & add some APIs.
As previously discussed, I categorized map APIs.
(http://marc.info/?l=enlightenment-devel&m=132685497711772&w=2)
1) Zoom
elm_map_zoom_set/get
elm_map_zoom_mode_set/get
elm_map_zoom_min_set/get
elm_map_zoom_max_set/get
2) Region - Geographic coordinates (region)
elm_map_region_get
elm_map_region_show/bring_in
elm_map_canvas_to_region_convert
I will not use "_geo_" in map APIs. All map APIs are basically used by
geographic coordinates.
3) Property
elm_map_paused_set/get
elm_map_rotate_set/get
elm_map_wheel_disabled_set/get
elm_map_user_agent_set/get
4) Overlay
elm_map_overlay_add/del
elm_map_overlay_xxx
elm_map_overlay_class_xxx
elm_map_overlay_bubble_xxx
elm_map_overlay_route_xxx
I will add line, rectangle, poi overlays ASAP.
5) Source - External Provider (Tile, Route, Name, )
elm_map_sources_get
elm_map_source_set/get
I will add more provider ASAP such as POI, etc.
6) Route
elm_map_route_add/del
elm_map_route_distance_get
elm_map_route_node_get
elm_map_route_waypoints_get
7) Name
elm_map_name_add/del
elm_map_route_address_get
elm_map_route_region_get
6) Route and 7) Name do not return visible objects actually. Those
just return data.
I don't know "_add" suffix is correct for none visible objects.
I cannot decide yet whether those should be removed from map widget.
But current trends are that route, geocoding are tightly coupled with
Map.
If Apps want to use only data, just use elm_map_route_add().
If not, use elm_map_route_add() & elm_map_overlay_route_add().
Also name overlay could be added in the future.
8) Miscellaneous
elm_map_tile_load_status_get
9) Signals
Basic events : "clicked", "clicked,double", "press", "longpressed",
Scroller events: "scroll", "scroll,xxx,xxx"
Zoom events: "zoom,start/stop/change"
Source (provider) events: "tile,load/loaded/loaded,fail" ,
"route,load/loaded/loaded,fail", "name,load/loaded/loaded,fail"
There are some big patches. I think diff program do not make exact
diff. :D.
Anyway, it's better to maintain if this can be in before API fix
(elementary 1.0).
Because after these change, It is hard to maintain old APIs.
PS) Documentations and some minor bugs are remained yet.
SVN revision: 68915
Git svn doesn't respect local 'author'
Have to revert and put the author in the commit msg.
This reverts commit 879a6c3573c3c741841647679dc4d04ccaa3e91a.
SVN revision: 68913
On Wed, Mar 7, 2012 at 12:21 PM, cnook <kimcinoo@gmail.com> wrote:
> Dear All, Hello.
>
> There was no API for preload cancel. simple
>
> Sincerely,
> Shinwoo Kim.
SVN revision: 68879
Hi Raster,
Please find the modified patch after the suggested changes.
[ APIs are provided for setting week_start, weekend_start & weekend_length.Default values are fetched
from elm_config instead of edc styles.]
Please review the patch and push it to svn.
Thanks,
Sumanth
Signed-Off-By: Sumanth Krishna Mannam(sumanth.m@samsung.com)
SVN revision: 68868