1. ELM_FREE_FUNC -> ELM_SAFE_FREE
2. There were a lot of suggestions and consideration in the mailing list.
ELM_SAFE_FREE will be used only when it checks the pointer, deletes it, and initializes it to NULL.
ex)
if (timer)
{
ecore_timer_del(timer);
timer = NULL;
}
=>
ELM_SAFE_FREE(timer, ecore_timer_del);
My first aim was to remove many human mistakes but it looks like people want more optimized code in a code level.
So this macro will be used only for reducing 5 lines of code into 1 line.
Otherwise, I will just call xxx_del() manually.
3. ELM_SAFE_FREE can be used for other del or free functions such as ecore_job_del, ecore_animator_del, eina_stringshare_del, free, ...
There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.
This is not all. I will work on enhancing elementary more and more.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
Subject: Re: [e-users] 3 small corrections in elc_player
Hi,
1. remove __UNUSED__ for parameter that is used.
2. emit a "elm,player,play" signal as is done in _pause to keep the
state of pause/play buttons in sync.
3. Correct double_to_string which misses out subtracting hours to get
seconds.
SVN revision: 83855
Previous part names are just the swallow part names
but in modified version, the part names chaned to simpler meaning names to use.
i.e for button
elm_object_content_part_set(button, "elm.swallow.icon", icon);
-> elm_object_content_part_set(button, "icon", icon);
SVN revision: 65295
This object should be linked with an elm_video to be
usefull at all. If people have some graphical skill,
the kind of thing I lack, you are welcome to improve
this player !
SVN revision: 61053
Daniel Juyung Seo
Daniel Juyung Seo
Cedric Bail
Daniel Zaoui
Tom Hacohen
Gustavo Lima Chaves
Arvind R
Carsten Haitzler
Yakov Goldberg
Jihoon Kim
Mike Blumenkrantz
Jiyoun Park
Sanjeev BA
ChunEon Park
Cedric BAIL
Boris Faure