Hello everyone,
There are two issues with ctxpopup:
- Memory leak: Elm_Ctxpopup_Item is used but not deleted.
- Incorrect callback function: returned object and event_info are list object and item
(should be ctxpopup object and item).
I would like to send a patch to fix above issues.
I also provide the patch for backporting.
Please review them.
Best Regards,
Thiep
Signed-Off-By: Theip Ha<thiep.ha@samsung.com>
SVN revision: 82968
Before the patch, when window of device which has elementary rotates,
the ctxpopup doesn't emit the "dismissed" signal to application.
For this reason, if an application developer wants to make an event using "dismissed" signal when device rotates,
he/she cannot do anything.
But after add evas_object_smart_callback in the function "_on_parent_resize",
this problem is resolved.
That means, whether a device is rotated or not, when ctxpopup disappears, "dismissed" signal is emitted.
So I want you to check this patch.
Thank you.
Signed-Off-By: Bora Hwang<bora1.hwang@samsung.com>
SVN revision: 82918
Subject: [E-devel] [PATCH] elm_index: removed unnecessary lines
I removed some unnecessary lines from elm_index.c
1. in _index_box_auto_fill
_index_box_clear(line 178) does nothing:
if _index_box_clear is called, it means sd->level_active[level] is
false (line 116).
if sd->level_active[level] is false, _index_box_clear returns
immediately (line 60).
2. in _on_mouse_down
3. in _on_mouse_in_access
4. in _autohide_disabled_set
Signal emit is enough.
Filling the box and displaying the box are separated jobs.
I think it's logically consistent to fill the box only when
1) elm_index_level_go is called
2) theme is changed
5. in _level_go
Always clear the box before fill the box.
SVN revision: 82864
On Tue, Jan 15, 2013 at 6:02 PM, SHILPA ONKAR SINGH <shilpa.singh@samsung.com> wrote:
Hi All,
Please find attached bug fix for elm_check - toggle style.
This patch prevents "changed" signal being sent twice in case of
toggle style when check is clicked.
This also fixes few indentation issues in the style.
Change description:
elm_check: Bug fix "changed" signal being sent twice in case of toggle style when check is clicked.
Signed-Off by: Rajeev Ranjan(rajeev.r@samsung.com)
Signed-Off by: Shilpa Singh(shilpa.singh@samsung.com)
Thanks & Regards
Shilpa Singh
SVN revision: 82845
On Sun, Jan 6, 2013 at 2:23 PM, 조재현 <jae_hyun_cho@naver.com> wrote:
Dear all,
Hello. This is Jaehyun Cho.
Now, naviframe emits state signals (e.g. show or hide) for customized text part (i.e. neither "elm.text.title" nor "elm.text.subtitle") which is going to be appended to the item's text_list.
However, if the customized text parts change the text label when the text parts are in the item's text_list, naviframe does not emit state signals for them.
To resolve this issue, I added additional case in _item_text_set_hook to handle the text part which is in the item's text_list. (elementary/src/lib/elc_naviframe.c)
Please review this.
Thank you,
Jaehyun Cho.
SVN revision: 82300
now it supports slides the texts if the label area is smaller than the text width length.
deprecated - elm_label_slide_set()/get()
added - elm_label_slide_mode_set()/get()
SVN revision: 82169
Subject: [E-devel] [BUG] [ELM] [PATCH] Bug fixes for APIs
elm_gengrid_region_show/bring_in
Please review the attached patches.
Attached patch "elm_gengrid.patch" which fix the bug related to
elm_gengrid_region_show/bring_in APIs.
And patch "test_gengrid.patch" in order to test the fix.
Change Description:
1. An internal function _item_show_region() is created which does
the
calculation for item position.
2. This function is called in _calc_job() as soon as pan
object
gets its
size.
3. Test_gengrid code enhancement for testing the fix.
SVN revision: 82063
On Sun, Dec 9, 2012 at 11:11 AM, thiep ha <thiep.ha@samsung.com> wrote:
Dear All,
In elementary list, the separator is not correctly set.
I would like to send a patch to correct the list with separator.
I also add an example named "List Separator" to test it.
Please review this patch.
Best Regards,
Thiep Ha
SVN revision: 82040
Dear all,
Hello. This is Jaehyun Cho.
The current version of _item_text_set_hook sends the part signal name to edje_object_part_text_set. (elementary/src/lib/elc_naviframe.c)
To resolve this issue, I sent different arguments to edje_object_part_text_set for each case.
Please review this patch.
Thank you,
Jaehyun Cho.
Signed-Off-By: JaeHyun Cho <jae_hyun_cho@naver.com>
SVN revision: 82030
For now, it supports only one system tray icon per application.
Each instance of ELM_OBJ_SYSTRAY_CLASS is a handler for
the same system tray item. But the API is ready to support
multiple system tray items per application.
Also, since this is a new feature, it only provides an EObject API. So,
if the old style API is still required, please do it.
Patch by: Murilo Belluzzo <murilo.belluzzo@profusion.mobi>
SVN revision: 81747
ChunEon Park
WooHyun Jung
Daniel Juyung Seo
Jaeun Choi
Cedric BAIL
DUBEYPRINCE KUMAR
Jaehwan Kim
JaeHyun Cho
Mike Blumenkrantz
Henrique Dante de Almeida
Jiyoun Park
Murilo Belluzzo
Gustavo Sverzut Barbieri