Commit Graph

93 Commits

Author SHA1 Message Date
ChunEon Park 4b6636bdd1 elementary/index - [E-devel] [PATCH] elm_index : set it->letter to NULL after eina_stringshare_del
Hello all,

In elm_index.c, _item_del_pre_hook calls _item_free, where it->letter
is not set to NULL after eina_stringshare_del.
This will cause invalid access later on. The attached patch fixes the
problem, which is reproducible in my code before the fix.
Please check if this makes sense.

I am sorry that I was unable come up with a simple test app to
demonstrate the problem.

Thanks in advance.


Brian

Signed-Off-By:Brian Wang<brian.wang.0721@gmail.com>



SVN revision: 75723
2012-08-27 08:23:20 +00:00
Gustavo Lima Chaves 84b23046da [elm] Now those comments make less sense, remove.
SVN revision: 74768
2012-08-01 21:05:16 +00:00
Gustavo Lima Chaves 31f18bb480 [elm] Index now inheritable.
SVN revision: 74754
2012-08-01 21:03:11 +00:00
Gustavo Lima Chaves 584c53c1be [elm] New elm_widget_add() usage spread.
SVN revision: 74148
2012-07-18 21:03:39 +00:00
Gustavo Lima Chaves 5f7bf01397 [elm] item del, not free, on index.
SVN revision: 71564
2012-05-30 17:42:26 +00:00
Gustavo Lima Chaves 6db319d810 [Elm] Index now a layout.
SVN revision: 70739
2012-05-03 22:44:11 +00:00
Carsten Haitzler c0f2f4be91 REVERT!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
this breaks theme api. so NO! come back with a version that doesn't
break it.



SVN revision: 70679
2012-05-03 01:19:05 +00:00
Gustavo Lima Chaves 6008d86c93 [Elm] Index now a layout.
SVN revision: 70662
2012-05-02 17:01:30 +00:00
Carsten Haitzler 3a7b769a63 use the new escape text set to clear up issues if theme has TEXT vs
TEXTBLOCK items and handling escapes so text is consistend across elm.
fiuxes the fileselector issues kai reported.



SVN revision: 70362
2012-04-20 12:51:10 +00:00
ChunEon Park edb1115ddc elementary/index - removed unnecessary code
SVN revision: 69856
2012-04-02 07:51:11 +00:00
Daniel Juyung Seo 91d43ae017 elm: Set timer/animator to NULL after they're deleted.
SVN revision: 69796
2012-03-30 12:31:11 +00:00
Daniel Juyung Seo 7908a77ad8 elm: Fixed formatting.
SVN revision: 69700
2012-03-28 09:02:22 +00:00
Jiyoun Park 588ddb272a remove deprecated code related with
elm_index_item_selected_get
function.


SVN revision: 69279
2012-03-13 01:51:46 +00:00
ChunEon Park cac0e6aec9 elementary/index - fixed null string segfault case
SVN revision: 69247
2012-03-12 11:10:57 +00:00
Jiyoun Park 8886ef1e38 remove deprecated code related with
elm_index_active_XXX
elm_index_item_append_relative
elm_index_item_append_relative
function.


SVN revision: 69239
2012-03-12 10:00:17 +00:00
Jiyoun Park 6763d9b38e remove deprecated code related with
elm_index_item_go
function.


SVN revision: 69236
2012-03-12 09:04:53 +00:00
ChunEon Park d25bfa1266 elemenatry/index - removed unnecesary compare and return when realloc is failed
SVN revision: 69099
2012-03-09 13:02:16 +00:00
Jiyoun Park 1b5662554c remove deprecated function related with elm_index
SVN revision: 69078
2012-03-09 08:51:24 +00:00
ChunEon Park b70396c859 elementary/index - + 1 api elm_index_item_selected_set
need compensation



SVN revision: 68867
2012-03-07 04:39:06 +00:00
ChunEon Park 2b45ebba0c elementary/index - more apis
elm_index_horizontal_set/get



SVN revision: 68820
2012-03-06 12:28:52 +00:00
Daniel Juyung Seo 480c61f20a elm: Formatting. No spacing after casting.
Signed-off-by: Daniel Juyung Seo <juyung.seo@samsung.com>

SVN revision: 68807
2012-03-06 11:51:42 +00:00
ChunEon Park 4b9a8cb744 elementary/index - set index visiblility again when style is changed.
SVN revision: 68780
2012-03-06 07:09:57 +00:00
WooHyun Jung 1acacd1c9b elementary/index : changed one API. elm_index_item_selected_set ->
elm_index_selected_item_set. 


SVN revision: 68720
2012-03-05 13:48:24 +00:00
WooHyun Jung 9073ed6efb [elementary/index] Some APIs were modified or removed + fix build
break.


SVN revision: 68690
2012-03-05 10:05:58 +00:00
ChunEon Park d1ac092565 elementary/index - return item handles.
SVN revision: 68660
2012-03-04 13:51:17 +00:00
Daniel Juyung Seo 2a8827cb3e elm index: Fixed build warning.
Signed-off-by: Daniel Juyung Seo <juyung.seo@samsung.com>

SVN revision: 68623
2012-03-02 12:07:44 +00:00
ChunEon Park f4e81e9033 elementary/index - trivial changes
SVN revision: 68566
2012-03-01 09:44:50 +00:00
ChunEon Park 2e5b1279ca elementary/index - [E-devel] [Patch] Add new API in Index widget (e lm_index_indicator_disabled_set/get())
I've attached patch file about new API in Index widget.
called elm_index_indicator_disabled_set() / elm_index_indicator_disabled_get()
Using this elm_index_indicator_disabled_set API, if it is set EINA_TRUE in second value, popup text could be invisible.
In this API, indicator notes popup text which shows a letter has been selecting.
I tested through elementary_test, and it works.

Signed-Off-By GoUn Lee<gouni.lee@samsung.com>



SVN revision: 68559
2012-03-01 02:42:51 +00:00
ChunEon Park c5232c4741 elementary - removed unnecessary checkings
SVN revision: 68393
2012-02-24 08:53:01 +00:00
ChunEon Park fcc6192848 elementary - modified item_del_pre_hook function prototype.
Now it returns the bool value to free the widget item.

Some widget items(i,e genlist) should not be deleted directly when elm_object_item_del is called.
So, if the pre_hook function returns EINA_FALSE, then the widget item will not be deleted.



SVN revision: 67565
2012-01-27 11:56:14 +00:00
ChunEon Park 56a881bd35 elementary/menu, ctxpopup, index, segment_control, diskselector, multibuttonentry, toolbar, naviframe, slideshow, hoversel, filpselector - deprecated xxxx_item_del() APIs.
But instead,  made to use the elm_object_item_del() APIs
for this, elm_widget_item needed to provide elm_widget_item_del_pre_hook.




SVN revision: 67010
2012-01-10 05:02:11 +00:00
ChunEon Park 569e56e904 elementary - Added 1 more API elm_object_item_del_cb_set()
also deprecated below APIs  

   elm_hoversel_item_del_cb_set()
   elm_diskselector_item_del_cb_set()
   elm_toolbar_item_del_cb_set()
   elm_index_item_del_cb_set()
   elm_menu_item_del_cb_set()                  



SVN revision: 66748
2012-01-02 11:46:32 +00:00
ChunEon Park 4bb1f9830c elementary/index - deprecated APIs
elm_index_item_data_set()
elm_index_item_data_get()



SVN revision: 66661
2011-12-30 05:12:54 +00:00
ChunEon Park 6f07cf3ea0 elementary/index - Elm_Index_Item -> Elm_Object_Item
SVN revision: 66659
2011-12-30 04:57:28 +00:00
Michael BOUCHAUD 65106b50ac elementary: API break ! using Elm_Index_Item instead of the item's data in the index widget. This was applied for function and smart callbacks
SVN revision: 65956
2011-12-06 14:05:55 +00:00
RAJEEV RANJAN ba55a1b120 elementary/index - [E-devel] [Patch] elm_index patch
Hi,

Attachment to the mail is elm_index patch.

Change Log:
a. Memory leak fix in function elm_index_item_append_relative due to memory allocated for item creation reamined allocated when the control returns.
b. Memory leak fix in function elm_index_item_prepend_relative due to memory allocated for item creation reamined allocated when the control returns.

Signed-Off-By: RAJEEV RANJAN <rajeev.r@samsung.com>
Signed-Off-By: PRINCE KUMAR DUBEY <prince.dubey@samsung.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>



SVN revision: 65697
2011-11-30 00:07:44 +00:00
Mike Blumenkrantz 88bbad2635 add VIEW() and WIDGET() macros for use with Elm_Widget_Items to create more consistency, reduce typing, and increase readability
VIEW(X) = X->base.view (visible evas object)
  WIDGET(X) = X->base.widget (owner widget)

also a demo of the oxford comma for seoz


SVN revision: 64220
2011-10-21 01:08:01 +00:00
Mike Blumenkrantz 4ad1c5f0db create and use ELM_WIDGET_ITEM for elm widget structs to ensure location/name
SVN revision: 64218
2011-10-21 00:45:19 +00:00
Mike McCormack beafec3884 elementary: Improve include file modularity
Move stuff out of elm_priv.h

Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>

SVN revision: 63900
2011-10-07 05:56:07 +00:00
Carsten Haitzler 0f71296a93 dont display indicator if no items in index.
SVN revision: 62801
2011-08-25 10:29:08 +00:00
Carsten Haitzler 62b4440c3c if you activate index without it being clicked, the indicator bit is
visible but empty - dont show this until someone actually clicks.



SVN revision: 62799
2011-08-25 10:20:47 +00:00
Gustavo Lima Chaves c2c47801f7 [elementary] Documentation for the index widget.
SVN revision: 61533
2011-07-20 16:28:12 +00:00
Michael BOUCHAUD c34c5c5a04 elementary: fix the prototype of elm_index_active_get
SVN revision: 59757
2011-05-27 17:33:40 +00:00
Michael BOUCHAUD efa1c08e88 elementary: add elm_index_active_get
SVN revision: 59755
2011-05-27 17:21:18 +00:00
ChunEon Park d45f0154cf elementary / menu, list, index, pager - modified to use signal callback table.
SVN revision: 58807
2011-04-21 15:57:03 +00:00
Daniel Juyung Seo 77450413d7 Elementary src/lib: Removed all trailing whitespaces.
SVN revision: 58492
2011-04-08 14:36:29 +00:00
ChunEon Park 3761fc17f5 elementary / menu, gengrid, slider, separator, photocam, index, toggle
updated signal callback list in the doxygen



SVN revision: 58347
2011-04-05 07:04:09 +00:00
ChunEon Park c7c99ddea6 elementry / entry, menu, notify, list, gengrid, actionslider, image, icon, anchorview, fileselector_button, calendar, photocam, anchorblock,
button, map, colorselector, hover, photo, diskselector, index, bubble, pager, hoversel, check, scrolled_entry, clock, flipselector

	    updated signal callback list in the  doxygen. 

            should update genlist, progressbar ... 



SVN revision: 58335
2011-04-04 16:34:18 +00:00
Daniel Juyung Seo 8a108db5ab Elementary: Use pre-defined type Edje_Signal_Cb instead of describing all of its parameters.
SVN revision: 58283
2011-04-03 05:32:17 +00:00
ChunEon Park b880342a74 elementary - entry, genlist, gengrid, image, icon, hover, frame, diskselector, index, layout, label, conform, flip, flipselector - removed white spaces
SVN revision: 58252
2011-04-01 11:32:33 +00:00