Commit Graph

861 Commits

Author SHA1 Message Date
ChunEon Park fa6e06a450 genlist: keep the item class as given argument. 2015-01-05 22:17:12 +09:00
ChunEon Park b79e3e4ffa genlist: Fix genlist index get bug
Because not all item block have "max_items_per_block" number of items in it's block.
So the calculation is not correct when items are added & removed in each block.

Anyhow, we need more efficient way for this API because genlist uses inlinst.
2015-01-05 20:43:58 +09:00
ChunEon Park 3695c3c0b3 genlist: add some comment in code. 2015-01-05 20:21:26 +09:00
ChunEon Park a898ca295f genlist: use macro as possible. 2015-01-05 15:56:27 +09:00
ChunEon Park a831b625b9 genlist: use ELM_NEW 2015-01-05 15:55:39 +09:00
ChunEon Park e608c88448 genilst: unselect items if the genlist select mode is display only or none.
make it behavior same with elm_genlist_item_select_mode_set()

@fix
2015-01-05 15:42:22 +09:00
ChunEon Park a0b170c2a3 genlist: unselect item if the select mode is display only or none.
@fix
2015-01-05 15:37:41 +09:00
ChunEon Park 28ac4ffe65 ggenlist: code refactoring.
don't do anything if same mode is applied.
2015-01-05 15:03:37 +09:00
ChunEon Park f3efe45e5e genlist: remove useless deco texts. 2015-01-02 20:18:24 +09:00
ChunEon Park 30a74e27da genlist: + null check 2015-01-02 20:04:55 +09:00
ChunEon Park 2ede0112bd genlist: code refactoring
refactor _item_content_realize() prototype to keep the consistency with state,text_realize()
2015-01-02 19:59:39 +09:00
ChunEon Park e89125754e genlist: code refactoring.
apply facade at _view_inflate() for simple item realization.
2015-01-02 19:45:48 +09:00
ChunEon Park a1b36ae6ee genlist: code refactoring.
remove contents_obj but use contents instead.
2015-01-02 19:04:34 +09:00
ChunEon Park 4cdcfac116 genlist: code refactoring.
remove target states strings in the widget item.
2015-01-02 17:34:05 +09:00
ChunEon Park 1470572cef genlist: code refactoring.
just clean up code. no logic change.
2015-01-02 16:54:01 +09:00
ChunEon Park a41e9d8044 genlist: refactoring code.
removed invalid content string free call.
and renamed flip_content_objs -> flip_contents.
2015-01-02 16:48:29 +09:00
ChunEon Park 60202b7f0a genlist: code refactoring.
remove contents string list that doesn't needed to keep in widget data.

next code refactoring based on this patch will be coming.
2015-01-02 16:17:16 +09:00
ChunEon Park 67e4baf1df genlist: exceptional handling.
just be hidden if contents are failed to swallow.
2015-01-02 12:14:41 +09:00
ChunEon Park 2dd05e1580 genlist: free selected items when genlist is cleared. 2014-12-31 19:55:09 +09:00
ChunEon Park ff9de8bea8 genlist: send reorder signal to decoration item and views.
Previous logic was too much stick to special case for *tizen*
let decide item styles in theme as possible.

This might break reorder group item ui, but it won't be critical.
because tizen ui only depeneded on the scenario and they don't use them anymore.

This will be much better for multiple scenario in the future.
2014-12-31 19:10:40 +09:00
ChunEon Park 4f1b1bcb9f genlist: let group item set reorder style as it needs.
we don't need to limit the group item it's reorder style.
2014-12-31 18:59:28 +09:00
ChunEon Park 66d78a4512 genlist: + warning msg for user notice
don't unrealize reordering item.
2014-12-30 17:56:24 +09:00
ChunEon Park 7dc5c3863c genlist: use convenient macro. 2014-12-30 17:36:14 +09:00
ChunEon Park 0e5b3f32d5 Revert "genlist: return as possible as soon."
This reverts commit ef56ed167206612f146d2c70f5b35a7bcd62c4c6.

This caused logic change. should not be changed.
2014-12-30 15:44:46 +09:00
ChunEon Park 10ac198400 Revert "genlist: return as possible as soon"
This reverts commit 1e6736c3a13d58c4e1a01d7e23983c721051be08.

This caused logic. should not be changed.
2014-12-30 15:43:20 +09:00
ChunEon Park 65de16477c genlist: return as possible as soon 2014-12-30 15:32:41 +09:00
ChunEon Park f86dbe4854 genlist: removed unnecessary check 2014-12-30 11:17:46 +09:00
Daniel Juyung Seo f14fa87c84 genlist: Fix internal comments. 2014-12-30 01:31:43 +09:00
ChunEon Park f9cc9863a3 genlist: return as possible as soon. 2014-12-29 22:58:38 +09:00
ChunEon Park f2b7e575f0 genlist: clean up code.
repositioned function and remove unnecessary prototype declaration.
2014-12-29 22:51:39 +09:00
ChunEon Park fb8af1004c genlist: remove duplicated signal registration. 2014-12-29 22:34:45 +09:00
ChunEon Park 1f73409844 genlist: send an additional signal
send flip disabled signal when it's state is switched.
2014-12-29 22:27:28 +09:00
ChunEon Park cce9511130 genlist: send a signal internally.
send a signal so that item set it's style according to it's depth
2014-12-29 22:16:34 +09:00
ChunEon Park 5b2493b7af genlist: send a disabled signal when the decorated item is unrealized. 2014-12-29 21:44:50 +09:00
ChunEon Park b4fe364f1b genlist: code refactoring
declare/use const strings for internal signals
2014-12-29 19:50:39 +09:00
Davide Andreoli 9988b752c7 Genlist: do not fire clicked,right while dragging in progress 2014-12-29 11:19:21 +01:00
ChunEon Park eb229ae0e2 genlist: add "scroll" smart call
@feature
2014-12-29 19:02:08 +09:00
Davide Andreoli 69b6310954 Improve -clicked- detection code by accept only if the mouse do not move too much
Too much in this case is a fixed 4px. As fingers do not have a right button I think
that taking into account finger size is not needed here.

Also someone argued about the signal name is not really correct...
should I change it to somethig like: clicked,secondary ?
2014-12-26 18:46:28 +01:00
Davide Andreoli 536c5de134 Genlist: added the clicked,right event on items
@feature
2014-12-26 17:29:51 +01:00
Amitesh Singh fc1579020c list/genlist/gengrid: Fix memory leak.
Summary: @Fix

Reviewers: kimcinoo, SanghyeonLee, raster, seoz

Reviewed By: seoz

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1825
2014-12-26 20:22:57 +09:00
Daniel Juyung Seo d47a4adae4 gengrid, genlist, list, toolbar: Fix memory leak and enhance performance.
1. Fix memory leak by freeing eina_list.
2. Enhance performance by getting the item list when it is really
needed.

@fix
2014-12-26 18:41:48 +09:00
Daniel Juyung Seo 9b038471bf genlist: Return the correct pointer for object item.
No backport needed.
2014-12-26 14:36:36 +09:00
Andrii Kroitor 8148de6e17 elm_genlist: add missing callback call
Summary:
Added missing "moved" callback call when reordering items with keyboard
"up" and "down" arrows

@fix

Reviewers: cedric, raster, seoz

Reviewed By: seoz

Subscribers: reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1818
2014-12-26 14:23:42 +09:00
Mike Blumenkrantz c201ec6c87 genlist should ignore no-select items when moving with the keyboard
@fix
2014-12-25 20:39:17 -05:00
Daniel Juyung Seo 4a61d3955e genlist: Fix dereference before null check.
This fixes coverity CID 1258636.
No backport needed.
2014-12-16 23:54:13 +09:00
Carsten Haitzler 17f411f6be elm - fix warnings added in f99be3a1d6bdc63153598b592b5437c33da44bf0 2014-12-16 19:36:35 +09:00
Jyotiprakash Sahoo 17419ec81c genlist: added reorder feature on key events
Summary: This feature allows user to reorder items using up/down keys.

Test Plan: elementary_test -to "Genlist Reorder Mode"

Reviewers: singh.amitesh, raster, seoz, SanghyeonLee

Differential Revision: https://phab.enlightenment.org/D1262

Conflicts:
	src/bin/test_genlist.c
	src/lib/elm_genlist_legacy.h
2014-12-16 18:20:32 +09:00
Daniel Juyung Seo 14e79451c2 genlist: Fix genlist crash issue when clearing genlist on item focus callback.
This fixes "genlist focus" test sample's crash issue.

@fix
2014-12-14 04:19:42 +09:00
Daniel Juyung Seo e31df3372c gengrid, genlist: Optimize eo item usage.
Remove unnecessary pointer reference.
2014-11-25 21:55:14 +09:00
Daniel Zaoui dfc3f7ac30 Genlist: Fix previous commit.
The items of an item is a list of Elm_Object_Item and not of Elm_Gen_Item.
Sorry @zmike ;-)

Fixes T1859

Another fix has been added in this commit, related to relative items.
2014-11-23 09:18:42 +02:00