During the migration of docs to the eo file the group name changed to have a
Elm_ prefix which resulted in our docs not including this group and not showing
any of the docs in there. Switching to the new name fixes this.
Having this prefix makes sense especially as we are now merging elm into efl.
@fix
Fixes T3109
Summary:
In auto scroller mode, both of vbar and hbar of scroller is created when scroller content size is getting large.
At the state, If we make hbar disappear by resizing scroller content, vbar size is set to small.
Because at the moment, the width and height of elm.swallow.content of sid->edje_obj are zero.
@fix
Test Plan:
1. set scroller auto mode
2. make vbar and hbar by resizing scroller content
3. make hbar disappear by resizing scroller content
4. see the vbar size whether it is correct or not
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3779
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
After this change genlist unrealizes all realized items on every resize.
Check this in elementary_test "Genlist Del".
The expand issue should be fixed in another way.
This reverts commit 89a7e471d155dedb14f23dbb85e2178497620864.
This reverts commit 22eefc9626e15e78612396a9c7adca89ffc228e2.
ok - so equation changed. tizen 2.3 did ship with index starting at
1, so back to 1 (ugh - ugly). so apparently we have switch between 0
and 1 over history at various points (and no one in efl land uses this
api so we dont see it). but given that the largest userbase of efl atm
starts at 1 - we'll leave it there.
Summary:
This patch focuses on Combobox widget customization,
Multibuttonentry widget is used instead of entry for taking user input.
The idea is to make the widget look like {F28112} {F28115} when the multiple_selection is set.
To-DO:
1) Need to add scrollable interface to combobox when MBE is used (need some suggestions on it).
2) focus cycle is still buggy as genlist requires focus otherwise selected item will return NULL (sometimes)
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
@feature
Test Plan: Please run combobox multiple selection example from elementart_test.
Reviewers: raster, shilpasingh, cedric
Subscribers: govi, rajeshps
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D3570
Summary:
The size of Colorclass is 20 bytes, but that of Elm_Color_Overlay 16 bytes.
Currently, there is no code to access last 4 bytes, but it can cause
seg fault by another patch.
Reviewers: cedric, zmike
Differential Revision: https://phab.enlightenment.org/D3784
so in feb 2015 seoz changed elm_genlist_item_index_get to start from 1
rather than 0. going back to elm code in 1.7 - it started at 0. this
is an api break that shouldn't have happend, but did. this fixes that.
yes - it's inconsistent with gengrid's index_get - but gengrid here is
wrong. nth_get starts at 0. this will get fixed with eo api's, and in
fact none of these index/nth api's should be in genlist's eo api.
legacy only. i can see why this was changed - it matches gengrid and
is more consistent, but we can't break things even if stupid.
@fix
eo.h and eo.c were added by mistake.
I couldn't quite test the build since the we still need ewekbit2
for configure to enable elm_web. @cedric has a bit of work left
here :)
This reverts commit 9f4c43c20dfa36e7a8be18278acf4336c13574d7.
I'm sorry but this causes a side effect(list sizing issue) at enventor.
And I couldn't find any mis-usage in enventor side.
We can't not accept this patch unless we figure the exact reason out.
Summary: This clarifies the documentation of the new api.
Reviewers: SanghyeonLee, shilpasingh, cedric
Reviewed By: cedric
Subscribers: bu5hm4n, buds
Differential Revision: https://phab.enlightenment.org/D3725
Summary:
elm_fileselector_buttons_ok_cancel_set() API checks the existence of
ok button before adding it.
This patch makes condition statement more intuitive.
Reviewers: cedric, bu5hm4n
Differential Revision: https://phab.enlightenment.org/D3770
======
CC libelementary_la-elm_interface_atspi_value.lo
elm_interface_atspi_image.c: In function '_elm_interface_atspi_image_description_set':
elm_interface_atspi_image.c:36:9: warning: 'old_descr' may be used uninitialized in this function [-Wmaybe-uninitialized]
eina_stringshare_del(old_descr);
^
======
Summary:
- in dump_cb buf is allocated by malloc() ->strdup() -> free.
This is needless.
- And buf allocated in dump_cb is strdup again.
This may cause memory leak.
Reviewers: Hermet, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3752
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When item_show / scrolling is happening, _item_block_position will be
called from smart_calculate where item width is set as block width.
If items are not realized _item_realize will be called and if items are
getting realized for first time we set mincalcd as false. So later
item width gets overwritten by min width of item and so issue is happening.
@fix T2603
Signed-off-by: godly.talias <godly.talias@samsung.com>
Test Plan: elementary_test -> Genlist Group -> show 480
Reviewers: prince.dubey, shilpasingh, SanghyeonLee, cedric
Subscribers: rajeshps, seoz, govi
Maniphest Tasks: T2603
Differential Revision: https://phab.enlightenment.org/D3729
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: This API will return the number of items that have passed the filter at a given point of time. If the API is called before "filter,done" callback comes, it may or may not give the filtered count for the complete genlist.
Test Plan: Updated Genlist_filter example to print the output from filtered_count_get API in "filter,done" callback.
Reviewers: SanghyeonLee, shilpasingh, cedric
Reviewed By: cedric
Subscribers: buds
Differential Revision: https://phab.enlightenment.org/D3725
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
refine code and theme, hopefully solve the issue
that the height of file list (genlist) is calculated wrong.
Test Plan: elementary_test -to fileselector
Reviewers: SanghyeonLee, jpeg, cedric
Subscribers: taxi2se
Differential Revision: https://phab.enlightenment.org/D3715
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: mapi have to be set NULL after free(m->api)
Reviewers: kimcinoo
Reviewed By: kimcinoo
Differential Revision: https://phab.enlightenment.org/D3756
Stefan Schmidt
taehyub
Tom Hacohen
Jean-Philippe Andre
Cedric BAIL
Daniel Juyung Seo
Vyacheslav Reutskiy
Carsten Haitzler
divyesh purohit
Jee-Yong Um
Hermet Park
shashank.p
Marcel Hollerbach
Amitesh Singh
SungTaek Hong
Shinwoo Kim
Minkyu Kang
godly.talias
Hosang Kim
Jonghee Choi