I just ran my script (email to follow) to migrate all of the EFL
automatically. This commit is *only* the automatic conversion, so it can
be easily reverted and re-run.
Summary:
Pressing "Delete" Key in MBE layout causes Segfault as MBE item is not deleted properly and also focus is not transferred back to MBE.
@fix
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan: Run MultibuttonEntry example from elementart_test . Add some MBE items, now press the delete key, it should delete items without causing segfaults and transfer focus to previous MBE item.
Reviewers: raster, cedric, CHAN, shilpasingh
Reviewed By: shilpasingh
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D3635
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Even MBE item lose focus, item state did not changed before.
So i send a signal to make item state as default when item lose own focus.
Signed-off By: Kumar Navneet <k.navneet@samsung.com>
@fix
Test Plan:
Run MBE sample.
Click any item.
Click out of MBE area.
See the item still got a highlight.
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D2994
Conflicts:
data/themes/edc/elm/multibuttonentry.edc
To configure elementary sources with bindings to use in nodejs add
––with-js=nodejs in configure flags in EFL compilation to generate
node files, then compile elementary normally:
path/to/efl$ configure --with-js=nodejs
path/to/efl$ make
path/to/efl$ make install
path/to/elm$ configure
path/to/efl$ make
path/to/efl$ make install
To use, you have to require elm:
elm = require('elm')
The bindings is divided in two parts: generated and manually
written. The generation uses the Eolian library for parsing Eo files
and generate C++ code that is compiled against V8 interpreter library
to create a elm.node file that can be required in a node.js instance.
@feature
Summary:
To prevent pasted markup text in entry.
User want tags removed text when paste text into entry.
@fix
Reviewers: jaehwan, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3333
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There is no need ellipsis, space as well before "%d".
The "%d" will show the actual invisible item count.
@fix
Reviewers: jaehwan, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3332
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When user called "elm_multibuttonetnry_editable_set()" API as false.
the internal entry will be unpacked from box.
Then called that API as true again.
the internal entry just show without box packed.
Also, editable set API should not work in MBE shrink mode.
Test Plan:
Alternately Call elm_multibuttonentry_ediable_set API as true, false.
Then check the internal entry state.
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3134
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The select function set in item_append does not get called on item selection issue fix.
As per documentation, the function has to get called.
@fix
Test Plan: elementary_test is updated with the demo
Reviewers: navnbeet, Hermet, CHAN, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3158
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The Internal box can has a lot of label for child when user set text many times.
Fix this wrong implement. It has to get only one label for child.
@fix
Test Plan:
Call elm_object_text_set() many times for MBE.
Check the label got a wrong geometry.
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3133
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Before item packed again in mbe box. box calc own min height.
In this case, there is no need to increase line number when entry is box item.
Actually the min height of box calculated wrong here.
@fix
Test Plan:
Give a color to internal box.
Then items add.
Check the internal box area got a wrong height value.
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3102
Summary:
MBE internal box get its padding size from edc.
Previously, it does not consider when calculating the padding size.
In this commit, the padding size from edc is divided by its base_scale
so that desirable size can be calculated.
@fix
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3103
Summary:
If item filters are appended and multibuttonentry is deleted, the
filter list is not freed causing leak
Signed-Off By: Kumar Navneet <k.navneet@samsung.com>
Signed-Off By: Shilpa Singh <shilpa.singh@samsung.com>
Test Plan:
append item filters and when multibuttonentry is deleted leak is
observed, run valgrind in this scenario.
Reviewers: Hermet, cedric, CHAN
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D3118
Summary:
elm_multibuttonentry_clear API not worked well.
It deleted only odd items. Because of the sd->items has been modified inside elm_widget_item_del().
Then we don't have to search target item inside of _item_del().
@fix
Test Plan:
Add MBE items.
Call elm_multibuttonentry_clear API.
Check the bug state.
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3065
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
multibuttonentry is editable
Summary:
Input panel should be controlled only if Multibuttonentry is editable, else causes issues in applications controlling keypad by themselves
@fix
Reviewers: CHAN, Hermet
Reviewed By: Hermet
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D3050
Add elm_object_focus_next_item_set/get,
elm_object_item_focus_next_object_set/get and
elm_object_item_focus_next_item_set/get.
If the item and object is set at the same time,
the item is preference to object when the focus moves.
This feature is implemented about gengrid.
It will be implemented about ohter widgets.
@feature
Summary:
MBE item append logic changed when mirrored set as true.
The item appended from left side of internal box to right side, even mirrored set as true.
@fix
Test Plan:
Precondition : elm_widget_mirrored_set as true.
Run mbe sample in elementary_test.
Add item.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2975
Summary:
When text is set on a multibuttonentry item, item does not resize
again based on text.
Signed-off By: Kumar Navneet <k.navneet@samsung.com>
@fix
Test Plan: Set long text to multibuttonentry item, after item is created and shown.
Reviewers: woohyun, CHAN, Hermet
Reviewed By: CHAN, Hermet
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D2967
Summary:
Item layout will be added in elm focus tree.
evas_object_focus_set is no meaning here for MBE operation.
So i changed focus API from "evas_object_focus_set()" to "elm_object_focus_set()"
elm_object_focus_allow_set() already called in item adding function.
@fix
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D2993
Summary:
_elm_access_say() does not free the given text.
But, the text from eina_strbuf_string_steal() is not cared
from outside of _elm_access_say(), too.
It should be changed to eina_strbuf_string_get().
Test Plan: N/A
Reviewers: cedric, woohyun, kimcinoo, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2918
Summary:
When editable set is set to FALSE, there is no need to specifically
hide the keypad as keypad will automatically hide when entry is hidden.
@fix
Signed-off By: Kumar Navneet <k.navneet@samsung.com>
Reviewers: woohyun, Hermet, CHAN, cedric
Reviewed By: cedric
Subscribers: subodh6129, navnbeet
Differential Revision: https://phab.enlightenment.org/D2907
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
An item size calculated with scale value when item appended.
This code is not need.
@fix
Reviewers: Hermet, woohyun, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2840
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There is no way to give padding between each items, previously.
So i added horizontal, vertical padding here.
I will add APIs for set, get padding size set, get.
@feature
Test Plan:
Change the horizontal, vertical paddidng value in multibuttonentry.edc
Run elementary_test
Execute multibuttonentry sample.
Add items.
Check the padding between items.
Reviewers: woohyun, seoz, Hermet, raster
Reviewed By: Hermet, raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2534
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Even user sets empty string here for text, label still packed in box with min size(finger size).
label_set internal logic is not clear before.
ex: object min set, resize check the string length then sending signal, min set again.
so i deleted the signal emit code here, we can handle label show, hide status in code and it's more clear.
Besides "sd->label" is always true all of the case. we need to check whether it's packed or not.
The label will be added to parent's sub object when it's packed into box.
label_set as empty string in adding time also meaningless.
@fix
Test Plan:
Run multibuttonentry sample.
Set a text somthing for it then set an empty string here.
Reviewers: Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2841
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
In some MBE use case, Application can append item using only item_append API.
in that case, the end text(item count) doesn't update properly.
So, i add a code for fix it.
@fix
Test Plan:
1. Add a button for call "elm_multibuttonentry_item_append()" in test_multibbutonentry.c
2. Make MBE shrink mode.
3. Click button to append item to shrinked MBE.
4. Check the MBE end text state.
Reviewers: Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2848
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If there is a uneditable MBE, the MBE doesn't have to get a entry inside of the box.
It breaks MBE box layout, resize logic.
And check the box focus, entry visible is not enough to cover MBE is uneditable case.
If MBE is uneditable, box_resize callback called when item added. in this case,
we need to check what view type user want. if its not shrink view here, do not make
MBE to shrink mode.
@fix
Test Plan: Run elementary_test -> execute multibuttonentry sample with editable set as false.
Reviewers: Hermet, seoz, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2824
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
We don't have event block area in mbe.
Item clicked callback is not called when user clicked the item in mbe shrinked state.
However, item press effect will be shown.
@fix
Test Plan:
Delete the line always calling expanded set API in MBE clicked callback.
Execute MBE sample in elementary_test.
Check the item got a click event but not call the clicked callback.
Reviewers: Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2870
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The mbe items has to get own min size to calc each items locate, box size etc...
but when first time box resize it will ignored.
It makes item wrong size issue when mbe located at some part of layout in runtime.
Reviewers: Hermet, seoz, woohyun
Differential Revision: https://phab.enlightenment.org/D2657
Summary:
1.) Fixing defective label position.
Whenever user create multibuttonentry and set some text into label,
label will be shown at zero point (0,0) of MultiButtonEntry parent.
But then, after clicking on any button of MBE object, label position forced to
be recalculated and changes it's position.
2.) Fixing wrong size when label is not used.
When label is not being used, buttons shift by few pixels,
and it looks like if label is actually there, which is wrong.
@fix
Reviewers: cedric, seoz, raster, reutskiy.v.v, Hermet
Reviewed By: Hermet
Subscribers: NikaWhite
Differential Revision: https://phab.enlightenment.org/D2416
Summary:
While setting theme currently changes style and theme to all button and
whole multibuttonentry object, it doesn't change few other parts of this object.
Part are, for examples, "guidetext", "label" and "closedbutton".
Fixing this sad mistake leads to be able to create different styles for such
wonderful widget.
@fix
Reviewers: cedric, seoz, raster, reutskiy.v.v, Hermet
Reviewed By: Hermet
Subscribers: NikaWhite
Differential Revision: https://phab.enlightenment.org/D2407
Summary: I missed this during btn object type change to layout from edje object .
Reviewers: Hermet, seoz, woohyun
Differential Revision: https://phab.enlightenment.org/D2289
Summary: Add long pressed callback for application. test code changed to following this change as well.
@feature
Reviewers: seoz, woohyun, Jaehyun, Hermet
Differential Revision: https://phab.enlightenment.org/D2103
Conflicts:
src/lib/elc_multibuttonentry.c
Summary:
API changed from "edje_object_signal_callback_add()" to "elm_layout_signal_callback_add"
to following code refactoring.
Reviewers: seoz, woohyun, Jaehyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2102
Summary:
Item width max size set as 130 in edc before, i thinks that value doen't have any meaning,
so i changed the item max width size to follow container width size.
For modification, item size calc, box resize logic changed.
Test Plan:
1. Run elementary_test
2. Execute multibuttonentry sample.
3. Input some text for make item.
Reviewers: Hermet, seoz, woohyun, Jaehyun
Differential Revision: https://phab.enlightenment.org/D1970
Tom Hacohen
divyesh purohit
woochan lee
Felipe Magno de Almeida
Lukasz Stanislawski
Shilpa Singh
ChunEon Park
Vivek Ellur
Jaehwan Kim
Stefan Schmidt
Youngbok Shin
Daniel Zaoui
Avi Levin
Daniel Kolesa
Vitalii Vorobiov
Amitesh Singh
Daniel Juyung Seo