Commit Graph

9193 Commits

Author SHA1 Message Date
Daniel Kolesa eb838d06ae fix atspi after eolian deduplication change; spank tasn on breakage 2014-06-20 17:09:38 +01:00
Daniel Kolesa b8eadb7166 update against latest eolian changes 2014-06-20 12:24:55 +01:00
Daniel Kolesa fb62fde68f move all eo files to new namespace syntax 2014-06-20 10:47:39 +01:00
Daniel Juyung Seo b26413cf32 entry: fixed shadow variable build warnings. 2014-06-19 18:30:21 +09:00
Daniel Kolesa 49c09c2d4b fix up some eo file documentation whitespace issues 2014-06-18 12:57:52 +01:00
Daniel Juyung Seo ddd3273cf8 test_progressbar: removed unnecessary null check. 2014-06-18 20:53:33 +09:00
Stefan Schmidt 16248748c6 test_progressbar: Verify incoming data object at the beginning
Align with how pd is checked for in other functions here. No need to
check before free() as it is done internally anyway.

CID: 1216621
2014-06-17 11:25:46 +02:00
Stefan Schmidt 9cf70c353a elm_index: Also free last on error path.
If we can't realloc label we need to free last before we can return
or we leak it.

CID: 1193240
2014-06-17 11:12:04 +02:00
Stefan Schmidt d3b0bb58a4 elm_map: Avoid unlikely division by zero.
The division by zeor could happen when zoom_cnt is zeor OR when region_cnt
is zero. No need for both cases. In the curent implementation this is
impossible as both are hard coded defines. But code changes so we should
handle this.

CID: 1216619
2014-06-17 11:01:22 +02:00
Vyacheslav Reutskiy af4120c5c8 Elementary/Panes: update functionality (add new 8 API functions)
Summary: Added possibility to set the minimum size of the left and right sides.

Reviewers: raster, cedric, seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D998
2014-06-17 10:23:30 +09:00
Lukasz Stanislawski 0975fd37e0 atspi: notify registry daemon about keyboard events.
Test Plan: elemeentary_test with Orca Screen reader 3.10.1

Reviewers: raster, z.kosinski

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D1025
2014-06-16 15:16:39 +09:00
Daniel Kolesa 763019c9d6 atspi: more conformance issues 2014-06-13 16:27:08 +01:00
Daniel Kolesa 56ce51b5d5 atspi: eo file conformance 2014-06-13 16:23:00 +01:00
Zbigniew Kosinski 3c0067305f atspi: checked state for elm_check added
Reviewers: stanluk

Differential Revision: https://phab.enlightenment.org/D1000
2014-06-12 12:57:55 +09:00
Vincent Torri 44b2c2bbb9 backend: add default engine support for Windows and Mac OS X 2014-06-12 03:12:56 +02:00
Vincent Torri 0d6cacb743 backend: remove Windows CE support Windows CE is dead and buried and its gcc port is even more dead and I don't believe in zombies 2014-06-12 03:12:15 +02:00
Vincent Torri f0c2f96f20 autotools: --enable-auto-import is passed by default, nowadays 2014-06-12 03:11:48 +02:00
Ryuan Choi dd829ffd81 elm_web2: Implement _elm_web_elm_widget_on_focus 2014-06-12 15:50:27 +09:00
Lukasz Stanislawski 1c350bbfad atspi: typo fix, avoid returning w/o va_end call
Summary:
CID: 1222462
CID: 1222461
CID: 1222465

Reviewers: raster, seoz, z.kosinski

Differential Revision: https://phab.enlightenment.org/D995
2014-06-11 16:05:54 +09:00
Lukasz Stanislawski e24102c696 atspi: add SENSITIVE to default widget state set.
Summary:
without given state Orca screen reader deafult script interpret
widget as 'grayed out'.

Test Plan: orca screen reader tests on ubuntu 13.10 with orca 3.10.1

Reviewers: raster, seoz, z.kosinski

Differential Revision: https://phab.enlightenment.org/D983
2014-06-11 15:29:31 +09:00
Jaeun Choi 636bb88170 bug fix: _elm_widget_focus_region_show
Summary: should do scrollable_content_set according to focus_region_get

Test Plan: None

Reviewers: woohyun

Differential Revision: https://phab.enlightenment.org/D981
2014-06-11 15:29:31 +09:00
Jean-Philippe Andre 2ffb942d5a Win32: Fix some compilation warnings
Reported by vtorri, thanks
2014-06-11 14:25:47 +09:00
Thiep Ha 36e153f956 dnd: rotate dragwin if main window is rotated when draging
Summary:
During drag, dragwin should be rotated when main window is rotated.

@fix

Reviewers: raster, JackDanielZ, woohyun

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D976
2014-06-11 14:19:27 +09:00
efl 589a8ba74f List: Focus does not move if it's set on item content object.
Summary:
If focus is set on item content object, it's treated as a
different object which results the focus deadlock. So, every
time whenever focus sets on item content object, we need to
unset and set the focus on genlist object. Thanks to Seoz for
the idea.

Test Plan: elementary_test -to "list focus"

Reviewers: seoz, SanghyeonLee, eagleeye

CC: seoz

Differential Revision: https://phab.enlightenment.org/D973
2014-06-11 14:14:28 +09:00
efl f6b7012329 List: Focus set on item content objects, the item content objects should be checked whether type widget or not.
Summary:
Upon focus set, if the item content object is not of type widget
(could be of type Evas_Rectnagle) focus set/get is not possible.
ERR<17428>:eo lib/eo/eo.c:603 _eo_call_resolve() in elm_widget.eo.c:112: you called func 'elm_obj_widget_can_focus_get' (239) which is unknown in class 'Evas_Rectangle'.
ERR<17428>:eo lib/eo/eo.c:788 _eo_api_op_id_get() in elm_widget.eo.c:212: unable to resolve regular api func 'elm_obj_widget_child_can_focus_get' 0xb75e6f40 in class 'Evas_Rectangle'

Test Plan: elementary_test -to "list focus" (make focus_on_selection enabled and give a right key event when a content object is focused)

Reviewers: seoz, SanghyeonLee, eagleeye

CC: seoz

Differential Revision: https://phab.enlightenment.org/D972
2014-06-11 14:07:01 +09:00
Lukasz Stanislawski 4de0d39376 atspi: Add GetInterfaces method
Summary:
Method is required by AT-SPI clients when interface caching is disabled.
Method is not listed in any at-spi specification - found during fixing
clients behaviour.

Reviewers: raster, seoz, z.kosinski

Reviewed By: z.kosinski

Differential Revision: https://phab.enlightenment.org/D971
2014-06-11 13:53:49 +09:00
Zbigniew Kosinski 9ce23f0004 atspi:Set roles for widgets
Reviewers: stanluk, m.jagiello, raster

Differential Revision: https://phab.enlightenment.org/D930
2014-06-11 11:07:16 +09:00
Gwanglim Lee dccab720a7 win: fix borderless_set behavior
Summary:
According to the current elm_win code, client side border should be removed
when window is fullscreen mode. And border couldn't be shown on window
during fullscreen mode. When window is going into normal mode from fullscreen,
then display of border should be determined by its borderless state.

1. client border should be shown when window is going into normal mode from fullscreen with borderless state.
2. client border shouldn't be shown when window is going into normal mode from fullscreen with border state.
3. and also client border shouldn't be shown when window is fullscreen mode.

@fix

Test Plan:
1. run elementary_test in wayland server
2. run window states
3. select borderless
4. select fullscreen
5. unselect fullscreen
6. unselect borderless

Reviewers: raster, devilhorns, seoz

Differential Revision: https://phab.enlightenment.org/D988
2014-06-10 15:28:20 -04:00
Anil Kumar Nahak bdb51ddd45 genlist: Focus out of genlist viewport area on resize fixed
Summary:
The focus of genlist was coming out of genlist's viewport area on resizing(shrinking).
This is fixed in this patch.

Test Plan: elementary_test -to genlist5, elementary_test -to fileselector

Reviewers: seoz, singh.amitesh, nirajkr

Differential Revision: https://phab.enlightenment.org/D949
2014-06-10 19:29:47 +09:00
Zbigniew Kosinski ec02c881e8 atspi: selection interface tests for elm_list widget fixed
Reviewers: raster, m.jagiello, stanluk

Differential Revision: https://phab.enlightenment.org/D927
2014-06-10 19:13:35 +09:00
abhi 9c59de7a70 fileselector: Adding search entry for realtime filename search
Summary:
search entry added for searching files/subfolders in a folder
@feature

Test Plan: elementary_test -to fileselector

Reviewers: seoz, raster

CC: raster

Differential Revision: https://phab.enlightenment.org/D875
2014-06-10 18:57:05 +09:00
Lukasz Stanislawski 139c871a72 atspi: add AtspiText and AtspiEditableText interface support.
Summary:
Added reference interface implementation for elm_entry widget. Tests added.
Updated at-spi-constants.h header to version 2.12.0.

Reviewers: raster, seoz

CC: raster

Differential Revision: https://phab.enlightenment.org/D806
2014-06-10 16:18:17 +09:00
Lukasz Stanislawski bc608f73c5 atspi: add AtspiText and AtspiEditableText interface support.
Added reference interface implementation for elm_entry widget. Tests
added. Updated at-spi-constants.h header to version 2.12.0.

@feature
2014-06-10 16:18:10 +09:00
efl b087e80e9b Gengrid: Added horizontal item loop feature.
Summary:
If item loop is enabled, the item moves infinitely in
         horizontal manner (from right to left and from left to
         right).
         Need to implement:
             -for reorder mode and horizontal mode.
         @feature

DEPENDs On D841

Test Plan: elementary_test -to gengrid2

Reviewers: seoz, eagleeye, SanghyeonLee, raster

CC: seoz, raster

Differential Revision: https://phab.enlightenment.org/D842

Conflicts:
	src/lib/elm_gengrid.c
2014-06-10 15:00:09 +09:00
Cedric BAIL ffcdbf20f5 config: always create a themes directory for user.
This make it more logical as it is part of Elementary config, so it
should be elementary duty to create that directory.

@fix
2014-06-10 00:19:19 +02:00
ChunEon Park 793145c4fb examples - renamed evas3d examples. 2014-06-09 13:31:54 +09:00
Cedric BAIL aacad9142d clock: remove use of deprecated functions. 2014-06-07 21:08:46 +02:00
Carsten Haitzler f4faf5d54a fix whitespace formatting 2014-06-07 14:57:44 +09:00
abhi e45774f6f2 gengrid: fixed _elm_gengrid_item_edge_check for ELM_FOCUS_DOWN and ELM_FOCUS_UP for normal and horizontal mode
Summary:
Added fixes for:
1.Normal mode: ELM_FOCUS_DOWN and ELM_FOCUS_UP
2.Horizontal mode: ELM_FOCUS_DOWN and ELM_FOCUS_UP

(i)

1|2|3
4|5|6
7|8|9

_elm_gengrid_item_edge_check for ELM_FOCUS_DOWN returns EINA_TRUE for item no.6.
It should not. Fixed this.

(ii)

1|2|3
4|5|6
7

_elm_gengrid_item_edge_check returns EINA_FALSE for ELM_FOCUS_DOWN
for item no. 5 and 6 but EINA_TRUE for item no. 7.
It should return EINA_TRUE for item no. 5 and 6 instead.
Fixed this.

(iii)

1|2|3
4|

_elm_gengrid_item_edge_check returned EINA_FALSE for ELM_FOCUS_UP
for item no. 3. Fixed this.

(iv)

1|4|7
2|5|
3|6|

Horizontal Mode: _elm_gengrid_item_edge_check returned EINA_FALSE
for ELM_FOCUS_DOWN for item no. 7. Fixed this.

(v)

1|4|7
2|5|
3|6|

Horizontal Mode: _elm_gengrid_item_edge_check returned EINA_FALSE
for ELM_FOCUS_UP for item no. 1. Fixed this.

Test Plan: elementary_test -to gengrid2

Reviewers: seoz, raster

CC: singh.amitesh, raster

Differential Revision: https://phab.enlightenment.org/D841

Conflicts:
	src/lib/elm_gengrid.c
2014-06-07 14:56:06 +09:00
ChunEon Park ff9238ad0e examples - clean up the button on 3d object example.
1. remove shadow var warnings.
2. use elm_main()
3. set engine gl in default.
2014-06-05 16:38:34 +09:00
se.osadchy 81dc840d03 example: add new example for button and Evas_3D object.
Summary: This example shows the mechanism of elementary widget (button) adding to the 3d scene object.

Reviewers: Hermet, cedric, raster

Differential Revision: https://phab.enlightenment.org/D937

Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
2014-06-04 19:37:23 +02:00
Tom Hacohen efa41c7d75 Elm: Update code to use the new class names generated by eolian. 2014-06-03 11:54:44 +01:00
ChunEon Park b3b5b83cf1 examples - clean up 3d_scene_on_button_example. 2014-06-02 22:50:33 +09:00
se.osadchy 26a4b301dd [Examples] Add new example for evas-3d and widget.
Summary: This example shows the mechanism of scene object adding to the widget button.

Reviewers: Hermet, cedric, raster

Differential Revision: https://phab.enlightenment.org/D914
2014-06-02 22:34:25 +09:00
Carsten Haitzler 77ff32b582 elm win - if no ELM_DISPLAY is set, try more engines before giving up
this should fix T1294 without needing ELM_DISPLAY set. @fix
2014-05-30 15:41:40 +09:00
Carsten Haitzler 546b0f6634 atspi:AtspiSelection interface added
Reviewers: stanluk, m.jagiello, raster

Differential Revision: https://phab.enlightenment.org/D810
2014-05-30 11:56:24 +09:00
Yakov Goldberg 4d334ffdd8 Fileselector Entry: add the changed signal in the events section of fileselector_entry.eo 2014-05-29 16:07:53 +03:00
Anil Kumar Nahak c72174031d fileselector: Added focus cycle feature.
Summary:
Previously there was no focus_direction & focus_next.
These functions are added in filesector winset for currect focus movement inside the winset.

Test Plan: elementary_test->"fileselector"

Reviewers: raster, seoz, nirajkr, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D913
2014-05-29 11:35:46 +09:00
efl a6e1a0e2c8 Gengrid: Fixed _elm_gengrid_item_edge_check for ELM_FOCUS_LEFT and ELM_FOCUS_RIGHT in horizontal mode.
Summary:
1|4         _elm_gengrid_item_edge_check for ELM_FOCUS_LEFT returns EINA_FALSE for item no. 3,
2|          which should return EINA_TRUE. Fixed this.
3|

1|4|7|      _elm_gengrid_item_edge_check for ELM_FOCUS_RIGHT returns EINA_FALSE for item no.5,
2|5|        which should return EINA_TRUE. Fixed this.
3|6|

Test Plan: elementary_test -to gengrid2

Reviewers: seoz, eagleeye, SanghyeonLee, raster

CC: seoz, raster

Differential Revision: https://phab.enlightenment.org/D846
2014-05-28 18:21:11 +09:00
Lukasz Stanislawski 39eb7acec6 atspi: add accessible default relations and attributes
Summary: Tests added for accessibile interface

Differential Revision: https://phab.enlightenment.org/D900
2014-05-28 17:12:34 +09:00
bluezery 044b99a2f1 elm_map: Add new elm_map_region_zoom_bring_in() API
Summary:
By using this API, we  can do region show & bring in concurrently.
This needs some tuning more because some main layouting logic in map
needs to be modified to support more smooth animation.
I will spare my time to do that later.
@feature

Reviewers: Hermet, raster, stefan_schmidt

Reviewed By: raster

CC: Jaehyun

Differential Revision: https://phab.enlightenment.org/D887
2014-05-28 17:08:01 +09:00
Yakov Goldberg 2ac106d3fd Entry: add the "changed", "changed,user" signals in the events section of entry.eo. 2014-05-28 10:09:39 +03:00
Lukasz Stanislawski f4f2bbdbcd atspi: add AtspiImage interface support.
Summary: Sample implementation for elm_image added.

Reviewers: raster, seoz

Differential Revision: https://phab.enlightenment.org/D794
2014-05-27 16:23:13 +09:00
Kateryna Fesyna 28e73198f7 Genlist: Add function to search item by string.
Summary:
This function allows user to search for item in Genlist.
It takes four search parameters:
1. pointer to function to get text of the item. It could be the same with item's
   get_text function. This parameter is added to let user use the specific search key
   and to avoid problems with setting item's text, that is not constant.
2. pointer to the item from which search should start.
3. search pattern.
4. fnmatch() flags.
To check it's usage the new test is added to the elementary_test (Genlist Item Search By Text)

Reviewers: cedric, seoz, raster

CC: reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D566
2014-05-27 15:55:05 +09:00
Daniel Juyung Seo 7357290056 genlist: fixed wrong item focus set on item_focus_set API call.
Reset the last_focused_item on _item_focus_set_hook.
This fixes the issue which sets the focus to the wrong item when the
focus is set by an API.

Reproduction step:
elementary_test -> genlist focus -> click an item (not the 2nd item) -> click "Focus 2nd
Item after 1.5 seconds" button.
Focus is not moved to the 2nd item.

@fix
2014-05-26 22:08:13 +09:00
Daniel Juyung Seo d9f0509b5e toolbar: changed internal variable types to sync with other widgets.
Changed the variable type from (Elm_Toolbar_Item *) to (Elm_Object_Item *)
for focused_item, last_focused_item, and prev_focused_item.
2014-05-26 22:07:07 +09:00
Carsten Haitzler ec896a6acc fix example to follow namespace correctness in elm theme
fixes T1024
2014-05-26 19:11:02 +09:00
Carsten Haitzler 27c8d879af elm scroller - fix documentation on gravity
this fixes T1262
2014-05-26 18:36:13 +09:00
Carsten Haitzler 6bcd3957ca elm spiner - fix flag read to also use the right field 2014-05-26 18:03:44 +09:00
Carsten Haitzler b38fed55aa elm spinner - fix invalid struct modification when wheel event 2014-05-26 18:01:45 +09:00
chinmaya 184c394259 Genlist: On focus_on_selection mode, the focus should set on item content objects of item type ELM_GENLIST_ITEM_TREE.
Summary:
On focus_on_selection set, the focus set on genlist item of type ELM_GENLIST_ITEM_TREE rather than
         on item content objects.

Test Plan: elementary_test -to "genlist focus"

Reviewers: seoz, eagleeye, SanghyeonLee, raster

Reviewed By: raster

CC: seoz

Differential Revision: https://phab.enlightenment.org/D899
2014-05-26 15:52:07 +09:00
chinmaya cd603fa02b Genlist: Focus does not move, if it is set on item content objects.
Summary:
If focus is set on item content object, it's treated as a
         different object which results the focus deadlock. So, every
         time whenever focus sets on item content object, we need to
         unset and set the focus on genlist object. Thanks to Seoz for
         the idea.

Test Plan: elementary_test -to "genlist focus"

Reviewers: seoz, SanghyeonLee, eagleeye

CC: seoz

Differential Revision: https://phab.enlightenment.org/D891
2014-05-26 15:45:54 +09:00
wonguk.jeong c3c0c7abc3 test_progressbar: delete timer when progressbar is destroyed.
Summary:
elementary_test -> progressbar/progressbar2 -> press start -> close window
-> annoying message is shown due to API invoking for already free'd progressbar

Test Plan: elementary_test -> progressbar/progressbar2 -> press start -> close progressbar/progressbar2 window

Reviewers: raster, seoz

CC: seoz

Differential Revision: https://phab.enlightenment.org/D888
2014-05-26 15:25:28 +09:00
Thiep Ha 283140a639 entry: update selection handlers' visibility when entry is hidden or shown
Summary:
Selection handlers' visibility should be updated when entry is hidden or shown
When entry has selection and hidden, the selection handlers should be hidden also.
This fix T1175.

@fix

Reviewers: seoz, woohyun, raster

Reviewed By: raster

Maniphest Tasks: T1175

Differential Revision: https://phab.enlightenment.org/D877
2014-05-26 11:28:12 +09:00
WooHyun Jung 3aa0cb8edf win: set NULL to focus_highlight.prev.target when it's deleted. 2014-05-23 11:07:59 +09:00
Andy Williams ccc06de678 Correctly emit the scroll signal when scrolling an entry @fix T1274.
As the Elm_Entry has replaced the _scroll_cb we need to emit the same signal
(that was the only function of elm_scroller's _scroll_cb)
2014-05-22 22:35:06 +01:00
Carsten Haitzler 3b6d64b85e default theme - make finger size 10 2014-05-22 18:46:36 +09:00
ChunEon Park a9c718361a image - null checking.
If the rotated image exceeds image maximum size, the data would be invalid.
2014-05-21 13:24:32 +09:00
Jean-Philippe Andre 8e45bb869e elm_test: Set PACKAGE_LIB_DIR to fix windows runtime 2014-05-20 16:37:17 +09:00
Carsten Haitzler c567a27a82 fix 0 size focus region
@fix - this fixes T1205 ... or should fix it... in theory.
2014-05-20 15:34:01 +09:00
Jean-Philippe Andre 1952c510b9 elm_cnp: Fix build for windows (ecore_x) 2014-05-20 11:37:30 +09:00
Daniel Juyung Seo 5c82d2d652 widget: updated internal documentation for elm_widget_item_del. 2014-05-20 00:55:27 +09:00
Vorobiov Vitalii 39e1971472 [Fileselector] Fix double-call of callback function on clicking "Enter" key.
Summary:
This feature (Clicking on "Enter" key) was previously implemented by using "activate" signal of entry (the one for entering name of the file),
so it was looking like "ok" button was clicked by pushing "Enter" key on the keyboard.
This little feature was added in commit 4d761f3a63270c88fa516764d9288f8bf0ff4a11.

Later the huge feature that adds key binding was implemented (commit 820f3dc907250c0c08ed8431b50567e58d6dab5c for ex).
It allows to bind widgets with keys (certain function calls when certain keys is pressed on keyboard).
This feature also adds same functionality to fileselecter, doing the same as previous (with "activate" signal) one.

Because of that it was looks like "ok" button was clicked twice.
This commit fixes this behavior and removes old and outdated method of "ok" button clicking processing.
@fix

Reviewers: cedric, seoz, raster

CC: reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D864
2014-05-19 15:41:32 +09:00
Jaehyun Cho 39b35f059d elm_map: Fix to calculate map size not to be smaller than viewport size
Summary:
Fix to calculator map size not to be smaller than viewport size when zoom mode is either fit or fill.
Previously, map size could be either smaller or larger than viewport.
@fix

Reviewers: Hermet, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D861
2014-05-19 13:30:04 +09:00
Daniel Juyung Seo bbb70363f1 example: added ellipsis: -1 to text parts which have min 1. 2014-05-17 20:22:00 +09:00
Daniel Juyung Seo 4f056651ac focus: apply the focus API change during the development phase.
This fixes the commit 422b8717 which was pushed to master without
considering the API change.
2014-05-17 20:20:52 +09:00
Daniel Juyung Seo c3acc8d0db Revert "Revert "focus: Fixed the animation issue related to bring_in.""
This reverts commit e4ae67535672d04eec9eb368b71c72932cc0f757.

This will be fixed in a next commit.
2014-05-17 20:20:07 +09:00
Carsten Haitzler e7563a179c cursor test - make button expand to test window edges with cursor 2014-05-16 19:04:37 +09:00
SangHyeon Lee c565ec1cde [Gengrid] Fix gengrid item position update bug, when item is reordered or deleted.
Summary:
When gengrid item is reordered or deleted, gengrid didn't update item's position.
         This Patch update item's position when item is placed. if middle of item deleted,
         every item after the deleted one, will re-postion on _item_place function, so they
         will be update there position well.

Test Plan:
modify test_gengrid grid_sel fuction to print there position. so when item selected,
           they print there position and it works fine both horizontal and vertical.

Reviewers: bluezery, seoz, raster

Reviewed By: raster

CC: Hermet, chinmaya061

Differential Revision: https://phab.enlightenment.org/D855
2014-05-15 12:13:23 +09:00
Amitesh Singh e6748f033a hoversel: Icon parent set to button.
Summary: This is an optimization over parent set to hoversel object.

Reviewers: seoz, raster

CC: seoz

Differential Revision: https://phab.enlightenment.org/D853
2014-05-15 12:09:33 +09:00
Amitesh Singh d7e56fb837 hoversel: item-loop should happen on UP/DOWN Key in case of vertical hoversel and on LEFT/RIGHT Key in case of horizontal hoversel.
Summary:
Earlier focus was moving to top item from bottom item on LEFT key and to bottom item on RIGHT Key
in case of vertical hoversel.
@fix

Test Plan: elementary_test -to "Hoversel Focus"

Reviewers: raster, seoz

Reviewed By: seoz

CC: seoz, chinmaya061

Differential Revision: https://phab.enlightenment.org/D858
2014-05-14 21:50:31 +09:00
Youngbok Shin 8730b8d990 entry: Enable context menu with mosue down even if the entry is not editable in some case.
Summary:
Even if a entry is not editable, user can select text in the entry.
When the entry has selection, we have to support "copy" option.
@fix

Test Plan:
Precondition: Apply D852 patch for fixing a bug in elementary_test
1. elementary_test -to entry7
2. Select some text in the non-editable entry.
3. Press mouse right button.

Note: You can test it in Desktop profile.

Reviewers: tasn, woohyun, seoz

Differential Revision: https://phab.enlightenment.org/D848
2014-05-14 13:26:48 +01:00
nirajkr 495fe1462c gengrid : Fix the issue to skip disable item in item select
Summary:
Fix to skip the item which is disabled and select the next item to the
         disabled item
         @fix

Reviewers: seoz, raster

CC: seoz, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D700
2014-05-14 20:50:11 +09:00
Jaehyun Cho 7e6799db44 elm_map: Fix to show and bring in a correct region after zooming
Summary:
Show and bring in a region which has the given latitude and longitude after zooming
@fix

Reviewers: Hermet

CC: seoz

Differential Revision: https://phab.enlightenment.org/D851
2014-05-14 12:27:27 +09:00
Lukasz Stanislawski e62b07f779 layout: remove sizing_eval call when layout is already destructed. @fix
Summary:
Layout's sub_object_del function calls sizing_eval even if layout's smart_del
function has already been called (Due to widget_smart_del impl).
This patch adds 'destructed_is' flag to Elm_Layout_Smart_Data and prevents unneeded
sizing_eval calls when object is already destructed.
Patch also fixes SIGSEGV in layout derived entry widget caused by calling
sizing_eval after entry_smart_del destructor.

Added entry test to avoid regression for SIGSEGV bug.

Test Plan: run tests/elm_test_entry

Reviewers: raster, seoz, tasn, cedric

Differential Revision: https://phab.enlightenment.org/D823
2014-05-14 12:02:10 +09:00
Youngbok Shin be3e33171f entry: Fix a test case for editable, non-editable entry.
Summary:
elm_entry_context_menu_disabled_set API is called to wrong entry.
It should be called to "en2" that added for testing the API.
@fix

Test Plan: 1. elementary -to entry7

Reviewers: woohyun, seoz, tasn

Reviewed By: seoz

CC: herdsman

Differential Revision: https://phab.enlightenment.org/D852
2014-05-13 15:50:05 +09:00
Carsten Haitzler 52dacc461f Revert "focus: Fixed the animation issue related to bring_in."
This reverts commit 422b8717660853ff099359dc3cd926e56f1b1665.
2014-05-13 11:32:00 +09:00
Anand 94bc3ce471 focus: Fixed the animation issue related to bring_in.
Summary:
Calculating the coordinate of the object to retain the focus with in view port.
Earlier focus was moving out of view port.

Test Plan:
elementary_test-> "Focus 3". Enable the Focus Auto scroll bring in and use
keys to move focused item.

Reviewers: raster, seoz, singh.amitesh, nirajkr

Differential Revision: https://phab.enlightenment.org/D822
2014-05-13 11:24:20 +09:00
Jean-Philippe Andre e3b0582c8d test_dnd: Fix build for windows
There is no strndup (with our compilation flags).
2014-05-12 19:34:07 +09:00
Jean-Philippe Andre d94daa2a63 elm_map: Fix compilation warning/error
ELM_WIDGET_DATA_GET_OR_RETURN can take a VA_ARGS if the function
should return something.
2014-05-12 15:44:18 +09:00
Jaehyun Cho d0c95fe3af elm_map: Fix to support customized style for elm_map
Summary: Load a map theme with a style to support customized style

@fix

Reviewers: Hermet

Reviewed By: Hermet

CC: seoz

Differential Revision: https://phab.enlightenment.org/D845
2014-05-12 13:50:38 +09:00
Daniel Juyung Seo a64e8eed91 focus: update the focus in_theme status on each item's focus set.
As widget and widget item can have different in_theme value (since
 30cada369), we need to update in_theme value whenever the widget or
widget item get the focus.

Applied this logic to genlist, gengrid, toolbar first.
List focus is not working well at the moment.

This fixes small focus highlight on the left top corner of genlist
when the genlist scroller is clicked before the genlist is focused.

Special thanks to zmike for the report.
2014-05-12 01:25:43 +09:00
Daniel Juyung Seo d6a8cea94c list: Use convenient macro ELM_RECTS_INCLUDE. 2014-05-11 23:06:59 +09:00
Daniel Juyung Seo 45e8b4c82e focus: Change new API names related to focus auto scrolling.
elm_config_focus_auto_scroll_bring_in_enabled_get/set()
 ->
elm_config_focus_autoscroll_mode_get/set()

The main reason is that bring_in_enabled_get/set() APIs are too restricted
and thus not flexible. I got more requirements for the focus autoscrolling
such as none, wholely visible not just bring_in and show. So it is correct
to add mode_set/get() APIs for the focus auto scrolling.

Thanks god, we've found this before the release :)

@feature
2014-05-11 22:46:16 +09:00
Daniel Juyung Seo 4f8614e866 Revert "remove all scrolling changes for focused items."
This reverts commit 377179bdaf84aa1a86621cdfa64ed43613ab9d45.

The main claim of https://phab.enlightenment.org/T1205 was fixed in
the previous commit 30cada369. This code will be modifed again in the
next commit due to the api change during development life cycle.

Note: do not blindly revert this commit if you have any problem with
widget item focus. This commit is not related to any fundamental cause
of the issues. If you have a problem, please contact me first.

seojuyung2@gmail.com or SeoZ on IRC.

Thanks.
2014-05-11 22:42:15 +09:00
Daniel Juyung Seo dfead75366 gengrid/genlist/list/toolbar: Do not set the focus to the item on widget's first focus.
This was introduced during 1.10 development phase but this changed the
default focus behavior and got a lot of complaints. (especially from
discomfitor)

So I would like to comment this out now and make it optional on 1.11
by keeping the default behavior.
2014-05-11 21:21:51 +09:00
Daniel Juyung Seo 5407141ac6 list: added comments about an unused function.
Fixing this issue is not trivial and will bring another issues like crashing.
So it is better to fix this in a development phase by refactoring list.

To fix this issue, the following are needed:
1. it->walking concept should be adopted instead of using just sd->walking.
   sd->walking was introduced in beb418d6
2. elm_widget_item_del() should be called instead of the combination of
   _elm_list_item_free() + elm_widget_item_free()
   This was introduced in f343011d
2014-05-10 23:44:28 +09:00
Daniel Juyung Seo 254798b47e list: initialize some internal variables on item free not item del pre.
This fixes variable initialize problems related to focus. This can be
reproduced when you enable focus highlight/animation and reuse
elm_list by clearing it.

This problem occurred because list item del pre is never been called.
This bug will be addressed in a next commit.
2014-05-10 23:44:28 +09:00
Daniel Juyung Seo 8ffbf246f4 elm: fixed trivial formattings.
Just found them while reading codes.
2014-05-10 23:44:27 +09:00
Daniel Juyung Seo af92b3e6f9 elm: call elm_widget_item_del instead of elm_object_item_del inside elementary.
This reduces only one more function call but this makes the elm code
more consistent between widgets.
2014-05-10 23:44:27 +09:00
Daniel Juyung Seo 44a67054de elm: fixed wrong internal variable name.
Unified the local variable name to ret if the ret is a return value of
another content_unset calls.
- Evas_Object *int_ret --> Evas_Object *ret
- Evas_Object *int_content --> Evas_Object *ret
- Evas_Object *content --> Evas_Object *ret
2014-05-10 14:13:57 +09:00
Daniel Juyung Seo 774e32be36 test_naviframe: added a test for event freeze checking. 2014-05-10 14:01:33 +09:00
Daniel Juyung Seo 45f7f881e8 gengrid: removed build warning. 2014-05-10 01:12:20 +09:00
Anil Kumar Nahak cae2b831a1 test_gengrid: Added a checkbox for enable/disable of reorder_mode feature
Summary: reorder mode can be enable/disable by clicking "'Reorder mode enable" checkbox

Test Plan: elementary_test->"GenGrid"

Reviewers: raster, seoz, nirajkr, singh.amitesh

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D829
2014-05-10 01:09:27 +09:00
Anil Kumar Nahak 9d1813f7ee genlist/gengrid: Use pan object geometry for focus highlight calculation
Summary: Genlist/gengrid object geometry was used before this patch but using the pan object geometry is more correct. This can be reproduced when the size of "elm.swallow.content" part is smaller then the size of scroller object, focus animtaion on items is jerky.

Reviewers: raster, seoz, singh.amitesh

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D818
2014-05-10 01:07:58 +09:00
Ryuan Choi 40a3850ee2 ctxpopup: Fixes that remains diskselector when dismissed ctxpopup of elm_datetime.
elm_object_content_unset should return child element which is unset.

Tests: elementary_test -to datetime
2014-05-09 23:02:56 +09:00
ChunEon Park e312e34652 widget - use eo call. 2014-05-09 15:24:18 +09:00
ChunEon Park 1a99f9274c widgets - propagate current parent orientation to sub object.
If object is unset then set to parent again, the current orientation signals
should be emitted so as to be latest state.

@fix
2014-05-09 15:18:49 +09:00
Patryk Kaczmarek 707599d4cc access: fix typo _elm_access_object_unhilight -> _elm_access_object_unhighlight
Summary: Name of that function is not proper in my opinion. Please consider that revision.

Reviewers: raster, seoz, bluezery, stanluk, jaehwan, kimcinoo

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D827
2014-05-08 11:20:18 +09:00
Daniel Zaoui 16199ba990 Web: bring legacy from the dead.
ABI check found that during Eolian integration of Elm Web, I forgot some
deprecated function.
2014-05-07 13:46:18 +03:00
zmike fe4fae4954 Revert "Revert "focus: Removed unused parameter from an internal focus function.""
This reverts commit b8549f3e83a8592145a50085182583adead2c74e.

this build system is bad and whoever did the eo integration should not feel pleased with themselves.
2014-05-07 01:13:19 -04:00
zmike 54eabd94e2 Revert "focus: Removed unused parameter from an internal focus function."
This reverts commit 5832b692aa5f68a2924bd7886390d489eb13aefb.

broke build
2014-05-07 01:08:04 -04:00
zmike be636e58be remove all scrolling changes for focused items.
this.is.BROOOOOOOOOOOOOOOKEEEEEEEEEEEEEEEEEEENNNNNNNNNNNNNNNNNNNNNNNNNNNNN.

SERIOUSLY.

you cannot go scrolling all over the place in every widget that has a scroller just because the widget gets focus. what user wants that? no user anywhere, under any circumstances, ever, in all of history.

if you dare to put this back in, I will continue to remove it for the rest of eternity until it never, ever scrolls in any unwanted case. the focused item doesn't have to always be in the viewport, and should never be moved into the viewport [[[[[[[ except to maintain an already-existing position inside the viewport ]]]]]]]

too much of my time wasted on this stupid "feature" which should have been MUCH more thoroughly tested and reviewed before it was merged.

T1205 STILL NOT FIXED
2014-05-07 01:06:30 -04:00
Daniel Juyung Seo d0380e3342 focus: Removed unused parameter from an internal focus function.
is_next parameter is not used for
elm_widget_focus_highlight_geometry_get() function.
But this parameter was not cleaned up in the commit 5320cca.
2014-05-07 00:05:07 +09:00
Daniel Juyung Seo fcd1a729ed theme: removed unnecessary null check.
Null check is already done in the previous line so do not check null
again.
2014-05-04 06:18:58 +09:00
Ryuan Choi 1c1cc3edd5 Fix the leak when closed alert/prompt/confirm since 1be3950fd
Spotted by seoz.
2014-05-03 19:36:54 +09:00
Daniel Juyung Seo a44e4e5411 photocam: added @c to EINA_TRUE/FALSE doxygen. 2014-05-03 03:51:44 +09:00
Daniel Juyung Seo 3b20add9a6 focus: Fixed focus_region_show to consider bring_in_enable configuration.
focus_auto_scroll_bring_in_enable feature is new in 1.10, this would
not be backported.
2014-05-01 22:27:05 +09:00
Daniel Juyung Seo cfb42e0502 test_focus: initialize focus related check states correctly.
Fetch the current focus config status.
2014-05-01 21:54:24 +09:00
Daniel Juyung Seo fa2a17a1fb config: internal code refactoring for the readability.
Gathers focus related configurations.
2014-05-01 21:34:55 +09:00
Daniel Juyung Seo be30d78165 config: removed unnecessary variable initialize.
It is overwritten in the following line.
2014-05-01 21:31:14 +09:00
Daniel Juyung Seo e9644d6882 elm_config: added focus menu to elementary_config.
This helps focus debugging by changing the global configuration.
2014-05-01 21:30:14 +09:00
Daniel Juyung Seo 5769f3954c config: apply CHECK_ADD macro to elementary_config. 2014-05-01 18:51:24 +09:00
Daniel Juyung Seo 00a0457aad config: introduced a global CHECK_ADD macro for elementary config. 2014-05-01 18:38:02 +09:00
Amitesh Singh 24a4e9e67c gengrid: frame variable should be used for position changes.
Summary:
Earlier pos was getting used for the item coordinates. To support other Ecore_Pos_Map variations, frame variable should be used.
@fix

Test Plan:
elementary_test-> "Gengrid Focus". Enable reorder mode and use keys to move
the focused item.

Reviewers: raster, seoz

Reviewed By: seoz

CC: seoz

Differential Revision: https://phab.enlightenment.org/D811
2014-04-30 17:59:40 +09:00
Daniel Juyung Seo 75736227cd test_dnd: removed dead code.
This fixes coverity CID 1210426.
2014-04-30 16:14:53 +09:00
Daniel Juyung Seo 8002e0e518 test_popup: Added more align usages to reveal popup align bug.
Actually the bugs are from notify.
2014-04-30 01:21:55 +09:00
Daniel Zaoui 07c8dd641f Entry: add the activated signal in the events section of entry.eo. 2014-04-29 16:00:51 +03:00
Thiep Ha e005cb7895 test_dnd: Change sending data to be compatible with other apps
Summary:
The sending data used # character, it is not compatible with other apps, so we should change it.

Change sending data to use newline character to be compatible with other apps, able to correctly drag to other apps like EFM, chrome, ...

Reviewers: JackDanielZ, seoz, raster, woohyun

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D751
2014-04-29 16:28:13 +09:00
WooHyun Jung d0fc678c1a notify_test: When elm_notify is shown, set focus to it. 2014-04-29 15:39:41 +09:00
Daniel Zaoui 0491d581c0 Eolian: fix elm_widget.eo
part_text has to be an extra property, not a method.
2014-04-29 08:45:51 +03:00
zmike 5757574678 ctxpopup should not blindly show arrows when they are not wanted by the theme
@fix
2014-04-28 11:01:20 -04:00
Carsten Haitzler e585ffb4d7 elm win - fix ELM_DISPLAY to choose the right software enine 2014-04-28 21:53:52 +09:00
Daniel Zaoui 70684ea730 Eolian: install .eo files 2014-04-27 16:09:01 +03:00
Daniel Juyung Seo 535fe6bd97 gengrid: Added elm_gengrid_wheel_disabled_set/get() APIs.
Summary:
The basic idea is from Abhinandan Aryadipta and I implemented this in
upstream.
Special thanks to JackDanielZ for eolian madness.

@feature

Reviewers: JackDanielZ

Differential Revision: https://phab.enlightenment.org/D803
2014-04-27 13:54:37 +09:00
Daniel Juyung Seo 4df87d5959 gengrid: removed unnecessary return value check.
Just return the return value without checking it.
2014-04-27 13:42:48 +09:00
Daniel Juyung Seo ecc89e2c4a test_gengrid: renamed stupid long internal variable names shorter. 2014-04-27 13:12:21 +09:00
Amitesh Singh 31fd782ab0 gengrid: Implemented item_select_on_focus feature.
Summary:
This is based on bb1e8afd.
@feature

Test Plan: elementary_test->"Gengrid Focus"

Reviewers: seoz, raster

CC: seoz

Differential Revision: https://phab.enlightenment.org/D702
2014-04-27 13:08:15 +09:00
Daniel Juyung Seo b4093d2310 test_genlist: renamed stupid long internal variable names shorter. 2014-04-27 13:04:26 +09:00
Daniel Juyung Seo d4aa2ccc08 genlist: refactor the internal code to make it more readable. 2014-04-27 12:55:58 +09:00
Amitesh Singh 8405b15b2b genlist: Implemented item_select_on_focus feature.
Summary: @feature

Test Plan: elementary_test->Genlist Focus

Reviewers: seoz, raster

CC: seoz

Differential Revision: https://phab.enlightenment.org/D705
2014-04-27 12:40:17 +09:00
Daniel Juyung Seo 9652839c96 genlist: renamed internal function according to the key binding adoption. 2014-04-27 11:26:53 +09:00
Amitesh Singh 8e0ffb8332 config: Added two APIs to enable/disable focus auto scroll bring in feature.
Summary:
 Summary:
    - APIs
      - elm_config_focus_auto_scroll_bring_in_enabled_set
      - elm_config_focus_auto_scroll_bring_in_enabled_get
    - list/genlist/toolbar/gengrid: Using this feature for scrolling for focus movement.
    - Added test case in "List Focus", "Genlist Focus", "Toolbar Focus" and "Gengrid Focus"

    @feature

Test Plan: elementary_test->"List Focus", "Genlist Focus", "Toolbar Focus" & "Gengrid Focus".

Reviewers: raster, seoz

CC: seoz

Differential Revision: https://phab.enlightenment.org/D799
2014-04-27 04:15:26 +09:00
Amitesh Singh 112d481dca gengrid: ignore key events if item reorder is going on.
Summary: This was missed in 43eb52e159.

Test Plan:
elementary_test->"Gengrid Focus" and enable "reorder mode" by clicking "redorder mode enable" checkbox.
Move the items by direction keys.

Reviewers: raster, seoz

Reviewed By: seoz

CC: seoz

Differential Revision: https://phab.enlightenment.org/D801
2014-04-27 03:17:02 +09:00
Daniel Juyung Seo 571b60e298 genlist: Removed unnecessary item show call on multi select.
item select will automatically trigger item show.
@fix
2014-04-27 03:02:58 +09:00
Daniel Juyung Seo 8147afcf72 toolbar: Fixed wrong edje api usage for elm objects.
This bug was introduced by the commit
4c8677166163316468da56c53b203ac572085c40 this January.

@fix
2014-04-27 02:42:01 +09:00
Daniel Juyung Seo 5f505de0b4 gesture_layer: updated internal documentations for the changed variables.
It looks like the variable names were changed at some point but the
documentation was not updated accordingly.
2014-04-27 00:45:24 +09:00
Daniel Juyung Seo 4d1d80481f gengrid: Changed internal variables to fix shadow variable build warnings.
elm_gengrid.c: In function '_item_move_cb':
elm_gengrid.c:2084:19: warning: declaration of 'y1' shadows a global
declaration [-Wshadow]
elm_gengrid.c: In function '_swap_items':
elm_gengrid.c:2136:19: warning: declaration of 'y1' shadows a global
declaration [-Wshadow]
2014-04-27 00:45:24 +09:00
zmike 07c2da9e2c entry no longer completely breaks focus by focusing itself on selection signal
I don't know why this was added, but it breaks the ability to set focus on any widgets at all under some circumstances. it also is nonsensical since you should never need to set focus while selecting because:

* you are selecting with the mouse button, thereby having previously triggered focus from the mouse click

* you are selecting using api, in which case there's a config option to allow retaining selection which is also conceptually broken by this behavior

@fix
2014-04-26 01:41:15 -04:00
Daniel Zaoui db4d33dc35 Fix Makefile indentation 2014-04-24 13:21:26 +03:00
Yossi Kantor 9c5ac1dd00 Eolian: Eo header clean.
Elementary Conform
  Elementary Widget
  Elementary Widget Container
2014-04-24 13:21:26 +03:00
Yossi Kantor 3de6b07a86 Eolian: Eo header clean and legacy integration.
Elementary Slider
  Elementary SlideShow
  Elementary Spinner
  Elementary Systray
  Elementary Table
  Elementary Thumb
  Elementary Toolbar
  Elementary Video
  Elementary Web
  Elementary Win
2014-04-24 13:21:26 +03:00
Yossi Kantor e4f4de0604 Eolian: Eo header clean and legacy integration.
Elementary Popup
  Elementary Panes
  Elementary Photo
  Elementary Photocam
  Elementary Plug
  Elementary Prefs
  Elementary Progress Bar
  Elementary Radio
  Elementary Route
  Elementary Scroller
  Elementary Segment Control
  Elementary Separator
2014-04-24 13:21:26 +03:00
Yossi Kantor 82ad449e56 Eolian: Eo header clean and legacy integration.
Elementary Interface File Selector
  Elementary Multibuttonentry
  Elementary Naviframe
  Elementary Inwin
  Elementary Label
  Elementary List
  Elementary Map
  Elementary Map Buffer
  Elementary Menu
  Elementary Notify
  Elementary Panel
2014-04-24 13:21:26 +03:00
Yossi Kantor 0f0e5cb3fe Eolian: Eo headers clean and legacy integration.
Elementary Hoversel
  Elementary Gengrid
  Elementary Genlist
  Elementary Gesture Layer
  Elementary GLView
  Elementary Grid
  Elementary Icon
  Elementary Image
  Elementary Index
2014-04-24 13:21:26 +03:00
Lukasz Stanislawski 21aafc3f2d atspi: AtspiValue interface added.
Summary:
Enables remote value changing on accessible widgets.
Added sample interface implementation for elm_slider widget.

Test Plan: build&install

Reviewers: raster, seoz

Differential Revision: https://phab.enlightenment.org/D784
2014-04-24 18:03:25 +09:00
Jaeun Choi 3c82b3c174 config: ELM_CONFIG_VERSION update
Summary: This patch updates ELM_CONFIG_VERSION according to elementary key binding.

Test Plan: None

Reviewers: raster, Hermet

CC: seoz

Differential Revision: https://phab.enlightenment.org/D768
2014-04-24 17:54:45 +09:00
Ryuan Choi 4e4c7e8658 entry: Create selection handles as lazily as possible
Summary:
Moved the construction of selection handles to _update_selection_handler in order to
reduce the cost of construction of elm_entry little bit.

Reviewers: thiepha, Hermet, seoz, raster

CC: seoz, raster

Differential Revision: https://phab.enlightenment.org/D756
2014-04-24 17:52:23 +09:00
Daniel Zaoui 67d8bd6e34 FlipSelector: fix callback type.
Evas_Smart_Cb was used in legacy while flipselector_func_type was used
in Eo. That made the compilation failing in E.
2014-04-24 11:04:35 +03:00
Yossi Kantor 40a65560f6 Eolian: Eo headers clean and legacy integration for:
Elc File Selector
  Elc File Selector Entry
  Elc File Selector Button
  Elementary Datetime
  Elementary Day Selector
  Elementary Disk Selector
  Elementary Entry
  Elementary Flip
  Elementary Flip Selector
2014-04-24 10:12:09 +03:00
Yossi Kantor 4ed35ccc04 Eolian: Eo header clean and legacy integration for:
Elementary Background
  Elementary Box
  Elementary Bubble
  Elementary Button
  Elementary Calendar
  Elementary Check
  Elementary Clock
  Elementary Color Selector
  Elementary Ctxpopup
2014-04-24 09:49:22 +03:00
Yossi Kantor 424f1b7ee0 Eolian: Eo header clean and legacy integration for:
Elementary Scrollable Interface
  Elementary Access
  Elementary Pan
  Elementary Client
  Elementary Client View
  Elementary Server
  Elementary Server View
  Elementary Layout
  Elementary Frame
  Elementary Hover
  Elementary ActionSlider
  Elementary Atspi Object
2014-04-24 09:21:32 +03:00
Jaehyun Cho ed6fb47ccc naviframe: Emit visible/invisible signals when view is shown/hidden
Summary:
Previously, previous view was just shown by evas_object_show and hidden by evas_object_hide.
Now, "elm,state,visible" and "elm,state,invisible" signals are emitted to enable application to do in edc what they want when each view is shown/hidden.

Reviewers: Hermet

CC: raster

Differential Revision: https://phab.enlightenment.org/D785
2014-04-24 14:22:26 +09:00
Hosang Kim 0f636e890a genlist: Add item loop feature
Summary:
If item loop feature is enabled, item is moved infinitely.

    1. Refactor direction key event handling routine
      - added internal function _elm_genlist_elm_widget_event_direction.
    2. Add looping feature for genlist
      - added Eolian function _elm_genlist_elm_widget_item_loop_enabled_set/get.
    3. Add demo - test_genlist.c / genlist focus

Reviewers: seoz, woohyun, jaehwan, Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D778

Conflicts:

	src/lib/elm_widget_genlist.h
2014-04-24 14:17:35 +09:00
Daniel Juyung Seo 94661ce059 genlist: reordered genlist internal structure members for a better structure packing. 2014-04-23 23:02:57 +09:00
Carsten Haitzler c196a72a31 formatting - space++ 2014-04-23 21:21:07 +09:00
Amitesh Singh f3ad4cd3c4 gengrid: item moving feature with keys.
Summary:
- Added two APIs elm_gengrid_reorder_mode_start/stop
- Add two smart callbacks
  - "item,reorder,anim,start" - This is called when a gengrid item movement
     has just started by keys in reorder mode.
  - "item,reorder,anim,stop" - This is called when a gengrid item movement just
     stopped in reorder mode.

@feature

Test Plan: elementary_test->Gengrid Focus

Reviewers: raster, seoz, SanghyeonLee

CC: seoz

Differential Revision: https://phab.enlightenment.org/D723
2014-04-23 21:13:57 +09:00
Lukasz Stanislawski 38f7840ca8 atspi: remove unused variable assignment
Summary: CID 1204328

Test Plan: build & install

Reviewers: seoz, raster

Differential Revision: https://phab.enlightenment.org/D781
2014-04-23 18:00:45 +09:00
Daniel Zaoui d2484d08d5 Genlist: fix EO errors.
Elm-Widget function was called on non elm-widget objects.
2014-04-23 11:00:50 +03:00
Ryuan Choi a4a140bd64 elm_web: Fixed build warning with ewebkit 2014-04-23 01:27:47 +09:00
Daniel Juyung Seo b173ed7c85 genlist/gengrid/list: Fix first on_focus call correctly by checking focus highlight.
First on_focus call should consider focus highlight enable status and
do the different job according to that.

This can be tested in "genlist 7" and "genlist focus" examples in
elementary_test.
2014-04-22 23:18:04 +09:00
Daniel Zaoui 1303a6dbec Eolian: fix names for elc widgets.
Even if the file names are elc_..., the class names are supposed to be
elm_...
2014-04-22 16:39:35 +03:00
Stefan Schmidt e038096529 atspi: Add header file to build to pass distcheck
The needed header was not packaged and thus made distcheck fail. I put
it into the unstable headers because I'm not sure if they are considered
stable yet. If this is the case please let us know so we can move it over.
2014-04-22 15:36:05 +02:00
zmike df0803a28c tooltips position more accurately in X in xinerama
elm_win_screen_size_get() is broken for this use case since the tooltip actually needs the full xinerama screen geometry, which is the geometry of the root window and NOT the current screen

@fix
2014-04-22 09:31:41 -04:00
Gwanglim Lee b7cb75ccb3 slider: fixed build warning
Summary: added EINA_UNUSED to fix build warning

Test Plan: N/A

Reviewers: raster, seoz, Hermet

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D777
2014-04-22 14:32:20 +09:00
Ryuan Choi c71dd81883 web2: Implemented alert/confirm/prompt
Added test cases for alert/confirm/prompt
2014-04-22 01:42:53 +09:00
Thiep Ha 7869c00600 dnd: Correct drag window positon in drag start
Summary:
If window is rotated, the drag window position is incorrect.

In drag start, the drag window is placed in incorrect position if main window is rotated.
Fix: Update drag window according to window rotation.

@fix

Reviewers: JackDanielZ, raster

Reviewed By: raster

CC: woohyun, seoz

Differential Revision: https://phab.enlightenment.org/D746
2014-04-21 17:27:46 +09:00
wonguk.jeong e1ea913a22 elm_interface_scrollable: fix wanted coordinate calculation
Summary:
boundary check of _elm_scroll_wanted_coordinates_update() is wrong.
boundary was checked with assumption that 0, 0 is top, left
however, 0, 0 could be different according to usages, in case of gengrid, 0, 0 was center left not top left)

Do not assume the min/max value, but use pan min/max value for boundary check

Fixes T1092

Test Plan: elementary_test -> grid -> uncheck multi select mode -> select first item -> click bring in -> resize window

Reviewers: raster, woohyun, seoz, zmike

CC: seoz

Maniphest Tasks: T1092

Differential Revision: https://phab.enlightenment.org/D720
2014-04-21 15:06:28 +09:00
Lukasz Stanislawski a4f3729da0 atspi: Atspi_Action interface implementation @feature
Summary: Enables remote execution of elementary widget actions.

Test Plan: build&install, accerrsiser tests on ubuntu 12.04

Reviewers: raster, seoz

Differential Revision: https://phab.enlightenment.org/D747
2014-04-21 15:04:25 +09:00
Lukasz Stanislawski 85c5216205 atspi: separate atspi mode from access mode.
Since elm_access provides its own support for screen reader, access mode
and atspi mode must be separated.

https://phab.enlightenment.org/D726
2014-04-21 15:01:11 +09:00
wonguk.jeong 495e0771c1 elm_interface_scrollable: fix resize after drag bug.
Summary:
after I drag by using scrollbar, if I resize window, the scroller position was moved to coordication before dragging.
invoke _elm_scroll_wanted_coordinates_update() after position setting in _elm_scroll_scroll_bar_read_and_update();

@fix

Test Plan: elementary_test -> drag scroller to center -> resize window -> scroller shouldn't go back to top

Reviewers: raster, woohyun, seoz

CC: seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D722
2014-04-21 14:17:43 +09:00
Lukasz Stanislawski d3fafebc9a atspi: change a method of calculating atspi VISIBLE state. 2014-04-21 12:55:28 +09:00
Lukasz Stanislawski c3b541bcda atspi: refactor atspi_object class into mixins.
Summary:
Allow to create ATSPI aware objects only by attaching Atspi interface to
Eo object. Apply protected rule to all methods, properties which should
not be available to app developer. Remove public atspi header from Elementary.h.
Make Elm_Widget inherit from Atspi interfaces, Elm_Win inherits additional
Atspi_Window interface.
Unified file names - all atspi related objects/interfaces can be found under
elm_atspi_*
and elm_interface_atspi_*.

Test Plan:
build&install, out-off tree example compilation with gcc and g++,
Orca screen reader tests on Ubuntu 12.04.

Reviewers: raster, seoz, tasn, JackDanielZ

Differential Revision: https://phab.enlightenment.org/D718
2014-04-21 12:46:12 +09:00
Carsten Haitzler 0312fd5b3d fix cursor setting to only set if currently visible
this should fix D715
2014-04-21 12:41:59 +09:00
Carsten Haitzler 9d55fab418 entry: wrong viewport value calculation issue fix
Summary:
Issue: As entire scroller edje co-ordinates was being taken instead of the actual viewport value,
if in scroller edje more parts are added apart from just "elm.swallow.content", then the viewport value
set will be wrong. hence the selection handlers will not hide when they have to hide.

solution: Instead of taking scroller edje's geometry, get the actual viewport values.
To get viewport x,y a new scrollable interface is also added.

signed-off by: Shilpa Singh <shilpa.singh@samsung.com>

@fix

Test Plan: Selection handlers have to hide correctly when the text is scrolled in a scrolled entry, if the scroller edc of entry has more parts added other than elm.swallow.content, then when we scroll the selection handlers are not hidden correctly.

Reviewers: jaehwan, woohyun, seoz, Hermet, raster

CC: govi, rajeshps, thiepha

Differential Revision: https://phab.enlightenment.org/D674
2014-04-21 12:31:49 +09:00
Jaeun Choi 200ec7840e slider: apply key binding
Summary: This patch applies key binding to elm_slider.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D761
2014-04-18 13:39:08 +09:00
ChunEon Park bce93b6342 slider - don't send signals multiple times if the multiple key is pressed/up.
since slider popup has the interval for hide animation(may have, may have not)
just checking visible is not enough but this flag is correct.
2014-04-18 12:00:32 +09:00
ChunEon Park 7809e91bbc slider: fix comment for readability. 2014-04-18 11:55:54 +09:00
Jaeun Choi fcd6880b6c slider: removed unnecessary key value check in case of key up event
Summary:
This patch removes unnecessary codes.
There is no need to check key value in case of key up event,
since any other key down event except direction keys will cancel sliding.
Instead, hide popup if the popup is visible at that point.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D760
2014-04-18 11:53:27 +09:00
Jaeun Choi f8a26ed1fa slider: code refactoring in widget_event func
Summary:
This patch improves maintainability and readability through code refactoring.
- complete branch statement instead of goto statement
- removed unnecessary codes

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D758
2014-04-18 11:45:13 +09:00
Jaeun Choi 69ddd5b7f5 multibuttonentry: change key up callback into key down callback for consistency
Summary:
Every elementary widget's action is triggered by key down event except multibuttonentry.
There's no reason why focus move and deletion should happen on key up in multibuttonentry.
This patch modifies _layout_key_up_cb into _layout_key_down_cb.

Test Plan: None

Reviewers: raster, Hermet, seoz, jpeg

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D755
2014-04-18 11:33:43 +09:00
Daniel Juyung Seo c1613811e7 spinner: Fixed broken focus movement by direction key.
This was broken by c9755bd3c828bcd2453a50542331b201089a7160.
2014-04-18 04:25:43 +09:00
Lukasz Stanislawski c30b49ecaa config: fix crash when finding key bidings
Summary: Crash occured when config was reloaded and hash data become invalid.

Reviewers: raster, seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D750

Signed-off-by: Cedric Bail <cedric.bail@free.fr>
2014-04-17 19:46:25 +02:00
Daniel Juyung Seo a3d9569910 button: Renamed internal variable of button smart data to match with
actual API.
2014-04-18 01:26:01 +09:00
Jaeun Choi 099fbbc79f spinner: apply key binding
Summary: This patch applies key binding to elm_spinner.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D752
2014-04-17 16:03:48 +09:00
ChunEon Park 58ea3efa5d ctxpopup: dimiss ctxpopup if escape key is pressed.
rahter than just hide of the ctxpopup, dimiss will be much better for usability.
because press "Escape" is closed to "Cancel" meaning conceptually.
2014-04-17 15:51:37 +09:00
Jaeun Choi e88c793425 ctxpopup: apply key binding
Summary: This patch applies key binding to elc_ctxpopup.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D754
2014-04-17 15:41:50 +09:00
Jaeun Choi bde04f61e9 ctxpopup: sd->box null check and event_flag set for previous and next focus move.
Summary:
The original code was missing
- null check of sd->box
- event_flag value set
for previous and next focus move.
@fix

Test Plan: None

Reviewers: raster, seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D753
2014-04-17 15:23:00 +09:00
Jaeun Choi f2bb1364e8 spinner: fixed odd behavior of the spinner
Summary:
when multiple key down is coming while increase/decrease the spinner values,
the speed acceleration will be reset by the new key down.

Instead, it stops the increase/decrease the spinner values behavior.

@fix

Test Plan: None

Reviewers: Hermet, raster

CC: seoz

Differential Revision: https://phab.enlightenment.org/D749
2014-04-17 11:51:51 +09:00
Ryuan Choi ed8969e557 elm_web2: Implement select popup interfaces 2014-04-17 00:34:41 +09:00