Commit Graph

84 Commits

Author SHA1 Message Date
Carsten Haitzler f779c49c89 edje - edje_cc - try and make coverty ignore the leak (invalid)
hope that this does not reappear in future if changes happen in src.
CID 1132627
2013-12-11 18:20:13 +09:00
Otavio Pontes afd8a238d1 Adding the cubic-bezier curve to edje transitions
Summary: Adding an option to use a cubic-bezier curve in edje transitions.

Reviewers: Sachiel, cedric, raster

Reviewed By: raster

CC: raster

Differential Revision: https://phab.enlightenment.org/D319
2013-12-02 15:02:40 +09:00
Cedric Bail 18632bc8c7 edje: make sure there is an initial value to avoid garbage out.
Detected by clang static analyzer.
2013-11-28 16:55:24 +09:00
Gustavo Sverzut Barbieri 8e362c7ad4 allow ecore to not load system modules.
this won't go to changelog/news as it's mainly internal, I can't see
people wanting to use it except rare cases as edje tools.
2013-11-14 13:27:19 -02:00
Cedric Bail 44f539e1a3 eina: fix eina_hash_int64 on Windows system. 2013-11-09 20:07:27 +09:00
Cedric Bail 926f4c5e84 efl: detect 64 bits correctly. 2013-11-09 19:48:31 +09:00
Thiep Ha 44639b2098 Remove selection handlers (and move to elm)
Summary:
Selection handlers are now implemented in elementary. So, we should remove them from edje.
The BLOCK_HANDLE mode should be removed also.

Reviewers: cedric, tasn

CC: cedric, raster

Differential Revision: https://phab.enlightenment.org/D312
2013-11-08 17:30:45 +09:00
Vyacheslav Reutskiy 8efe24c87d edje: add string "program_%p" (%p - edje_program pointer) to a default description of the program being build.
Fix deffect with a missing tokken 'name' in the program description block when
generated by edje_cc.

Reviewers: cedric, seoz

CC: cedric

Differential Revision: https://phab.enlightenment.org/D323

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-11-07 18:03:03 +09:00
Cedric Bail 11bad33813 epp: avoid to rely on undefined behavior for fopen.
In the case we didn't define the file to save to, fopen would have
been called with a NULL parameter. The result of that call is not
really defined and could have led to some crash at some point.
2013-11-05 16:28:56 +09:00
Vyacheslav Reutskiy d9a72ccf8b edje: add string "default" to a default description of the part being build.
Fix deffect with a missing tokken 'state' in the first description block when
generated by edje_cc (It is perfectly valid to not specify the first description
name as it will always be "default").

Reviewers: cedric, seoz

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D310

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-11-04 15:41:54 +09:00
Vyacheslav Reutskiy cff3ec04b4 edje: delete unused images from eet(edj) file.
Update the data_process_lookups function.
Earlier images are not deleted, but his name was
removed from the list, and it was possible to
access the image by id. Now all unused images
are deleted.

Reviewers: cedric, seoz

Differential Revision: https://phab.enlightenment.org/D309

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-11-04 15:29:09 +09:00
Andrii Kroitor 3973ecf2e8 edje: make functions return Eina_Bool and fix documentation.
Make the following functions return Eina_Bool so the caller can detect errors:
edje_edit_part_drag_x_set
edje_edit_part_drag_y_set
edje_edit_part_drag_step_x_set
edje_edit_part_drag_step_y_set
edje_edit_part_drag_count_x_set
edje_edit_part_drag_count_y_set

Added functions for threshold:
edje_edit_part_drag_threshold_set
edje_edit_part_drag_threshold_get

Fixed description of 'count' parameter of dragable.x/y

Reviewers: cedric, seoz

Reviewed By: cedric

CC: reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D304

Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-11-01 11:03:34 +09:00
Chris Michael 28fed3fdb7 Fix formatting
Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-10-27 15:44:31 +00:00
Chris Michael 2be84a6073 Fix compiler warning(s) about eina_hash_int64 being passed pointer
from integer

Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-10-27 15:43:18 +00:00
Cedric Bail 4be4076cd4 edje: handle reallocation of pointed data properly for limits. 2013-10-15 18:15:51 +09:00
Cedric BAIL 443012dbcb edje: typo fix. 2013-10-14 14:00:59 +02:00
Cedric BAIL 48bc51b0c7 edje: fix CID 1054522 - Logically dead code
The buffer is a static buffer in that scenario, so never going to be NULL indeed.
2013-10-14 13:53:06 +02:00
Cedric BAIL 12072b2217 edje: fix CID 1062226 - Dereference after null check.
It seems to be possible in some badly crafted edj to trigger that path.
2013-10-14 13:45:26 +02:00
Carsten Haitzler 6732ab15af 1 char editing messup - revert it. 2013-10-13 11:38:59 +09:00
Carsten Haitzler f3e3739e7c edje_cc - CEEEEEEEEEEEEDRIIIIIIIIC! realloc+lookup bug workaround!
need i say more. this is a q1uick workaround a bug that is a result of
realloc moving memory around and thus lookups becoming broken.
2013-10-13 02:07:28 +09:00
Cedric Bail 797ad7528f edje: add border linked to Image sets.
It is quite common that in an image sets each image has different border size.
This patch permit to define the border value on a per image basis in the set.
2013-09-06 16:47:36 +09:00
Boris Faure 84c383dc1a export EFL_VERSION_MAJOR/MINOR 2013-08-29 15:28:32 +02:00
Boris Faure 18ee1e1789 edje: export EINA_VERSION_MAJOR/MINOR when compiling edc files 2013-08-29 15:17:19 +02:00
Gustavo Lima Chaves d84e77d93f Enough with this bad align Edje property documentation. 2013-08-12 13:29:43 -03:00
Stefan Schmidt 84a7cefcc2 edje: Do not access after freeing
Better free it after we access it.

CID 1039917
2013-08-09 11:43:25 +01:00
Cedric Bail 93b0fbfe65 edje: add warning when not finding the exact match.
This will close T223.
2013-08-07 16:01:57 +09:00
Chris Michael ff9b4775e8 Fix memleak in data_thread_script of edje_cc_out
NB: If we are going to exit data_thread_script function due to malloc
failure or fread failure, then we should close the previously fdopen'd
file so that we do not leak 'f'.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-05 15:32:12 +01:00
Chris Michael 397e8afc1a Avoid potential divide by zero in INF call.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-05 12:42:31 +01:00
Chris Michael 42496ac4ea fopen can fail. check file is open before trying to write to it.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-05 10:41:16 +01:00
Daniel Juyung Seo a3165bff15 edje: added BLOCK_HANDLE description and vim syntax. 2013-08-02 13:27:54 +09:00
Cedric Bail cf9b0180d6 edje: add threshold to draggable part. 2013-07-19 15:40:11 +09:00
ChunEon Park 8cec34d1d4 edje/map - changed data structure from list to array to improve color data memory access 2013-07-18 20:09:54 +09:00
Carsten Haitzler 08105a0136 fix clang sizeof complaint 2013-07-16 20:45:24 +09:00
Carsten Haitzler a484403db8 fix a bunch of reallocs self-assigning the same var 2013-07-16 20:45:24 +09:00
Carsten Haitzler b84e81fbea fix clang sizeof complaint 2013-07-16 20:45:24 +09:00
Carsten Haitzler a091a1d730 fix clang sizeof complaint 2013-07-16 20:45:24 +09:00
Carsten Haitzler 9a3256ba44 fix clang sizeof complaint 2013-07-16 20:45:24 +09:00
Carsten Haitzler 36cd49a182 fix realloc assign to "self". 2013-07-16 20:45:24 +09:00
Carsten Haitzler 2ca7f23dbc fix clang nonnull complaint 2013-07-16 17:12:08 +09:00
Carsten Haitzler 8db1013956 fix clang nonnull complaint 2013-07-16 17:10:59 +09:00
Chris Michael 7fc497ee6e Fix memleak reported by Coverity:
If we have file And fname, then we can call the source_fetch_file
function, HOWEVER we may only have One or the Other in which case we
still need to potentially free the other.

NB: Fixes Coverity CID1039296

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 13:13:15 +01:00
Chris Michael 61e17aa5c2 Fix memleak reported by Coverity: Don't leak a strdup.
NB: Fixes Coverity CID1039295

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 13:11:10 +01:00
Chris Michael 93fc18daf2 Fix leak of fd handle reported by Coverity
NB: Fixes Coverity CID1039288

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 13:07:18 +01:00
Chris Michael 9d60d6ccff Check return value of lseek call for errors.
NB: Fixes Coverity CID 1040029

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 07:31:50 +01:00
Ryuan Choi 8d41667412 edje_cc: Fixed possible leak when description.map.color defines same idx more than one time
Spotted by coverity. CID 1039298.
2013-07-06 01:30:54 +09:00
Chris Michael 03448524ab Don't try to print out how many bytes we write to an eet file Unless
we actually write something.

NB: Fixes klockwork issue.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-02 09:54:30 +01:00
Chris Michael 292d23321c Check for valid out_file before trying to write eet data to it.
NB: Fixes klockwork issue.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-02 09:53:08 +01:00
Chris Michael e2b2918858 Check for valid output_filename before trying to use it.
NB: Fixes klockwork issue.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-02 09:43:23 +01:00
Chris Michael 204212131b Fix klockwork error: Null pointer may be dereferenced
Check for valid out_file before trying to use it.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-06-28 13:48:21 +01:00
Daniel Willmann cd980c4bea edje_cc: Fix memory leak in data_thread_script() in error case
Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
2013-06-26 11:10:57 +01:00