Commit Graph

187 Commits

Author SHA1 Message Date
Kateryna Fesyna 8ceef8c6ca edje: Edje_Edit - fix segfault on copying state of IMAGE part with twins
Summary:
The copying of state of IMAGE part with twins caused the sefmentation fault due to the extra memory freing in _edje_edit_part_state_copy() that is deleted with this commit.
The data that is freed was previously copied from the structure of state 'from' and freeing of this data leads to freeing data of 'from' part.
Later, on copying of tweens to 'to' state array of tweens appears segmentation fault because we try to access freed data of 'from' state.

@fix

Reviewers: cedric, Hermet, raster, seoz

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1636

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-11-06 06:18:38 +01:00
Kateryna Fesyna 41ea6e81d6 edje: Edje_Edit - fix segfaults on restacking of text parts with set 'text_source'.
Summary:
This commit fixes segfault on restacking text parts with set 'text_source'
that is caused by wrong updaiting of 'text_source' IDs on restacking of parts due to typo.

@fix

Reviewers: Hermet, seoz, raster, cedric

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1646

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-11-06 06:04:43 +01:00
Vyacheslav Reutskiy 890ad5dd95 edje: edje_edit - fix posible resource leak
Fixes: https://phab.enlightenment.org/T1760

@fix
2014-10-27 10:28:25 +00:00
Vyacheslav Reutskiy 4d7c0fe3d9 edje: edje_edit - don't unlick(NULL)
Summery: fix, posible to delete file by 'NULL' path (T1760)

@fix
2014-10-27 09:21:45 +00:00
Kateryna Fesyna f8db9a85fb edje: Edje_Edit - fix edje_edit_state_aspect_pref_set() function to setup Source and None aspect preferences
Summary:
This commit fixes check of passed value of aspect preference in edje_edit_state_aspect_pref_set() because it ignores None and Sorce values.
@fix

Reviewers: reutskiy.v.v, Hermet, raster, cedric

Reviewed By: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1542

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-10-20 17:30:57 +02:00
Maksym Volodin 9eb1093424 edje: Edje_Edit - add state alloc for PROXY part.
Summary:
To allow edje_edit_state_add work properly for PROXY part, EDIT_ALLOC_POOL for PROXY is added.
@fix

Reviewers: Hermet, seoz, cedric

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1545

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-10-18 13:48:51 +02:00
Kateryna Fesyna dad54f4f75 edje: Edje_Edit - fix edje_edit_image_usage_list_get() to return usage list with images with USER compression.
Summary:
add recalculating of image id in edje_edit_image_usage_list_get() to fix wrong behavior of this function when the image has USER compression.

@fix

Reviewers: Hermet, cedric, raster, reutskiy.v.v

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1547

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-10-18 13:47:30 +02:00
Igor Gala 7366caab1a edje: Edje_Edit - get the source name of the sample
@feature

Reviewers: cedric, Hermet, seoz, raster, reutskiy.v.v

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1546

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-10-18 13:44:30 +02:00
Vitalii Vorobiov d8955625ce Edje_Edit: creating new hash in global data if it is not created yet
Summary: edje_edit_data_add doesn't work if loaded EDJ file doesn't contain
any data items. It can't add new data item to emptry (NULL) hash.
Now, if there is no data in EDJ yet (so hash is empty), by adding new data it
will create hash and after that will add new data.

@fix
2014-10-13 16:57:08 +03:00
Tom Hacohen a7560dbc61 Eo: Change eo_add/del/unref behaviour.
Before this change eo_add() used to create an object with 1 ref, and if
the object had a parent, a second ref.
Now, eo_add() always returns an object with 1 ref, and eo_add_ref()
    preserves the old behaviour (for bindings).

eo_unref now un-parents if refcount is 0, and eo_del() is an alias for
eo_unref (will change to be a way to ensure an object is dead and goes
        to zombie-land even if still refed).
2014-09-25 17:38:45 +01:00
Igor Gala 6baada490e edje: Edje_Edit - get the buffer with sound's data
Summary:
add opportunity get the buffer with sound data for certain sound
from the given edje object. It is needed to play some sound with logic API.
@feature

Reviewers: Hermet, raster, seoz, reutskiy.v.v, NikaWhite, cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1422

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-09-22 14:59:27 +02:00
Andrii Kroitor d4f92b987f edje: Edje_Edit: fixing text properties setting
Summary:
edje_edit_state_text_source_set shouldn't replace existing text.
edje_edit_state_text_set should update text in other parts, that are using given part as text.text_source

Reviewers: seoz, Hermet, cedric

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1463

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-09-22 14:59:27 +02:00
Andrii Kroitor 51a5f852c2 edje: Edje_Edit: add missing part type checks
Summary: added necessary type checks before using typedata

Reviewers: seoz, Hermet, cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1464

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-09-22 14:59:27 +02:00
Andrii Kroitor 520809864d edje: Edje_Edit - add edje_edit_program_transition_state_set
Summary:
Set parts into intermediate state of programs transition.
0.0 represents the start state, 1.0 - the final state. Other values will set
parts to an intermediate state taking into account programs transition type.

Reviewers: seoz, Hermet, cedric

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1435

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-09-12 23:04:53 +02:00
Andrii Kroitor 38561202bf edje: Edje_Edit - add edje_edit_program_stop_all
Summary:
Stops all running programs. If any program has "after" field its value
will be ignored.

Reviewers: cedric, seoz, Hermet

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1433

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-09-12 23:00:52 +02:00
Stefan Schmidt a7fb8cd7fe edje_edit: Use eina_file_mkstemp() to avoid problems with umask
CID 1039613
2014-09-11 11:55:49 +02:00
Stefan Schmidt debb51e5df edje_edit: Check return of _edje_part_description_find_byname
If this retruns NULL we would do a NULL deref some lines below. Better check.

CID 1222458 1222457
2014-09-04 15:09:17 +02:00
Stefan Schmidt ffd1031d2b edje_edit: Another instance where we need to check the return of eet_list
Return could be NULL so check here before derefenrcing ent.

CID 1224764
2014-09-04 14:44:33 +02:00
Stefan Schmidt 703d179eb6 edje_edit: Check return value of eet_list() to avoid NULL dereference.
We check eet_list elsewhere and it might retrun NULL. Don't just hope
keys will never be NULL. Check it.

CID 1232733
2014-09-04 14:20:56 +02:00
Stefan Schmidt cfba724a37 edje_edit: Check return of _edje_edit_edje_file_save and close files if we fail
We check the retrun of _edje_edit_edje_file_save everywhere else and should do
here as well.

CID 1224759
2014-09-04 11:28:33 +02:00
Irfan Abdul 13773009de edje: Edje_Edit - add code to generate edc source for all transition types in programs
Summary:
Add code to generate edc source for all transition types used in program block.

_edje_generate_source_of_program() api generates program source code from the edje object.
Very few transition types are handled in the function. Added code to generate edc source
code for all the transition types.

Reviewers: govi, raster, jpeg, zmike, cedric

@feature

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1367

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-09-03 22:11:00 +02:00
Carsten Haitzler ec3c84b61e edje_edit - fix Dereference after null check
fix CID 1224350
2014-09-01 19:40:47 +09:00
Tom Hacohen ceada9523f Efl interfaces: Drop interface namespace from the used interfaces.
We don't need this namespace, it just makes the names long and complicated.
2014-08-21 11:02:11 +01:00
Tom Hacohen 3a468f7ad3 Efl interface file: Start using the new interface. 2014-08-21 11:02:11 +01:00
Andrii Kroitor 9a1fb1b88d edje: Edje_Edit - fix support for program's targets
Summary:
added support of all action types that use targets to
edje_edit_program_target_add and edje_edit_program_target_del

added targets cleaning to edje_edit_program_action_set to avoid usage of program id
as part id and vise versa.

@fix

Reviewers: cedric, seoz, Hermet

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1342

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-08-21 12:04:53 +02:00
Daniel Kolesa bb24b60638 eolian: generate implicit typedef for each class
And use these typedefs instead of just Eo in API.
2014-08-21 09:26:03 +01:00
Carsten Haitzler 6682add15d edje edit - clarify src a bit better (change no logic) 2014-08-13 23:50:26 +09:00
Carsten Haitzler 3eb9e586ef edje edit - make source set api clearer as to what it does for coverity
this addresses CID 1222452 - this fallthough is intended, so
document it and make the code clearer
2014-08-13 23:37:54 +09:00
Stefan Schmidt 0f658dc09d edje_edit: Actually check for z if we want to append z
Classical copy and paste error.

CID: 1224760
2014-08-08 14:37:27 +02:00
Andrii Kroitor fd3f5f4615 edje_edit: fixing return value of edje_edit_program_name_set
Summary: If name of program is setted to its current value EINA_TRUE should be returned

Reviewers: cedric, seoz, raster, Hermet

Reviewed By: Hermet

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1290
2014-08-07 23:48:22 +09:00
Mykyta Biliavskyi c037b3e80a edje: Edje_Edit - delete unnecessary check id's in edje_edit_part_restack_part_below(above).
Summary:
In case when reorder part below or above part with id 0, function return
EINA_FALSE. But part shoud restacked normaly.

Reviewers: raster, seoz, cedric, Hermet, reutskiy.v.v

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1184

Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
2014-07-14 15:55:47 +02:00
Maksym Volodin 93d3b5e285 edje: Edje_edit - edje_edit_state_text_source_set and edje_edit_state_text_text_source_set logic fix.
Summary: Patch make it possible to set NULL value for text_text_source and text_source.

Reviewers: cedric, raster, Hermet, seoz, reutskiy.v.v

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1167

Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
2014-07-10 11:51:32 +02:00
Mykyta Biliavskyi 3d2a46a417 edje: Edje_Edit - fix size memory calculating for realloc array of tweens.
Summary:
If in _Edje_Part_Description_Spec_Image->tweens wasn't added no one image,
when edje object was loaded from file, then realloc will work as free(), because size
of reallocating memory always will equal 0.

@fix

Reviewers: raster, seoz, cedric, Hermet, reutskiy.v.v

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1160

Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
2014-07-10 10:38:32 +02:00
Mykyta Biliavskyi 3e79b47e80 edje: Edje_Edit - add edje_edit_part_item_row/col_span functions.
Summary:
Getter and setter of span for box/table items.
Following functions were added:
   edje_edit_part_item_span_set
   edje_edit_part_item_span_get

Reviewers: raster, seoz, cedric, Hermet, reutskiy.v.v

CC: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1074

Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
2014-07-07 19:08:41 +02:00
Vorobiov Vitalii e35e18f8e0 edje: Edje_Edit - fix Documentation generation error's and warning's
Summary:
Fixing errors and warning with Edje_Edit documentation,
for example, adding documentation for enum and structs,
adding missed @see, @params, @returns etc.

@fix

Reviewers: Hermet, seoz, cedric, raster

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1107

Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
2014-07-07 19:02:55 +02:00
Vorobiov Vitalii 05cad6fc7a edje: Edje_Edit - add edje_edit_part_item_spread functions.
Summary:
Add four main functions to deal with TABLE or BOX items:
- edje_edit_part_item_spread_w_get
- edje_edit_part_item_spread_w_set
- edje_edit_part_item_spread_h_get
- edje_edit_part_item_spread_h_set

@feature

Reviewers: cedric, Hermet, seoz, raster

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1104

Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
2014-07-07 18:55:20 +02:00
Kateryna Fesyna 6f8d017d93 edje: Edje_Edit - Change names of two functions to match the other sounds api
Summary:
This commit provides small cleanup for sounds api.
The next functions are renamed:
edje_edit_sounds_samples_list_get() -> edje_edit_sound_samples_list_get()
edje_edit_sounds_tones_list_get() -> edje_edit_sound_tones_list_get()

Reviewers: cedric, Hermet, seoz, raster, reutskiy.v.v

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1134

Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
2014-07-07 15:51:12 +02:00
Vorobiov Vitalii 9fc7929829 edje: Edje_Edit - add edje_edit_part_item_weight functions.
Summary:
Add four main functions to deal with TABLE or BOX items:
- edje_edit_part_item_weight_x_get
- edje_edit_part_item_weight_x_set
- edje_edit_part_item_weight_y_get
- edje_edit_part_item_weight_y_set

@feature

Reviewers: cedric, raster, seoz, Hermet

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1131

Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
2014-07-07 15:51:12 +02:00
Vorobiov Vitalii 325d760c55 edje_edit: adding code generation for map functions
Summary:
After changing edj file with edje_edit functions which deals
with map, it require to regenerate source code including map block
with all changes.

Reviewers: cedric, Hermet, seoz, raster

Reviewed By: Hermet

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1105
2014-07-04 21:25:56 +09:00
Vorobiov Vitalii 75d65aef9c edje_edit: fixing -Wshadow compile warning with edje_edit_access_set
Summary:
There was -Wshadow compile warning with edje_edit_access_set
and one of it's param called access.
Changed it's name to avoid such annoying warning

Reviewers: Hermet, raster, cedric, seoz

Reviewed By: Hermet

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1106
2014-07-04 21:22:35 +09:00
Igor Gala 6fbcf48fe0 edje: Edje-Edit: edje_edit_state_map_on_xet()
Summary:
There are new 'get and set' API for block 'map'.
Those functions return or set flag which enables mapping for the part.
Default is 0.
@feature

Reviewers: seoz, cedric, raster, Hermet

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1051
2014-07-03 19:37:16 +09:00
Andrii Kroitor d8316bcc07 Edje_Edit: added clean save function
Summary:
This save function removes all unnecessary string from internal eet
distionary in .edj file. Needed after removing some objects from edje_object
e.g. groups, parts, limits etc.

Reviewers: cedric, seoz, raster, Hermet

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1090
2014-07-03 19:23:11 +09:00
Kateryna Fesyna f0f5c393d0 edje_edit: fix edc code generation for image fill tipe parameter and PLAY_SAMPLE and PLAY_TONE actions.
Summary: This commit fixes edc code generation for image fill tipe parameter and PLAY_SAMPLE and PLAY_TONE actions.

Reviewers: cedric, Hermet, seoz, raster, reutskiy.v.v

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1091
2014-07-03 18:54:37 +09:00
Vorobiov Vitalii 2447bc3556 edje_edit: Add edje_edit_state_map_point_color functions.
Summary:
Add two main functions for working with map colors of part vertexes/points:
- edje_edit_state_map_point_color_get
- edje_edit_state_map_point_color_set

@feature

Reviewers: seoz, raster, cedric, Hermet

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1086
2014-07-03 17:27:53 +09:00
Maksym Volodin 8b66dc0e7c edje_edit: Add edje_edit_part_item_position_get/set.
Summary: Edje_edit_part_item_position_set/get operates with column/row part`s item position, only for "TABLE" type part.

Reviewers: seoz, raster, cedric, Hermet, reutskiy.v.v

CC: reutskiy.v.v, cedric, c

Differential Revision: https://phab.enlightenment.org/D1078
2014-07-03 17:15:10 +09:00
Vorobiov Vitalii 2155e8a3fb edje_edit: Add edje_edit_part_item_aspect_mode functions.
Summary:
Add two main functions for TABLE and BOX part items:
- edje_edit_part_item_aspect_mode_get
- edje_edit_part_item_aspect_mode_set

Also add support to generate source code of changed aspect mode for an item

@feature

Reviewers: cedric, Hermet, seoz, raster

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1075
2014-07-03 16:59:16 +09:00
Andrii Kroitor 8c74a8fbb0 Edje_Edit: added API for group.limits
Summary:
added functions:
edje_edit_group_limits_vertical_list_get
edje_edit_group_limits_vertical_add
edje_edit_group_limits_vertical_del
edje_edit_group_limits_horizontal_list_get
edje_edit_group_limits_horizontal_add
edje_edit_group_limits_horizontal_del
edje_edit_limits_list_free

Reviewers: cedric, seoz, raster, Hermet

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1073
2014-07-03 16:54:44 +09:00
Igor Gala ddac21534f edje: Edje-Edit: edje_edit_state_map_perspective_xet()
Summary:
There are new 'get and set' API for block 'map'.
Those functions return or set  part's name which is used as 'perspective point'
for giving a part '3d look'.
@feature

Reviewers: seoz, cedric, raster, Hermet

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1047
2014-07-03 16:23:15 +09:00
Tom Hacohen aa450fa8dd Edje eolian: Fix namespaces for all of the edje classes. 2014-06-30 17:47:06 +01:00
Kateryna Fesyna 7c1a78cfd2 edje: Edje_Edit - add edje_edit_sound_tone_add() function that allows user to add new tone to collection
Summary:
New function provides the ability to add new tones to currently loaded collection.
It takes the name that will define new tone in collection and its frequency as parameters.

@feature

Reviewers: cedric, Hermet, seoz, raster

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D1023

Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
2014-06-23 11:33:25 +02:00