enlightenment/efl
enlightenment
/
efl
8
7
Fork 15
Code Issues 13 Pull Requests 2 Projects Releases Wiki Activity
23,990 Commits 489 Branches 2 Tags 428 MiB
Commit Graph

149 Commits

Author SHA1 Message Date
discomfitor 0f46b8d7ec fix ecore-x shadow warning 2013-12-12 09:31:08 -05:00
Sebastian Dransfeld 50569a69c9 ecore_x: ensure positive malloc size 
size_ret is used later as an argument for malloc, so it should be
positive. In addition this should ensure that
ecore_x_window_porp_property_get returns a positive value and is true if
we malloc data.

Hopefully also fixes CID 1135636
 2013-12-10 09:10:54 +01:00
Sebastian Dransfeld 4a24b84185 ecore_x: remove double free 
We first free'd the data in the else, then at the end.

Now we free old_data just before return, and at the end.

Fixes CID 1135637
 2013-12-10 08:30:23 +01:00
Carsten Haitzler 82841fefe3 fix seb "fix" commit that causes lots of segvs. 
this fixes 04e0a6d95e which introduced
copy & paste segv's by properly terminating the right buffer.
 2013-12-09 18:39:07 +09:00
Daniel Zaoui 1ae7a4f5e2 Ecore: add DnD abort from source 
This can be used to cancel a DnD drag operation in the middle.
 2013-12-09 09:11:27 +02:00
Sebastian Dransfeld 8b72bd6e6d ecore_x: Fix bug in ecore_x_region_invert 
As bounds is a pointer, bounds + num will always be postive, so this is
an eternal loop. In addition, XFixesInvertRegion only accepts one
region, so num must be 1.

Fixes CID 1039469
 2013-12-07 21:11:34 +01:00
Sebastian Dransfeld c8b8738612 ecore_x: Remove NULL check 
to get here, old_data != NULL.

Fixes CID 1039648 and 1039649
 2013-12-07 21:11:34 +01:00
Sebastian Dransfeld 1905fd4858 ecore_x: Use free, not XFree 
Data returned from ecore_x_window_prop_property_get are malloced, so use
free, not XFree. Which also is consistent, as free was used on other
occasions.
 2013-12-07 21:11:34 +01:00
Sebastian Dransfeld f4c71fba21 ecore_x: supported isn't an optional argument 
if supported is NULL, this function isn't of any use.

Fixes CID 1039430
 2013-12-07 21:11:34 +01:00
Sebastian Dransfeld 31d0a2d71c ecore_x: Only use att if call succeeds. 
XGetWindowAttributes isn't guaranteed to succeed.

Fixes CID 1039692
 2013-12-07 21:11:34 +01:00
Sebastian Dransfeld 6b1438af05 ecore_x: Only do memset if len < 20 
If len is 20, n is 0, and nothing to memset.

Fixes CID 1039311
 2013-12-07 21:11:34 +01:00
Sebastian Dransfeld aca33ef3d9 ecore_x: always free data and return value 
if we are the selected parser, we are responsible for free'ing data and
returning a selection value.
 2013-12-07 21:11:33 +01:00
Sebastian Dransfeld f22f861f61 ecore_x: Check if we have data 
data could be NULL and size == 0, so check for this.

Fixes CID 1039264
 2013-12-07 21:11:33 +01:00
Sebastian Dransfeld 04e0a6d95e ecore_x: '\0' terminate converted text 
This makes ecore_x text converter behave like elm text converter.

Fixes CID 1039310
 2013-12-07 21:11:33 +01:00
Sebastian Dransfeld 50feb1f8da ecore_x: Use eina_inlist 
ecore_x_selection implemented it's own single linked list. Use
eina_inlist instead.
 2013-12-07 21:11:33 +01:00
Sebastian Dransfeld d09ceaf4c1 ecore_x: Only send XdndEnter when we have types 
If ecore_x_window_prop_property_get fails, we have no types to drop so
don't send XdndEnter.

Fixes CID 1039693
 2013-12-07 21:11:33 +01:00
Sebastian Dransfeld 31fde249d4 ecore_x: Also check for !prop here 
We check if prop is NULL after first property check, do it here too.

Fixes CID 1039429
 2013-12-07 21:11:33 +01:00
Daniel Juyung Seo e2467724da ecore ecore_x_e: check 0 and -1 for ecore_x_window_prop_card32_get() return value which mean fail. 
- ecore_x_window_prop_card32_get() returns:
  -1 if the property was not successfully fetched.
  0 if the property exists but has no elements.
 2013-12-02 12:46:18 +09:00
Daniel Juyung Seo a5c98947ae ecore ecore_x_e: initialize local variable to avoid having wrong value. 
Thanks to devilhorns!
 2013-11-27 21:43:06 +09:00
Sebastian Dransfeld 3dc5eb16cc ecore_x: accept -1 as valid mm size for no change 
If we pass in w_mm = h_mm = -1 we want no change if w == cw and h == ch,
as we calculate w_mm and h_mm based on these later.
 2013-11-07 09:18:16 +01:00
Sebastian Dransfeld 144d124445 ecore_x: store atoms internally 
No need to request them every time.
 2013-11-07 09:18:16 +01:00
Sebastian Dransfeld a7382dacfa ecore_x: get correct property 
Since the function is ecore_x_randr_output_connector_type_get, I guess
we want RR_PROPERTY_CONNECTOR_TYPE, not RR_PROPERTY_CONNECTOR_NUMBER.
 2013-11-07 09:18:16 +01:00
Carsten Haitzler b07c0a76ce alpha1 release autofoo/build tree work to pass distcheck and actually work 2013-11-04 18:33:35 +09:00
Chris Michael 3cc4efaf50 Fix doxy typo/grammar 
Signed-off-by: Chris Michael <cp.michael@samsung.com>
 2013-09-26 12:16:10 +01:00
discomfitor 42fb964592 ecore-x xlib errors now only print when sync is enabled 
I give up. people continually complain about these and submit them as crashes, so now they're only visible if you set ECORE_X_SYNC. the next step is an #ifdef ISCOMFITOR.
 2013-08-25 17:15:19 +01:00
Mike Blumenkrantz 5e8e8aec7d print error when ecore-x shm check fails 2013-08-07 08:36:46 +01:00
Chris Michael 585ad86480 Patch from Phoenix Kayo <kayo@illumium.org> to fix 
ecore_x_selection_parser functions for mozurl.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
 2013-08-05 07:44:50 +01:00
Chris Michael aa75297381 Add #ifdef ECORE_XRANDR around the edid functions. 
NB: Cannot really happen for 1.8 (as --disable-ecore-x-randr has no
effect), but really these should have been ifdef'd from the start.

NB: IMO, Don't think a ChangeLog is really needed for this....

Signed-off-by: Chris Michael <cp.michael@samsung.com>
 2013-08-01 15:18:01 +01:00
Chris Michael 55094c9eb0 Set Crtc info->outputs and info->possible to NULL initially. 
Signed-off-by: Chris Michael <cp.michael@samsung.com>
 2013-07-26 07:06:58 +01:00
Chris Michael 3e9edcd539 Fix typo 
Signed-off-by: Chris Michael <cp.michael@samsung.com>
 2013-07-25 13:32:06 +01:00
Chris Michael 551610fa41 Guard against allocating 0 outputs and 0 possible outputs. 
Signed-off-by: Chris Michael <cp.michael@samsung.com>
 2013-07-25 13:09:34 +01:00
Chris Michael 8aef3fa98a Guard against trying to allocate 0 outputs. 
Signed-off-by: Chris Michael <cp.michael@samsung.com>
 2013-07-25 13:08:18 +01:00
Chris Michael f287fd33a7 Trap for number of crtcs < 1 so we do not try to allocate space for 
zero crtcs.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
 2013-07-25 12:32:49 +01:00
Carsten Haitzler e945f0d196 ecore-x: fix randr query when noutputs is 0. 2013-07-24 19:22:31 +09:00
Mike Blumenkrantz ea7bc3f670 revert e7862929e4 
the ECORE_X_SYNC environment variable exists to make ecore-x debugging synchronous.
printing X errors as they occur is useful for application developers; errors should not
be silenced just because they are inconvenient or plentiful.
 2013-07-19 09:02:33 +01:00
Carsten Haitzler e7862929e4 ecore-x: make error prints DBG not ERR so we don't get spammed 
because an error with no idea where it came from since its async is
pretty much usless noise. if you want this to be useful you literally
need to do an xsync every x call and be able to get backtraces... the
xsync then would be inside ecore-x. and of course this would be so
nastily slow that you need to make it an option at build...
 2013-07-19 09:23:11 +09:00
Mike Blumenkrantz 464dd4f206 disable ecore-x trace debugging...whoops 2013-07-18 06:24:50 +01:00
Mike Blumenkrantz 60111ce8ca add ECORE_X_SYNC env variable for xlib backend 2013-07-18 06:17:40 +01:00
Mike Blumenkrantz d77d9134f8 delete e pixmap atom based on atom pixmap atom, not pixmap 2013-07-18 05:21:07 +01:00
Mike Blumenkrantz ad7933670f ecore_x_pixmap_free no longer fails when passed 0 2013-07-18 05:21:07 +01:00
Mike Blumenkrantz 23795d1733 add ECORE_X_ATOM_XDND_DIRECTSAVE0 2013-07-17 08:44:22 +01:00
Mike Blumenkrantz 3e45bbecf6 print ecore-x xlib errors when they occur 2013-07-17 08:43:38 +01:00
Carsten Haitzler c6309b44b2 fix clang sizeof complaint 2013-07-16 19:58:01 +09:00
Carsten Haitzler d07a30fa25 fix clang sizeof complaint 2013-07-16 19:57:13 +09:00
Carsten Haitzler 604fac4166 ecore-x: vsync_animator_tick_source_set fail if drmWaitVBlank fails 2013-07-16 19:39:10 +09:00
Mike Blumenkrantz c3916df200 clamp size to ximage size for ecore_x_image_get to prevent BadMatch errors 2013-07-15 09:37:54 +01:00
Mike Blumenkrantz b67be2ee25 add error messages to ximage function failures 2013-07-15 05:19:23 +01:00
Chris Michael 207ad636fe Avoid potential divide by zero error. 
NB: Fixes Coverity CID1039437and CID1039438

Signed-off-by: Chris Michael <cp.michael@samsung.com>
 2013-07-08 14:55:14 +01:00
Chris Michael 7bf6ba1f67 Add missing free(data) reported by jeyzu. Thanks ;) 
Signed-off-by: Chris Michael <cp.michael@samsung.com>
 2013-07-08 14:22:20 +01:00
Chris Michael f880ef9045 Remove erroneous copy/paste of data free 
Signed-off-by: Chris Michael <cp.michael@samsung.com>
 2013-07-08 14:04:29 +01:00