Commit Graph

347 Commits

Author SHA1 Message Date
Jaehyun Cho db2d711d64 [elm_widget] Enable not to add resize object to or delete resize object from sub object when the resize object is set.
Summary: Add one more argument, 'Eina_Bool sub_object' to elm_widget_resize_object_set. If the argument, 'sub_object' is set as EINA_TRUE, the new resize object is added to the sub object and the previous resize object is deleted from the sub object.

Reviewers: Hermet, seoz

CC: Jaehyun_Cho, seoz, raster

Differential Revision: https://phab.enlightenment.org/D265
2013-10-17 01:19:40 +09:00
Daniel Juyung Seo e82477ab29 elm_toolbar.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:15:58 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
ChunEon Park d461a8be05 elementary/widgets - set parents before widget constructs their body.
This avoids unnecessary multiple setups when obj and subobj has connected.
2013-08-27 14:19:19 +09:00
Daniel Juyung Seo c5b0d63838 fixed documentation for consistency. Gets -> Get.
Occurance of Get is super much higher than Gets.
So change Gets to Get for consistency.
2013-08-22 05:24:46 +09:00
Carsten Haitzler 59e8bc5a35 Fix elm to use key not keyname (so xmodmap works) 2013-07-31 15:16:41 +09:00
Shinwoo Kim c47ef1b7fe [access] use proper name _elm_access_info_get(); not _elm_access_object_get(); to get access information 2013-07-31 12:57:49 +09:00
Daniel Juyung Seo 7bbcf8a271 elm_toolbar.c: check reorder_from at the start of _items_change. reorder_from is used here and there.
this fixes dereference before null issue which was spotted by coverity. CID 1039999.
2013-07-06 12:26:59 +09:00
Hosang Kim 32affd3725 added callback call "scroll", "scroll,anim,start", "scroll,anim,stop", "scroll,drag,start", "scroll,drag,stop"
in toolar widget.
2013-07-03 13:57:17 +09:00
Daniel Juyung Seo 6cf684f02a elm: added more "focused" and "unfocused" documentations.
genlist, hover, index, list, map, photocam, progressbar, radio, scroller, slider, slideshow, spinner, toolbar, win.
2013-06-10 14:13:55 +09:00
Daniel Juyung Seo 8bfdbd2ba6 elm: all the focusable widget now emits "focused" and "unfocused" smart callbacks.
1. documentations, NEWS, and ChangeLog will be updated later after some more test.
2. need to check entry.
2013-06-07 01:13:37 +09:00
Daniel Juyung Seo 4355c54715 elm_toolbar.c: ELM_SAFE_FREE adoption.
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
2013-05-29 21:08:50 +09:00
Daniel Juyung Seo 5f053bf79a elm: refactoring. use more ELM_FREE_FUNC. 2013-05-23 15:54:49 +09:00
Hosang Kim 5eda949b8f [toolbar] fixed code for verification(ecore_job_add)
make a pair for job event, check the event is alive before adding event.
2013-05-22 16:55:23 +09:00
Daniel Juyung Seo ac25946a19 elm: introduce ELM_FREE_FUNC for code quality enhancement.
There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.

This is not all. I will work on enhancing elementary more and more.
2013-05-22 02:24:02 +09:00
Carsten Haitzler df9f486bdb toolbar needs to be able to adjust better to layout
as part of 1.8 review... elm toolbar really should add some signals so
theme can adjust better.
2013-05-10 16:53:34 +09:00
Cedric Bail c929b33052 elementary: properly sanitize headers order. 2013-05-03 16:07:06 +09:00
Daniel Zaoui 187d6bf8de Elementary: replace eo_data_get for objects data referencing. 2013-05-01 11:04:09 +03:00
Daniel Juyung Seo 7edc0d056e elm_toolbar.c: refactoring. reuse api return value. 2013-04-30 00:50:35 +09:00
ChunEon Park 8e85586ebe elementary/toolbar - fix toolbar item clip problem on reordering items. 2013-04-29 18:35:32 +09:00
ChunEon Park ff10726141 elementary/ctxpopup, hoversel, naviframe, multibuttonentry, popup, diskselector, list, menu, segment_control, toolbar - support widget item language change 2013-04-23 20:30:15 +09:00
Jaehwan Kim cb86345c1d Scroll to highlighted item in toolbar. This is related to ed93aa20588633d36bfcdf6e3b093923be65f4d8. 2013-04-16 21:06:11 +09:00
Jaehwan Kim 633be421a5 [Toolbar] Add the feature for key events. 2013-04-15 14:34:15 +09:00
Daniel Juyung Seo ba4dbce9d9 elm: enhance eina_list_free usages. use EINA_LIST_FREE if needed. 2013-04-10 20:28:35 +09:00
Daniel Juyung Seo 74b3eed5fd elm: print the error message inside elm_widget_sub_object_add().
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
   Elm devs should fix it beforehand.
   So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
2013-04-03 11:28:53 +09:00
Jaehwan Kim 9636ed621c Remove warning in toolbar 2013-03-21 15:14:23 +09:00
Cedric BAIL 47e280d21b toolbar: fix icon size not being initalized. 2013-03-20 11:57:22 +09:00
Tom Hacohen d75cb616da Change usage of eo_do_super to the new prototype. 2013-03-18 16:15:12 +00:00
Daniel Willmann c9534bab25 toolbar: Use snprintf for elm,number,item buffer handling
Avoid potential buffer overflow

Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
2013-03-18 12:13:50 +00:00
Jaehwan Kim e9313c9525 Fix the toolbar cannot be unselected when it's mode is ELM_OBJECT_SELECT_MODE_ALWAYS. 2013-03-08 17:21:38 +09:00
Shinwoo Kim ea9fe742a0 [access][toolbar] use proper access activate callback 2013-03-07 21:33:26 +09:00
Jaehwan Kim 8ed79613c5 Add edje_object_message_signal_process before edje_object_size_min_restricted_calc.
If the min size is changed by edje signal in edc, the the function should be called before the calculation.

This commit is related to 40dc2a25c72103c3b01620830e1bde964f96b2fa
2013-03-05 16:47:07 +09:00
Jaehwan Kim 621775dad2 Revert this commit to fix the problem by the other method.
Revert "Small bug. In some case, the box cannot be proper size."

This reverts commit ca95166f9a8cb7db8c1557d75f444d76772b2176.
2013-03-05 16:27:44 +09:00
Jaehwan Kim 962b965563 Typo. Sync a variable name with others 2013-03-05 14:49:29 +09:00
Gustavo Lima Chaves 312d0217a0 An internal layout error, on a widget set, is a CRITICAL error. 2013-03-01 23:04:31 -03:00
ChunEon Park 844b5805ff elementary/widget - don't handle tthe resize objects in widget infrastructure. Acutally these resize objects are sub objects so we don't need to care them separately. This caused overhead in some cases(ie, theme change)
SVN revision: 83990
2013-02-16 13:39:59 +00:00
Jaehwan Kim 2a4a111289 Add the reorder effect in Toolbar.
SVN revision: 83936
2013-02-15 05:37:53 +00:00
Daniel Zaoui cdd1eea853 Replace supported_types
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 83803
2013-02-10 07:52:31 +00:00
Daniel Juyung Seo ffa9c1e793 elm: Refactoring.
Smart data is already initialized so we do not need to re-initialize them if the value equals to 0, NULL, or EINA_FALSE.
Sometimes re-initializing smart data explicitly is needed for readability. So there are left overs.

SVN revision: 82228
2013-01-04 19:10:19 +00:00
Shinwoo Kim 88dac18cf7 [access] export elm_access_activate_cb_set(); and add related documentation.
SVN revision: 82052
2013-01-03 09:31:33 +00:00
Shinwoo Kim f10fb3e115 [access] export some APIs,and remove unnecessary lines.
+ elm_access_object_register();
  + elm_access_object_unregister();
  + elm_access_text_set();
  + elm_access_text_get();
  + elm_access_cb_set();

These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();


SVN revision: 81659
2012-12-23 14:50:56 +00:00
Stefan Schmidt 193e83033e elm/toolbar: Fix NULL dereference waiting to happen.
The macro returns NULL if it->prev is not valid. So we better check if prev is
not NULL before accessing it.

SVN revision: 81144
2012-12-17 14:12:49 +00:00
Daniel Juyung Seo e8152fd7c3 elm: refactoring. on_deletion -> delete_me.
1. delete_me was already there before on_deletion was used.
2. delete_me and on_deletion are same.
3. evas also has delete_me so use the same name.
4. i didn't change naviframe because it has different on_deletion usages from other widgets.

SVN revision: 80528
2012-12-08 18:17:04 +00:00
Jaehwan Kim ca6994b182 Small bug. In some case, the box cannot be proper size.
SVN revision: 80412
2012-12-07 06:57:16 +00:00
Jaehwan Kim b5c0606180 Remove the warning in toolbar
SVN revision: 80012
2012-12-03 07:12:38 +00:00
Jaehwan Kim af28727f14 Fix 0 division
SVN revision: 80011
2012-12-03 07:01:22 +00:00
Jaehwan Kim db9aec704d When the toolbar is deleted, there's no need to pass the selection to next item.
SVN revision: 80008
2012-12-03 06:52:03 +00:00
Yakov Goldberg 5c98343198 We have ported to Eo all the widgets of elementary. We didn't change the inheritance itself, only the mechanism, as done previously in Evas, Ecore and Edje. We removed totally the previous inheritance mechanism.
Signed-off-by: Yakov Goldberg <yakov.g@samsung.com>
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 79668
2012-11-26 06:32:53 +00:00
Jaehwan Kim add19e4e4f Change the parameter of the elm_toolbar_item_show/bring_in. Add the scroll type.
SVN revision: 79333
2012-11-15 10:27:46 +00:00
Daniel Juyung Seo 06e4578483 elm elm_toolbar.c: Use correct callback function.
SVN revision: 79286
2012-11-14 10:49:59 +00:00
Jaehwan Kim 7d98e7db8d Support the theme change about "base" in Toolbar.
SVN revision: 79270
2012-11-14 08:18:02 +00:00
Jaehwan Kim af3ceeccfd When toolbar is expand mode and scrolled, it's scrolled as a item.
SVN revision: 79265
2012-11-14 05:55:43 +00:00
Shinwoo Kim 2c018f252e [toolbar] enhance access feature - add smart_activate() to access object
*note: the toolbar item which has menu would need access feature of menu.


SVN revision: 79262
2012-11-14 04:08:25 +00:00
Jaehwan Kim 7cfe5d503e Add elm_toolbar_item_show/bring_in. It show or bring a specific item, when the toolbar can be scrolled.
SVN revision: 79134
2012-11-12 07:29:17 +00:00
Shinwoo Kim a19e32528f dear all, hello.
i would like to add access enhancement to the toolbar.
please review the attached. if there are no objections, I will commit it. 

cordially,
shinwoo kim. 


SVN revision: 78995
2012-11-08 09:20:37 +00:00
Daniel Juyung Seo 71d832404a elm access: Create access object only when access mode is enabled.
SVN revision: 78992
2012-11-08 08:02:12 +00:00
Shinwoo Kim 8ef6ac7f41 [toolbar] temporary smart_event() has blocked event propagation
SVN revision: 78354
2012-10-23 06:07:30 +00:00
Jaehwan Kim 45622bb3fa When the theme is changed, the min value should be set the min of edc newly.
SVN revision: 78162
2012-10-18 08:47:41 +00:00
Jaehwan Kim 0487a76057 Add the fitting the size of items according the viewport size.
If the sum of item's min is larger than the viewport size in ELM_TOOLBAR_SHRINK_EXPAND mode,
it can be scroll. And the end of the item is fitted on the end of the viewport.


SVN revision: 78156
2012-10-18 07:57:13 +00:00
Jaehwan Kim f3f96e6b7e No need code.
SVN revision: 78033
2012-10-16 05:29:24 +00:00
Kim Shinwoo 0dc4ef5aef From: Kim Shinwoo <kimcinoo.efl@gmail.com>
Subject: [E-devel] [patch][elementary] toolbar - highlighting item on
access

the current toolbar does not show highlight effect on accessibility mode.
the attached would give the highlight to toolbar item.
please review the patch and give feedback. thanks.



SVN revision: 77972
2012-10-15 05:47:02 +00:00
Cedric BAIL 4e92316193 elementary: Simplifies code and removes redundant duplicated code.
Patch by Igor Murzov <e-mail@date.by>


SVN revision: 77396
2012-10-04 02:43:57 +00:00
Jaehwan Kim 01691d9e7d fix indentation
SVN revision: 77177
2012-09-28 04:23:29 +00:00
Jaehwan Kim 052588f9d7 Add the toolbar API which expand the transverse length
SVN revision: 77107
2012-09-27 03:05:50 +00:00
Jaehwan Kim e7b533d11d Add reorder mode set/get API in Toolbar.
SVN revision: 76841
2012-09-19 05:23:22 +00:00
Jaehwan Kim 30c479371f The hidden signal is emitted when the icon or text is hidden.
SVN revision: 76488
2012-09-12 05:30:35 +00:00
Jaehwan Kim 4613933a34 When the number of item is changed, the toolbar emits the signal to theme.
The theme can be changed something according the number of item.



SVN revision: 76487
2012-09-12 05:15:43 +00:00
Jaehwan Kim 5211f692dd Toolbar items support to set/get the generic text.
SVN revision: 76270
2012-09-07 04:33:45 +00:00
Christopher Michael 0fce46076e Elementary: Revert all framespace changes.
NB: This means elm will be broken in wayland for a while while I sort
out what went wrong in evas.



SVN revision: 76173
2012-09-05 07:42:57 +00:00
Christopher Michael 58643b42bf Elm: Fix toolbar widget to account for framespace. Fixes ticket 1418
where the 'more' button was showing the popup incorrectly.



SVN revision: 76116
2012-09-04 09:42:27 +00:00
Gustavo Lima Chaves c0d48e6035 [elm] Toolbar ported.
SVN revision: 75889
2012-08-30 16:45:00 +00:00
Carsten Haitzler a4175ba928 fix toolbar icon size property to actually work as expected.
fix toolbar select cb to only be callled if select always is on or
item WAS unselected before (as per docs).



SVN revision: 75512
2012-08-22 03:11:23 +00:00
Carsten Haitzler fee7a0c645 fix another elm bug where arrows are not "clickable" for scrolling to
next/prev item - needed to add a feature to scrolelr (and accidentally
also to scrolled interface too :)) to make this work. now works.



SVN revision: 74969
2012-08-07 10:20:30 +00:00
Carsten Haitzler f8a6c01a79 formatting improvements.
SVN revision: 74958
2012-08-07 06:02:31 +00:00
Carsten Haitzler e33501260f fix toolbar srhink problem with a policy chnage. u cant have
homogenous and shrink menu or expand or hide. :)



SVN revision: 74929
2012-08-06 12:17:02 +00:00
WooHyun Jung 0cc6390e32 elementary/elm_toolbar : Toolbar didn't get key_down event because
there was no evas focus. And add event_hook for JaeHwan :)


SVN revision: 74411
2012-07-26 04:36:12 +00:00
Jaehwan Kim 634b9dc80e The label should be inserted and the visible signal should be emitted, only when the text exists.
SVN revision: 74304
2012-07-23 01:59:41 +00:00
ChunEon Park df36c3afa2 elementary/toolbar -- removed white space
SVN revision: 73598
2012-07-12 06:19:16 +00:00
Jaehwan Kim 1231092691 The more panel should be changed when the theme is changed.
SVN revision: 73483
2012-07-09 05:22:25 +00:00
Jaehwan Kim 445926adf9 The visible signal should be called when it is reloaded in _theme_hook_item.
SVN revision: 73482
2012-07-09 05:11:05 +00:00
Carsten Haitzler c21998e3b3 oops forgot part of previous toolbar style patch. in!
SVN revision: 73035
2012-06-29 12:28:08 +00:00
Artem Popov 281c8480ee From: Artem Popov <artem.popov@samsung.com>
Subject: [E-devel] Fwd:  [Patch] elm_toolbar add signals patch.

For new style of toolbar (align icon and text to center of item) are
necessary some signals ("elm,state,text,visible",
"elm,state,text,hidden", "elm,state,icon,visible",
"elm,state,icon,hidden")

 New style for toolbar, where icon and text are align to center of item.



SVN revision: 73028
2012-06-29 10:03:27 +00:00
Cedric BAIL d78b70af51 elementary: use Edje to enable accessibility on TEXTBLOCK.
Patch by Kim Shinwoo <kimcinoo.efl@gmail.com>.


SVN revision: 72841
2012-06-26 05:54:45 +00:00
Jaehwan Kim cab76c1f57 Sorry, Fix build conflict.
SVN revision: 72792
2012-06-25 08:50:11 +00:00
Jaehwan Kim f4db8e4ec1 In case a user sets min-value of the item, the toolbar shouldn't set the min-value to the number which is smaller than it.
SVN revision: 72788
2012-06-25 08:33:15 +00:00
Jaehwan Kim 3f370e5148 Add the reorder feature when the more panel is shown.
After the item is long-pressed, it can be moved.


SVN revision: 72129
2012-06-14 12:59:38 +00:00
Carsten Haitzler 0babab585e bitch--
SVN revision: 72044
2012-06-12 16:31:02 +00:00
Carsten Haitzler 9e0801e8ea debug bitch--
SVN revision: 72042
2012-06-12 16:27:15 +00:00
Jaehwan Kim 564b6f13c8 Remove the APIs elm_toolbar_items_max_set/get.
Instead of them, add the APIs elm_toolbar_standard_priority_set/get.
The items which are lower than standard priority are located in more menu or panel.


SVN revision: 71777
2012-06-07 07:32:55 +00:00
Gustavo Lima Chaves bbf0a4345e [elm] And now remove deprecated calls usage (WRT
icon/image thing).



SVN revision: 71473
2012-05-28 21:50:11 +00:00
Gustavo Lima Chaves 4f8b51b1aa [elm] And here comes image, icon and photo on the
new schema.
els_icon smart object was brought to be the base of the image widget,
in the form of an image class.

An elm icon is now a elm image, with a little more on top of it.

An elm photo is a now base widget aggregating an icon.

Toolbar's internal usage of the former els_icon is now changed to
icons, instead.

Some naviframe instantiations were set to enable events during
transitions, because this code is buggy and my chages exposed the
problem. It will be fixed as soon as I get to port Naviframe.



SVN revision: 71429
2012-05-25 19:53:59 +00:00
Jaehwan Kim 034c6928ed The parent of elm_menu_add shouldn't be a edje object.
SVN revision: 71314
2012-05-22 10:33:14 +00:00
Jaehwan Kim de1be9600b Toolbar: Add the more panel feature in toolbar. When it is the ELM_TOOLBAR_SHRINK_EXPAND mode and the max item is set, the items over max number are located in more panel.
The APIs are added for this feature.(elm_toolbar_more_item_get, elm_toolbar_items_max_set/get)


SVN revision: 71297
2012-05-22 05:18:12 +00:00
Jaehwan Kim 25ee318e6d Revert the revision 71185.
SVN revision: 71225
2012-05-18 07:16:28 +00:00
Jaehwan Kim 069260423e The separator is not a real item. So it shouldn't be counted.
SVN revision: 71185
2012-05-17 01:37:50 +00:00
Jaehwan Kim cd3281329b The elm_toolbar_iteams_count have to return only the number of manually added items.
SVN revision: 71096
2012-05-15 07:00:47 +00:00
Jaehwan Kim c5fcdbb59c When the separators exist in toolbar and the toolbar shrinks by resizing window,
sometimes the only separators are shown even though the items are hidden.
So the separator's visibility is desided by it's previous item.


SVN revision: 71093
2012-05-15 06:30:17 +00:00
Carsten Haitzler 3a7b769a63 use the new escape text set to clear up issues if theme has TEXT vs
TEXTBLOCK items and handling escapes so text is consistend across elm.
fiuxes the fileselector issues kai reported.



SVN revision: 70362
2012-04-20 12:51:10 +00:00
Daniel Juyung Seo 8c17d99712 elm: Fixed formatting. Added a space after 'if/while/for'
SVN revision: 69744
2012-03-29 11:09:45 +00:00
Daniel Juyung Seo 3d15654faa elm elm_object_item: Fixed item part content set hooks.
1. delete old content object
2. check whether new content object is same as old content object
3. rename internal content set hook function
4. elm_widget_sub_object_del will be followed by evas_object_del
5. added some doxygen description.

SVN revision: 69738
2012-03-29 10:08:37 +00:00