Hi,
On behalf of Rajeev Ranjan, I am submitting the elm_cnp_helper patch.
Change Log:
Removal of DEAD_CODE (Unreachable code statement tmppath = "/tmp").
Please review it.
I'd appreciate any comments on this.
Thank you,
SVN revision: 65666
Hi,
On behalf of Rajeev Ranjan, I am submitting the elm_flip patch.
Change Log:
a. Removed unnecessary comparison and assignment from the function _state_update inside file src/bin/test_flip_page.c. The comparison test will always be failed. Hence the assignment which was unreachable is removed.
b. Removed unnecessary comparison and assignment from the function _state_update inside file src/lib/elm_flip.c. The comparison test will always be failed. Hence the assignment which was unreachable is removed.
Please review it.
I'd appreciate any comments on this.
Thank you,
SVN revision: 65664
Hi,
On behalf of Rajeev Ranjan, I am submitting the elm_genlist patch.
Change Log:
a. Dead code removal in function _sizing_eval
b. Memory leak fix in function elm_genlist_item_insert_before due to return when wd->items is NULL and in this case, memory allocated for item was not getting free.
c. Memory leak fix in function elm_genlist_item_insert_after due to return when wd->items is NULL and in this case, memory allocated for item was not getting free.
Please review it.
I'd appreciate any comments on this.
Thank you,
SVN revision: 65662
it didn't work if orient were ELM_IMAGE_ROTATE_90_CW or CCW.
and it also make seg fault if application calls elm_image_orient_set more than twice.
for 90 or 270 rotation, we need seperate memory.
(It can be algorithm without more memory, but I selected readability than memory efficiency)
Before, els icon use file name for data2.
So it make problem, if file name was removed because of obj's data_set or size_set function.
I modified els icon code using copy data function.
SVN revision: 65634
Hi Mr. Park,
Change description: [ commit message ]
Bug: Hide signal sent twice in case of prev button, next button and icon swallow areas.
Fix: Hide signal sent only once in delete callback.
Thanks & Regards
Shilpa Singh
SVN revision: 65570
CC libelementary_la-elc_multibuttonentry.lo
elc_multibuttonentry.c: In function ‘_set_vis_guidetext’:
elc_multibuttonentry.c:309:20: warning: unused variable ‘en_width’
elc_multibuttonentry.c: In function ‘_resize_button’:
elc_multibuttonentry.c:741:16: warning: unused variable ‘button_text’
elc_multibuttonentry.c: In function ‘_add_button_item’:
elc_multibuttonentry.c:772:40: warning: unused variable ‘h_btn’
elc_multibuttonentry.c: In function ‘_entry_resized_cb’:
elc_multibuttonentry.c:1064:86: warning: unused parameter ‘event_info’
elc_multibuttonentry.c: In function ‘elm_multibuttonentry_item_select’:
elc_multibuttonentry.c:1531:12: warning: suggest explicit braces to avoid ambiguous ‘else’
elc_multibuttonentry.c: In function ‘_resize_button’:
elc_multibuttonentry.c:747:37: warning: ‘padding_inner’ is used uninitialized in this function
^Cmake: *** [libelementary_la-elc_multibuttonentry.lo] Error 1
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65550
---------------------------------------------------
Dear Developers,
I added a new widget called “Multibuttonentry" which could be used as contact button in App
This widget allows a user to insert a text button.
text button is inserted by pressing the "Enter key"
If there is no space in the current row, the new button is entered in the next row. If the button is clicked, it will become focused.
And focused button can be removed by pressing the "backspace" key.
when items are added over 1 lines, if Multibuttonentry lost focus, it becase shrink mode (made it as 1 line)
Please review it's APIs and functionalities.
Thank you,
Goun
---------------------------------------------------
Widget was originally written by Hyunsil Park <hyunsil.park@samsung.com>.
It has been contributed to by the following people:
* Jihoon Kim <jihoon48.kim@samsung.com>
* WooHyun Jung <wh0705.jung@samsung.com>
* deasung.kim <deasung.kim@samsung.com>
* Myungjae Lee <mjae.lee@samsung.com>
* Goun Lee <gouni.lee@samsung.com>
* Mike McCormack <mj.mccormack@samsung.com>
* Daniel Juyung Seo <juyung.seo@samsung.com>
* Seunggyun Kim <sgyun.kim@samsung.com>
* sanghoon80.cho <sanghoon80.cho@samsung.com>
Signed-off-by: 이고은 <gouni.lee@samsung.com>
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65548
elm_win.c: In function ‘elm_win_focus_get’:
elm_win.c:2182:4: warning: ‘return’ with no value, in function returning non-void
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65527