wrong, and internally it didnt handle mime types properly. no one
really used/tested this much... because it wasnt available for use
really :). so fix up.
SVN revision: 84103
Very well spotted from Hermet. My original fix only free'ed the buffer
in the case fread failed, but apperently we we always leaked this buffer.
Make sure we free it in all cases.
SVN revision: 84087
now if applying the orientation style is failed, it tries to apply the original style. if it fails again then default theme.
also it fixed a logic error when theme changed is happened.
It will try to apply the original style if the orientation style is invalid on theme changing.
SVN revision: 84082
1. if user just hides the popup, the focus tree is broken. it is caused by elm_object_content_unset(notify);
popup calls elm_object_content_set(notify, popup); in the _on_show(); it would be terrible.
there would be a structual problem, but it is hart to figure out.
2. _elm_popup_smart_focus_direction(); calls notify's focus_direction(); and it calls popup's one again.
there is circular dependency between notify and popup.
SVN revision: 84073
let elm_wdg_orientation_set() have return value and call the elm_wdg_theme() inside.
since every widgets tend to do same task with smart_theme() when it's orient mode is changed.
SVN revision: 83981
The eina_file_stat_ls() function should be used instead of
eina_file_direct_ls() in _elm_config_profiles_list() - since it checks
for file types.
Patch by "Paulo C. A. Cavalcanti Jr" <paulo.cavalcanti@intel.com>
SVN revision: 83979
elm.panes.fixed/unfixed -> elm,panes,fixed/unfixed.
whoever added this signal should be spanked.
I left the signal emission from the code due to backward compatibility.
So there is no theme api break.
We should remove the previous one when we start EFL 2.0.
SVN revision: 83967
_elm_access_highlight_cycle sets access read_mode as EINA_TRUE
and then never set it back as EINA_FASLE,
which causes elm_widget_focus_steal not to be called when restoring focus tree.
...sorry for a lame explanation (somebody help me out!)
signed-off-by: Jaeun Choi jaeun_choi@naver.com
SVN revision: 83883
Orientation Mode is used for widgets to change it's styles or to send signals
whenever it's window degree is changed. If the orientation mode is enabled
and the widget has different looks and styles for the window degree(0, 90,
180, 270), it will apply a style that is readied for the current degree,
otherwise, it will send signals to it's own edje to change it's any states if
the style doesn't be readied.
SVN revision: 83880
Subject: Re: [e-users] 3 small corrections in elc_player
Hi,
1. remove __UNUSED__ for parameter that is used.
2. emit a "elm,player,play" signal as is done in _pause to keep the
state of pause/play buttons in sync.
3. Correct double_to_string which misses out subtracting hours to get
seconds.
SVN revision: 83855
It's the first time sending patch. haha :)
I found the simple typo.
1. At the description of list : algarism (x) ----> algorithm (o)
2. ~trunk/elementary/src/examples/ fileselector_entry_example.c
line 8 : gcc -g file selector_entry_example.c -o file selector_entry_example 'pkg-config --cflags --libs elementary' (x)
*** wrong word spacing (file selector) ***
----> gcc -g fileselector_entry_example.c -o fileselector_entry_example 'pkg-config --cflags --libs elementary' (o)
I fixed these 2 typo.
So I want you to check this patch.
SVN revision: 83707
the Eo function with id EO_BASE_SUB_ID_DBG_INFO_GET will be able to show
in Clouseau their own specific information.
Information contents handling is controlled by the class itself and
no more by Clouseau. Basic types are supported, as couple of ints,
couple of doubles, colors and lists.
Signed-off-by: Aharon Hillel <a.hillel@samsung.com>
SVN revision: 83411
Hi all,
All tween modes are added and you can set the interp.
ELM_TRANSIT_TWEEN_MODE_ACCELERATE_FACTOR
ELM_TRANSIT_TWEEN_MODE_DECELERATE_FACTOR
ELM_TRANSIT_TWEEN_MODE_SINUSOIDAL_FACTOR
ELM_TRANSIT_TWEEN_MODE_DIVISOR_INTERP
ELM_TRANSIT_TWEEN_MODE_BOUNCE
ELM_TRANSIT_TWEEN_MODE_SPRING
EAPI void elm_transit_tween_mode_factor_set(Elm_Transit *transit, double v1, double v2);
EAPI Elm_Transit_Interp *elm_transit_tween_mode_factor_get(const Elm_Transit *transit);
Thanks,
Joey
Singed-Off-By: ChanWook Jeong<jchanwook@gmail.com>
SVN revision: 83344
1. Idle enterer is deleted when ECORE_CALLBACK_CANCEL is returned.
So calling the idle enterer callback directly from the code needs more considerations.
2. Used better variable names and added more comment.
3. Diskselector needs much more love.
SVN revision: 83298
This patch replaces the ELM_EXTERNAL_MENU environment variable for
ELM_DISABLE_EXTERNAL_MENU, so that the main menu bar always attemps
connecting via D-Bus, if possible.
Patch by: Henrique Dante de Almeida <hdante@profusion.mobi>
SVN revision: 83099
With this patch, the main menu now keeps listening for the app menu
registrar all the time. Whenever it's available, it tries to register
itself. If the registrar exits, the menu switches back to local mode.
Patch by: Henrique Dante de Almeida <hdante@profusion.mobi>
SVN revision: 83098
style
The theme with double spinners is now a different style, so the user
can choice wich style he wants to use. It also removes the deprecated
flag from the elm_calendar_format_function_set() function.
SVN revision: 83095
the user would be visually impaired person or blind, so the type infomation
of genlist or list is not proper. there would be more proper type infomation.
SVN revision: 83005
Hello everyone,
There are two issues with ctxpopup:
- Memory leak: Elm_Ctxpopup_Item is used but not deleted.
- Incorrect callback function: returned object and event_info are list object and item
(should be ctxpopup object and item).
I would like to send a patch to fix above issues.
I also provide the patch for backporting.
Please review them.
Best Regards,
Thiep
Signed-Off-By: Theip Ha<thiep.ha@samsung.com>
SVN revision: 82968
The layout has two parts, one for placing a menu bar on the window and
the other for placing the actual window contents. The content part is
an Evas box with a custom layout that mimics the standard widget
placement rules inside the window (adapted from resize_objects_eval
and resize_job)
Note: a custom layout was written here, because it's not possible to
use a common stacking layout, since applications do not follow the
stacking rules (they don't use EVAS_HINT_FILL and
evas_object_size_hint_align_set). Maybe, with time, applications
could be changed to use them, so the custom layout may be removed.
Patch by: Henrique Dante de Almeida <hdante@profusion.mobi>
SVN revision: 82957
This allows slightly changing behavior of the top level menu entry widgets
for them to work as a menu bar.
Patch by: Henrique Dante de Almeida <hdante@profusion.mobi>
SVN revision: 82956
so new object would be highlighted if there is new object under the previous mouse(cursor) position.
to fix this issue, elm_access is using the mouse_event_enable flag. but it would cause a problem as
following case: 1. create input window in access module, 2. read something, 3. disable access module
this would be resolved by export api to set mouse_event_enable flag the other day.
SVN revision: 82933
Before the patch, when window of device which has elementary rotates,
the ctxpopup doesn't emit the "dismissed" signal to application.
For this reason, if an application developer wants to make an event using "dismissed" signal when device rotates,
he/she cannot do anything.
But after add evas_object_smart_callback in the function "_on_parent_resize",
this problem is resolved.
That means, whether a device is rotated or not, when ctxpopup disappears, "dismissed" signal is emitted.
So I want you to check this patch.
Thank you.
Signed-Off-By: Bora Hwang<bora1.hwang@samsung.com>
SVN revision: 82918
Subject: [E-devel] [PATCH] elm_index: removed unnecessary lines
I removed some unnecessary lines from elm_index.c
1. in _index_box_auto_fill
_index_box_clear(line 178) does nothing:
if _index_box_clear is called, it means sd->level_active[level] is
false (line 116).
if sd->level_active[level] is false, _index_box_clear returns
immediately (line 60).
2. in _on_mouse_down
3. in _on_mouse_in_access
4. in _autohide_disabled_set
Signal emit is enough.
Filling the box and displaying the box are separated jobs.
I think it's logically consistent to fill the box only when
1) elm_index_level_go is called
2) theme is changed
5. in _level_go
Always clear the box before fill the box.
SVN revision: 82864
- elm_access_object_item_register(); -> elm_object_item_access_register();
- elm_access_content_cb_set(); -> elm_access_info_cb_set(); The content would be considered as an evas object.
- elm_access_text_set(); -> elm_access_info_set();
SVN revision: 82791
Disabling frame calculation for now, because, in the code, a call
for getting the geometry might return the size with the frame
included, so adding it in the resize call would result in doubling
the frame size.
Patch by: Henrique Dante de Almeida <hdante@profusion.mobi>
SVN revision: 82643
Build was broken with the following message:
elm_main.c: In function 'elm_need_e_dbus':
elm_main.c:372:4: warning: implicit declaration of function 'dlopen' [-Wimplicit-function-declaration]
elm_main.c:372:46: error: 'RTLD_LAZY' undeclared (first use in this function)
elm_main.c:372:46: note: each undeclared identifier is reported only once for each function it appears in
elm_main.c:372:58: error: 'RTLD_GLOBAL' undeclared (first use in this function)
elm_main.c:374:4: warning: implicit declaration of function 'dlsym' [-Wimplicit-function-declaration]
elm_main.c:374:14: warning: assignment makes pointer from integer without a cast [enabled by default]
elm_main.c: In function '_elm_unneed_e_dbus':
elm_main.c:387:18: warning: assignment makes pointer from integer without a cast [enabled by default]
elm_main.c:392:4: warning: implicit declaration of function 'dlclose' [-Wimplicit-function-declaration]
I wonder if this is correct for other platforms other than linux??
SVN revision: 82573
show_region_hook, but rather get it from the actual Object.
Fixes a crash that happens if someone overrides the show_region_hook
(via elm_widget call) and passes an Int or String or something else as
the data parameter.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 82571
On Sun, Jan 6, 2013 at 2:23 PM, 조재현 <jae_hyun_cho@naver.com> wrote:
Dear all,
Hello. This is Jaehyun Cho.
Now, naviframe emits state signals (e.g. show or hide) for customized text part (i.e. neither "elm.text.title" nor "elm.text.subtitle") which is going to be appended to the item's text_list.
However, if the customized text parts change the text label when the text parts are in the item's text_list, naviframe does not emit state signals for them.
To resolve this issue, I added additional case in _item_text_set_hook to handle the text part which is in the item's text_list. (elementary/src/lib/elc_naviframe.c)
Please review this.
Thank you,
Jaehyun Cho.
SVN revision: 82300
Smart data is already initialized so we do not need to re-initialize them if the value equals to 0, NULL, or EINA_FALSE.
Sometimes re-initializing smart data explicitly is needed for readability. So there are left overs.
SVN revision: 82228
now it supports slides the texts if the label area is smaller than the text width length.
deprecated - elm_label_slide_set()/get()
added - elm_label_slide_mode_set()/get()
SVN revision: 82169
Subject: [E-devel] [BUG] [ELM] [PATCH] Bug fixes for APIs
elm_gengrid_region_show/bring_in
Please review the attached patches.
Attached patch "elm_gengrid.patch" which fix the bug related to
elm_gengrid_region_show/bring_in APIs.
And patch "test_gengrid.patch" in order to test the fix.
Change Description:
1. An internal function _item_show_region() is created which does
the
calculation for item position.
2. This function is called in _calc_job() as soon as pan
object
gets its
size.
3. Test_gengrid code enhancement for testing the fix.
SVN revision: 82063
On Sun, Dec 9, 2012 at 11:11 AM, thiep ha <thiep.ha@samsung.com> wrote:
Dear All,
In elementary list, the separator is not correctly set.
I would like to send a patch to correct the list with separator.
I also add an example named "List Separator" to test it.
Please review this patch.
Best Regards,
Thiep Ha
SVN revision: 82040
Dear all,
Hello. This is Jaehyun Cho.
The current version of _item_text_set_hook sends the part signal name to edje_object_part_text_set. (elementary/src/lib/elc_naviframe.c)
To resolve this issue, I sent different arguments to edje_object_part_text_set for each case.
Please review this patch.
Thank you,
Jaehyun Cho.
Signed-Off-By: JaeHyun Cho <jae_hyun_cho@naver.com>
SVN revision: 82030
If Elementary is compiled with Efreet support, D-Bus menu will
export freedesktop icon names.
Patch by: Henrique Dante de Almeida <hdante@profusion.mobi>
SVN revision: 81809
Do some extra effort to find out a name for the menu item to send via D-Bus
Patch by: Henrique Dante de Almeida <hdante@profusion.mobi>
SVN revision: 81808
The D-Bus menu interface description requests that properties with
default values should be optimized out.
Patch by: Henrique Dante de Almeida <hdante@profusion.mobi>
SVN revision: 81807
For now, it supports only one system tray icon per application.
Each instance of ELM_OBJ_SYSTRAY_CLASS is a handler for
the same system tray item. But the API is ready to support
multiple system tray items per application.
Also, since this is a new feature, it only provides an EObject API. So,
if the old style API is still required, please do it.
Patch by: Murilo Belluzzo <murilo.belluzzo@profusion.mobi>
SVN revision: 81747
+ elm_access_object_register();
+ elm_access_object_unregister();
+ elm_access_text_set();
+ elm_access_text_get();
+ elm_access_cb_set();
These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();
SVN revision: 81659
need to run an engine compare before trying to get wayland specific
items (in this case, the ecore_evas window).
NB: Fixes ticket #1992
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 81369
On Tue, Dec 11, 2012 at 8:46 PM, SHILPA ONKAR SINGH <shilpa.singh@samsung.com> wrote:
Hi All,
Please find attached bug fix patch for Colorselector.
This patch fixes the resize issue in palette which happens when
palette item size is given more than finger size.
This patch also fixes a fixed: 1 1 warning shown in picker(New addition to colorselector).
This warning can be seen when we shift from "both mode"(palette+component) to picker
mode and back to both mode.
Change description:
elm_colorselector: Palette items resize issue when item size is more than finger size and fixed: 1 1 warning in picker
fixed.
Signed-Off by: Shilpa Singh(shilpa.singh@samsung.com)
Thanks & Regards
Shilpa Singh
SVN revision: 80937
1. delete_me was already there before on_deletion was used.
2. delete_me and on_deletion are same.
3. evas also has delete_me so use the same name.
4. i didn't change naviframe because it has different on_deletion usages from other widgets.
SVN revision: 80528
Hi All,
Please find attached bug fix patch for Naviframe.
This patch fixes crash in naviframe which happens when evas_object_del
is called immediately after item_pop.
Change description:
elc_naviframe: Crash on calling evas_object_del of naviframe immediately after item_pop fixed.
Signed-Off by: Shilpa Singh(shilpa.singh@samsung.com)
Thanks & Regards
Shilpa Singh
Signed-Off-By: Shilpa Onkar Singh<shilpa.singh@samsung.com>
SVN revision: 80442
i would like to export an API which name is elm_access_external_info_set(Evas_Object *, const char*);
this will be using by application side to set additional accessibility information.
widget could have different information which could be different in another context.
for example: there would be an entry which is for user ID, and there would be another entry which is for password.
in this case, developer would like to add additional information for each entry as below.
entry for user id reads "entry (default information), this entry is for user id (additional information)"
entry for password reads "entry, this entry is for password"
for this reason, i have attached patch. please review the patch and give feedbacks.
SVN revision: 80339
Murilo Belluzzo spotted that we're incrementing a counter on an EAPI
elm_need_*(), but the unneed version is executed automatically from
elm_shutdown(), thus only once.
SVN revision: 80257
Subject: Re: Re: Re: [E-devel] [RFC] Virtual desktop window profile
I've attached 4th patch. May the 4th be with you.
ecore patch has been merged with efl and all files are based on r80123.
Thanks & Regards,
Gwanglim
------- Original Message -------
Sender : Daniel Juyung Seo<seojuyung2@gmail.com>
Date : 2012-12-04 01:55 (GMT+09:00)
Title : Re: Re: [E-devel] [RFC] Virtual desktop window profile
It looks ok to me.
Sorry but can you re-generate the patch according to the recent ecore
merge to efl single tree?
Daniel Juyung Seo (SeoZ)
On Thu, Nov 29, 2012 at 12:29 AM, Gwanglim Lee <gl77.lee@samsung.com>
wrote:
Dear Raster and Daniel Juyung Seo,
I've attached 3rd patches and test_config according to your reviews.
These are based on r79782.
[elementary & ecore]
1. "profile,set" -> "profile,changed" - done
2. spaces after EINA_LIST_FOREACH - done
3. variable type - keep
4. author - done
5. removing deprecated marking in patch - done
6. add elm_win_available_profiles_get to test_config for the debugging
purpose - done
7. check whether a given profile is present in an available profiles.
otherwise window profile will be one of the item
in available profiles. - newly added thing to the elm_win
8. merge with EO - done. :(
Any comments would be appreciated.
SVN revision: 80215
Hi All,
Please find attached bug fix patch for Naviframe.
As hide signal was sent even before object was created, the theme did not work
properly.
Change description:
elm_naviframe: Removal of hide signals emissions before Object creation.
Signed-Off by: Shilpa Singh(shilpa.singh@samsung.com)
Thanks & Regards
Shilpa Singh
Signed-Off-By: Shilpa Onkar Singh<shilpa.singh@samsung.com>
SVN revision: 80207
Shinwoo Kim
Tom Hacohen
Carsten Haitzler
Stefan Schmidt
ChunEon Park
Jaehwan Kim
Mike Blumenkrantz
Cedric BAIL
Daniel Juyung Seo
Jihoon Kim
Arvind R
Daniel Zaoui
WooHyun Jung
Jiyoun Park
Yakov Goldberg
Mike McCormack
Aharon Hillel
U. Artie Eoff
Henrique Dante de Almeida
Bruno Dilly
Flavio Vinicius Alvares Ceolin
Jaeun Choi
Lucas De Marchi
Gustavo Sverzut Barbieri
Mike McCormack
Eduardo de Barros Lima
Christopher Michael
DUBEYPRINCE KUMAR
JaeHyun Cho
Gustavo Lima Chaves
Murilo Belluzzo
Luis Felipe Strano Moraes
Rafael Antognolli
Gwanglim Lee