Commit Graph

8383 Commits

Author SHA1 Message Date
Jaeun Choi 78accca4db elementary key binding feature implementation
Summary: This patch implements elementary key binding feature.

Test Plan: None

Reviewers: Hermet, raster

CC: seoz

Differential Revision: https://phab.enlightenment.org/D506

Conflicts:

	src/lib/elm_config.c
2014-02-28 10:47:03 +09:00
Sohyun Kim d1e7e15601 [elm_config] support color classes
Summary:
support color classes for runtime color changes.
It works like text classes and is also added in configuration files.

Reviewers: seoz, Hermet, cedric, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D541
2014-02-28 07:16:45 +09:00
Daniel Juyung Seo 770e87bcdf fileselector: added more description to is_save_set api. 2014-02-28 02:45:28 +09:00
Jihoon Kim 3011093658 entry: Add ELM_INPUT_PANEL_LAYOUT_EMOTICON 2014-02-27 14:58:36 +09:00
Daniel Juyung Seo f5750399b3 hover: Made hover itself unfocusable.
@fix

Hover itself does not get key event. It should just forward the event to
the internal objects. So make it unfocusable.
Special thanks to Woohyun Jung.
2014-02-27 11:56:50 +09:00
Daniel Juyung Seo 63e5af12df test_popup: made the focus highlight optional for the popup test. 2014-02-26 01:52:03 +09:00
Daniel Juyung Seo 168bf54520 test_popup: added more popup items for the better focus test. 2014-02-26 01:41:11 +09:00
Amitesh Singh 38ac88d9d5 list: focus highlight is handled by item theme.
Summary:
Problem: list theme (elm/list/base/default) is an alias of scroller
base theme (elm/scroller/base/default) in which focus_highlight is set to "on".
Solution: Now focus highlight in_theme is set by list item theme.

Test Plan: elementary_test->"List Focus"

Reviewers: seoz, woohyun

Reviewed By: seoz

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D572
2014-02-26 01:27:05 +09:00
Amitesh Singh ff3521ba9e list: Code refractoring of _item_focused_next()
Summary:
  # Added code to handle the case of disabled items.
  #  Code refractoring of _item_focused_next().

Test Plan: elementary_test->"list focus"

Reviewers: seoz, woohyun

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D571
2014-02-26 01:26:57 +09:00
Amitesh Singh d8ec1e5dde hoversel: Added "item,focused" and "item,unfocused" smart events for widget items.
@feature

Test Plan: elementary_test->hoversel focus

Reviewers: seoz, woohyun

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D564
2014-02-26 01:26:49 +09:00
Amitesh Singh 64370c24f3 popup: Added descriptions for the newly introduced item,focused/item,unfocused smart callbacks.
@feature

Reviewers: seoz

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D568
2014-02-26 01:26:42 +09:00
Daniel Juyung Seo 0492223206 list: Added descriptions for the newly introduced item,focused/item,unfocused smart callbacks.
@feature
2014-02-26 01:26:31 +09:00
Amitesh Singh 069a3de27d list: implemented widget item focus feature.
@feature

Summary:

  #    Added "item,focused" and "item,unfocused" smart callbacks.
  # Added elm_object_focused_item_get() in elm_widget
  # Added elm_object_item_focus_set and elm_object_item_focus_get() APIs for
  # Added one argument in existing _focus_highlight_geometry_get(...,is_next)
  This is required to find out previous and current widget item.
  # Added a elm_win function _focus_highlight_start() which starts the focus

Test Plan: elementary_test->List Focus , List Horizontal Focus

Reviewers: seoz, woohyun

Reviewers Comments: SeoZ - there are some known bugs. we will actively
fix them in a near future.

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D532
2014-02-26 01:26:22 +09:00
Amitesh Singh b22dd17eed popup: implemented widget item focus feauture.
@feature

Summary:
1. Added "item,focused" and "item,unfocused" callbacks for widget item since
  VIEW(item) is a elm layout.
2. Added sd->box into focus chain to enable the focus movement on widget items.

Test Plan: elementary_test -> popup -> "popup-center-title + items + 3 buttons"

Reviewers: seoz, woohyun

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D563
2014-02-26 01:26:02 +09:00
Daniel Juyung Seo fe9a0ec73a elm_authors.h: sync with AUTHORS. 2014-02-25 01:34:16 +09:00
Daniel Juyung Seo ff18fac8e7 list: fixed list to emit elm,state,list,single signal when there is only
one item.

This is a fix of a commit 44495f6431cdc5dbe6e8cb257cf73a69563ec67c.
2014-02-25 00:58:54 +09:00
Ryuan Choi 473b183ebf test_fileselector_entry: null check
There are warning when toggled folder after pressing "api state" which clear icon.
2014-02-24 23:53:45 +09:00
Yakov Goldberg f863057d21 menu: add NULL checks to elm_obj_menu_item_add()
Function returns newly created item through last param
   Elm_Object_Item**. Add checks to make possible to pass NULL,
   if return is not needed.
2014-02-24 14:25:37 +02:00
Andy Williams 6e71ec05f7 Revert "oops, a mistake in T966 fix that could cause a segv"
This reverts commit b7d1cb531d1e196dee5f93dd4457e68df2692ed3.
2014-02-22 12:40:20 +00:00
Thiep Ha 8f92069a63 [Elm_Entry] Fix bug: magnifier position is incorrect when mouse down on selection handler
Summary:
Magnifier is displayed incorrectly when mouse down on selection handler

Reproduce way: Right click on entry (eg Entry), choose Select, select some text, press left mouse
on selection handler (do not move the mouse), take a look at magnifier position.
Reason: Magnifier position is set to mouse down position in entry.
Fix: Check mouse down status and place correct position for magnifier.

Reviewers: seoz, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D573
2014-02-22 12:06:31 +09:00
Daniel Juyung Seo aba69c4c5f elm_authors.h: Sync with AUTHORS. 2014-02-22 11:36:55 +09:00
Daniel Juyung Seo 05998a7730 tooltip: Fixed wrong API names. elm_tooltip -> elm_object_tooltip.
This was added in 1.9, so it should be changed before 1.9 release.
Thank god I found this out just right before the release.
2014-02-22 05:22:35 +09:00
Sung W. Park e10f506d51 elementary_test glview: fixed segv on close
It was deleting gldata object twice upon closing the program.
2014-02-22 03:17:06 +09:00
Gustavo Lima Chaves c80868da12 Elm list, like genlist, should emit 1st/middle/last signals to its items.
So that one is able to theme these cases accordingly.
2014-02-20 14:10:10 -03:00
ChunEon Park 577d29a484 transit - fix the double free obj_data case.
if the object is added twice to the one transit,
the obj_remove_cb would be called twice.

in this case it will try to access the freed obj_data and crashed up.

now it's fixed.
2014-02-20 23:51:38 +09:00
ChunEon Park 390d70d95b tooltip - renamed the new tooltip apis until 1.9 release.
Before
elm_tooltip_move_lock_set()
elm_tooltip_move_lock_get()

After
elm_tooltip_move_freeze_push()
elm_tooltip_move_freeze_pop()
elm_tooltip_move_freeze_get()

we're likely to use the freeze rather than lock among the entire apis.
it's already discussed in the mailing list.
2014-02-20 20:49:01 +09:00
Yakov Goldberg d95f67d9c9 widget: remove OP_ID ELM_WIDGET_SUB_ID_DISPLAY_MODE_GET
elm_widget_display_mode_get() was removed in
   2aca940f040df01364301fe7b024be1f6d89a9d6.
   So OP_ID is not needed.
2014-02-20 09:56:26 +02:00
Andy Williams a5f38fe810 oops, a mistake in T966 fix that could cause a segv 2014-02-19 18:32:58 +00:00
Andy Williams 72191ab692 Fix T966, sort order of child folders.
Comparison was being incorrectly applied for child elements - they need to be treated differently if there are no siblings
2014-02-19 10:30:50 +00:00
Carsten Haitzler 9b23d6e02b calendar - fix unstable calc complaint
thios fixes T951
2014-02-19 19:25:32 +09:00
Bora Hwang 30e14a3a65 spinner: it has to be recalculated when its style is changed
Summary:
when style is set to be different one, spinner didn't update its min size.
So there was an issue that spinner has wrong position since it wasnt' check the updated size

Reviewers: Hermet, seoz

Reviewed By: seoz

CC: raster, cedric

Differential Revision: https://phab.enlightenment.org/D569
2014-02-19 14:02:44 +09:00
Daniel Juyung Seo bb9c784880 genlist: Added a small description 'Generic list' like gengrid does. 2014-02-19 13:45:27 +09:00
Thiep Ha 771887df2b [Dnd] Fix double text insert issue in elm_entry, drop at disable, non-editable entry
Summary:
Issue 1: If you drop text to elm_entry, text is inserted twice.
Reason: Drop callbacks are registered multiple times in elm_entry.
Resolve: Register only one drop callback at entry side.

Issue 2: Even thought entry is disabled, non-editable, you still can drop text, image file. (Example, run Entry Scrolled and drop text, image file to disabled or non-editable entries).
Reason: Drop callback are registered but not remove when entry is set to disabled, non-editable mode.
Resolve: Correct registering and removing drop callbacks in entry.

Reviewers: JackDanielZ, raster

Reviewed By: raster

CC: woohyun

Differential Revision: https://phab.enlightenment.org/D565
2014-02-19 12:25:08 +09:00
Yakov Goldberg 8a312631e6 app, atspi: add comments for Eo API
Add minimum comments for Eo API to make Eolian correctly
   process methods and parameter directions
   There are still exist not/half implemented functions, for which
   I didn't add comments.
2014-02-18 18:12:40 +02:00
Yakov Goldberg f40c6044a7 interface scrollable: fix doxygen 2014-02-18 16:27:52 +02:00
Yakov Goldberg 0d8777306a slider: fix doxygen 2014-02-18 16:27:52 +02:00
Yakov Goldberg 6345941ef3 elm widget container: fix doxygen 2014-02-18 16:27:52 +02:00
Yakov Goldberg 549e8cf8f0 elm atspi: add comments for Eo API
add minimum comments for Eo API to make Eolian correctly
    process methods and parameter directions
2014-02-18 16:27:52 +02:00
Yakov Goldberg 8a3e75f6c2 fileselector interface: fix doxygen 2014-02-18 14:57:33 +02:00
Carsten Haitzler a4cbdd7c39 fix more complaints on inwin shutdown and focus stuff
this fixes the rest of T958
2014-02-18 16:15:55 +09:00
Carsten Haitzler 7201bf91ff elm win - on shutdown some objects become null during shutdown so be quiet
so don't complain so much about it - it's normal. don't use the noisy
macros to do so. this fixes much of T958
2014-02-18 15:58:57 +09:00
Thiep Ha ae8c65f968 [DnD] Fix bug of hard-coded type when drag
Summary:
When we start dragging, the type is always set to "text/uri-list" no matter the format type set by application.
This patch fixs this hard-coded type issue. It will set types corresponding to the format type set by application.
For example, if application set format as ELM_SEL_FORMAT_TEXT, it will set types UTF8_STRING, STRING, COMPOUND_TEXT, TEXT,
text/plain, text/plain;charset=utf-8.

Reviewers: JackDanielZ, raster

Reviewed By: raster

CC: woohyun, seoz

Differential Revision: https://phab.enlightenment.org/D546
2014-02-18 15:47:08 +09:00
Daniel Juyung Seo 68a8e25672 test_list: Disabled 'focus on selection' as it is turned off by default.
- This can be enabled by checking the check buttons.
- Switches 'focus on selection' and 'focus animation' check buttons.
2014-02-18 03:49:19 +09:00
Yakov Goldberg be9053f343 fileselector interface: fix doxygen 2014-02-17 18:02:19 +02:00
Daniel Hirt 6248f9c0fa els_cursor: Fix mouse_out changing cursor to wrong image
Summary:
Fixes a bug when having a mouse_out event from elm objects that had a cursor set to them.
For example, Entry has a specific cursor set to it.
The bug is observable in Entry Test, and in any other test that has anchors (markup) in the entry widget.
Just take your mouse in an anchor, and out of it, to see that the entry now has the wrong cursor.

The old way of handling this asssumed that the triggering object had an elm-parent.
However, this is not the case for anchors.
Instead, it was agreed that the simplest way was to determine if there is any elm object,
with a cursor set to it, under the current mouse position.
If one is found, then use the cursor assigned to it.
Fixes T878.

Reviewers: tasn, raster

CC: raster, JackDanielZ

Maniphest Tasks: T878

Differential Revision: https://phab.enlightenment.org/D551
2014-02-17 21:34:59 +09:00
Ryuan Choi 7c4288548b colorselector: Do not add custom palette color to the palette of config
Summary:
elm_colorselector_palette_color_add() clears the palette if config_load is true.
It means that this API will add paletter color only for this colorselector object.

Fixes T786

Test Plan: Added elm_colorselector_palette.

Reviewers: seoz, raster

Maniphest Tasks: T786

Differential Revision: https://phab.enlightenment.org/D557
2014-02-17 21:26:14 +09:00
Jaehyun Cho bd7c5cbbff naviframe: Fix elm_naviframe_item_pop_to not to attempt to remove removed item
Summary:
Previously, the following error message is shown.
         eina_inlist_remove() safety check failed: item does not appear to be part of an inlist!
         Now, eina_inlist_remove() is removed from elm_naviframe_item_pop_to
         because eina_inlist_remove() is called in _item_del_pre_hook.

Reviewers: seoz, raster

Reviewed By: raster

CC: Hermet

Differential Revision: https://phab.enlightenment.org/D553
2014-02-17 21:09:53 +09:00
Jaehyun Cho 934113bc20 naviframe: Fix to set only top view to be focusable
Summary:
Previously, all views were focusable except during transition.
         Now, only top view is focusable.

Reviewers: seoz

CC: Hermet

Differential Revision: https://phab.enlightenment.org/D554
2014-02-17 21:03:01 +09:00
Jaeun Choi 0e6364aeef elm_index: disable indicator when the selected item is unselected
Summary:
in current code, indicator is disabled only when mouse up event happens.
if the selected item is unselected through API before mouse up,
the indicator will remain active while no item is selected (highlighted).

Test Plan: None

Reviewers: Hermet, seoz, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D560
2014-02-17 20:24:18 +09:00
Carsten Haitzler 4053da6f6f more thread example fixes
this should cover fixes for T956
2014-02-17 17:08:18 +09:00