Summary:
An application starts before the indicator has. In this case,
the application should try to connect again with the indicator.
Test Plan:
1. Start an application without the indicator service.
2. Start the indicator service.
Reviewers: raster, Hermet, woohyun, jaehwan, cedric
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3258
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When the window is in background, for associated conformant, indicator must not update the plug information.
To fix this issue, On window goes to background, the associated plug handled by confromant is deleted.
Test Plan:
On any device (like handset) which should have indicator support, this scenario can be reproduce. I tested on a handset
with gdb attach to running process having window and confromant with indicator support.
Reviewers: raster, Hermet, cedric
Reviewed By: cedric
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D3177
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Set the display mode to none only when both clipboard and keypad is
hidden.
Signed-Off By: Shashank Pandey <shashank.p@samsung.com>
Signed-Off By: Shilpa Singh <shilpa.singh@samsung.com>
@fix
Test Plan: Keypad opened, Clipboard opened, close clipboard
Reviewers: woohyun, CHAN, Hermet
Reviewed By: Hermet
Subscribers: CHAN, Jaehyun, shashank0990
Differential Revision: https://phab.enlightenment.org/D2968
When the conformant is removed, elm_widget_sub_object_del is called
before calling _elm_conformant_evas_object_smart_del.
Because parent-child relation about window-conformant is unrelated,
there's no meaning elm_widget_top_get in
_elm_conformant_evas_object_smart_del.
@fix
Summary:
The strcmp(line 738) has been failed since the eo applied.
the widget type get API returned "Elm_Genlist" now.
For fix it, using eo_isa() to check object types instead of string comparison.
@fix
Reviewers: seoz, woohyun, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2148
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.
Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
(if someone decides to use beta APIs).
Test Plan: out-off tree build with gcc, g++
Reviewers: tasn
Reviewed By: tasn
Subscribers: seoz, q66, kuuko
Maniphest Tasks: T1721
Differential Revision: https://phab.enlightenment.org/D1528
MAX and MIN are defined in a couple of places and they was already
defined in elm_priv.h. So use elm_priv.h's one.
I also moved CEIL to elm_priv.h that can be used in another places.
ecore_animator_del, and ecore_job_del.
As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
There are elm_widget_theme/theme_set/theme_get functions.
In Eolian these functions will be described as "theme" method and
"theme" property. There is clash here.
So add suffix "_apply" to Eo API for "elm_widget_theme".
Summary:
The geometry of elm_widget_show_region_get is only updated by elm_widget_show_region_set.
If the geometry of *show_region_get is not updated, the result of show_region_job would be incorrect.
So, we need to get a proper geometry using *focus_region_get for focused object.
Reviewers: seoz, woohyun, Hermet, raster, tasn
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D466
this makes efl ignore certain env vars for thnigs and entirely removes
user modules (that no one ever used) etc. etc. to ensure that *IF* an
app is setuid, there isn't a priv escalation path that is easy.
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
This reverts commit cbd7446f0bf413ad821ac40703d2a2ca728758ef.
Conflicts:
ChangeLog
NEWS
Please be more considerable to add this feature.
The function itself is not logical and we don't think it's proper for the conformant yet.
When the virtualkeypad size is changed, applications get the notice.
Applications can do internal object calculation according to the exact virtualkeypad size.
This is useful when the exact size is important such as webkit usecase.
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.
This is not all. I will work on enhancing elementary more and more.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
Shinwoo Kim
Prince Kumar Dubey
Shilpa Singh
Vivek Ellur
Daniel Zaoui
Jaehwan Kim
Tom Hacohen
ChunEon Park
woochan lee
Lukasz Stanislawski
Daniel Juyung Seo
Zbigniew Kosinski
Yakov Goldberg
Youngbok Shin
Carsten Haitzler
Daniel Juyung Seo
Cedric Bail
Daniel Juyung Seo
Chris Michael
Jiyoun Park