Summary: Minor defect in example program fixed.
Test Plan: gcc -g radio_example_01.c -o radio_example_01 `pkg-config --cflags --libs elementary`
Reviewers: seoz, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D363
When the offset is not bigger than 0 && abs(offset) is not smaller than dx(or dy), round up routine could have mis-calculation bug.
It should substract one value more to get a proper round up result.
For example, when x = 1440, offset = -2160, dx = 360, x should become 720 but round up routine made it 1440.
Because it was rounded up from 1080 to 1440. It should be rounded down from 1079 to 720.
Special thanks to Hosang Kim for the help.
Signed-off-by: Daniel Juyung Seo <juyung.seo@samsung.com>
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Summary:
Hello guys,
Below You can find a proof o concept for ATSPI2 support for elementary applications. Currently application can only be listed on bus by clients such as 'accersiser'. I am strongly looking for comments to this design.
Here are my comment regarding following code:
* This pach requires https://phab.enlightenment.org/D327 patch to compile
* I have decided to include whole atspi-constants header, because in fact i will need one-to-one copy of all its enums and defines. Qt has something like 3rdparty folder from which they include this header and don't require atspi dev packages at compilation time. Maybe efl needs the same solution or should just require next package in compilation? I agree that putting atspi-constant.h in main source tree is bad idea, but where? src/utils ??
Reviewers: cedric, raster, kimcinoo
Reviewed By: raster
CC: pkaczmarek-samsung, seoz, jaehwan, kimcinoo
Differential Revision: https://phab.enlightenment.org/D328
Summary: Added support for popup align set
Test Plan: elm_popup_align_set, elm_popup_align_get, elementary_test -to popup
Reviewers: seoz, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D321
Scrollto positions are divided 4 type
NONE : do not scrollto.
TOP : scrollto position is always top viewport.
MIDDLE : scrollto position is always middle of viewport.
IN : scrollto position to fully visible in viewport.
Summary: Changes in the _item_realize to decorate the item T576 test_genlist10
Reviewers: seoz, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D358
If we're walking an item and it's deleted, the memory won't go away
immediately in _item_del_pre_hook() as would in _item_del(), then it's
not enough to remove ourselves from the reverse-relative list of the
item we were relative to, we also need to clean our own relative
pointer so we won't touch it later when the item is not being walked
anymore and _item_del() is called.
I was getting this annoying error with espionage application, opening
an interface of an object and then closing the window or selecting
another bus name (whatever would call elm_genlist_clear()).
During the clear process genlist will flag the next item as "walking"
so it's not gone when the current item dies (would happen if next item
is a subitem). The item would run _item_del_pre_hook() but not
_item_del(), but on the next loop iteration the next item would be the
current, then not walking anymore and during _item_del() it would
access it->item->rel which would point to the now-dead item.
When we scroll the genlist with decorate all mode, newerly realized items looked like a normal mode.
This was caused by a new theme. Genlist item style should handle all the necessary parts when decorate mode is enabled/diabled.
This fixes T576.