Commit Graph

161 Commits

Author SHA1 Message Date
Amitesh Singh 0b7de4a33e hoversel: Added item_focus_set/item_focus_get.
Summary: @feature

Reviewers: seoz, Hermet, raster

Subscribers: seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2436

Conflicts:

	src/lib/elm_hoversel_item.eo
2015-05-19 21:25:39 +09:00
Shobhit b2b4f805bb hoversel: Enabled default mirroring in hoversel.
Removed default disable automatic mirroring of hoversel.

Summary:
Removed below API call for hoversel, hover, box and button object
elm_widget_mirrored_automatic_set(obj, EINA_FALSE);

Modified theme of "elm/button/base/hoversel_vertical_entry/default" to remove console errors due to theme, and modified text.align to -1 as 'x' value to set auto align for Arabic text.
Modified example hoversel_example_01.c to illustrate mirroring functionality

@fix

Reviewers: Hermet, seoz, tasn

Subscribers: sachin.dev

Differential Revision: https://phab.enlightenment.org/D1910
2015-03-04 15:54:41 +09:00
Daniel Juyung Seo fb4b67afb5 hoversel, popup, colorselector: Optimize eo item usage.
Remove unnecessary pointer reference.
2014-11-25 21:54:26 +09:00
Daniel Zaoui 7e396432ef Object Items: replace most of del_pre functions with destructor.
This change is not simple because Elementary has not been built from the
first day to work with Eo. Code had to be adapted to fit the new design.

The del_pre that have not been replaced yet can return FALSE and
prevent deletion. For these classes, code modification has to be deeper
and will be done later.
2014-11-12 12:03:58 +02:00
Daniel Zaoui 05225b162e Object Items: remove data variable from widget item.
Now, data is stored in Eo layer via eo_key_data_set/get.

Two macros have been added to facilitate access.
2014-11-12 12:03:58 +02:00
Daniel Zaoui ef03bc098e Object Items: remove legacy APIs.
They are now generated by Eolian.
2014-11-12 12:03:58 +02:00
Daniel Zaoui b01d01528a Object Items: remove casts that are no more needed.
It includes casts to Eo, Elm_Object_Item and to specific items data.
This belongs to the cleaning phase of the object items porting to Eo.
2014-11-12 12:03:57 +02:00
Daniel Zaoui 4f67061872 Elm Hoversel Item: Migrate to Eo 2014-11-12 12:03:54 +02:00
Lukasz Stanislawski 2ca1f8a75a atspi: properly include at-spi headers.
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.

Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
  (if someone decides to use beta APIs).

Test Plan: out-off tree build with gcc, g++

Reviewers: tasn

Reviewed By: tasn

Subscribers: seoz, q66, kuuko

Maniphest Tasks: T1721

Differential Revision: https://phab.enlightenment.org/D1528
2014-10-17 16:57:26 +01:00
Tom Hacohen 7629c147eb Eo related: Change according to recent changes in eo_add().
For more info check out a7560dbc61 in
the EFL tree.
2014-09-25 17:39:34 +01:00
Daniel Kolesa c159cb2ebc update according to Eolian syntax changes 2014-08-21 09:27:32 +01:00
Lukasz Stanislawski 09b9ef0bc0 atspi: expose more actions through atspi bus.
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.

Reviewers: z.kosinski

Reviewed By: z.kosinski

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1227
2014-07-25 11:58:16 +02:00
Zbigniew Kosinski 9ce23f0004 atspi:Set roles for widgets
Reviewers: stanluk, m.jagiello, raster

Differential Revision: https://phab.enlightenment.org/D930
2014-06-11 11:07:16 +09:00
Tom Hacohen efa41c7d75 Elm: Update code to use the new class names generated by eolian. 2014-06-03 11:54:44 +01:00
Amitesh Singh e6748f033a hoversel: Icon parent set to button.
Summary: This is an optimization over parent set to hoversel object.

Reviewers: seoz, raster

CC: seoz

Differential Revision: https://phab.enlightenment.org/D853
2014-05-15 12:09:33 +09:00
Amitesh Singh d7e56fb837 hoversel: item-loop should happen on UP/DOWN Key in case of vertical hoversel and on LEFT/RIGHT Key in case of horizontal hoversel.
Summary:
Earlier focus was moving to top item from bottom item on LEFT key and to bottom item on RIGHT Key
in case of vertical hoversel.
@fix

Test Plan: elementary_test -to "Hoversel Focus"

Reviewers: raster, seoz

Reviewed By: seoz

CC: seoz, chinmaya061

Differential Revision: https://phab.enlightenment.org/D858
2014-05-14 21:50:31 +09:00
Daniel Zaoui 1303a6dbec Eolian: fix names for elc widgets.
Even if the file names are elc_..., the class names are supposed to be
elm_...
2014-04-22 16:39:35 +03:00
ChunEon Park 5ab6a7739f widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.

conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
Jaeun Choi e6d6066581 hoversel: apply key binding
Summary: This patch applied key bindiing to elc_hoversel.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D729
2014-04-15 14:40:38 +09:00
Tom Hacohen 4a3a802a5d hoversel: Adjusted to Eo2. 2014-04-10 09:34:59 +01:00
Daniel Zaoui c48c2e2608 Eolian: Integration of Hoversel 2014-03-23 14:17:38 +02:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
Daniel Juyung Seo 1a29ad5679 elm: removing trailing white space ceremony for 1.9 release. 2014-03-02 00:52:26 +09:00
Amitesh Singh d8ec1e5dde hoversel: Added "item,focused" and "item,unfocused" smart events for widget items.
@feature

Test Plan: elementary_test->hoversel focus

Reviewers: seoz, woohyun

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D564
2014-02-26 01:26:49 +09:00
Jaehwan Kim db23689614 access: Add smart signal "access,changed"
It occurs that access mode is changed.
Application can add this callback for each widget.
2014-02-08 14:05:14 +09:00
Daniel Juyung Seo 18f5c6b19c hoversel: Removed unnecessary null check for elm_object apis. 2014-02-03 14:58:08 +09:00
ChunEon Park f8d00ae0f2 elementary - override widget translation but work also the base widget's behavior.
Some widgets override the widget translation but it didn't inherit the base widget's function.
Becuase of it,The language changed won't be properly called in the widget tree.

Now it fixed it.
2014-01-23 20:20:43 +09:00
ChunEon Park 39ad0e358e elementary - support language changed callback from a few widgets.
support a language,changed callback if a widget has the text part in default.
2014-01-23 20:07:20 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Chinmaya Panigrahi 28a9e53e08 [Hoversel]: Added NULL check
Summary: Added NULL check

Test Plan: elementary_test -to hoversel

Reviewers: seoz, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D427
2013-12-31 13:12:20 +09:00
ami 02edf1abdb [hoversel] - Added evas smart signal "expanded" in hoversel. This patch depends on D373.
Test Plan: elementary_test -to Hoversel, Click on "Custom Item Style".

Reviewers: seoz, raster, cedric

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D381
2013-12-28 17:48:11 +09:00
Chinmaya Panigrahi 5a3fea6a28 [Hoversel] Making focus cyclic for hoversel items.
Summary: Focus cyclic feature on hoversel items.

Test Plan: elementary_test -to "Hoversel Focus"

Reviewers: seoz, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D377
2013-12-28 17:21:23 +09:00
ami afa4398ce2 [elm_object_item] - Added elm_object_item_style_set/elm_object_item_style_get().
Reviewers: seoz, raster

CC: aryarockstar, nirajkr, chinmaya061

Differential Revision: https://phab.enlightenment.org/D373
2013-12-27 20:00:04 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
ami 7dbda5f2d3 [hoversel] - Removed focus_direction since focus_cycle is applied on sd->hover.
Summary: removed focus_direction

Test Plan: elementary_test -> hoversel

Reviewers: seoz, raster

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D359
2013-11-30 15:34:55 +09:00
Tom Hacohen 28fee48f35 Hoversel: Fix access to already deleted object.
Thank you eo pointer indirection for detecting this.
The issue is a mix of design choices (will discuss on the ML) and
a bug in hoversel which was probably caused because of the confusing design
choices.
The problem is that while widget_item->view is set by whoever created
the item, it's automatically deleted by elm_widget_item_del. This means
that objects that decided to delete their views, but were too sloppy to
update the widget_item->view pointer to NULL, would trigger an attempt
to deleted an already deleted object. This does not happen in 1.7
because widget_item->view was introduced in 1.8.
The automatic view deletion is problematic, as smart subobjects are
already deleted when the parent subobject (the widget) is deleted. So
clearing the views is redundant. However if the widget item is manually
deleted, the view should be deleted. This causes this mixture of cases
that are problematic at best.

Indication error:
Error:
 ERR<5394>:eo lib/eo/eo_ptr_indirection.x:275 eo_obj_pointer_get()
    obj_id 0x8000002900000149 is not pointing to a valid object. Maybe
    it has already been freed.

This fixes T500.
2013-11-19 17:13:31 +00:00
Daniel Juyung Seo c70405bdde elc_hoversel.c: use int_ret instead of ret because ret can be null.
This fixes coverity CID 1129609 and 1129610.
2013-11-18 22:33:37 +09:00
Amitesh Singh 08936d7f38 [hoversel] - Added focus support on hoversel items.
Summary: Focus support on hoversel items.

Test Plan: elementary_test->hoversel2

Reviewers: seoz, raster, Hermet

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D316
2013-11-13 20:39:48 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Juyung Seo 07136563ea elc_hoversel: Support elm_object_item_signal_emit() in hoversel.
This works only when the item is actually created by clicking the hover button.
2013-10-14 13:56:27 +09:00
Daniel Juyung Seo 5788a3583c elc_hoversel.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:12:44 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
Daniel Juyung Seo 3e8e2b2abd hoversel: flurish hoversel source/example/documentation a little bit more.
1. fixed documentation to be more descriptive.
2. added hoversel smart callback examples.
3. added internal callback description.
2013-08-30 18:31:29 +09:00
ChunEon Park fe0f0a445e elementary/widgets - set parents before widget constructs their body.
This avoids unnecessary setups again when obj <-> sub has connected.
2013-08-27 00:29:45 +09:00
Cedric Bail c929b33052 elementary: properly sanitize headers order. 2013-05-03 16:07:06 +09:00
Daniel Zaoui 187d6bf8de Elementary: replace eo_data_get for objects data referencing. 2013-05-01 11:04:09 +03:00
ChunEon Park ff10726141 elementary/ctxpopup, hoversel, naviframe, multibuttonentry, popup, diskselector, list, menu, segment_control, toolbar - support widget item language change 2013-04-23 20:30:15 +09:00
Daniel Juyung Seo bd5246c512 elc_hoversel.c: hide hover object when hoversel is hidden. 2013-04-09 13:14:21 +09:00