Commit Graph

37 Commits

Author SHA1 Message Date
Vincent Torri 8272318d71 Eina: introduce API eina_file_path_relative() to uniformize this check 2023-12-19 12:20:42 +00:00
Elyes HAOUAS dc4fd17a9c Fix typos - (Part #5)
Fix some typos

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D12019
2020-06-25 09:03:07 +02:00
Vincent Torri d135957ffa Use __func__ C99 identifier instead of __FUNCTION__ compiler extension
Summary: see http://www.open-std.org/JTC1/SC22/wg14/www/docs/n1124.pdf section 6.4.2.2 page 52

Test Plan: compilation

Reviewers: raster, devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11785
2020-05-07 09:27:07 -04:00
Carsten Haitzler 65e9ad0b03 efreet menu - fix truncation in snprintf to have bigger buffers 2018-11-09 12:21:30 +00:00
Carsten Haitzler 80d7f0b7c1 efreet menu - only build internal cmp func if used in ifdefs 2018-11-09 12:18:59 +00:00
Alastair Poole c0b672db9c efreet_menu: remove unused and unreachable code.
Coverity doesn't like this unreachable code. This purges
efreet_menu of all unused code for the deprecated and
non-working menu_async methods. The warnings remain
at compile time and run time.
Differential Revision: https://phab.enlightenment.org/D7101
2018-09-27 10:13:50 +02:00
Alastair Poole c3d2ba07bc efreet: silent deprecated API build warnings.
Silent warnings on EFL build. Warn on API "mis-use".
2018-06-22 07:16:50 +01:00
Alastair Poole 48dc758688 efreet: make efreet_menu_async_get() deprecated.
Marking deprecated. Func will warn and instantly return on
call.
2018-06-15 10:42:54 +01:00
Alastair Poole 6baaab4b21 efreet: mark efreet_menu_async_parse() deprecated.
Marking deprecated, with warnning and instant return.
Disabling test code also (for now). Awaiting a fresh
implementation.

@fix T585
2018-06-14 19:00:22 +01:00
Vincent Torri 3b44645363 efl: add binary mode to f(re)open() calls
This allows better compatibility with Windows

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-12-05 21:04:36 +01:00
Sebastian Dransfeld b624345bbd efreet: improve messages 2014-09-29 09:39:38 +02:00
Sebastian Dransfeld 0f4f0a7e5e efreet: Fix leak on error
If we encountered an error, special hashes in internal desktop struct
wasn't free'd.
2014-09-25 09:01:12 +02:00
Carsten Haitzler 356d10fbee efreet - add menu ref/unref calls and refcounting to try solve e issue
not much more to say really... efreet_menu_free now unrefs nd checks
for 0 refcount first... unref just calls it to be "nice"

@feature
2014-07-23 20:36:19 +09:00
Jean-Philippe Andre 62e3c75777 Efreet: Fix shadow warning 2014-06-19 10:33:49 +09:00
Sebastian Dransfeld 9415f8a7ef efreet: improve handling of merged menus
If the menu is of the format ${XDG_MENU_PREFIX}applications.menu, we
want to merge applications-merged/, not
${XDG_MENU_PREFIX}applications-merged
2014-06-11 11:04:23 +02:00
Sebastian Dransfeld a10d4167f1 efreet: remove code duplication
If the menu starts with either kde- or gnome- the resulting action is
the same.
2014-06-11 11:04:23 +02:00
Sebastian Dransfeld ffda8635fe efreet: Correctly handle default merge dir
When main menu file is gnome-applications.menu or kde-applications.menu,
we should be using applications as base for merged dir.

Part of T1284
2014-06-10 13:46:49 +02:00
Carsten Haitzler e8c13118eb fix mingw build for setuid fix/checks 2014-01-08 22:06:41 +09:00
Carsten Haitzler b95ef3801f setuid safeness - ensure if an app that is setuid doesn't do bad things
this makes efl ignore certain env vars for thnigs and entirely removes
user modules (that no one ever used) etc. etc. to ensure that *IF* an
app is setuid, there isn't a priv escalation path that is easy.
2014-01-08 19:46:23 +09:00
Sebastian Dransfeld c85534af7e efreet: TODO++ 2013-11-21 09:29:25 +01:00
Sebastian Dransfeld 76721f4153 efreet: Check buffer size
CID 1039582, 1039583
2013-10-14 13:21:48 +02:00
Sebastian Dransfeld 2e4fb25922 efreet: clean up ugly internal_get function
CID: #1039186
2013-08-07 13:02:54 +02:00
Sebastian Dransfeld 75dd06bcb1 efreet: Remove dead code
CID: #1039942
2013-08-07 13:02:54 +02:00
Chris Michael 80f2498909 efreet_menu_move_free will free "move" here so remove the menu from
the parent's list Before we free the menu.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-05 13:58:13 +01:00
Chris Michael 57924e5824 Fix memleak reported by Coverity: Close the descriptor returned by
popen if we are going to error out.

NB: Fixes Coverity CID1039184

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:25:59 +01:00
Chris Michael aeb4b7f7b9 Fix memleak reported by Coverity: If we fail to allocate a new
internal menu, then free the previously allocated memory for xml file.

NB: Fixed Coverity CID 1039183

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:19:37 +01:00
Chris Michael c04cfde0e5 Fix mem leak reported by Coverity: If we fail to create a new internal
menu, then free the previously allocated xml file.

NB: Fixes Coverity CID 1039182

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:17:13 +01:00
Sebastian Dransfeld a0ba7941ad efreet: Use end cb of thread to run cb 2013-06-21 12:56:21 +02:00
Mike Blumenkrantz 51246fff68 efreet menu cbs don't return a value and take const data params 2013-06-21 09:50:03 +01:00
Sebastian Dransfeld aa8565b372 efreet: Add data to async request 2013-06-21 10:39:40 +02:00
Sebastian Dransfeld 5b3cd4cde1 efreet: Add async menu parsing 2013-06-20 11:56:46 +02:00
Sebastian Dransfeld f0ff83c3f5 efreet: Reorganize file 2013-06-20 11:56:46 +02:00
Sebastian Dransfeld e8ff0e7b68 efreet: Init efreet_menu_prefix in init
Makes efreet_menu_prefix access threadsafe
2013-06-20 11:56:46 +02:00
Sebastian Dransfeld 3190e526f4 efreet: Remove static variable 2013-06-20 11:56:46 +02:00
Sebastian Dransfeld da1b1f6649 efreet: Improve eina hash usage
eina_hash_del + eina_hash_add = eina_hash_set
2013-06-20 11:56:45 +02:00
Gustavo Sverzut Barbieri 0a2d116119 efl: eina_alloca.h to simplify alloca() usage.
having to replicate 18 lines per file just to access alloca() is
insane. Let's do that in Eina.h and avoid that crap :-/



SVN revision: 82082
2013-01-03 15:10:34 +00:00
Gustavo Sverzut Barbieri 4bc0210bd3 efl: merge efreet.
seems to be fine, pass distcheck and friends. please report.

changes:
 - documentation hierarchy fixes
 - replaced __UNUSED__ with EINA_UNUSED
 - replaced PKG_DATA_DIR with PACKAGE_DATA_DIR"/efreet"



SVN revision: 81889
2012-12-29 23:04:40 +00:00