Summary:
Fix to hide magnifier when menu is disabled
@fix
Test Plan:
1. Enable magnifier
2. Disable menu
3. Long press and mouse up
4. observe magnifier is not hidden.
Reviewers: tasn, herdsman, thiepha
Subscribers: shilpasingh
Differential Revision: https://phab.enlightenment.org/D3490
Summary:
The spinner buttons in elm_calendar widget can be replaced by elm_buttons.
Then, using elm_button widgets makes it much easier to maintain.
And the buttons has to be focusable with "tab" key just like elm_spinner widget.
The lagacy callbacks for signals from edje is not removed for backward compatibility.
@feature
Test Plan: elementary_test -> calendar, calendar2, calendar3
Reviewers: seoz, Hermet, kimcinoo, cedric, woohyun
Reviewed By: woohyun
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D3198
Summary:
Add newline filter
Using the present filter infra
a newline or paragraph separator filter
is being added for single line entry.
@fix
Test Plan:
Copy multiline text from
and paste it to single line entry.
it will fix T2660
Reviewers: herdsman, tasn
Subscribers: thiepha, DaveMDS
Maniphest Tasks: T2660
Differential Revision: https://phab.enlightenment.org/D3109
Summary:
The use of elm_widget_type_get here is pretty harmfull, for the usecase
of inheriting a widget elm_widget_type_get is something else than
before. But the key binding should still work.
@fix T2891
Reviewers: tasn
Reviewed By: tasn
Maniphest Tasks: T2891
Differential Revision: https://phab.enlightenment.org/D3470
this is handled correctly in evas. checking load errors from
the engine/loaders is sufficient, but the printed ERR messages
for these cases have been improved
partially reverts 865383aa0da5d1eb6d29f4ed5447a73f63800a33
reverts ee7d5425628942a45e23a2cb6be253db8ec0b3fd
ref 840dcc618ead292414b0de64a7a3ae38d778311f
ref a915229dc87606472480a8b2eacce9514055ac27
fix Titalia
Clean up elm_popup actions. Move actions should not be used
from accessibility API. Only dismiss seems to be resonable
action which could be triggered.
The selection is cleared by losscb when we set it.
As result, selection is not done.
To avoid it, we should check if the new selection owner
is current selection owner or not and only call losscb
if the new selection owner is not the current one.
Test Plan:
In wayland, select text in entry (e.g double click, ctrl-a).
Summary :
When genlist compressed, size width must updated after sizing eval,
but still hash is not changed after sizing eval, so wrong width are
applied.
so when sizing eval called, free all buckets to get updated width.
@fix
Summary:
previously, homogeneous was only supported for one type of items or group items,
so if user want to use various item styles with different height,
they should set homogeneous false.
This patch is increase usability of homogeneous to make possible homogeneous for
each item class, with the assumption that every item in same class have same height.
Now the item class not only define it's style and class funcitons, also define the
shape properties of item including height and width also.
@feature
Test Plan: Already exist test case in genlist group
Reviewers: raster, cedric
Differential Revision: https://phab.enlightenment.org/D3396
Summary:
Added a config variable Context_Menu_Disabled to make the appearance
of the context menu configurable.
@feature
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Reviewers: Hermet, SanghyeonLee, raster, singh.amitesh
Subscribers: stefan_schmidt, alok25, cedric, thiepha, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2463
using a job results in the resize occurring after render in the same loop,
meaning that anything which depends on resizes to happen in a certain
time will not have synchronized display vs toolkit geometries
fixes all issues related to wayland window geometries
regions have not yet been calculated during RENDER_PRE, and commit
happens during the outbuf flush, so this callback should be the latest
possible time at which window geometry can be sent
Expected behavior: when Cancel or X is pressed in Filesector
don't change entry.
Wrong behavior: entry is cleaned.
If no file was selected 'file' variable is NULL,
and elm_entry_utf8_to_markup(NULL) returns empty string.
Thus this empty string was set to entry.
@fix
Item anchors can have null items likes <item size=10x10>. That is,
there is no "href". The problem is that Elm Entry segfaults as it
expects a non-null item. I prefer this fix over passing "" from Edje
Entry, and leave the decision to be made by Elm Entry. It will now just
show the error emoticon if there is no "href".
@fix
This code is obviously wrong and could never have worked.
The parent that is being kept between iterations is being overwritten on
ever iteration, leading to the wrong result.
CID1327358.
This is again obviously wrong. This code tries to check if the type is not
one of three, what it does instead is checking if it's either not the
first two, or is the third, which is always true (because format can't
be too different values at the same time) and always wrong.
CID1327361
This example is completely broken and doesn't make much sense. Should be
overhauled and probably rewritten/dumped.
This is just to fix the more obvious errors (some pointed out by coverity).
CID1327356
high should be the last item of the array, not the length of the array.
As part of this change, I also changed the code to use the better way of
getting the array size.
CID1339827
This whole code reeks. This generating and parsing strings as a value
store is hacky and could use an overhaul.
This just fixes the more obvious possible errors (that are maybe not
even possible, just look possible).
CID1339828
CID1339829
Emit accessibility events if slider value was chagned through API.
Moreover emit accessibility event more rarely if value is being
changed by the user.
Summary:
In _item_single_select_left/right functions if logic is corrected from && to ||.
The previous thing is like: if "there is a generation mismatch" and "item is
disable" then only get the next gengrid item. This seems logically incorrect.
The suggested logic is if "there is generation mismatch" OR "item disabled" then
go for the new item. Whether we get a generation mismatch or item disable, we
should look for next item. So there should be || logic instead of && logic.
@fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Reviewers: Hermet, raster, singh.amitesh, SanghyeonLee, cedric
Subscribers: cedric, sachin.dev
Differential Revision: https://phab.enlightenment.org/D3354
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The alignment of popup can be different in each profiles.
So I added the align configuration of popup.
@feature
Reviewers: cedric, woohyun
Differential Revision: https://phab.enlightenment.org/D3357
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Even if spinner's min max values range from -ve to +ve, it wasn't possible to enter
-ve values in spinner.
@fix T2915
Test Plan:
1. Launch Elementary Test
2. Launch spinner demo
3. Tap on the editable area of first spinner
4. Enter negative value
'-' is not allowed to enter even though the min max value of spinner ranges from -5000 to +5000.
Reviewers: CHAN, cedric
Reviewed By: cedric
Maniphest Tasks: T2915
Differential Revision: https://phab.enlightenment.org/D3403
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
As Elementary handles the window border theme, we can more accurately
set ecore_wl2 window geometry from here. The window geometry is
defined as the "visible bounds" from the user's perspective, so the
values we set here should come from the theme.
@fix
ref T2919
Signed-off-by: Chris Michael <cp.michael@samsung.com>
During _elm_config_sub_shutdown we were explicitly calling
ecore_wl2_shutdown. We should only be doing this if we are actually in
a wayland environment.
@fix
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
This change will hide the cursor once there is an actual change, and
there is a difference between the selection cursors. If there is no
difference, then it is better to show the cursor again.
Summary:
Spinner on scroller case.
Scroll should be freeze when spinner button in long press state.
If not, the scolling will be started after delete longpress timer.
Like a other widgets, scroll not allowing is correct action for this.
@fix
Reviewers: jaehwan, Hermet, eagleeye, cedric
Differential Revision: https://phab.enlightenment.org/D3334
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Application set language using elm_language_set and when elm_language_set is called
language should be set to edje as well
@fix
Test Plan:
Call elm_language_set and check language should be set to
edje as well.
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3365
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Patch fixes issue when widgets could be orphaned in accessibility tree
due to overloaded accessible_children_get methods in widgets returning
Elm_Object_Items. Widgets like genlist, gengrid, list and toolbar returned
only items as its accessibility children so if some widget was attached
directly to those widgets (like ctxpopup/popup) it become orphaned
in accessibility tree.
Type API provides possibility to skip/ignore widgets in accessiblity
tree. It make sense to ignore object if it do not provide any valuable contextual
information for disabled users. Skipped objects are usually container objects
and are ommited in parent-child relationship.
@feature
The test_colorclass function (and prototype) were incorrect in that
they did not have the proper function parameters defined. This lead to
a warning when building elementary tests.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
In Elm_Cnp, a markup data preparer was missing, which resulted
in _x11_notify_handler_targets not requesting
"application/x-elementary-markup" (requested "UTF8_STRING" instead) when
trying to paste markup text from one entry to another (or itself).
Also, there was a missing handling in the selection data callback for
ELM_SEL_FORMAT_MARKUP data format.
This fixes issues like not being able to paste "item" formats to the
entry widget.
@fix
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
Summary:
The function evas_object_resize(win, 480, 800) was being called after evas_object_show(popup)
so size calculations of popup were going wrong(height was 0).
It should be called before creating popup as win is parent of popup,
This fix needs to be done only here as in other cases window is already present before creating popup
but here both are being created for exmaple purposes.
Signed-off-by: Aditya Raj <aditya1.raj@samsung.com>
Reviewers: singh.amitesh, raster
Subscribers: jpeg, tanwar.umesh07, sachin.dev
Differential Revision: https://phab.enlightenment.org/D3360
previously, mousing out of an icon during the pulse animation would
instantly stop the animation. this looks strange and is quite noticeable
when mousing through a bar
Summary:
If the entry is a single line, rather than return the cursor height,
it is better to return the height of the object.
Reviewers: herdsman, tasn
Differential Revision: https://phab.enlightenment.org/D3169
Summary:
When _elm_theme_set() failed to set given style, it sets style
as "default".
However, setting style to "default" can be unintended behavior,
so developer should have the chance to get to know fallback.
Reviewers: cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3352
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
This is for support dynamically field sequence changing case
for example
User sets datetime format as "%d/%b/%y" first.
Then change the format dynamically in runtime to "%I:%M %p"
Previous format datetime items still there.
It breaks view(object dulicated on same geometry)
@fix
Test Plan:
Run datetime sample.
Add changed callback.
Change format in changed callback function.
Check the bug state.
Reviewers: jaehwan, id213sin, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3340
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
To prevent pasted markup text in entry.
User want tags removed text when paste text into entry.
@fix
Reviewers: jaehwan, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3333
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There is no need ellipsis, space as well before "%d".
The "%d" will show the actual invisible item count.
@fix
Reviewers: jaehwan, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3332
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>