Commit Graph

30349 Commits

Author SHA1 Message Date
Jean-Philippe Andre 2cff6f1205 ecore_evas_convert: Fix useless clang warning 2015-04-21 20:11:02 +09:00
Jean-Philippe Andre 97fd661451 ETC1: Fix more clang warnings
Some of these are a bit pointless (eg. init with {0})
but at least this silences clang and helps reveal more
potentially useful warnings.
2015-04-21 20:11:02 +09:00
Jean-Philippe Andre 8fe89711ee Ethumb: Fix clang warning
Unused function.......
2015-04-21 20:11:02 +09:00
Jean-Philippe Andre 25b4846314 Evas/cserve2: Fix clang warning 2015-04-21 20:11:02 +09:00
Jean-Philippe Andre 45b15037ef Ector: Fix (probably valid) clang warning
This time it looks like this is a valid warning.
if (abs(double) <= 0.00001f) might too often be true since abs() returns
an int.
2015-04-21 20:11:02 +09:00
Jean-Philippe Andre 5bc153c6fb Ector: Fix clang warning
Invalid type used for field and implicit conversions
2015-04-21 20:11:02 +09:00
Jean-Philippe Andre 565a4da138 ETC1/2: Fix clang warnings
Unused functions.
I keep them around for reference, for whoever wants to work on
improving the encoder.

There are still some warnings. Clang is just crazy.
2015-04-21 20:11:02 +09:00
Jean-Philippe Andre 64ca10bcf6 Evas DDS: Fix clang warning
This one was almost a real catch by clang. Too bad we don't actually
support DXT3.
2015-04-21 20:11:02 +09:00
Jean-Philippe Andre 6637e7cda9 Evas filters: Fix clang warnings 2015-04-21 20:11:02 +09:00
Jean-Philippe Andre fb812c13b3 Evas render2: Fix clang warnings
More unused functions. Kept around for later debugging.
2015-04-21 20:11:01 +09:00
Jean-Philippe Andre 92a844fd36 Eolian: Fix clang warnings
Return proper type (NULL, not bool)
2015-04-21 20:11:01 +09:00
Jean-Philippe Andre 12b562482e Eina: Fix clang warnings
Use fabs for double values
2015-04-21 20:11:01 +09:00
Jean-Philippe Andre a3897562c5 Eina: Fix clang warnings
Remove unused static function
2015-04-21 20:11:01 +09:00
Jean-Philippe Andre 20dac6d27a Evas: Fix clang warning in generated shaders file
Use const char a[] instead of const char const a[].
2015-04-21 20:11:01 +09:00
Jean-Philippe Andre 63204da26a Edje: Fix compilation warnings with clang
Fixes T2343.

Thanks for the report.
2015-04-21 18:07:34 +09:00
Jean-Philippe Andre cf6646812c Edje pick: Fix use after free
Fixes CID 1267458
2015-04-21 11:11:11 +09:00
Jean-Philippe Andre a253468442 Edje: Remove non-sensical NULL check
Fixes CID 1261450
2015-04-21 11:11:11 +09:00
Carsten Haitzler 555f09009a eet - fix emile changes to not leak in eet_cipher/deciper()
coverity spotted a missing binbuf free for the in binbuf created in
CID 1288921 and CID 1288920. this fixes both of these. leak. new.
2015-04-21 11:01:54 +09:00
Carsten Haitzler efdca32fe8 ecore_x - axis events - if event struct alloc fails, free axis data
this frees the axis data coming in if struct alloc fails - should
basically never happen, but if it does we don't lose axis data as
caller asumes this data will be freed in the event

related to CID 1256115
2015-04-21 10:32:40 +09:00
Carsten Haitzler 39bbfc3030 ecore_evas extn module - fix coverity complaint
coverity is right. CID 1295139 fixed here. tmpstr_free on sometimes
uninitialized local var.
2015-04-21 10:19:28 +09:00
Chris Michael ea77578ad6 ecore-evas-extn: Use eina_mkstemp in place of mkstemp
Summary: This fixes Coverity CID1039610 'calling mkstemp without
securely setting umask first'. Since we have eina_mkstemp which
already handles creating temporary files in the proper directory,
let's use it.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-04-20 13:23:47 -04:00
Chris Michael 820eca333e emile: Fix resource leak
Summary: This fixes Coverity CID1288919 where buffer variable was
being leaked if emile failed to load the image due to corrupt file.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-04-20 13:13:55 -04:00
Chris Michael 843d4705d8 emile: Fix resource leak
Summary: This fixes Coverity CID1288918 where data_start variable was
being leaked if the rectangles did not intersect.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-04-20 13:06:41 -04:00
Chris Michael c66275c99b ecore-evas-x: Fix issue of wrong interface function pointer being set
Summary: This fixes Coverity CID1267461 where the pointer to the
interface shape_input_reset function was being assigned multiple
times. It looks like this is just a copy/paste error.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-04-20 12:58:42 -04:00
Chris Michael d5005d0efc ecore-drm: Use #if 0 to comment out unused function
Summary: It was mentioned on the mailing list to use #if 0 instead of
commenting the block. This does not change any functionality

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-04-20 12:15:13 -04:00
Chris Michael 6195910698 Revert "ecore-drm: Remove 'defined but not used' function"
This reverts commit d625167e07.

Reverting this to use #if 0 as suggested by q66
2015-04-20 12:14:27 -04:00
Chris Michael d625167e07 ecore-drm: Remove 'defined but not used' function
Summary: As we no longer require the idler to repaint outputs, comment
out the function that was defined for the idler.

NB: I left it commented (and not totally removed) just in case it is
needed for a later (undiscovered) issue

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-04-20 11:47:55 -04:00
Tom Hacohen c7999fbf42 Evas 3d mesh: remove non-implemented functions from "implements".
They are not implemented, so they should not be marked as implemented.
Eo already properly handles functions that are not implemented, this is
completely unnecessary.
2015-04-20 15:00:40 +01:00
Tom Hacohen 1807adf70b Ector: remove use of #warning directive as TODO.
There's already a fixme in code, and an error output at runtime.
As discussed on the ML, using #warning this way is bad.
2015-04-20 15:00:13 +01:00
Carsten Haitzler 7d36abad25 eio - fix crashes due to stale eio files in tracking list
so eio_eet didnt free fiels the same as the rest of eio. it thought it
was special. it thought it could just go free() it's objects (even
though they inherit the core Eio_File object type in their structs).
everyone else ended up calling eio_file_free() EXCEPT eio_eet. so the
eio_(long)_file_set() funcs ewnded up adding this eio file to the
tracking list via eio_file_register() but never unregistered because
they really liked to just do their own thing anyway...

BAD CEDRIC! SPANKING TIME

http://33.media.tumblr.com/3422c76c33c3b9b045f623ff73e0bf8d/tumblr_mhvu61N9br1rbavngo1_500.gi

so this unifies all allocation to now use a single allocator (that
also ensures all eio async io objects are zero'd out), and a SINGLE
free path, and then it all works. no more valgrind complaints on e
shutdown/restart whilst eio "things" were used before or ... maybe
still around.

this should fix T2129

so try again "git master" after this commit.

@fix
2015-04-20 21:55:24 +09:00
Stefan Schmidt b81b29eba2 release: Update NEWS and bump version for 1.14.0-beta2 release 2015-04-20 12:17:35 +02:00
Carsten Haitzler 425de99145 emotion gst1 module - remove printf
this debugging printf seems to have been left around - remove it so we
don't get unexpected noise in gst playback
2015-04-20 18:34:58 +09:00
Carsten Haitzler 6458ca32bc emotion - gst1 module - handle long standing bad map/unmap of gst buf
this fixes a pending XXX where we didnt keep the buffer mapped as long
as the evas image object pointed to the video pixel data. this fixes
this along with less over-zealous refinf to make things more obvious
(now last_buffer actualyl really matters and if it was mapped and
refed).

@fix
2015-04-20 18:34:58 +09:00
Jean-Philippe Andre 1804d460ee Evas: Fix memory leak
Fixes CID 1293000
2015-04-20 17:34:15 +09:00
Jean-Philippe Andre d766a765e3 Evas tests: Add callback_del order test 2015-04-20 16:51:00 +09:00
Jean-Philippe Andre 1dddbbd8f7 Evas: Remove callbacks in reverse order with callback_del
This function is deprecated, because del_full should be used instead.
Still, the documentation specifies in which order the callbacks should
be deleted.

Fixes T2077 (not really fixes according to the comment but fixes
according to the doc).
2015-04-20 16:41:12 +09:00
Jean-Philippe Andre 6eff3fa3f5 Evas tests: Add debug logs telling people to ignore ERR
Some of the ERR messages are expected and it's part of the
test suite to test for invalid cases (parsing stuff).
2015-04-20 16:41:12 +09:00
Jean-Philippe Andre 7dbb61b0a1 Eina tests: fix warning about pointer signedness 2015-04-20 16:36:49 +09:00
Jean-Philippe Andre c2a9dd3a31 Eina tests: suppress warnings over deprecated functions 2015-04-20 16:36:49 +09:00
Jean-Philippe Andre 6e587b5479 Evas GL_X11: Fix memory leak 2015-04-20 16:36:49 +09:00
Stefan Schmidt c650282285 bindings/eo: Only install Eo.hh once to avoid failing double install
Eo.hh is listed in both dist_installed_eocxxmainheaders_DATA and
dist_installed_eocxxheaders_DATA this leads to a situation where they file
should be installed but already exists and thus the installation fails.

00:32:27.919 /usr/bin/install: cannot create regular file '/srv/build/workspace/changely_efl_configure_xcb/destdir/include/eo-cxx-1/Eo.hh': File exists
00:32:27.923 Makefile:32620: recipe for target 'install-dist_installed_eocxxmainheadersDATA' failed
00:32:27.923 make[4]: *** [install-dist_installed_eocxxmainheadersDATA] Error

Given that it is the only item in dist_installed_eocxxmainheaders_DATA I suspect
it was but into the other rule by accident.
2015-04-20 09:12:34 +02:00
Vincent Torri d1722eb394 evil: remove unused files (evil_p*) and uneeded evil_uuid.c file (managed by mingw-w64)
Just keeping up with latest mingw-w64.
2015-04-19 09:51:41 +02:00
Cedric BAIL 880310617e eio: forgot to test when xattr tests are disable. 2015-04-19 09:50:29 +02:00
Cedric BAIL d7bad56e72 eio: this should not be visible outside of this file. 2015-04-18 18:50:27 +02:00
vivek 2e7c348aca eio: add test cases for eio xattr module.
Summary:
Added test cases for eio_file_xattr, eio_file_xattr_set and eio_file_xattr_get functions

Signed-off-by: vivek <vivek.ellur@samsung.com>

Reviewers: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2374

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-04-18 18:50:27 +02:00
Cedric BAIL 0784d5cc2a eio: reorder include to fix build on Windows. 2015-04-18 17:28:46 +02:00
Vincent Torri d94e780b18 eio: headers are part of the source code and should be handle like they are. 2015-04-18 17:28:16 +02:00
Adrien Nader 7b3332ddf4 ecore_win32: don't fail if OleInitialize() had been called before. 2015-04-18 17:24:53 +02:00
kabeer khan 963fe509ca ecore_file: less confusing documentation of ecore_file_download API
Summary: Signed-off-by: kabeer khan <kabeer.khan@samsung.com>

Reviewers: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2373

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-04-17 12:06:47 +02:00
kabeer khan 1b8aaa9e4e ecore_file: fix crashing test of ecore_file
Summary: Signed-off-by: kabeer khan <kabeer.khan@samsung.com>

Reviewers: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2372

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-04-17 12:05:23 +02:00