1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
When the scroller is resized, the signals("elm,action,scroll", "elm,edge,top" so on) shouldn't be sent,
because it's not a scroll-action. So in this case, the content_pos_set should be called without the signals.
Subject: [E-devel] [BUG] [ELM] [PATCH] Bug fixes for APIs
elm_gengrid_region_show/bring_in
Please review the attached patches.
Attached patch "elm_gengrid.patch" which fix the bug related to
elm_gengrid_region_show/bring_in APIs.
And patch "test_gengrid.patch" in order to test the fix.
Change Description:
1. An internal function _item_show_region() is created which does
the
calculation for item position.
2. This function is called in _calc_job() as soon as pan
object
gets its
size.
3. Test_gengrid code enhancement for testing the fix.
SVN revision: 82063
+ elm_access_object_register();
+ elm_access_object_unregister();
+ elm_access_text_set();
+ elm_access_text_get();
+ elm_access_cb_set();
These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();
SVN revision: 81659
On Fri, Oct 19, 2012 at 12:30 PM, Bluezery <ohpowel@gmail.com> wrote:
> Dear all,
>
> There is a bug, invalid data assign into ecore_job.
> Trivial whilte space removal is included also. it's automated in my editor :D.
>
> Please review this patch.
>
> --
> BRs,
> Kim.
SVN revision: 78221
Subject: [E-devel] [patch][elementary] * access *
Series of of pathes from kim shinwoo. looked good to me - so in they
go, finishing off some more access mode to be more complete.
SVN revision: 75415
Subject: [E-devel] [patch] elm_gengrid - add item_select_mode_set/get
apis
I made a item_select_mode_set/get in elm_gengrid.
It works like genlist_item_select_mode apis.
+EAPI void
+elm_gengrid_item_select_mode_set(Elm_Object_Item *it,
+ Elm_Object_Select_Mode mode)
+EAPI Elm_Object_Select_Mode
+elm_gengrid_item_select_mode_get(const Elm_Object_Item *it)
from this morning - left over from last night.
SVN revision: 69056
Subject: [E-devel] [patch] elm_genlist - fix typos and remove
display_only variable
I found a mistake in example. and display_only value is remained.
It's fixed some trivial errors.
SVN revision: 69000
Subject: [E-devel] [patch] elm_gengrid - add item_index_get func
I made a patch that's adding elm_gengrid_item_index_get function.
+EAPI int
+elm_gengrid_item_index_get(const Elm_Object_Item *it)
It works like elm_genlist_item_index_get()
SVN revision: 68951
Subject: [E-devel] [patch] elm_gen{list, grid} - add
no_highlight_mode_set/get
actually change it to hilight_mode/set/get with the inverse.
SVN revision: 68947
Subject: [E-devel] [patch] elm_gen{list, grid} - add elm_genlist_select_mode_set
As discussed in irc, I made a patch about unifying
always_select_mode_set and no_select_mode_set.
I'm introducing two apis in genlist (also in gengrid)
+EAPI void
+elm_genlist_select_mode_set(Evas_Object *obj,
Elm_Object_Select_Mode_Type mode)
+EAPI Elm_Object_Select_Mode_Type
+elm_genlist_select_mode_get(const Evas_Object *obj);
And added a enum in elm_general.h
+typedef enum
+{
+ ELM_OBJECT_NORMAL_SELECT = 0, /**< default select mode */
+ ELM_OBJECT_ALWAYS_SELECT, /**< always select mode */
+ ELM_OBJECT_NO_SELECT, /**< no select mode */
+
+ ELM_OBJECT_SELECT_MODE_MAX
+} Elm_Object_Select_Mode_Type;
After this is commited, i'll send a patch about examples and
edje_external.
SVN revision: 68937
Subject: [E-devel] [patch] elm_gengrid - add item class management api
(1/3)
As like genlist item class management api, I added 4 apis to
elm_gengrid.
+EAPI Elm_Gengrid_Item_Class *elm_gengrid_item_class_new(void);
+EAPI void elm_gengrid_item_class_free(Elm_Gengrid_Item_Class *itc);
+EAPI void elm_gengrid_item_class_ref(Elm_Gengrid_Item_Class *itc);
+EAPI void elm_gengrid_item_class_unref(Elm_Gengrid_Item_Class *itc);
gengrid item class is maintained by gengrid in automatic manner.
it maintains its reference count. and item_class_free api marks
"delete_me".
Unless item_class_free, item class will not be freed.
SVN revision: 68308
Jeonghyun Yoon <jh0506.yun@samsung.com>
2011/12/23 윤정현 <jh0506.yun@samsung.com>:
> Dear All.
>
> I found a bug in elm_gengrid.c
>
> Gengrid will be crashed if input “Enter” key when selected is null.
>
> I fixed code, please review this small patch.
>
> Thanks.
SVN revision: 66471
NOTE: As side fix, both genlist and gengrid now share their Widget_Data. Need
a lot more work to be clean and match our quality standard.
NOTE2: Genclear is now faster as it doesn't require to mark all item that need
to be removed, but just increase one int.
SVN revision: 65811
recent elementary api corrections.
I changed item class's 'label_get' to 'text_get'. But 'label_get' is still
supported by union structure. So 'label_get' will just give you
deprecated warnings while compiling but it's recommended to fix your
apps to 'text_get'. Sometimes when you initialize item class using
braces, you will get 'missing braces around initializer' but ignore
this. That warning will be gone after I remove 'label_get' backport. I
will remove this 'label_get' backport after I finish below
jobs.
[TODO]
1. Fix all apps in trunk.
2. Change edc "labels" to "texts" as well. I haven't done this yet.
SVN revision: 65751
deprecate all elm_gen APIs.
We will merge gengrid into genlist later and remove elm_gen.
I updated http://trac.enlightenment.org/e/wiki/ElementaryChanges
I will fix other libraries/programs in trunk soon.
SVN revision: 65700
Remove almost all of them. Remaining:
- device on _event_history_clear, elm_gesture_layer
- config has a hand of these cases.
- ctxpopup var inside macro
- segment control edje external (it's unfinished)
SVN revision: 64365
Do not limit the swallowed objects to icon. This had to be done before
elm 1.0 and now it's time to break. This will break all applications
which are using gengrid/genlist. Please fix it icon_get -> content_get.
TODO
1. fix theme as well.
2. fix documents.
SVN revision: 64344
from here, it should be trivial to continually move more and more code into elm_gen.c and reduce duplication.
ideally we should be aiming for an elm_gen_* api where you differentiate between list/grid with style or something since the apis are almost identical
SVN revision: 64245
On Tue, Oct 4, 2011 at 7:54 AM, Benjamin Drucker
<benjamin.t.drucker@alum.mit.edu> wrote:
> Right now, signals coming from the gengrid's internal edje object are
> propagated up to the gengrid object.
> This patch enables the other direction as well: you can use the
functions
>
> elm_object_signal_callback_add(grid, ...)
> elm_object_signal_callback_del(grid, ...)
>
> to signal the gengrid's internal edje object.
>
> Please review, thanks.
> -Ben
SVN revision: 63784
Subject: Re: [E-devel] [Patch] elm_gengrid reorder bug patch
I found a gengrid bug about reordering.
It sometimes happens that some gengrid item disappear when reorder item.
SVN revision: 63783
<benjamin.t.drucker@alum.mit.edu>. Thanks a lot!
On Wed, Aug 31, 2011 at 1:52 PM, Benjamin Drucker
<benjamin.t.drucker@alum.mit.edu> wrote:
> Earlier this month, there was a svn commit
> (http://trac.enlightenment.org/e/changeset/62496) which added a few
> page-related APIs to the elm scroller. These should probably also be
> added to gengrid, genlist and maybe even grid and list. Right now,
> though, I need them for gengrid. So I propose this patch, based
> entirely on the change that went in before. I've built it and I'm
> using these new gengrid APIs in my code now.
On Fri, Sep 9, 2011 at 4:45 PM, Benjamin Drucker
<benjamin.t.drucker@alum.mit.edu> wrote:
> Slowly but surely....
>
> This version of the gengrid page APIs patch has the following changes:
> 1. fixed spacing issues
> 2. add const where needed
> 3. submitted a gengrid longpressed change in a separate patch
>
> I really want to try to squeak this in the upcoming release if at all
> possible. If I have an extra space in some file, I promise I'll not do
> it again for the next patch!
>
> Thanks!!
> Ben
SVN revision: 63403
On Fri, Sep 9, 2011 at 4:18 PM, Benjamin Drucker <benjamin.t.drucker@alum.mit.edu> wrote:
> gengrid already emits "longpressed" signals, but it is not currently
> documented nor demonstrated in the examples. See the attached patch,
> please.
SVN revision: 63323
these bad boys are so big and pixelthirsty they can't be constrained by a regular canvas or window, they use OVERRIDE REDIRECT WINDOWS. not only that, they totally exceed the boundaries of what a reasonable function name length could be. 50 character function name limit? puh-leeze. these guys don't care what side of the screen they're even on so long as they get to wade into the thick of the action and block out each and every crappy non-efl application behind them. and that's when they're in good moods. you don't even want to know what happens when you piss these guys off.
SVN revision: 61735
this signal is called whenever an item receives either a double click or selection+(enter/spacebar/return)
this commit also unifies the click/enter/spacebar/etc event api for these widgets, including removing the double click signal from keypress events and removing the 'clicked' signal from double click events
SVN revision: 61720
Subject: [E-devel] [Patch] elm_gengrid reorder mode moving effect added
Dear All.
I made a patch for elm_gengrid moving effect on reorder mode.
You can see reorder moving effect when you reorder item.
Please review this patch.
... I like! in svn! :)
SVN revision: 60301
Subject: [E-devel] [Patch] elm_gengrid - added new feature : gengrid
reorder mode
I added a new feature "reorder mode" of gengrid refer to genlist
reorder mode.
After set this reorder API, if user press an item (long press), the item can
be moved another position.
Then if the user releases the item, the item will be reordered in gengrid.
SVN revision: 59892
<hj0506.yun@smasung.com>
From Jeonghyun Yun.
Hello.
I attached the patch file for calc_job bug.
I found ecore_magic_fail problem when ecore_job_del(wd->calc_job).
wd->calc_job should also to be NULL when pan_smart's cvw and cvh is 0 in
calc_job().
Please check about this patch.
Thanks.
SVN revision: 59034
Unified double-click smart callback signal name to "clicked,double".
Wrong signal name "clicked" is still there.
But this will be removed soon after fixing all codes in trunk.
SVN revision: 58293
Subject: [E-devel] [PATCH] elm_gengrid selection key patch
Unlike other widget, gengrid processes only the "Return" key for
selecting item.
This patch makes gengrid be able to process KP_Enter and space key for
selecting item.
SVN revision: 57662
Hello.
I attached the modified patch about calc_job problem.
When I tested gengrid, sometimes gengrid renderd two times in different
shape in a moment.
So I checked gengrid code, I found cause in calc_job function.
calc_job added to ecore job after elm_gengrid_item_size_set and
elm_gengrid_item_append(,prepend,insert_before,insert_after) and etc.
Sometimes pan_smart's cvw and cvh is 0 at this time.
I think, No need to calc_job when pan_smart's cvw and cvh is 0.
Please check about this patch.
Thanks.
SVN revision: 57491
I found one small bug in elm_gengrid.c
"item" is used after "free(item)" in elm_gengrid_item_del() function.
Can anybody check about this ?
SVN revision: 55841
If you try to create a new widget, you must be sure that the parent
is really an evas object.
With the previous implementation it was possible to call an _add
function for an elementary widget with any non-null pointer as parent
eventually causing crashes (like with the elm_box).
SVN revision: 55521
Subject: [E-devel] [PATCH] Some modifications for adapting
elm_longpress_timeout_get().
I made a patch for adapting elm_longpress_timeout_get() function to all
winsets, using long press event.
And I checked one warning in elm_entry.c , so I modified it.
SVN revision: 55339
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
If no item is selected, pressing up it will select the first and down
will select the last item
SVN revision: 53924
Instead of just setting the bounce property to its scroller, each widget now
first checks in the profile used whether bounce is enabled or not.
SVN revision: 53730
Now alignment works no matter whether the item is smaller than the grid or not.
Also added a spinner to Gengrid 2 test so we can see the alignment in action
for different item sizes.
SVN revision: 53252
use inlist so we don't have to find stuff to operate on.
export more methods, like elm_gengrid_item_next_get(),
elm_gengrid_item_prev_get() and elm_gengrid_first_item_get() and elm_gengrid_last_item_get()... so we don't expose elm_gengrid_items_get().
People using the old elm_gengrid_items_get() should move to
elm_gengrid_first_item_get() and then next variant.
SVN revision: 53248
Gengrid now has modes append, prepend, insert_before and insert_after. To see
them working check the Gengrid 2 test on elementary_test.
SVN revision: 53242