Commit Graph

112 Commits

Author SHA1 Message Date
Daniel Zaoui 1303a6dbec Eolian: fix names for elc widgets.
Even if the file names are elc_..., the class names are supposed to be
elm_...
2014-04-22 16:39:35 +03:00
Jaeun Choi 69ddd5b7f5 multibuttonentry: change key up callback into key down callback for consistency
Summary:
Every elementary widget's action is triggered by key down event except multibuttonentry.
There's no reason why focus move and deletion should happen on key up in multibuttonentry.
This patch modifies _layout_key_up_cb into _layout_key_down_cb.

Test Plan: None

Reviewers: raster, Hermet, seoz, jpeg

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D755
2014-04-18 11:33:43 +09:00
Tom Hacohen 5a1d105c5e multibuttonentry: Adjusted to Eo2. 2014-04-10 09:34:59 +01:00
Daniel Zaoui 4b163aecbc Eolian: Integration of Multi Button Entry 2014-03-31 13:48:26 +03:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
ChunEon Park f8d00ae0f2 elementary - override widget translation but work also the base widget's behavior.
Some widgets override the widget translation but it didn't inherit the base widget's function.
Becuase of it,The language changed won't be properly called in the widget tree.

Now it fixed it.
2014-01-23 20:20:43 +09:00
Daniel Juyung Seo 43533a2fb9 elm: Removed unnecessary null check for eina_stringshare_del. 2014-01-22 10:54:45 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo 16f687b87a multibuttonentry, genlist, layout, toolbar: Fixed dereference of null
pointers which were reported by clang builg.

https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-XZo1hW.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-isAlRt.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-8Ascv8.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-gBkVuE.html#EndPath
2014-01-06 23:26:46 +09:00
Carsten Haitzler 99b270868d multibuttonentry - emit edje signal to oedje object not item struct! 2013-12-27 11:46:35 +09:00
Gustavo Lima Chaves 89da5dfc91 Reach mbe item on signal emit hook properly.
Fixes 360bba13c7c1004f7520e5e1ebe341c2e6323d2a mistake.
2013-12-26 16:03:24 -02:00
Gustavo Lima Chaves f6ad9605d6 New Elementary API -- elm_multibuttonentry_format_function_set().
Useful when one does not want the default multi button entry counter
item's format string.
2013-12-26 15:27:39 -02:00
Gustavo Lima Chaves 31f2530bd7 Multi button entry items now support custom parts on elm_object_item_text_[gs]et() calls.
I also removed a crazy "if (!label) return", since no other item text
hook on Elementary does that and I can't find a single reason for that
to be there.
2013-12-26 13:54:57 -02:00
Gustavo Lima Chaves e9f9e9a897 Now multi button entry items will happily listen to_object_item_signal_emit() calls. 2013-12-26 13:45:22 -02:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
WooHyun Jung cc4a41e641 Fix build warning. 2013-11-20 20:23:49 +09:00
WooHyun Jung 10775281a7 elementary/elc_multibuttonentry.c : Multibuttonentry doesn't need to call parents' on_focus. 2013-11-20 20:17:17 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Juyung Seo d22076681b elm: Fixed formatting about smart_event check for code consistency.
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Daniel Juyung Seo 7cca8036d7 elc_multibuttonentry.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:12:50 +09:00
Daniel Juyung Seo e756f97dae elm: Longwaited trailing white space removal. Clean elm up! 2013-09-30 22:15:01 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
ChunEon Park fe0f0a445e elementary/widgets - set parents before widget constructs their body.
This avoids unnecessary setups again when obj <-> sub has connected.
2013-08-27 00:29:45 +09:00
Carsten Haitzler e663eb4411 clean up some multibutton ugliness - this breaks theme api...
multibuttonentry really didnt follow elm conventions - it didnt use
namespacing for most singals/swallows - it dug into objects reading
object part geometry where it just should have calced min size and be
done. it did all sorts of other things it shouldnt/didnt need to.. so
i fixed that now... and dark theme has the support.
2013-08-23 23:33:06 +09:00
Daniel Juyung Seo c5b0d63838 fixed documentation for consistency. Gets -> Get.
Occurance of Get is super much higher than Gets.
So change Gets to Get for consistency.
2013-08-22 05:24:46 +09:00
Carsten Haitzler 59e8bc5a35 Fix elm to use key not keyname (so xmodmap works) 2013-07-31 15:16:41 +09:00
Shinwoo Kim c47ef1b7fe [access] use proper name _elm_access_info_get(); not _elm_access_object_get(); to get access information 2013-07-31 12:57:49 +09:00
Jaehwan Kim 5e7742d4c3 Fix the wrong parameter in multibuttonentry. 2013-07-23 18:48:09 +09:00
Daniel Juyung Seo ecf6eff9a4 elm: formatting fix for consistency. 2013-07-23 06:05:16 +09:00
Daniel Juyung Seo cc9a5b3f06 elc_multibuttonentry.c: fixed dereference null return value issue which was spotted by coverity. CID 1040023.
elm_widget_item_new() can return NULL on error so it's better to check NULL.
2013-07-06 12:07:51 +09:00
Cedric Bail c929b33052 elementary: properly sanitize headers order. 2013-05-03 16:07:06 +09:00
Daniel Zaoui 187d6bf8de Elementary: replace eo_data_get for objects data referencing. 2013-05-01 11:04:09 +03:00
ChunEon Park ff10726141 elementary/ctxpopup, hoversel, naviframe, multibuttonentry, popup, diskselector, list, menu, segment_control, toolbar - support widget item language change 2013-04-23 20:30:15 +09:00
Daniel Juyung Seo 74b3eed5fd elm: print the error message inside elm_widget_sub_object_add().
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
   Elm devs should fix it beforehand.
   So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
2013-04-03 11:28:53 +09:00
Stefan Schmidt 9840d67f6a elm: No need for two set of parentheses in a simple comparison.
Seems this got copied around. Better fix it now before it widespreads more.
2013-03-22 08:44:15 +00:00
Tom Hacohen d75cb616da Change usage of eo_do_super to the new prototype. 2013-03-18 16:15:12 +00:00
Daniel Juyung Seo 78c042cdbe elm *.c: fixed formatting with EINA_LIST_FREE.
EINA_LIST_FREE (xxx) -> EINA_LIST_FREE(xxx)
2013-03-09 13:23:42 +09:00
Gustavo Lima Chaves 312d0217a0 An internal layout error, on a widget set, is a CRITICAL error. 2013-03-01 23:04:31 -03:00
Cedric BAIL 1aaa6e41e1 elementary: as previously stated sizeof (long) != sizeof (void*)
SVN revision: 84014
2013-02-17 03:53:02 +00:00
Daniel Zaoui cdd1eea853 Replace supported_types
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 83803
2013-02-10 07:52:31 +00:00
ChunEon Park e68959696d elementary/multibuttonentry - fix memory leak
SVN revision: 82439
2013-01-09 08:28:03 +00:00
Daniel Juyung Seo ffa9c1e793 elm: Refactoring.
Smart data is already initialized so we do not need to re-initialize them if the value equals to 0, NULL, or EINA_FALSE.
Sometimes re-initializing smart data explicitly is needed for readability. So there are left overs.

SVN revision: 82228
2013-01-04 19:10:19 +00:00
Shinwoo Kim f10fb3e115 [access] export some APIs,and remove unnecessary lines.
+ elm_access_object_register();
  + elm_access_object_unregister();
  + elm_access_text_set();
  + elm_access_text_get();
  + elm_access_cb_set();

These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();


SVN revision: 81659
2012-12-23 14:50:56 +00:00
Stefan Schmidt 94fd96be35 elm/multibuttonentry: Don't leak memory if the filter was already there.
SVN revision: 80879
2012-12-13 15:20:22 +00:00
WooHyun Jung 2bbb2dac16 [elementary/multibutton_entry] Fix focus problem in multibuttonentry.
Entry can get focus only when multibuttonentry is focused.


SVN revision: 80433
2012-12-07 10:54:04 +00:00
Cedric BAIL 3ef34e5dac elementary: eo_data_get can return NULL if the object is dead.
SVN revision: 80418
2012-12-07 08:44:47 +00:00
Daniel Zaoui 0c915e9023 Cleaning: removed include Eo.h in widgets because it was indirectly included by Elementary.h
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 79682
2012-11-26 09:29:01 +00:00
Yakov Goldberg 5c98343198 We have ported to Eo all the widgets of elementary. We didn't change the inheritance itself, only the mechanism, as done previously in Evas, Ecore and Edje. We removed totally the previous inheritance mechanism.
Signed-off-by: Yakov Goldberg <yakov.g@samsung.com>
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 79668
2012-11-26 06:32:53 +00:00