Commit Graph

8364 Commits

Author SHA1 Message Date
Amitesh Singh 8e47bbb70a tooltip: Corrected namespacing for tooltip label style.
Summary:
namespacing is wrong for tooltip label. Although we still support old theme
but it should be removed in EFL 2.0.

Test Plan: elementary_test -to tooltip

Reviewers: seoz, Hermet, raster

Reviewed By: raster

Subscribers: kimcinoo, sachin.dev, seoz

Differential Revision: https://phab.enlightenment.org/D2120
2015-03-25 07:23:07 +09:00
Carsten Haitzler ac771e51af elm - fix warnings after patches to datetime 2015-03-25 07:14:08 +09:00
Subodh Kumar 7bf866f8bf [elm_datetime] Fix to consider second field while comparing datetime values.
Summary:
Some app like calendar, they heavily depend on the value of datetime,so to ensure accuracy
second field is considered while comparing datetime values.

@fix

Test Plan: NA

Reviewers: shilpasingh, raster

Reviewed By: shilpasingh, raster

Subscribers: poornima.srinivasan, govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D2204
2015-03-25 07:09:23 +09:00
Subodh Kumar 79e7d5bcad [elm_datetime] Fix to parse the POSIX locale format properly.
Summary:
In POSIX, some format include extra character like dash, hash, etc, which gives unexpected behaviour.
Fix to filter out those character.

Signed Off By: Seongjun Yim <se201.yim@samsung.com>
Signed Off By: Subodh Kumar <s7158.kumar@samsung.com>

@fix

Test Plan:
1. Set datetime as POSIX locale.
2. Check the datetime behaviour in elementary_test.

Reviewers: raster, shilpasingh

Reviewed By: shilpasingh

Subscribers: poornima.srinivasan, govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D2203
2015-03-25 07:06:03 +09:00
Subodh Kumar 12f6f56f85 [elm_datetime] Corrected the logic for datetime values comparison.
Summary:
Datetime value should be compared earlier to avoid unnecessary code execution.
Also added logic for single field comparion which will avoid to compare all fields when field limit is set.

Signed Off By: Seongjun Yim <se201.yim@samsung.com>
Signed Off By: Hyunseok Yang <hs0219.yang@samsung.com>
Signed Off By: Subodh Kumar <s7158.kumar@samsung.com>

Test Plan: NA

Reviewers: shilpasingh, raster

Reviewed By: shilpasingh, raster

Subscribers: poornima.srinivasan, govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D2202
2015-03-25 07:00:44 +09:00
Jaehwan Kim 1925ec3b8e scroller: add loop feature.
This feature works the infinite loop horizontally or vertically.
If the content is set, it will be shown repeatedly.
@feature

Change-Id: I1f20b794ae44bc8e5d120901222c7cccadca96b7

Conflicts:
	src/lib/elm_scroller.c
	src/lib/elm_scroller_legacy.h
2015-03-23 20:35:04 +09:00
Yakov Goldberg 9a2f068740 Implement efl_file_get() for Elm_Layout and Elm_Video
"file" property in Efl.File interface is virtual pure,
so according to OO principles must be implemented in derived classes.

This patch adds implementation of "file.get" in Elm_Layout.

Further, Elm_Video class has it's own implementation of "file.set",
thus also requires implementation of "file.get"
2015-03-22 14:37:52 +02:00
WooHyun Jung 56b6792584 toolbar: remove useless codes 2015-03-21 09:45:59 +09:00
Jee-Yong Um 89d4986aee elc_popup: Fix to make popup get proper size
Summary:
There is a bug that popup can't get proper size when list is set as its content.
Because of unneccesary calling evas_object_show() in popup's overriding elm_obj_container_content_set(),
sizing eval doens't work correctly.
This patch fixes this bug.

Test Plan:
Execute 14th popup sample in "elementary_test popup".
(popup-center-title + list content + 1 button)
After applying this patch, popup shows correctly.

Reviewers: seoz, Hermet

Reviewed By: Hermet

Subscribers: Hermet, seoz

Differential Revision: https://phab.enlightenment.org/D2158
2015-03-20 14:14:02 +09:00
Subodh Kumar c7b28cb1ac Elm_toolbar: Sizing evaluation improvement.
Summary:
Issue: Flickering when toolbar was set/unset
Solution: Unnecessary resizes and show caused the flicker, removed unnecessary resizes.

Reviewers: seoz, raster, shilpasingh

Reviewed By: shilpasingh

Subscribers: poornima.srinivasan, rajeshps, govi

Differential Revision: https://phab.enlightenment.org/D2070
2015-03-19 18:46:59 +09:00
Youngbok Shin fa68fc7603 config: Reinitialize font config using evas_font_reinit() API.
Summary:
Call evas_font_reinit() API before applying font overlays when config is fully reloaded.
Application could modify or add font config "*.conf" files.
And It should affects all of other running EFL application.
So, put evas_font_reinit() API to be called when x win property is changed.
@feature

Reviewers: cedric, raster, tasn, woohyun

Differential Revision: https://phab.enlightenment.org/D2113
2015-03-19 18:04:59 +09:00
Andrii Kroitor 3857bf83ea elm_entry: fix focus on text selection
Summary:
Setting focus to entry object when text is being selected

@fix

Test Plan:
1. open "elementary_test entry3"
2. click on the big entry
3. mouse down on singleline entry to start selection
4. move mouse out of window
5. mouse up. text in that entry seems to be selected
6. press del or type any text

expected result: selected text in singleline entry is deleted/replaced
result without this patch: singleline entry is not focused and all edit actions are affecting the big one

Reviewers: cedric, Hermet, seoz

Subscribers: poornima.srinivasan, subodh6129, raster, reutskiy.v.v, herdsman

Differential Revision: https://phab.enlightenment.org/D1476
2015-03-19 17:43:04 +09:00
Jaehwan Kim 9c26cdf25a elm_widget: fix wrong parmeter.
The parameter what the application gets should Elm_Object_Item.

@fix
2015-03-19 16:47:24 +09:00
Mike Blumenkrantz 97912ed487 elm_win fullscreen setting on FAKE wins should just toggle the flag
@fix
2015-03-18 10:53:56 -04:00
Mike Blumenkrantz 39a3a9a827 elm_win fullscreen getter does not need a third case for an inclusive if/else 2015-03-18 10:51:29 -04:00
ChunEon Park dc01331903 Revert "widget: fix the abi break."
This reverts commit 841fcdfb18a414a7381910bcbb0b0ef4807bc5c2.

It's been too much passed.
we have more dependencies to the change (ie, key bindings)
so conclude to have the abi break in this case.
2015-03-17 15:46:19 +09:00
ChunEon Park 82ee39739d conform: remove redundant declares. 2015-03-17 15:44:27 +09:00
woochan lee fb2144d9e0 conform: Use eo_isa() to check object types.
Summary:
The strcmp(line 738) has been failed since the eo applied.
the widget type get API returned "Elm_Genlist" now.

For fix it, using eo_isa() to check object types instead of string comparison.
@fix

Reviewers: seoz, woohyun, JackDanielZ, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2148
2015-03-17 15:42:36 +09:00
Daniel Juyung Seo 53fafc464e image: Initialize parameters in case of it just returns without assigning any value.
In this way, callers does not need to consider initializing the
parameters for their local variables.
2015-03-16 23:19:20 +09:00
Hosang Kim 74b6b65426 elm_image: Fix to initialize variable.
Summary: If _elm_image_object_size_get fails, w and h have garbage value.

Test Plan: no

Reviewers: seoz, Hermet, cedric, raster

Differential Revision: https://phab.enlightenment.org/D2163
2015-03-16 21:18:28 +09:00
Daniel Zaoui 87aa8cdb54 DnD/Wl: extend types support to all the atoms.
uri-list type was always sent as source data type.
2015-03-16 09:42:03 +02:00
Daniel Zaoui c0bd72eaa4 DnD/Wl: fix drop sequence when drop is done on a bad target.
The problem occurs when no drop target below the mouse can receive the
data type provided and the mouse button is released. The mouse pointer
stays grabbed and this leads to issues for the next drags.
To solve this, on a bad drop, the destination window has to request
from the source window the end of the dnd.
2015-03-16 09:42:02 +02:00
Daniel Zaoui 29ddeff501 DnD/Wl: add a better support to data types.
The types management mechanisms for X11 and Wayland use the same
infrastructures.
2015-03-16 09:42:02 +02:00
Daniel Zaoui cc0368334d DnD: Arrange code for better usability
Specific types need to be declared before other, as well as functions
prototypes.
2015-03-16 09:42:02 +02:00
Daniel Zaoui 1f86e80f0a DnD/X11: generalize function
This is needed for the types management in Wayland.
2015-03-16 09:42:02 +02:00
Daniel Zaoui 1191f41238 DnD/X11: generalize atoms descriptions
This step is needed to simplify types management for Wayland by using
the same data structures.
2015-03-16 09:42:02 +02:00
Jean-Philippe Andre 89d8f954de GLView: Return false if the surface could not be created
Apps had no easy mean to check that their chosen configuration
was actually working.

@fix
2015-03-16 16:40:08 +09:00
Jean-Philippe Andre b408b31537 elm_config: Add doc for the new depth/stencil/msaa preference 2015-03-16 15:10:57 +09:00
Wonsik Jung c27ab30fae elm_config: Add feature to set depth/stencil/msaa bit to window surface
Summary:
When evas gl/elm glview runs with direct rendering, it can not set these bits to window surface.
Because of no interface and method.This patch can do that.

This patch just uses current interface as a elm_config_accel_preference_set instead of new API.
Also, it is related D2144 patch.

Test Plan: ElmGL View test menu in elementary_test app JP's test app.

Reviewers: spacegrapher, cedric, raster, jpeg

Reviewed By: jpeg

Subscribers: mer.kim

Differential Revision: https://phab.enlightenment.org/D2145

Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
2015-03-16 14:26:41 +09:00
ChunEon Park 622fe4c5da widget: fix the abi break.
Widget type string should be all lower-cases!

This acutally was caused in 7b10fdb8f39c3b36f575dd22d26a1efe6ecd28ec

@fix
2015-03-13 17:46:00 +09:00
Jaehyun Cho 80baf57494 elm_panel: Fix incorrect scroller content region calculation of panel.
Summary:
Fix incorrect scroller content region calculation of panel.
It is fixed that the parent of panel content becomes scr_ly if panel is scrollable.

Test Plan:
Test Panel Scrollable in elementary_test.
1. Change panel orient as ELM_PANEL_ORIENT_RIGHT in test_panel.c.
2. Run elementary_test and test Panel Scrollable.
3. You can see the right panel drawer is hidden right after it is shown.
   (After applying this patch, this problem will be resolved.)

Reviewers: seoz, woohyun, eunue, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2125
2015-03-13 17:28:17 +09:00
ChunEon Park 2ffc39659b elm_object: update doc.
remove redundant note.
2015-03-13 17:24:07 +09:00
Amitesh Singh a56457ac76 entry: use ea_isa() for object types comparison
Reviewers: seoz, raster, Hermet

Reviewed By: Hermet

Subscribers: kimcinoo, seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2132
2015-03-12 15:44:09 +09:00
woochan lee 1f8ad27e40 genlist: Send param item type instead of eo item type.
Summary:
The _item_unselect() fucntion called at _elm_genlist_select_mode_set() with parameter.
It makes crash when access it->item. it is eo item type actually so it doesn't have member as item or something.
@fix

Test Plan:
1. Run elementary_test
2. Execute genlist
3. Select an item on list and click Next API fucntion button 2times.
4. Check the crash.

Reviewers: seoz, woohyun, Hermet

Reviewed By: Hermet

Subscribers: SanghyeonLee

Differential Revision: https://phab.enlightenment.org/D2136
2015-03-12 15:42:30 +09:00
SangHyeon Lee 411c30b408 Genlist/Gengrid : Modified to handle the focus highlight on unrealized items
Summary:
When unrealized item is focused, edje object is not exist,
         so genlist cannot read the focus highlight information from edje object.
         Therefore, when the item is realized, check the item is focused or not and
         need to update focus highlight.

@fix

Test Plan: change edc for supporting focus highlight in edc, and set focus on unrealized items.

Reviewers: raster, seoz, jaehwan

Differential Revision: https://phab.enlightenment.org/D2128
2015-03-11 20:35:53 +09:00
Carsten Haitzler 8cfa96fee7 elm - fix zmikes smart-arse stupid documentation remark 2015-03-11 20:16:36 +09:00
Daniel Juyung Seo f5d144e421 elm: Use eo_isa() to check object types instead of manual string comparison. 2015-03-10 22:52:29 +09:00
Daniel Juyung Seo c49d674d81 atspi: Remove unnecessary null check.
win could not be null due to EINA_LIST_FOREACH design.
2015-03-10 22:51:22 +09:00
Daniel Juyung Seo c9e3ab3363 elm: Clean up elm_win_resize_object_add caller.
- Do not need to call align_set for window resize object.
- Call weight_set before adding an object to a window's resize object.
2015-03-10 22:41:44 +09:00
ChunEon Park 86783c4c9a main: use eo_isa() to check obj type. 2015-03-10 22:31:13 +09:00
woochan lee d66a2555a8 multibuttonentry: registered object change for callback add.
Summary:
API changed from "edje_object_signal_callback_add()" to "elm_layout_signal_callback_add"
to following code refactoring.

Reviewers: seoz, woohyun, Jaehyun, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2102
2015-03-10 17:19:47 +09:00
ChunEon Park 6761b04c47 popup: fix mistake
this is introduced in d4eaee4eb97210ed153c161fc8b7d21967f61131.

the position should be rearragned after geometry_get().
2015-03-10 17:03:36 +09:00
ChunEon Park 304d582953 layout: here default content alias can be acceptable.
elm_object_content_set() for layout will be working.

@fix.
2015-03-10 16:56:22 +09:00
ChunEon Park 51b05f466f popup: correct popup position.
actually popup position should be updated when it's parent is moved.

@fix
2015-03-10 16:51:44 +09:00
woochan lee aa51e5ac24 layout: Add text alias description as default.
Summary:
The _text_aliases value exists. but never use here on layout for text part aliases.
in addition, i think that "elm,text" should be the default part for text set.

Reviewers: seoz, woohyun, JackDanielZ, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2116
2015-03-10 16:40:53 +09:00
ChunEon Park fddc22e30a Revert "Fix for T2042 ctxpopup don’t know its size"
This reverts commit aeeef70cfbc6d589262024105b52ae2c07336ecd.

Ahhh this patch wasn't intended. revert.
2015-03-10 16:36:24 +09:00
Jee-Yong Um 80f2f61c14 elc_popup: Adjust popup size when its parent is resized
Summary:
When parent is resized, popup keeps its original size.
This patch makes popup have proper size in proportion to parent's size.

T2082

Test Plan: You can check the effect of this patch in "elementary_test popup".

Reviewers: seoz, Hermet

Subscribers: stefan_schmidt, J5lx, seoz

Differential Revision: https://phab.enlightenment.org/D2121
2015-03-10 16:21:16 +09:00
woochan lee 325513c396 popup: Delete useless restack cb.
Summary:
This restack callback added for support previous tree [parent - notify - popup].
The popup has been redesigned to have correct tree [parent -popup - notify].
So the restack callback does not need anymore.

Test Plan:
1. Run elementary_test
2. Execute popup sample.
3. Activate popup which has restack feature.
4. Check the result.

Reviewers: seoz, woohyun, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2127
2015-03-10 16:17:49 +09:00
ChunEon Park ed6e7043a7 Fix for T2042 ctxpopup don’t know its size
Summary:
Since this patch ctxpopup is able to report its size which is equal to 1 element of list.
This can be treated as another bug (list visibility implementation must be so list will be counting its size dynamic on every item add)
Might be also ignored.

Test Plan:
1. Use application provided in T2042 (should have coordinates greater then 0).
2. Using atspi check is accessible element is visible. (with patch ctxpopup will be visible, without ctxpopup and its children will have status visible and showing set to FALSE)

Reviewers: raster, seoz, Hermet

Subscribers: m.jagiello

Projects: #elementary

Maniphest Tasks: T2042

Differential Revision: https://phab.enlightenment.org/D2045
2015-03-09 09:57:42 +09:00
Mike Blumenkrantz 00e8d1737c cursor theme setting should use cur->owner instead of cur->eventarea for parent
owner is required to be an elm widget, eventarea is not
2015-03-05 11:35:41 -05:00