Commit Graph

699 Commits

Author SHA1 Message Date
WooHyun Jung 0a1179dde4 elm_layout now supports focused/unfocused smart callback
by itself for widgets that inherit layout class.
If it uses elm_widget's, smart callback will be called at the
beginning or smart_on_focus function.
2014-02-06 16:18:57 +09:00
ChunEon Park dbacb2fef9 elementary - send signal "language,changed" with one way in the widget.
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.

This makes reducing duplicated code and supporting language,chagned from all widgets.
2014-01-23 19:30:34 +09:00
ChunEon Park aebdcff513 elementary - use the focused/unfocused string in widget defined.
Now, it will share the strings so that reduce the binary size also user uses it in one way.
2014-01-23 17:27:17 +09:00
Daniel Juyung Seo 0d1ac0fa05 elm: Removed unnecessary null check for eina_list_free. 2014-01-22 10:55:01 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Daniel Juyung Seo 43533a2fb9 elm: Removed unnecessary null check for eina_stringshare_del. 2014-01-22 10:54:45 +09:00
Daniel Juyung Seo c066009c49 elm: Removed unnecessary null check for ecore_idler_del, ecore_idle_enterer_del. 2014-01-22 10:54:28 +09:00
Daniel Juyung Seo a4f3074f9c elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
2014-01-21 23:18:16 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Ryuan Choi 23bebb1c47 genlist: Check return value out of the loop in _realized_items_get 2014-01-13 17:34:36 +09:00
Daniel Juyung Seo a7a8b257c2 gengrid, genlist: Fallback into default item style if the required item
style does not exist.
2014-01-08 19:07:56 +09:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo 16f687b87a multibuttonentry, genlist, layout, toolbar: Fixed dereference of null
pointers which were reported by clang builg.

https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-XZo1hW.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-isAlRt.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-8Ascv8.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-gBkVuE.html#EndPath
2014-01-06 23:26:46 +09:00
Chinmaya Panigrahi e4cbf1bcfb [Genlist]: Added NULL check
Summary: Added NULL check

Test Plan: elementary_test -to genlist

Reviewers: seoz, singh.amitesh, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D432
2014-01-01 14:11:50 +09:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
discomfitor ba5823f188 bugfix: unset genlist mincalcd flag when changing to/from having no item contents
not backporting because not sure if correct, but definitely a bug

also there's a similar issue where objects (I'm looking at you, elm_list) don't size until the first render, which causes the initial genlist calc sizes to be 100% wrong every time
2013-12-16 14:15:29 -05:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
Viacheslav Lvov 332cdd1e7c genlist - don't do heavy queue work for 0 width genlists and defer fill
Scenario:
1. Create elm_genlist.
2. Add some items to it.
3. Do not resize the genlist and leave it with width == 0.

PROPOSAL:
1. When the element is queued for recalculation check current width of
widget. If it is equal to 0 do not add idle enterer.
2. In smart callback on resize check if queue of items that need
recalculation is not empty and new width is not 0. In this situation
add idle enterer.
2013-12-06 16:08:09 +09:00
Daniel Juyung Seo 8a0159df4f elm: long waited seasonal trailing whitespaces removal!
This is a ceremony of elementary 1.8 release!
2013-12-02 19:43:46 +09:00
Daniel Juyung Seo 9efa212975 elm_genlist.c: return "elm.swallow.icon" part's object when the part parameter is null on _item_content_get_hook().
Now elm_object_item_content_get() works fine.
+ avoid ambiguous if-else statement by using braces.
2013-11-30 18:28:47 +09:00
Daniel Juyung Seo 00bd27a883 elm_genlist.c: return "elm.text" part's text when the part parameter is null on _item_text_get_hook().
Now elm_object_item_text_get() works fine.
2013-11-30 17:02:24 +09:00
nirajkr 98b0383451 elm_genlist.c: Fix to decorate the item if it is set
Summary: Changes in the _item_realize to decorate the item T576 test_genlist10

Reviewers: seoz, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D358
2013-11-29 19:18:00 +09:00
Gustavo Sverzut Barbieri 085e644c49 genlist: clear 'rel' pointer when it becomes unused during del_pre_hook.
If we're walking an item and it's deleted, the memory won't go away
immediately in _item_del_pre_hook() as would in _item_del(), then it's
not enough to remove ourselves from the reverse-relative list of the
item we were relative to, we also need to clean our own relative
pointer so we won't touch it later when the item is not being walked
anymore and _item_del() is called.

I was getting this annoying error with espionage application, opening
an interface of an object and then closing the window or selecting
another bus name (whatever would call elm_genlist_clear()).

During the clear process genlist will flag the next item as "walking"
so it's not gone when the current item dies (would happen if next item
is a subitem). The item would run _item_del_pre_hook() but not
_item_del(), but on the next loop iteration the next item would be the
current, then not walking anymore and during _item_del() it would
access it->item->rel which would point to the now-dead item.
2013-11-28 20:42:16 -02:00
Carsten Haitzler f6b66cc1d3 genlist - fix show item if list manipulation changes shown item position
this fixes T38 - it's a bit brute force but the only way i can think
of that is not too invasive before release.
2013-11-28 16:36:55 +09:00
Jihoon Kim 9e99a7f579 fix typos in doxygen and comments 2013-11-22 11:06:37 +09:00
Carsten Haitzler 872d21341e genlist - fix queue processor to not account for entire loop run in time 2013-11-19 15:10:03 +09:00
Tom Hacohen 4c8d03894c Changed Eo class names to be consistent. #2
All the class names are now of the format: Elm_Type_Subtype_Extra

Thanks to Yakov for pointing out I forgot a few and for giving me a nice
list.
2013-11-07 14:30:22 +00:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Juyung Seo 9509986a05 gengrid/genlist: added Eo compatibles for elm_genlist/gengrid_multi_select_mode_set/get() APIs. 2013-11-04 01:15:58 +09:00
Daniel Juyung Seo 6a0f47d120 Genlist/Gengrid: Added multi select mode for genlist/gengrid.
elm_genlist_multi_select_mode_set/get()
elm_gengrid_multi_select_mode_set/get()
2013-11-03 23:58:57 +09:00
Ryuan Choi 5836a25bc8 genlist, gengrid: Add ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL
Summary:
Some applications like file viewer allow multiple selection only with
Control key was pressed.

Reviewers: seoz, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D251

Conflicts:
	ChangeLog
	NEWS
2013-11-02 20:53:43 +09:00
Daniel Juyung Seo d22076681b elm: Fixed formatting about smart_event check for code consistency.
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Carsten Haitzler 95fdc9cc88 fix up namespace for many signal while keeping old versions for compat 2013-10-05 21:35:27 +09:00
Daniel Juyung Seo a2c704d613 elm_genlist.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:14:25 +09:00
Carsten Haitzler 0aed5eb970 genlist - fix homogenouse mode after previous fix to stop realizing all 2013-10-04 15:00:26 +09:00
Carsten Haitzler 6641cc792e genlist - fix homogenous to NOT go (un)realizing every item on queue 2013-10-01 12:54:28 +09:00
Daniel Juyung Seo e756f97dae elm: Longwaited trailing white space removal. Clean elm up! 2013-09-30 22:15:01 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
ChunEon Park a7b11a4c56 elementary/genlist,gengrid - should be cancel the track object before item view is removed. 2013-09-13 16:20:40 +09:00
ChunEon Park f426e08982 elementary/elm_object_item - delete the track objects when genlist/gengrid items are unrealized. 2013-09-13 14:19:41 +09:00
Daniel Zaoui 9cb42442f8 Genlist: fix memory not freed when item is expanded.
Thanks to TaeHwan Kim for the fix.
2013-09-09 10:14:14 +03:00
Daniel Juyung Seo 745488fff3 genlist/gengrid: use spacer when item edc supports elm.swallow.pad part. 2013-09-06 13:08:21 +09:00
Daniel Juyung Seo ce2df375b2 elm_genlist.c: use more ELM_SAFE_FREE. 2013-09-06 13:00:42 +09:00
ChunEon Park fe0f0a445e elementary/widgets - set parents before widget constructs their body.
This avoids unnecessary setups again when obj <-> sub has connected.
2013-08-27 00:29:45 +09:00
Gustavo Sverzut Barbieri 19b55ddc65 genlist: implement list position signals.
Genlist will now emit the following signals to item view related to
their position in the whole list:
      - elm,state,list,first: first item of the whole list
      - elm,state,list,last: last item of the whole list
      - elm,state,list,middle: any item that is not first or last.
      - elm,state,list,single: when the item is the only element of list.
And the following related to a group (considering its given 'parent'):
      - elm,state,group,first: first item of the group
      - elm,state,group,last: last item of the group
      - elm,state,group,middle: any item that is not first or last.
      - elm,state,group,single: when the item is the only element of group.

Unlike odd/even the signals have an extra namespace "list" or "group"
to avoid conflicts with applications that may have declared these
signals themselves for other purposes.

With this patch one can implement easily something like this:

         https://developer.apple.com/library/ios/documentation/userexperience/conceptual/tableview_iphone/Art/tv_grouped_style.jpg
2013-08-22 17:02:49 -03:00
Gustavo Sverzut Barbieri 1bba4c94d3 genlist: rename even_odd_update to more generic name.
The next patch will also send signals to say if it's the first, middle
or last item and also for group, thus using a more generic name will
help.
2013-08-22 17:02:49 -03:00
Daniel Juyung Seo c5b0d63838 fixed documentation for consistency. Gets -> Get.
Occurance of Get is super much higher than Gets.
So change Gets to Get for consistency.
2013-08-22 05:24:46 +09:00
Carsten Haitzler 59e8bc5a35 Fix elm to use key not keyname (so xmodmap works) 2013-07-31 15:16:41 +09:00
Shinwoo Kim c47ef1b7fe [access] use proper name _elm_access_info_get(); not _elm_access_object_get(); to get access information 2013-07-31 12:57:49 +09:00
Ryuan Choi 477c38cdd8 elm, genlist: Introduce ELM_PRIV_STATIC_VARIABLE_DECLARE and ELM_PRIV_SMART_CALLBACKS_DESC
This can reduce human mistakes when adding new signals (and typing).

This is not all, I will work on adopting these macros for oter widgets.
2013-07-15 11:28:18 +09:00