Commit Graph

10753 Commits

Author SHA1 Message Date
Stefan Schmidt 998d007558 examples/camera_light: free resources if we fail to allocate all and leave
We return here leaving maybe some other allocations around and leaking.

CID: 1327348, 1327349, 1327350
2015-10-20 16:16:31 +02:00
Lukasz Stanislawski f9defcd945 atspi: fix invalid shift operation.
Add additional check in case when Elm_Atspi_Role_Type enum will enlarge.

CID: 1325724
2015-10-20 12:00:08 +02:00
Carsten Haitzler e7dbba85c9 elm test - make automated test betetr by auto-exiting after 50 bounces 2015-10-20 14:05:05 +09:00
Carsten Haitzler 5a4ee64637 elm test - genlist test - add bounce option test for testing performance
for release we need to test performance - esp of evas and eo in real life usage
and scroling is just such one. this adds a simple automated scrolling
test to genlist test (hit the button or ELM_TEST_AUTOBOUNCE=1
elementary_test -to genlist) so you can get consistent input and benchmark info
2015-10-20 12:26:31 +09:00
Cedric BAIL 1164824201 toolbar: limit number of min restricted calc to exacly what we need.
This change is the simplest I could do, but I think it would be better
to move _item_theme_hook inside _item_new. This is a further attempt
to fix T2777.
2015-10-19 17:10:01 -07:00
Nak-Gyeong Kim 11e5e87103 elm_win: fix wrong comment.
Summary:
static const char SIG_FOCUS_OUT[] = "focus,out"; // deprecated. use "unfocused" instead.
static const char SIG_FOCUS_IN[] = "focus,in"; // deprecated. use "focused" instead.

@fix

Test Plan: N/A

Reviewers: seoz, cedric

Reviewed By: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D3187

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-10-19 11:55:30 -07:00
Sung-Taek Hong 1f03888c27 elc_file_selector_button: free allocated path name
Summary:
Currently path is strdup() when getting real path, but it is not freed
in some cases.

@fix

Reviewers: seoz, Hermet, woohyun, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3194

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-10-19 11:55:30 -07:00
Sung-Taek Hong 5bfa138bcc elm_map: block longpressed event when scrolled, zoomed, or rotated
Summary:
Currently, longpressed event can be called when map is
scrolled, zoomed or rotated. This might cause unintentional
result, because mouse need to be down at lease once to
execute scroll, zoom, or rotate, and longpressed event will start
when those events takes long enough time.

Reviewers: seoz, Hermet, woohyun, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3195

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-10-19 11:55:30 -07:00
Cedric BAIL a3806857ca hoversel: rename label_auto_changed -> auto_update
Thanks to Davide Andreoli for his review and suggestion.
2015-10-19 11:55:30 -07:00
Lukasz Stanislawski 12feff963e atspi: clean-up children-changed event emission.
Patch fixes bugs caused by difference between elm widget
and atspi objects hierarchy.
2015-10-19 17:26:13 +02:00
Lukasz Stanislawski f9fa294776 atspi: always update cache
libatspi implementation allows to call methods on objects which
are not added to client cache with "AddAccessible" at-spi signal.
Bridge should allow to perform such calls by updating its internal
cache as soons as it returns a reference to the dbus object to client.
2015-10-19 17:18:06 +02:00
Lukasz Stanislawski 2e70c7c15b atspi: fix typo 2015-10-19 13:40:05 +02:00
Amitesh Singh 56951adbfb test_genlist: set focus on popup's button 2015-10-17 00:50:17 +05:30
Cedric BAIL a77b922e28 toolbar: shutup compiler warning. 2015-10-15 17:23:21 -07:00
Cedric BAIL 58d38c10d2 toolbar: delay evaluation of the toolbar size until it stabilize.
Elementary is not using much the calculate callback from Evas. This
create all sort of problem where it transform O(n) algorithm. Like
sizing a toolbar for next frame to O(n^n) by actually sizing the
toolbar every time an object is inserted.

T2777
2015-10-15 16:38:24 -07:00
Cedric BAIL e13d263fe1 toolbar: remove useless call to _sizing_eval.
_sizing_eval is very costly on toolbar as it recalc all edje part and sends
signal to all of them. _item_theme_hook was already calling _sizing_eval
doubling the cost of adding new item.
2015-10-15 16:38:24 -07:00
Amitesh Singh 3d743982f1 example: genlist - intialize buffer array to 0
CID: 1327347
2015-10-14 20:47:46 +05:30
Amitesh Singh 97e0b8a7d2 example: genlist - intialize buffer array to 0
CID: 1327346
2015-10-14 20:45:10 +05:30
Amitesh Singh fd10a7de21 example: glview - use delete to deallocate memory
CID: 1327362
2015-10-14 20:33:13 +05:30
Amitesh Singh 78cde26a79 example: glview - use delete to deallocate memory
CID: 1327363
2015-10-14 20:30:06 +05:30
Chris Michael 8ab665bab0 elementary: Fix genlist example to not free data until After it has
been removed from the list

@fix CID1327342

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-14 10:52:03 -04:00
Chris Michael e03df78dbb elementary: Remove unused static variable
Summary: clang reports _list_focus_objects as being an unused static
variable, so remove

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-14 10:04:03 -04:00
Chris Michael 362a41cbd5 elementary: Remove unused static variable
Summary: clang reports SIG_THEME_CHANGED as being an unused static
variable, so remove

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-14 10:03:03 -04:00
Chris Michael 7a237d9052 elementary: Remove unused variables
Summary: clang reports SIG_BLOCK_CLICKED and SIG_TIMEOUT as being
unused variables, so remove

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-14 10:01:58 -04:00
Chris Michael 647a8571a1 elementary: Remove unused function
Summary: clang reports _icon_size_min_get as being an unused function,
so remove

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-14 10:01:15 -04:00
Chris Michael 441f309d46 elementary: Remove unused static varible
Summary: clang reports _smart_callbacks as being an unused static
variable, so remove

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-14 10:00:28 -04:00
Chris Michael 166ac9fb05 elementary: Remove unused variable
Summary: clang reports SIG_LANG_CHANGED as being unused here, so remove

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-14 09:59:30 -04:00
Chris Michael 0c5d2de146 elementary: Fix passing wrong parameter
Summary: clang reports passing EINA_FALSE here is being treated as an
Eo object, so pass NULL instead

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-14 09:58:20 -04:00
Chris Michael 345fb357c5 elementary: Fix passing wrong parameter
Summary: clang reports passing EINA_FALSE here is being treated as an
Eo object, so pass NULL instead

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-14 09:57:14 -04:00
Chris Michael 98f56ee12f elementary: Remove unused static variable
Summary: clang reports ELM_APP_SERVER_VIEW_PROPS_ENTRY as being an
unused variable, so remove.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-14 09:52:14 -04:00
Chris Michael 953e8fb421 elementary: Remove unused static variable
Summary: clang reports SIG_CLICKED as being unused so remove the
variable

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-14 09:51:09 -04:00
Jean-Philippe Andre 310f7d0321 elm_test: Fix bug in GLView test
Scenario:
  const char * accel = accel_get();
  accel_set("gl:depth");

Now accel may not be valid anymore since the original
Eina_Stringshare might have been destroyed. So there was
no point in saving the const char * pointer. It was not valid
after the call to set(). This is a bit confusing here. Returning
char* would be clear: the caller would own the data.
2015-10-14 20:19:30 +09:00
Amitesh Singh f1773531c3 image: remove unused variables 2015-10-13 09:08:01 +05:30
Cedric BAIL b7f6a004fa elm_image: let's not trigger confusing update add.
Elm_Image rely on Evas_Image ability to rotate content. There is no
pixels manipulation involved that require an update_add here. In fact
this cause a bug where the content would disapear due to evas trying
to get some pixels data that are not where it think they are.
2015-10-12 16:00:04 -07:00
Jee-Yong Um acccd9e10e elm_hoversel: fix to show dismiss animation
Summary:
In hover.edc, hoversel dismiss animations are defined,
but it doesn't work at all. (Hover is removed before animation)
This patch makes hoversel remove its hover after dismiss animation.

@fix

Test Plan: elementary_test hoversel

Reviewers: Hermet, cedric

Reviewed By: cedric

Subscribers: woohyun

Differential Revision: https://phab.enlightenment.org/D3070

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-10-12 13:22:47 -07:00
Chris Michael d1bc1b64ae elementary: Fix calling ecore_evas_wayland_move with improper values
Summary: As ecore_evas_wayland_move ends up updating the location of
the ecore_wl_window, we should be calling move with the proper
geometry as this ends up updating the internal ecore_wl_window
geometry (which in turn sends to xdg_surface_set_window_geometry).
This is part of a fix where xdg_surface_set_window_geometry was
getting sent inproper values.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-12 11:02:50 -04:00
SangHyeon Lee 0e353c727d Revert "gengrid : add all_contents_unset API in gengrid for reusing contents."
This reverts commit 1094fb77a0ee23cbe1e8b15783e406a8d93b7fd4.

Feature is freezed for new released version.
This patch must updated after release finished.
2015-10-12 18:23:56 +09:00
Jaehyun Cho 5d85d6a29f toolbar: Fix crash on more_item when shrink mode is set with no item.
Toolbar creates a more_item when shrink mode is
ELM_TOOLBAR_SHRINK_EXPAND.
If select mode is ELM_OBJECT_SELECT_MODE_ALWAYS and there is no item
appended, then toolbar sets a selection on a newly created item.
In this case, sd->more_item is referenced before the new more_item is
assigned to sd->more_item.

@fix
2015-10-12 16:53:51 +09:00
SangHyeon Lee 72cebeb662 gengrid : add all_contents_unset API in gengrid for reusing contents.
Summary:
Add elm_gengrid_item_all_contents_unset API for reusing contents in application side.
User can unset all contents or re-use their contents for increase scrolling performance.
genlist already support this API.

@feature

Test Plan: Need to add test in elementary_test.

Reviewers: raster, singh.amitesh, cedric

Subscribers: woohyun, Hermet, seoz

Differential Revision: https://phab.enlightenment.org/D3066
2015-10-12 14:42:37 +09:00
Carsten Haitzler 969354493e elm cursor - fix hotspot tracking to actually work right
hotspot tracking was broken. this fixes it.

@fix
2015-10-10 13:39:40 +09:00
Carsten Haitzler b8a3f7aa7a elm cusro config - move elm to by default look for cursors in theme
previous config ignored elm theme if ithas cursors. this was just
wrong, so switch default back to using theme and update configs
accordingly etc. this is houw it should have worked.
2015-10-10 13:21:58 +09:00
Carsten Haitzler 11eec45f4f elm cursors - if min size is too small then force it to be sane
cursor if less than 8x8 then make it 8x8. avoidx 0 sized pointers.

@fix
2015-10-10 13:08:37 +09:00
Lukasz Stanislawski 16ec6120be tests: add new tests for AT-SPI beta API. 2015-10-06 17:18:44 +02:00
Lukasz Stanislawski 6b49c30cd0 list: set atspi parent despite atspi mode.
Path fixes failing test case when atspi mode was off.
2015-10-06 11:27:15 +02:00
Stefan Schmidt fd063a336b tests: disable new atspi parent test for me as it breaks
Breaking distcheck for me and delaying the alpha1 tarballs. The API is still
marked as unstable but we might want to look into it during the beta's.
2015-10-05 15:46:24 +02:00
Chris Michael bcc0cd758a elementary: Comment out (#if 0) unused functions
Summary: Unsure whether these are left-over, or are going to be
implemented in the near future...but for now, #if 0 out these 2
functions as they are currently unused.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-10-05 09:11:25 -04:00
Carsten Haitzler 956a05ff8d elm run - be explicit about elm run not nesting in docs
@feature
2015-10-05 16:09:58 +09:00
Lukasz Stanislawski 0c8a75442a atspi: add new relationship append/remove/clear API
Allow to add some extra contextul information about accessibility objects
which can be used by Assistive Technology to provide better user experience.

API is still marked as beta.

@feature
2015-10-05 08:58:12 +02:00
Lukasz Stanislawski 83fd91edf5 atspi: support org.a11y.atspi.Collection interface
org.a11y.atspi.Collection interface allows to perform fast search
queries on accessibility objects tree.
Due to lack of specification of collection interface this implementation
base on gnome project implementation from https://git.gnome.org/browse/at-spi2-atk/.

@feature
2015-10-05 08:06:51 +02:00
Tom Hacohen 2299d98139 Revert "Genlist: only get item data if needed."
This actually doesn't work for coverity, I guess we just need to mark it
as false-positive, as it will never be null.

This reverts commit 178e7e6ac9419742d1bbe583fd252fc6536e5649.
2015-10-04 17:52:18 +01:00