There are elm_widget_theme/theme_set/theme_get functions.
In Eolian these functions will be described as "theme" method and
"theme" property. There is clash here.
So add suffix "_apply" to Eo API for "elm_widget_theme".
Panes smart callback depends on the signals from theme but it was broken
when dark theme was introduced.
"clicked" does not work yet, it should be fixed.
Thanks for the report, JackDanielZ.
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
elm.panes.fixed/unfixed -> elm,panes,fixed/unfixed.
whoever added this signal should be spanked.
I left the signal emission from the code due to backward compatibility.
So there is no theme api break.
We should remove the previous one when we start EFL 2.0.
SVN revision: 83967
Attached to the mail is a patch for elm_panes.
I have a query that shall we hide the unset content in the widget itself or should application explicitly hide them after unsetting!
In case of edje_object_part_unswallow, application needs to do it explicitly and it is documented but in case of elm_object_part_content_unset, there is no documentation available.
Details of the patch:
Existing Issue before this change:
1. Panes deletes the older content while setting a new content even though both are same.
2. left and right content are being unswallowed in the content_left_set and _content_right_unset functions. So when the reparenting happens, say when the content is put inside a layout then only _sub_del gets called and
unswallowing does not happen as these functions do not get called.
e.g. @@ -253,8 +250,6 @@ _content_left_unset(Evas_Object *obj)
if (!wd->contents.left) return NULL;
Evas_Object *content = wd->contents.left;
elm_widget_sub_object_del(obj, content); //wd->contents.left already gets set to NULL in _sub_del
- edje_object_part_unswallow(wd->panes, content); // can be unswallowed in _sub_del as in case of reparenting like setting content in a layout, only _sub_del will get called, not this function
- wd->contents.left = NULL; //this instruction is redundent as it happens in _sub_del anyway
return content;
}
Change Description:
1. Unswallowing the contents now in _sub_del as this is a common function to be executed when subobject removal happens.
2. Comparing the current content with new before deleting.
Signed-Off-By: RAJEEV RANJAN<rajeev.r@samsumg.com>
Thanks.
Regards,
Rajeev
SVN revision: 69720
Previous part names are just the swallow part names
but in modified version, the part names chaned to simpler meaning names to use.
i.e for button
elm_object_content_part_set(button, "elm.swallow.icon", icon);
-> elm_object_content_part_set(button, "icon", icon);
SVN revision: 65295