Commit Graph

10204 Commits

Author SHA1 Message Date
Carsten Haitzler 0312fd5b3d fix cursor setting to only set if currently visible
this should fix D715
2014-04-21 12:41:59 +09:00
Carsten Haitzler 9d55fab418 entry: wrong viewport value calculation issue fix
Summary:
Issue: As entire scroller edje co-ordinates was being taken instead of the actual viewport value,
if in scroller edje more parts are added apart from just "elm.swallow.content", then the viewport value
set will be wrong. hence the selection handlers will not hide when they have to hide.

solution: Instead of taking scroller edje's geometry, get the actual viewport values.
To get viewport x,y a new scrollable interface is also added.

signed-off by: Shilpa Singh <shilpa.singh@samsung.com>

@fix

Test Plan: Selection handlers have to hide correctly when the text is scrolled in a scrolled entry, if the scroller edc of entry has more parts added other than elm.swallow.content, then when we scroll the selection handlers are not hidden correctly.

Reviewers: jaehwan, woohyun, seoz, Hermet, raster

CC: govi, rajeshps, thiepha

Differential Revision: https://phab.enlightenment.org/D674
2014-04-21 12:31:49 +09:00
Jaeun Choi 200ec7840e slider: apply key binding
Summary: This patch applies key binding to elm_slider.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D761
2014-04-18 13:39:08 +09:00
Jaeun Choi 10c82f4269 multibuttonentry: add key binding in config files
Summary:
This patch adds multibuttonentry key binding info into config files.
Multibuttonentry has some issues in event handling so not suitable for key binding yet.
So, added key binding info first to upgrade config version.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D767
2014-04-18 12:07:07 +09:00
ChunEon Park bce93b6342 slider - don't send signals multiple times if the multiple key is pressed/up.
since slider popup has the interval for hide animation(may have, may have not)
just checking visible is not enough but this flag is correct.
2014-04-18 12:00:32 +09:00
ChunEon Park 7809e91bbc slider: fix comment for readability. 2014-04-18 11:55:54 +09:00
Jaeun Choi fcd6880b6c slider: removed unnecessary key value check in case of key up event
Summary:
This patch removes unnecessary codes.
There is no need to check key value in case of key up event,
since any other key down event except direction keys will cancel sliding.
Instead, hide popup if the popup is visible at that point.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D760
2014-04-18 11:53:27 +09:00
Jaeun Choi f8a26ed1fa slider: code refactoring in widget_event func
Summary:
This patch improves maintainability and readability through code refactoring.
- complete branch statement instead of goto statement
- removed unnecessary codes

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D758
2014-04-18 11:45:13 +09:00
Jaeun Choi 69ddd5b7f5 multibuttonentry: change key up callback into key down callback for consistency
Summary:
Every elementary widget's action is triggered by key down event except multibuttonentry.
There's no reason why focus move and deletion should happen on key up in multibuttonentry.
This patch modifies _layout_key_up_cb into _layout_key_down_cb.

Test Plan: None

Reviewers: raster, Hermet, seoz, jpeg

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D755
2014-04-18 11:33:43 +09:00
Daniel Juyung Seo c1613811e7 spinner: Fixed broken focus movement by direction key.
This was broken by c9755bd3c828bcd2453a50542331b201089a7160.
2014-04-18 04:25:43 +09:00
Lukasz Stanislawski c30b49ecaa config: fix crash when finding key bidings
Summary: Crash occured when config was reloaded and hash data become invalid.

Reviewers: raster, seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D750

Signed-off-by: Cedric Bail <cedric.bail@free.fr>
2014-04-17 19:46:25 +02:00
Daniel Juyung Seo a3d9569910 button: Renamed internal variable of button smart data to match with
actual API.
2014-04-18 01:26:01 +09:00
Jaeun Choi 099fbbc79f spinner: apply key binding
Summary: This patch applies key binding to elm_spinner.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D752
2014-04-17 16:03:48 +09:00
ChunEon Park 58ea3efa5d ctxpopup: dimiss ctxpopup if escape key is pressed.
rahter than just hide of the ctxpopup, dimiss will be much better for usability.
because press "Escape" is closed to "Cancel" meaning conceptually.
2014-04-17 15:51:37 +09:00
Jaeun Choi e88c793425 ctxpopup: apply key binding
Summary: This patch applies key binding to elc_ctxpopup.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D754
2014-04-17 15:41:50 +09:00
Jaeun Choi bde04f61e9 ctxpopup: sd->box null check and event_flag set for previous and next focus move.
Summary:
The original code was missing
- null check of sd->box
- event_flag value set
for previous and next focus move.
@fix

Test Plan: None

Reviewers: raster, seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D753
2014-04-17 15:23:00 +09:00
Jaeun Choi f2bb1364e8 spinner: fixed odd behavior of the spinner
Summary:
when multiple key down is coming while increase/decrease the spinner values,
the speed acceleration will be reset by the new key down.

Instead, it stops the increase/decrease the spinner values behavior.

@fix

Test Plan: None

Reviewers: Hermet, raster

CC: seoz

Differential Revision: https://phab.enlightenment.org/D749
2014-04-17 11:51:51 +09:00
Ryuan Choi ed8969e557 elm_web2: Implement select popup interfaces 2014-04-17 00:34:41 +09:00
Ryuan Choi 2a9cd79e6d elm_web2: Implement several interfaces
- elm_web_bg_color_{get|set}
- elm_web_zoom_{get|set}
2014-04-17 00:34:41 +09:00
Jaeun Choi bdf2c672ec spinner: unified two functions with different name and same functionality
Summary:
This patch unifies two functions with different name and same functionality:
_val_inc_stop and _val_dec_stop into _spin_stop.

Test Plan: None

Reviewers: Hermet

Differential Revision: https://phab.enlightenment.org/D748
2014-04-16 20:58:37 +09:00
Jaeun Choi edeea1eb96 flipselector: apply key binding
Summary: This patch applies key binding to elm_flipselector.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D745
2014-04-16 17:29:16 +09:00
Jaeun Choi 8b8a4b6922 gengrid: apply key binidng
Summary: This patch applies key binding to elm_gengrid.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D744
2014-04-16 17:29:16 +09:00
Jaeun Choi fc491c7c6c genlist: apply key binding
Summary: This patch applies key binding to elm_genlist.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D743
2014-04-16 17:29:16 +09:00
Stefan Schmidt c0ca21b666 theme: Add new image files to EXTRA_DIST to fix distcheck
This was broken in 995c0c0257605d857c907aab98fb8f942e4be411
2014-04-16 10:01:34 +02:00
ChunEon Park 5044b58cfb flipselector - don't say warning.
set EINA_UNUSED for unused argument.
2014-04-16 11:05:02 +09:00
Jaeun Choi 9d571ef5a4 web: apply key binding
Summary: This patch applies key binding to elm_web.

Test Plan: None

Reviewers: Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D740
2014-04-16 11:03:14 +09:00
ChunEon Park 5ab6a7739f widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.

conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
Jaeun Choi 40704d6d43 win: apply key binding
Summary: This patch applies key binding to elm_win.

Test Plan: None

Reviewers: Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D741
2014-04-16 10:38:34 +09:00
Carsten Haitzler d721cf2588 theme - improve efm icons provided by ApB
this fixes T575 wishlist item and improved the icons in default

@feature
2014-04-15 18:42:29 +09:00
Carsten Haitzler cb397f09fc win - add ELM_ACCEL env var to set acel method that is preferred
@feature
2014-04-15 18:41:39 +09:00
Jaeun Choi 33465d260a config: bug fix in popup key binding
Summary: This patch changes 'Tap' into 'Tab'.

Test Plan: None

Reviewers: Hermet

Differential Revision: https://phab.enlightenment.org/D739
2014-04-15 16:41:16 +09:00
Jaeun Choi 48a4a4add7 video: apply key binding
Summary: This patch applies key binding to elm_video.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D738
2014-04-15 16:09:12 +09:00
Jaeun Choi 2411bf5c62 toolbar: apply key binding
Summary: This patch applies key binding to elm_toolbar.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D737
2014-04-15 16:07:52 +09:00
Jaeun Choi 840e1fa07f slideshow: apply key binding
Summary: This patch applies key binding to elm_slideshow.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D736
2014-04-15 16:07:41 +09:00
Jaeun Choi 10fb0a3f30 photocam: apply key binding
Summary: This patch applies key binding to elm_photocam.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D735
2014-04-15 16:07:17 +09:00
Jaeun Choi 660591102a radio: apply key binding
Summary: This patch applies key binding to elm_radio.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D734
2014-04-15 14:54:58 +09:00
Jaeun Choi d8d53f4268 map: apply key binding
Summary: This patch applies key binding to elm_map.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D733
2014-04-15 14:52:06 +09:00
Jaeun Choi 3449c44221 image: apply key binding
Summary: This patch applies key binding to elm_image.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D732
2014-04-15 14:49:35 +09:00
Jaeun Choi 71149158e2 popup: apply key binding
Summary: This patch applies key binding to elc_popup.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D731
2014-04-15 14:47:19 +09:00
Jaeun Choi 16dd06bb8e player: apply key binding
Summary: This patch applies key binding to elm_player.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D730
2014-04-15 14:46:39 +09:00
Jaeun Choi e6d6066581 hoversel: apply key binding
Summary: This patch applied key bindiing to elc_hoversel.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D729
2014-04-15 14:40:38 +09:00
Jaeun Choi 530fcf2d8c fileselector: apply key binding
Summary: This patch applies key binding to elm_fileselector.

Test Plan: elementary_test > fileselector > check key events

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D728
2014-04-15 13:58:01 +09:00
Jaeun Choi fbcadfd87a list: apply key binding
Summary: This patch applies key binding to elm_list.

Test Plan: elementary_test > list > check key events

Reviewers: Hermet, raster, seoz

Differential Revision: https://phab.enlightenment.org/D727
2014-04-15 13:13:57 +09:00
Jaeun Choi 872a1de3c9 key binding infra change for modifiers
Summary: This patch makes key binding support multiple and inverse modifier set.

Test Plan: None

Reviewers: raster, Hermet

Differential Revision: https://phab.enlightenment.org/D717
2014-04-14 19:47:52 +09:00
Ryuan Choi 5514493f31 elm_web2: Fix build break with latest EFL
Followes Eo2 changes.
2014-04-14 14:53:28 +09:00
Daniel Juyung Seo cfef2a2a12 toolbar: Initialized some internal variables.
This fixes coverity CID 1199658, 1199659.
2014-04-13 02:00:33 +09:00
Daniel Juyung Seo 11ad4e125d scroller: Initialized some internal variables.
This fixes coverity CID 1199657, 1199622, 1199621, 1199620.

@fix
2014-04-13 01:58:43 +09:00
Daniel Juyung Seo a3a3766845 widget: Initialized internal variables.
This fixes coverity CID 1199625 and 1199626.

@fix
2014-04-13 01:44:22 +09:00
Daniel Juyung Seo 237d8dd624 test_genlist: Initialize internal variable.
This fixes coverity CID 1193249.
2014-04-13 01:40:27 +09:00
Daniel Juyung Seo ac10d9ac6e test_gengrid: Refactor gengrid test code.
- Added 'unselected' callback to reveal multiselect bug.
- Passed 'gengrid' directly instead of passing 'api' structure and using it indirectly.
- Added more box to make the GUI cleaner.
- Removed unnecessary comments and added more important comment.
2014-04-13 01:37:38 +09:00