Summary:
Get right application prefix by using elm_app_data_dir_get() for the
slideshow images.
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If elm_object_text_set() function is called twice,
elm_obj_containter_content_set(CONTENT_PART, sd->text_content_obj)
function makes sd->text_content_obj null since sd->text_content_obj already exists.
Test Plan:
1. run elementary_test(popup) and excute "popup-center-text + 1button (check hide, show)"
2. print sd->text_content_obj value in content_text_set()
3. push hide button and excute the example again
4. check sd->text_content_obj value if null or not
Reviewers: woohyun, Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D2225
Summary:
In case of the toolbar item size is fixed, the size of toolbar item became finger size.
so, after signal emission in _inform_item_number(),
edje_object_size_min_restricted_calc() and evas_object_size_hint_min_set() function are added.
Test Plan: change edc for supporting fixed toolbar item and run examples of toolbar in elementary_test
Reviewers: woohyun, seoz, Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D2184
Summary:
namespacing is wrong for tooltip label. Although we still support old theme
but it should be removed in EFL 2.0.
Test Plan: elementary_test -to tooltip
Reviewers: seoz, Hermet, raster
Reviewed By: raster
Subscribers: kimcinoo, sachin.dev, seoz
Differential Revision: https://phab.enlightenment.org/D2120
Summary:
Some app like calendar, they heavily depend on the value of datetime,so to ensure accuracy
second field is considered while comparing datetime values.
@fix
Test Plan: NA
Reviewers: shilpasingh, raster
Reviewed By: shilpasingh, raster
Subscribers: poornima.srinivasan, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D2204
Summary:
In POSIX, some format include extra character like dash, hash, etc, which gives unexpected behaviour.
Fix to filter out those character.
Signed Off By: Seongjun Yim <se201.yim@samsung.com>
Signed Off By: Subodh Kumar <s7158.kumar@samsung.com>
@fix
Test Plan:
1. Set datetime as POSIX locale.
2. Check the datetime behaviour in elementary_test.
Reviewers: raster, shilpasingh
Reviewed By: shilpasingh
Subscribers: poornima.srinivasan, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D2203
Summary:
Datetime value should be compared earlier to avoid unnecessary code execution.
Also added logic for single field comparion which will avoid to compare all fields when field limit is set.
Signed Off By: Seongjun Yim <se201.yim@samsung.com>
Signed Off By: Hyunseok Yang <hs0219.yang@samsung.com>
Signed Off By: Subodh Kumar <s7158.kumar@samsung.com>
Test Plan: NA
Reviewers: shilpasingh, raster
Reviewed By: shilpasingh, raster
Subscribers: poornima.srinivasan, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D2202
This feature works the infinite loop horizontally or vertically.
If the content is set, it will be shown repeatedly.
@feature
Change-Id: I1f20b794ae44bc8e5d120901222c7cccadca96b7
Conflicts:
src/lib/elm_scroller.c
src/lib/elm_scroller_legacy.h
"file" property in Efl.File interface is virtual pure,
so according to OO principles must be implemented in derived classes.
This patch adds implementation of "file.get" in Elm_Layout.
Further, Elm_Video class has it's own implementation of "file.set",
thus also requires implementation of "file.get"
Summary:
There is a bug that popup can't get proper size when list is set as its content.
Because of unneccesary calling evas_object_show() in popup's overriding elm_obj_container_content_set(),
sizing eval doens't work correctly.
This patch fixes this bug.
Test Plan:
Execute 14th popup sample in "elementary_test popup".
(popup-center-title + list content + 1 button)
After applying this patch, popup shows correctly.
Reviewers: seoz, Hermet
Reviewed By: Hermet
Subscribers: Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D2158
Summary:
Call evas_font_reinit() API before applying font overlays when config is fully reloaded.
Application could modify or add font config "*.conf" files.
And It should affects all of other running EFL application.
So, put evas_font_reinit() API to be called when x win property is changed.
@feature
Reviewers: cedric, raster, tasn, woohyun
Differential Revision: https://phab.enlightenment.org/D2113
Summary:
Setting focus to entry object when text is being selected
@fix
Test Plan:
1. open "elementary_test entry3"
2. click on the big entry
3. mouse down on singleline entry to start selection
4. move mouse out of window
5. mouse up. text in that entry seems to be selected
6. press del or type any text
expected result: selected text in singleline entry is deleted/replaced
result without this patch: singleline entry is not focused and all edit actions are affecting the big one
Reviewers: cedric, Hermet, seoz
Subscribers: poornima.srinivasan, subodh6129, raster, reutskiy.v.v, herdsman
Differential Revision: https://phab.enlightenment.org/D1476
Summary:
spinner don't changes its size after showing entry.
Entry is now clipped to area between arrows.
Test Plan:
1. Run "elementary_test spinner"
2. Click on top spinner. It shouldn't resize
3. Type very long number. It shouldn't overlaps arrows.
Reviewers: Hermet, raster, seoz, cedric
Subscribers: raster, reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1509
This reverts commit 841fcdfb18a414a7381910bcbb0b0ef4807bc5c2.
It's been too much passed.
we have more dependencies to the change (ie, key bindings)
so conclude to have the abi break in this case.
Summary:
The strcmp(line 738) has been failed since the eo applied.
the widget type get API returned "Elm_Genlist" now.
For fix it, using eo_isa() to check object types instead of string comparison.
@fix
Reviewers: seoz, woohyun, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2148
Summary: If _elm_image_object_size_get fails, w and h have garbage value.
Test Plan: no
Reviewers: seoz, Hermet, cedric, raster
Differential Revision: https://phab.enlightenment.org/D2163
The problem occurs when no drop target below the mouse can receive the
data type provided and the mouse button is released. The mouse pointer
stays grabbed and this leads to issues for the next drags.
To solve this, on a bad drop, the destination window has to request
from the source window the end of the dnd.
Summary:
When evas gl/elm glview runs with direct rendering, it can not set these bits to window surface.
Because of no interface and method.This patch can do that.
This patch just uses current interface as a elm_config_accel_preference_set instead of new API.
Also, it is related D2144 patch.
Test Plan: ElmGL View test menu in elementary_test app JP's test app.
Reviewers: spacegrapher, cedric, raster, jpeg
Reviewed By: jpeg
Subscribers: mer.kim
Differential Revision: https://phab.enlightenment.org/D2145
Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
Summary:
Fix incorrect scroller content region calculation of panel.
It is fixed that the parent of panel content becomes scr_ly if panel is scrollable.
Test Plan:
Test Panel Scrollable in elementary_test.
1. Change panel orient as ELM_PANEL_ORIENT_RIGHT in test_panel.c.
2. Run elementary_test and test Panel Scrollable.
3. You can see the right panel drawer is hidden right after it is shown.
(After applying this patch, this problem will be resolved.)
Reviewers: seoz, woohyun, eunue, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2125
Summary:
The _item_unselect() fucntion called at _elm_genlist_select_mode_set() with parameter.
It makes crash when access it->item. it is eo item type actually so it doesn't have member as item or something.
@fix
Test Plan:
1. Run elementary_test
2. Execute genlist
3. Select an item on list and click Next API fucntion button 2times.
4. Check the crash.
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Subscribers: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2136
Summary:
When unrealized item is focused, edje object is not exist,
so genlist cannot read the focus highlight information from edje object.
Therefore, when the item is realized, check the item is focused or not and
need to update focus highlight.
@fix
Test Plan: change edc for supporting focus highlight in edc, and set focus on unrealized items.
Reviewers: raster, seoz, jaehwan
Differential Revision: https://phab.enlightenment.org/D2128
Summary:
API changed from "edje_object_signal_callback_add()" to "elm_layout_signal_callback_add"
to following code refactoring.
Reviewers: seoz, woohyun, Jaehyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2102
Summary:
The _text_aliases value exists. but never use here on layout for text part aliases.
in addition, i think that "elm,text" should be the default part for text set.
Reviewers: seoz, woohyun, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2116
Summary:
When parent is resized, popup keeps its original size.
This patch makes popup have proper size in proportion to parent's size.
T2082
Test Plan: You can check the effect of this patch in "elementary_test popup".
Reviewers: seoz, Hermet
Subscribers: stefan_schmidt, J5lx, seoz
Differential Revision: https://phab.enlightenment.org/D2121
Summary:
This restack callback added for support previous tree [parent - notify - popup].
The popup has been redesigned to have correct tree [parent -popup - notify].
So the restack callback does not need anymore.
Test Plan:
1. Run elementary_test
2. Execute popup sample.
3. Activate popup which has restack feature.
4. Check the result.
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2127
Summary:
Since this patch ctxpopup is able to report its size which is equal to 1 element of list.
This can be treated as another bug (list visibility implementation must be so list will be counting its size dynamic on every item add)
Might be also ignored.
Test Plan:
1. Use application provided in T2042 (should have coordinates greater then 0).
2. Using atspi check is accessible element is visible. (with patch ctxpopup will be visible, without ctxpopup and its children will have status visible and showing set to FALSE)
Reviewers: raster, seoz, Hermet
Subscribers: m.jagiello
Projects: #elementary
Maniphest Tasks: T2042
Differential Revision: https://phab.enlightenment.org/D2045
the original code for handling label positioning was not robust enough to handle
cases such as ibar scrolling or gadget moving. this greatly simplifies the code
as well as handling all cases and providing small animations for moving the label
when necessary
This fixes partly T1828
Summary: Use the feature provided by ibar.
Reviewers: raster, zmike
Subscribers: zmike
Differential Revision: https://phab.enlightenment.org/D1797
Summary:
Add extra check to prevent crashing when user clicks configuration
test from elementary_test window
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz, cedric
Differential Revision: https://phab.enlightenment.org/D2086
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Item width max size set as 130 in edc before, i thinks that value doen't have any meaning,
so i changed the item max width size to follow container width size.
For modification, item size calc, box resize logic changed.
Test Plan:
1. Run elementary_test
2. Execute multibuttonentry sample.
3. Input some text for make item.
Reviewers: Hermet, seoz, woohyun, Jaehyun
Differential Revision: https://phab.enlightenment.org/D1970
Restacking not selected item should be selected after it is done.
@fix
Test Plan:
1. run in console
> elementary_test "Genlist Reorder Mode"
2. Switch to reorder mode
3. Select Item #6
4. Try to restack Item #4
(not selecting it, but holding mouse on it and moving down)
5. See that Item #4 and Item #6 is not selected
Reviewers: cedric, Hermet, raster, seoz
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1931
this adds logic in elm widget and elm win to figure out how to
automatically show a focus hilight when switching focus, or to hide
it. this really should be the default mode, thus in all default
profiles (default, standard, mobile) it's turned on. this means if you
tab or shif+tab or use arrow keys to switch focus, the focus hilight
will magicallly appear. click with a mouse to change focus and it'll
disappear assuming you want to use the mouse to do things. If focus is
explicitly turned on in config or in the window by api, then this has
no effect and focus will remain on all the time. this adds apis to
change these config values and options in the default elm config tool
to swizzle them as well as config upgrade handling for existing configs.
@feature
Summary:
Issue: Focus was not getting transferred individually on arrow buttons and text area.
Solution: Remove the usage of image parts and text parts and replace them with buttons
so as to handle the focus transfer normally than forcibly via smart event.
hence Focus next hook and focus direction hook is implemented.
Signed-off by: Subodh Kumar<s7158.kumar@samsung.com>
Signed-off by: Shilpa Singh<shilpa.singh@samsung.com>
Test Plan:
Use keyboard keys on spinner and test focus transfer, enable accessibility and test
accessibility.
Reviewers: woohyun, Hermet, shilpasingh, raster, seoz
Reviewed By: shilpasingh, raster
Subscribers: stefan_schmidt, raster, rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D1911
Removed default disable automatic mirroring of hoversel.
Summary:
Removed below API call for hoversel, hover, box and button object
elm_widget_mirrored_automatic_set(obj, EINA_FALSE);
Modified theme of "elm/button/base/hoversel_vertical_entry/default" to remove console errors due to theme, and modified text.align to -1 as 'x' value to set auto align for Arabic text.
Modified example hoversel_example_01.c to illustrate mirroring functionality
@fix
Reviewers: Hermet, seoz, tasn
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D1910
Summary:
1. Implemented genlist mode ELM_LIST_EXPAND
2. Implemented content_min_limit function which override scroll interface.
This function will be used by call API elm_scroller_content_min_limit.
This function will set the object minimum size as its scroll content size,
if parameter value is EINA_TRUE.
@feature
Test Plan: Add new test case in test_popup.c
Reviewers: raster, seoz
Subscribers: stefan_schmidt, bluezery
Differential Revision: https://phab.enlightenment.org/D1279
when a layout's theme is changed by elm_layout_theme_set, the edje is updated
according to the widget's states such as 'disabled' or 'highlight_in_theme'.
but the update is dropped for elm_layout_file_set.
this patch tied up the codes into _visuals_refresh function
so that the same update happens for elm_layout_file_set.
@fix
Summary: When running the E startup wizard using DRM, the cursor ends
up getting unset (and never reset) due to the DRM engine not having a
wayland window. To fix this, we will test the the engine being DRM and
if so then set the cursor->use_engine to false so that it defaults to
ecore_evas_object_cursor calls (which work on DRM).
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: If we are unsetting the cursor for an object, then if it's an
object on a wayland window, we should be callbacking
ecore_wl_window_cursor_default_restore
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
There is no reason why drop targets callbacks registered for a specific
type would be invoked when a not supported data is dragged.
This patch fixes it by comparing the data type and the callback type of
the drop target. Only the callbacks supporting the data type are
invoked.
During a DnD position event, we need to find the first dropable target
located under the mouse pointer; one of its callbacks has to support
at least one of the types of the dragged data.
This search process was done by strcmp-ing types for every drop target
and for each of their types until a good target is found.
This patch improves the process by comparing types formats, i.e and-ing bits
vectors.
Summary:
When box has expanded items (evas_object_size_hint_weight_set() with EVAS_HINT_EXPAND)
and homogeneous is set (elm_box_homogeneous_set() with EINA_TRUE),
there is a bug that it miscalculates its items size omitting padding size (space among items),
so the last item looks cropped or having smaller size than others.
This patch makes box calculate its items' size correctly.
T2033
Reviewers: Hermet, seoz
Subscribers: seoz, Hermet
Maniphest Tasks: T2033
Differential Revision: https://phab.enlightenment.org/D2016
Summary:
If user sets the limit value using elm_datetime_field_limit_set() API, the filed value will be recalculated.
Even though the value changed in case, value changed signal didn't send to user before.
@fix
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1980
Summary:
When an item is realized, select/disable/expand signal emission to the view object of an item was handled correctly,but there are no updating code for focus state.
@fix
Test Plan: tested by editing genlist/genlist item edc to react on elm,state,focused and move scroll signals to unrealized/realized item again.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: eunue
Differential Revision: https://phab.enlightenment.org/D2024
Summary: The API "elm_box_horizontal_get" missed @ingroup tag. so i added the tag for grouping when doxygen making API documentation.
Reviewers: Hermet, JackDanielZ, Jaehyun, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1966
Summary:
Thumbscroll is disabled in default configuration,
but "scrollable" feature in panel only works when thumbscroll is turned on.
To make "scrollable" work always in elementary test,
this patch enables thumbscroll temporarily regardless of configuration.
(configuration is restored when sample window is closed.)
Reviewers: Hermet, seoz
Subscribers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1983
Summary:
evas_image_orient_set is a newly added API to set orientation of evas image.
Using this API to set orientation of image widget.
Also removed Elm_Image_Orient enums and replaced it with Evas_Image_Orient enums.
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: raster, seoz, cedric
Differential Revision: https://phab.enlightenment.org/D1987
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This reverts commit 83f94464f1743cfa55e6b39704c605978edcee19.
This is incorrect. both windows evas are different,
we cannot set the child window as the resize object.
This reverts commit 72ef635ff3b8939509ecfb29ecf19e465b40e652.
changing a test so that it will not crash in a valid use case is not an appropriate fix.
ref T1973
Summary:
This small application for quick testing main features and changes in Evas 3D.
Main features: effects shadow, fog, measuring fps, load 3D model, panel for change
sets light and camera.
Reviewers: Hermet, raster, cedric
Differential Revision: https://phab.enlightenment.org/D1953
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm_transit_go() is executed immediately after it is called.
elm_transit_go_in() starts transit in given seconds.
@feature
Reviewers: Hermet, seoz
Reviewed By: seoz
Subscribers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1954
Summary:
_current_item_change() called at _item_select() internally.
it means _current_item_changed() called two times in vain.
so that's why item select callback called two times.
@fix
Test Plan:
1. Run elementary_test
2. Excute multibuttonentry sample.
3. Added some items and click the item area.
4. Select signal called two times.
Reviewers: Hermet, woohyun, JackDanielZ, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1955
now when a whele event comes in, 1. the amount we scroll accelerates
based on time between wheel events (the faster wheel events come out,
the more accel), and 2. we animate to the new position providing a
smooth transition to the new spot rather than a jump. very visually
nice.
@feature
there was no way to select an item with key input on ELM_ITEM_SELECT_ON_FOCUS_DISABLE mode.
this patch enables select and multi select with enter/space key input.
@fix
there was no way to select an item with key input on ELM_ITEM_SELECT_ON_FOCUS_DISABLE mode.
this patch enables select and multi select with enter/space key input.
@fix
Summary:
elm_coords_finger_size_adjust() is called twice.
It might not be intended.
Reviewers: Hermet, Jaehyun, seoz
Reviewed By: seoz
Subscribers: raster, seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1924
this fixes a deprecation of elm engine done just before 1.13 release
that ends up breaking "make doc" and also will make ELM_ENGINE env var
stop working (the latter was intentional). but since this is relied on
for things like make doc - keep the env var and haveit set preferred
engine and let people migrate away from using the engine var EXCEPT
for things like the shot engine
@fix
Summary:
There was no consistency with another widget which has item object, basically widgets has Elm_Object_Item object for own's item object.
but multibuttonentry used edje object for item object before.
Test Plan:
1. Run elementary test.
2. Execute multibuttonentry.
3. Doing variety action on multibuttonentry widget.(add, delete, key event, focus etc...)
Reviewers: seoz, woohyun, Jaehyun, Hermet, JackDanielZ
Subscribers: herdsman, cedric
Differential Revision: https://phab.enlightenment.org/D1864
Summary:
elm_layout_content_set API calls _elm_panel_elm_container_content_set func.
The panel widget checks the given "parts" string is whether "elm.swallow.event" or not.
To avoid error message and set the given object to the "elm.swallow.event" internally,
the panel widget need to call *_content_set for "elm.swallow.event" part using eo_do_super.
@fix
Test Plan: elementary_test -> panel
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1949
Summary:
1) According to description in .eo file,
some APIs return not 0 when the given object is NULL or not proper object.
But, several APIs are not implemented as those description.
Now, they will return a value as description.
2) If there is no description about the return value when the API fail,
put description according to pair API or old version of elementary.
@fix
Reviewers: woohyun, Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D1933
Summary:
Resolved FIXME filled all smart callbacks and also set it in the constructor
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D1876
the elm config tool only lets you set accel preference. if you set
none, then the old engine config takes charge, but there is no way to
change/set this, so deprecate the old engine set and don't use it.
this accel preference has been around for a while, so use it now
instead.
Summary: Added indicator_visible_mode to each slider in order not to make elm_config controlls every sliders.
Reviewers: Hermet, woohyun, seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1887