Summary:
User application may call some fileselector APIs to configure fileselector instance.
And some of them may call _populate but only last request is needed.
However, T1663 raises that last request might be rejected with expansion option and
multiple requests of _populate.
It's because expansion mode do not allow next _populate until previous one is finished.
So, this patch fixes it via scheduling _populate instead of calling _populate() directly in APIs.
@fix
Maniphest Tasks: T1663
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.
Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
(if someone decides to use beta APIs).
Test Plan: out-off tree build with gcc, g++
Reviewers: tasn
Reviewed By: tasn
Subscribers: seoz, q66, kuuko
Maniphest Tasks: T1721
Differential Revision: https://phab.enlightenment.org/D1528
Summary:
When fileselector is opened, it would be nice to be able to provide initial filename.
Like "Untitled Document" in Gedit, when save for the first time.
More details in Gedit,
Gedit provies default name, "Untitled Document" and does not change default name
while navigating directories.
Once we selected any file, Gedit changes value of name entry to selected filename and
it is not also changed while navigating directories.
@feature
Reviewers: seoz, yakov-g
Reviewed By: yakov-g
Subscribers: seoz
Maniphest Tasks: T1664
Differential Revision: https://phab.enlightenment.org/D1504
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.
Reviewers: z.kosinski
Reviewed By: z.kosinski
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1227
Summary:
Previously there was no focus_direction & focus_next.
These functions are added in filesector winset for currect focus movement inside the winset.
Test Plan: elementary_test->"fileselector"
Reviewers: raster, seoz, nirajkr, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D913
Summary:
This feature (Clicking on "Enter" key) was previously implemented by using "activate" signal of entry (the one for entering name of the file),
so it was looking like "ok" button was clicked by pushing "Enter" key on the keyboard.
This little feature was added in commit 4d761f3a63270c88fa516764d9288f8bf0ff4a11.
Later the huge feature that adds key binding was implemented (commit 820f3dc907250c0c08ed8431b50567e58d6dab5c for ex).
It allows to bind widgets with keys (certain function calls when certain keys is pressed on keyboard).
This feature also adds same functionality to fileselecter, doing the same as previous (with "activate" signal) one.
Because of that it was looks like "ok" button was clicked twice.
This commit fixes this behavior and removes old and outdated method of "ok" button clicking processing.
@fix
Reviewers: cedric, seoz, raster
CC: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D864
we can prevent to handle the widget events from the widget infra,
if the object is disabled.
conceptually, disabled object should not be interacted to user input(key, mouse)
When moved to root(/) and typed something in name_entry,
ok button sent //something as as data of "done" signal.
This patch checked current path string not to concatenate two slash.
We already know some apis are just wrapping the internal widget apis.
Iternally we don't need to call the external apis that have additional object validation checking.
Summary:
fileselector_button and fileselector_entry should have almost same interfaces with fileselector.
Previously , we exposed them individually such as elm_fileselector_is_save_set().
Instead of adding the same APIs three times, we can reuse one fileselector's API using Eo interface.
This patch introduced fileselector interface and applied it to elm_fileselector.
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D475
There are elm_widget_theme/theme_set/theme_get functions.
In Eolian these functions will be described as "theme" method and
"theme" property. There is clash here.
So add suffix "_apply" to Eo API for "elm_widget_theme".
Summary:
Now, application developers can decide whether files and directories to show in
fileselector view.
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D416
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
- I used "activate" signal of entry and this will call ok button clicked function directly.
- This is very useful when the fileselector is used in desktop with keyboard.
Summary:
From now, the list of files/directories can be ordered by filename,
type, size, modified time with both ascent and descent.
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D367
Davide Andreoli
Daniel Zaoui
Ryuan Choi
Lukasz Stanislawski
Tom Hacohen
Daniel Kolesa
Daniel Juyung Seo
Zbigniew Kosinski
abhi
Anil Kumar Nahak
Vorobiov Vitalii
ChunEon Park
Jaeun Choi
WooHyun Jung
Yakov Goldberg
Daniel Juyung Seo
Jihoon Kim
Carsten Haitzler