Subject: [E-devel] [Patch] [Elementary] ctxpopup - correct position
and size of ctxpopup
With ctxpopup, if it has many items and user uses -1 as parameter in
set direction priority function,
the ctxpopup position and size are calculated incorrectly.
Ex:
elm_ctxpopup_direction_priority_set(ctxpopup,
ELM_CTXPOPUP_DIRECTION_DOWN, ELM_CTXPOPUP_DIRECTION_UP, -1, -1);
SVN revision: 76505
Dear all,
With ctxpopup, if it has many items and user uses -1 as parameter in set direction priority function,
the ctxpopup position and size are calculated incorrectly.
Ex:
elm_ctxpopup_direction_priority_set(ctxpopup, ELM_CTXPOPUP_DIRECTION_DOWN, ELM_CTXPOPUP_DIRECTION_UP, -1, -1);
I would like to send a small patch to fix this issue.
Please take a look on it.
Thanks & Regards,
Thiep Ha
Signed-Off-By: Thiep ha<thiep.ha@samsung.com>
SVN revision: 76452
Subject: [E-devel] [patch][elementary] ctxpopup, focus-chain
i'd like to raise an issue about focus chain on the ctxpopup. the focus
would go around only in the ctxpopup. (IMHO, raster keep the previous
popup
patch. so definitely!!)
but.. first of all, current ctxpopup does not have focus_next(). even
though there is focus_next(), it is not work properly,
because the parent of ctxpopup would be a widget which does not take
care
of sub objects in the focus_next(); such as elm_list.
(every widget can be a parent of ctxpopup, if the widget is enough
size to
display ctxpopup. thus the elm_list can be a parent of ctxpopup also).
anyhow, to resolve this issue, the patch uses event() of
elm_widget_event_hook_set().
the ctxpopup item is equal to the elm_list item. but the focus chain of
elm_list does not work properly.
generally, we use 'Tab' key to move focus, but elm_list uses the
(up,down)
arrow key moreover it is not a focus.
if you want to check this patch, it would be better to use
ELM_ACCESS_MODE=1.
SVN revision: 74650
There is a case that parent can be NULL when you call
elm_ctxpopup_add().
This reverts commit 8bc665a6ebc9daf0d5faa46223635f46f3d0f682.
SVN revision: 71305
<ohpowel@gmail.com>
On Mon, May 21, 2012 at 5:32 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> When ctx_popup is deleted, it calls "elm_widget_sub_object_del(parent,
> popup)" so that ctx_popup's parent can delete it's sub_ojbect,
> "ctx_popup".
> But this is not needed because parent already deletes it's sub-object
> in elm_widget.c
>
> Thanks
>
> --
> BRs,
> Kim.
SVN revision: 71301
Currently there's semi-ready code (1 liner) that does nothing. Hermet, you
promised you'll add ui-mirroring support AGES ago when this widget got in.
SVN revision: 70960
Subject: [E-devel] [Patch][elementary] elc_ctxpopup using elm_list
internally.
The patch is for using elm_list as a item controller of elc_ctxpopup.
I have learned that there was an opinion to change the internal
structure
of ctxpopup using the list.
It would be able to match up to your expectation. but it is just a draft
version of using list in ctxpopup.
So, It would be pretty good to me if you give any feedback on this.
Thanks.
SVN revision: 69561
Now it returns the bool value to free the widget item.
Some widget items(i,e genlist) should not be deleted directly when elm_object_item_del is called.
So, if the pre_hook function returns EINA_FALSE, then the widget item will not be deleted.
SVN revision: 67565
Subject: [E-devel] [Patch] Removing content resize callback before the
ctxpopup is deleted.
Sometimes, widget data is referred after ctxpopup is deleted.
So before the ctxpopup is deleted, the content resize callback should
be removed.
SVN revision: 67268
The ctxpopup had used elm_ojbect_scroll_freeze_push(), pop() for the
scroll-freeze-on,of callback.
If user calls elm_object_scroll_freeze_pop() only after
elm_ojbect_scroll_freeze_push(), then it will be fine.
But sometimes user calls elm_object_scroll_freeze_pop() two times in a
row.. Then you can find there is infinite loop in following..
Signed-Off-By: cnook <kimcinoo@gmail.com>
SVN revision: 66584
Subject: [E-devel] [Patch] elc_ctxpopup, add restacking feature
I have attached two files, one is the patch(*.diff) for adding
restacking feature to the ctxpopup.
The other is test example(*.TEST_EXAMPLE). You can test on the
elementary_test > ctxpopup > "Ctxpopup with user content"
And click the button which is labeled "Enlightenment". Then label will
overlap the ctxpopup.. The ctxpopup will raise in a little time.
Please review the patch and if there is no problem, please throw the
test example away! :-)
SVN revision: 66415
Hey dear, here is the second patch using the box for the ctxpopup's
content.
The wd->content is content which is set by
elm_object_content_set(ctxpopup, content) not the box.
Please check this and give any feedbacks, Thanks. :-)
Signed-Off-By: Kim Shinwoo <kimcinoo.efl@gmail.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 66268
Sure, I have separated the path.
The attached patch is for the using previous result which is calculated by
the _calc_base_geometry();
Thanks always.. Please review this patch first. I will send second one
based on the attached.
Sincerely,
Shinwoo Kim.
Signed-Off-By: Kim Shinwoo <kimcinoo.efl@gmail.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 66267
As the title, attached patch has followings.
1) Using Calculated Value: The _update_arrow(); had used
evas_object_geometry_get(); internally for getting its base size.
But the _calc_base_geometry(); already got the base size which
is more accurate.
2) Getting Size From The Style Also: If the ctxpopup has content
which is composed using the style (means, the size of
content can get from *.edc file only), then ctxpopup does not
come properly. So resolving this, the patch is using a box,
and add a RESIZE callback to the box. When the box is resized,
the callback calls elm_box_recalculate();
SVN revision: 66130
Previous part names are just the swallow part names
but in modified version, the part names chaned to simpler meaning names to use.
i.e for button
elm_object_content_part_set(button, "elm.swallow.icon", icon);
-> elm_object_content_part_set(button, "icon", icon);
SVN revision: 65295
Dear All, Hello.
The arrow of ctxpopup is swallowed in one of 4 swallow parts(left,
right, top, bottom) of base group.
If user REuses ctxpopup which is already displayed with different
direction, then the arrow will be swallowed in previous position.
So the attached patch will unswallow arrow from the base before swallow...
Please review the patch and give any feedbacks.
Sincerely,
Shinwoo Kim.
SVN revision: 64054
Dear All, Hello!
The transition effect is added to the ctxpopup when it comes.
Please review the attached patch. Thanks always!
Sincerely,
Shinwoo Kim.
SVN revision: 62735
Dear All, Hi!
Previously, the ctxpopup have used only direction up or down if there is no
enough area to display.
So, there was some dead codes and TODO list for this..
By using wd->horizontal, we can decide between "up/down" and "left/right"
If elc_ctxpopup is horizontal, "up/down" is more proper than "left/right"
and vice versa.
Sincerely,
Shinwoo Kim.
SVN revision: 62420
Hi All,
The ctxpopup arrow is attached on the drag-able part.
If arrow height/width is smaller than drag-able part,
then there is a gap between arrow and ctxpopup base.
So this patch comes for resolving this issue. Thanks.
Sincerely,
Shinwoo Kim.
SVN revision: 61462
Subject: Re: [E-devel] [Patch][CtxPopup] Add Arrow on the drag-able
area of Base
Dear Mr. Hermet,
Hello, I have attached more accurate patch based on latest elementary. The
last patch already there.
All your review items are reflected on the attached patch.
Please review this again, sorry for any inconvenient.
SVN revision: 59911
Subject: [E-devel] [Patch][CtxPopup] Add Arrow on the drag-able area
of Base
If CtxPopup has elm_slider for content, the elm_slider indicator is covered
by CtxPopup arrow.
So, I have made a patch for resolving this issue. As the title the arrow
will be swallowed in the base.
Even though user uses his/her own style, the attached patch will work
properly.
Sincerely,
Shinwoo Kim.
SVN revision: 59890
Subject: [PATCH] elc_ctxpopup
Here code is for the ctxpopup.
Since the functionalities of ctxpopup are somewhat different,
I'm trying to overwrite the ctxpopup code entirely first.
The main reason is,
Original ctxpopup could determine it's size and position by itself.
Of course, upstreamed version supports this. But it can not be reduced
it's
size
And it supposes the arrow position to center of box edje.
Basically,
This version calculates it's box size first then find available space
from
the it's position.
The origin position of the box is not expected, it finds the available
positions.
But if there is not enough space to be shown, then it finds a best
direction
to be shown again.
In this case, it reduces it's size also as to be shown entirely.
Since the ctxpopup supports scroller, the reduced box could show the all
items also.
(The point is ctxpopup should know the size of total items...)
I'm not sure the upstreamed version could cover the above scenario,
If then, I need to modify it first.
(fixed some minor formatting issue too)
SVN revision: 56021
If you try to create a new widget, you must be sure that the parent
is really an evas object.
With the previous implementation it was possible to call an _add
function for an elementary widget with any non-null pointer as parent
eventually causing crashes (like with the elm_box).
SVN revision: 55521
Daniel Zaoui
Yakov Goldberg
Aharon Hillel
Carsten Haitzler
thiep ha
WooHyun Jung
ChunEon Park
Gustavo Lima Chaves
Daniel Juyung Seo
Kim Shinwoo
Tom Hacohen
cnook
Daniel Juyung Seo
Jiyoun Park
Mike Blumenkrantz
Jonas M. Gastal
ChunEon Park
3v1n0
Otávio Pontes