Summary:
fileselector_button and fileselector_entry should have almost same interfaces with fileselector.
Previously , we exposed them individually such as elm_fileselector_is_save_set().
Instead of adding the same APIs three times, we can reuse one fileselector's API using Eo interface.
This patch introduced fileselector interface and applied it to elm_fileselector.
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D475
There are elm_widget_theme/theme_set/theme_get functions.
In Eolian these functions will be described as "theme" method and
"theme" property. There is clash here.
So add suffix "_apply" to Eo API for "elm_widget_theme".
Summary:
elm_layout_theme_set can call some methods like _smart_disable and there are some warnings
when these methods manipulate some member variabls which are not initialized yet.
It's because elm_layout_theme_set is called too early in _smart_add.
Spotted while digging warnings after rELM4c3e23de9e46
Reviewers: seoz, raster
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D459
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
This commit is invalid.
It just use strdup and strdup may return NULL when memory is not enough.
This reverts commit f579f7fd4b5e863f01a001876e536f5becc40811.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
can be scrollable or not. scrolled entry now just calls entry calls
and is marked as dperecated to be killed off in the future so no need
to document it etc. edje external also goes.
SVN revision: 60438
If you try to create a new widget, you must be sure that the parent
is really an evas object.
With the previous implementation it was possible to call an _add
function for an elementary widget with any non-null pointer as parent
eventually causing crashes (like with the elm_box).
SVN revision: 55521
The profile now defines the default value for expand and inwin modes. The
fileselectors tests were changed to reflect that.
Note that the default for desktops is expand mode enabled and inwin disabled
and for mobiles is the opposite.
SVN revision: 53728
Daniel Juyung Seo
Ryuan Choi
Yakov Goldberg
Daniel Juyung Seo
Tom Hacohen
Cedric Bail
ChunEon Park
Daniel Juyung Seo
Daniel Zaoui
Gustavo Lima Chaves
Carsten Haitzler
Jiyoun Park
3v1n0
helen
Tiago Rezende Campos Falcao
Rafael Fonseca
Bruno Dilly