Commit Graph

113 Commits

Author SHA1 Message Date
ChunEon Park 5ab6a7739f widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.

conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
Jaeun Choi 3449c44221 image: apply key binding
Summary: This patch applies key binding to elm_image.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D732
2014-04-15 14:49:35 +09:00
Tom Hacohen 687762a344 image: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Daniel Zaoui fceca47f28 Eolian: Integration of Image 2014-03-23 14:17:38 +02:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
Daniel Juyung Seo 5f0ca660b4 elm: Unified the usage of strncmp.
- Use strlen instead of sizeof(x) - 1 for string length calculation.
- Use !strncmp for null check.
2014-01-27 02:07:44 +09:00
Jihoon Kim 54ec084e76 fix some typos in comment and description 2014-01-22 13:20:15 +09:00
Daniel Juyung Seo 5353aa863c elm: Removed unnecessary null check for free. 2014-01-22 11:13:11 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Daniel Juyung Seo 43533a2fb9 elm: Removed unnecessary null check for eina_stringshare_del. 2014-01-22 10:54:45 +09:00
Daniel Juyung Seo 68eca6d62e url: Added underscore(_) to elm internal functions, elm_url_xxx.
- _elm_url_download, _elm_url_cancel, _elm_url_get
- other internal functions in elm_priv.h also have same prefix.
2014-01-21 23:23:37 +09:00
Daniel Juyung Seo a4f3074f9c elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
2014-01-21 23:18:16 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Carsten Haitzler d90886c992 fix alloc to use right sizeof type in elm_image
this should fix CID 1132738 - not a real issue as it still was * 4 but
more obvious and clean after fix
2014-01-09 15:04:46 +09:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo f232ff14be image: Remove unnecessary parameter for elm_obj_image_editable_set.
This parameter was introduced as an internal funciton parameter long ago and migrated to eo as it was.
But this parameter is not needed. obj pointer is already there.

Thanks to Yakov for the report.
2014-01-02 09:21:16 +09:00
Jihoon Kim 2f3525f518 image: add NULL check 2013-12-31 11:36:43 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
ChunEon Park 45ed80a0c8 image - fix the elm_image_prescale_set() to work properly.
before this, it had the insane logic so the prescale_set() never work.
Now, it works well and the prescale won't be set in default. (before, the default value is 64. why?)
2013-11-25 20:48:22 +09:00
Daniel Juyung Seo 5567837cf5 button,check,colorselector,diskselector,flipselector,image,radio,toolbar: fixed formatting of smart_event functions before working on it.
Now they look more consistent.
2013-11-13 09:54:37 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Zaoui b66233d128 DnD: multi-callbacks support
This features permits execution of more than one set of functions during
DnD.
Delete function API has been modified to give the developer the
possibility to remove a specific set of functions.
2013-11-05 08:28:54 +02:00
Daniel Juyung Seo cee446d308 elm_slider.c, elm_image.c: Removed executable permission from c source.
Please be more careful of file permission.
2013-11-04 22:46:50 +09:00
Cedric Bail 1f442e4a8e elm_image: add mmap_set infrastructure. 2013-11-04 12:19:04 +09:00
Amitesh Singh 72c30bb3e2 [image] - Added support for "clicked" callback on Return/space/KP_Enter key press.
Summary: [image] - Added support for "clicked" callback on Return/space/KP_Enter key press.

Reviewers: seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D278
2013-10-30 08:32:44 +09:00
Daniel Juyung Seo 6397761c6a elm_test: Fixed formatting. tab to space.
Changed tab to space before working on the code.
Kinda surprised by the number of tabs we had.
2013-10-14 19:12:32 +09:00
Daniel Juyung Seo a4fb4efcd7 elm_config/elm_image: Internal small refactoring.
1. Use more ELM_SAFE_FREE macro.
2. Use correct more descriptive macro for timer callback.
2013-10-02 20:18:51 +09:00
Jean-Philippe Andre 6078f040fb elm_image: Fix preload for normal files
grmbl, elm_image must explicitely start preload or the
image will stay blank if evas_object_show() is called before
elm_image_file_set().
2013-10-01 19:09:52 +09:00
Jean-Philippe Andre fada635034 elm_image: Remove double callback on mouse_up
In case of MOUSE_UP event, both the hit rectangle and the
smart image object received the event, thus producing double
clicks.
2013-10-01 19:09:52 +09:00
Daniel Juyung Seo e756f97dae elm: Longwaited trailing white space removal. Clean elm up! 2013-09-30 22:15:01 +09:00
Jean-Philippe Andre 39fe09b137 elm_image: Fix remote image loading
Fixes commit dcb8b54aee3a545a1:
 - elm_image: do not preload full image on file_set.

elementary_test "Image Remote" was not working anymore because
the image was never loaded after download.
2013-09-26 18:57:16 +09:00
Jean-Philippe Andre cdf8137da7 elm_image: do not preload full image on file_set. 2013-09-25 18:39:42 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
ChunEon Park d461a8be05 elementary/widgets - set parents before widget constructs their body.
This avoids unnecessary multiple setups when obj and subobj has connected.
2013-08-27 14:19:19 +09:00
Daniel Juyung Seo c5b0d63838 fixed documentation for consistency. Gets -> Get.
Occurance of Get is super much higher than Gets.
So change Gets to Get for consistency.
2013-08-22 05:24:46 +09:00
Cedric Bail 1baaa321a7 elm_image: add support for url. 2013-08-09 21:13:15 +09:00
Cedric Bail 118918d42c elm_image: let's only propagate the event from one object.
NOTE: Why do we destroy and recreate the image object, couldn't we just reset its state ?
2013-07-29 11:31:23 +09:00
Daniel Juyung Seo 59c5970c72 elm_image.c: eo refactoring. place internal functions into a better place. 2013-06-25 11:15:15 +09:00
Daniel Juyung Seo d0d4afd590 elm: refactoring. no printf in the library. use eina log instead. 2013-06-05 14:40:03 +09:00
Daniel Juyung Seo 9a7bbbf3be elm_image.c: ELM_SAFE_FREE adoption.
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
2013-05-29 20:56:07 +09:00
Daniel Juyung Seo 5f053bf79a elm: refactoring. use more ELM_FREE_FUNC. 2013-05-23 15:54:49 +09:00
Cedric Bail c929b33052 elementary: properly sanitize headers order. 2013-05-03 16:07:06 +09:00
Daniel Zaoui 187d6bf8de Elementary: replace eo_data_get for objects data referencing. 2013-05-01 11:04:09 +03:00
Daniel Juyung Seo 74b3eed5fd elm: print the error message inside elm_widget_sub_object_add().
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
   Elm devs should fix it beforehand.
   So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
2013-04-03 11:28:53 +09:00
Tom Hacohen d75cb616da Change usage of eo_do_super to the new prototype. 2013-03-18 16:15:12 +00:00
Carsten Haitzler 3091ccc3f6 flesh out a lot more of dnd support in elm and add apis to set up dnd
targets for objects as well as initiate a dnd.



SVN revision: 84282
2013-02-21 13:21:08 +00:00
Cedric BAIL 1aaa6e41e1 elementary: as previously stated sizeof (long) != sizeof (void*)
SVN revision: 84014
2013-02-17 03:53:02 +00:00
Daniel Zaoui cdd1eea853 Replace supported_types
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 83803
2013-02-10 07:52:31 +00:00
Daniel Juyung Seo ffa9c1e793 elm: Refactoring.
Smart data is already initialized so we do not need to re-initialize them if the value equals to 0, NULL, or EINA_FALSE.
Sometimes re-initializing smart data explicitly is needed for readability. So there are left overs.

SVN revision: 82228
2013-01-04 19:10:19 +00:00
ChunEon Park a4c735c632 elementary/image - +FIXME
SVN revision: 81413
2012-12-20 01:54:57 +00:00