Subject: Patch to address some focus and disabling issue in elementary
widgets
We have observed some generic issues in Elementary widgets.
1. Widgets not getting disabled if we call elm_object_disabled_set(ob,
EINA_TRUE) followed by elm_object_style_set(obj, <style_name>);
This works fine if we disable the widget after changing the style(call
to theme_hook happens here).
It happens because we are not sending the edje signal in theme_hook of
the widgets, if the widget is already in disabled state.
I have added this code in theme_hook of elm_button as an example and
we will need to apply the similar stuff in all other widgets if needed.
2. The widget gets focused in a particular scenario even though we
call elm_object_focus_allow_set(obj, EINA_FALSE).
The code snippet to explain the scenario which we observed was like
this:
Evas_Object *button = NULL, *icon = NULL;
button = elm_button_add(parent);
elm_object_focus_allow_set(button, EINA_FALSE);
icon = elm_icon_add(button);
elm_icon_file_set(icon, EDJE_PATH, "test.icon");
elm_button_icon_set(button, icon);
An icon object does not take focus by default. But still whenever
the focus returned to the parent(layout in this case) after closing
some popup, the button gets focused though we had disabled it
explicitly.
The reason is in this case, when we call elm_icon_add(button), icon
gets added to button as a sub-object and in this call, we set
sd->child_can_focus for button(the parent) as true because till now,
the focus property for icon has not been set to false which by default
is true.
This was set later in the function elm_icon_add() as follows:
elm_widget_can_focus_set(obj, EINA_FALSE);
Actually this should be set before adding icon as sub-object of the
parent which in this case is a button.
I have done the required modification in the function elm_icon_add().
Attached to this mail is the patch file for these two issues.The
revision from which I have created this patch file is 53129.
We may need to do similar changes in other widgets if required.
SVN revision: 53137
Subject: [EFL] Small Patch for Genlist : elm_genlist_item_expanded_depth_get() API
I added one API to genlist : elm_genlist_item_expanded_depth_get(). This is
used to get an item's expanded depth. I tested this with latest SVN revision
53090.
Can you review this patch and apply this to upstream?
SVN revision: 53134
Added set, get, unset, prepend and append (relative or not).
Set - overwrite the custom chain
Unset - Delete the custom chain
Get- Return the custom chain
Append - append after the relative object or in the end
Prepend - prepend before the relative object or in the start
SVN revision: 53115
Before, the focus_cycle try pass the focus to next, and try again if
need loop the objects. Now, the focus cycle return possible next
object and if is necessary loop or not to focus this returned object.
SVN revision: 53111
This is one more widget whose idea come from Samsung set of
contributions to Elementary.
There is a known bug involving embryo + string functions, which will,
if in "stress", appear at the labels of the widget. Not time to attack
it right now, though.
SVN revision: 53109
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
Up and Down to navigate without multi selection. Hold shift +
up/down to multi select.
SVN revision: 53078
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
Keys:
up
kp_up
down
kp_down
left
kp_left
right
kp_right
Page Up
Page Down
Home
End
p.s.: kp = key pad
SVN revision: 53076
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
The list use elm_scroller instead els_scroller like the others. This is
a problem, because the scroller is son of the list, so when you click on
an item, the event will be done in the item (an edje object) that will
pass to the box it is inside, the box will pass the event to the
scroller and then to the list. So, with the event arriving the scroller
first than the list, if you press up, the navigation between item will
not happen because the scroller is treating the event first. So a good
solution is to pass the list to use smart scroller intead elm_scroller
(like genlist and gengrid).
SVN revision: 53075
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
Up, Down, Left and Right to navigate without multi selection.
Hold shift + up/down/left/right to multi select.
SVN revision: 53074
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
Up and Down to navigate without multi selection. Hold shift + up/down to
multi select.
SVN revision: 53073
This Debug search all subobjects from one object and put in file all
sub-tree of elementary objects as dot language in file. After you can
use dot(from graphviz) to generate PNG, SVG,... diagram of objects.
SVN revision: 53035
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
Keys:
up
kp_up
down
kp_down
left
kp_left
right
kp_right
Page Up
Page Down
Home
End
p.s.: kp = key pad
SVN revision: 52964
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
Keys:
up
kp_up
down
kp_down
left
kp_left
right
kp_right
Page Up
Page Down
Home
End
p.s.: kp = key pad
SVN revision: 52963
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
The idea of the treatment of the key downs events in the smart scroller
is be equal to any widget that use it. But to do this, the smart
scroller must listen to the EVAS_CALLBACK_KEY_DOWN, this will cause a
problem to list, genlist, gengrid, because the event will arrive first
to the smart scroller then to this widgets (because the widgets are
listening the event by event_hook). So, if the scroller treat "Up", the
genlist will not select the item above because this event was already
treat by the scroller.
Now the tratment of the keys was tranfer to the elm_scroller instead of
els_scroller.
SVN revision: 52962
Now Widgets can control between children interation or receive focus
itself. And focus_cycle has now one default code.
And don't pass focus to disabled widgets
SVN revision: 52959
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
Event hook in hoversel is not needed, because the center of the hoversel
is a button that gets the event and calls the activate of the hoversel.
SVN revision: 52889
EAPI void elm_slider_end_set(Evas_Object *obj, Evas_Object *end);
will set a *right* aligned sub-object relative to the slider.
EAPI const Evas_Object *elm_slider_end_get(const Evas_Object *obj);
Getter for that object.
EAPI Evas_Object *elm_slider_end_unset(Evas_Object *obj);
Unparent a previously set end object.
EAPI Evas_Object *elm_slider_icon_unset(Evas_Object *obj);
The same for the icon sub-object.
EAPI void elm_slider_indicator_show_set(Evas_Object *obj, Eina_Bool show);
EAPI Eina_Bool elm_slider_indicator_show_get(const Evas_Object *obj);
Set/get whether the slider should display the augmented knob (indicator) at
mouse drag at all.
SVN revision: 52852
They will only display a warning because they don't have a cursor themselves.
Only adding for the eventareas will free everything created.
SVN revision: 52821
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
elm_slider now respond to the keyborad arrows depends on its position.
If it is in a horizontal mode, than its value will change by pressing
left and right, other wise it will respond by pressing up and down
elm_slideshow: go to next and previous with keyboard arrows
elm_spinner: respond to left and right keys in an animated way
SVN revision: 52816
The old theme start show animation on obj show, if you want
disabled by default it doesn't work well. I changed the theme
default to be visible, don't need animation on "show".
And hidden_set was with inverted logic.
The focus highlight is in theme. And the widget react to
Return/Space.
SVN revision: 52814
This patch add tooltip and mouse cursor support for items of genlist
and gengrid and extends the elementary tests for tooltips and
cursor
By: Thiago Ribeiro Masaki <masaki@profusion.mobi>
SVN revision: 52805
yeah, i should do the tooltips one as well, but it's boring so I'll
leave the implementation as the exercise for someone else :-)
and yeah, we should have that inside edje, like a nice description {
cursor: "xterm"; }, but that's not going to happen in Edje 1.0.
SVN revision: 52793
If you have problem seeing stuff due theme misses, then use:
export EINA_LOG_LEVELS=elementary:4
and you should see some reports of missing groups with files. This
helps a lot for genlist and its complex way of naming items :-)
SVN revision: 52791
instead of refetching and revalidating Widget_Data everytime, just
handle it. Although this will save some instructions, the goal is to
make code shorter and less error prone.
SVN revision: 52790
With this commit is now possible to not use theme's cursor (default behevior)
that could be overriding cursors defined by the engine.
SVN revision: 52761
Basically, get the group from widget theme, using the string passed to
elm_object_cursor_set, get hot spots x and y from the theme (keeps the object
and these two integers on cursor struct).
Cursor is set with ecore_evas_object_cursor_set()
Some functions to change style were added to the api.
SVN revision: 52760
Most of the errors referred to the cast from int to void* in x86_64.
This need conversion to long, as intermediate.
Some calls to elm_widget not exposed API were changed to their similar
at elm_object API.
Elm_Photo never call "drop" smart callback, but i leave the callback
in tests.
And others API methods are included in Elementary.h
Now elementary build with -Wall -Werror in x86_64.
SVN revision: 52691
it's simple. only allows 1 level of theme. would need an advanced
dialog to allow:
theme1:theme2:theme3:theme4... etc.
also no browsing for themes - just whats instaleld n system and user
dirs atm.
SVN revision: 52667
Carsten Haitzler
RAJEEV RANJAN
서주영
Tiago Rezende Campos Falcao
Gustavo Lima Chaves
Iván Briano
Christopher Michael
Nicolas Aguirre
Bruno Dilly
김지훈
Vincent Torri
Brett Nash
Gustavo Sverzut Barbieri